Re: [PATCH 20/26] staging: wilc1000: remove define TCP_ACK_FILTER

2016-01-21 Thread Dan Carpenter
What does TCP_ACK_FILTER do? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-21 Thread Michal Kazior
On 21 January 2016 at 18:40, Peter Oh wrote: > > On 01/21/2016 05:46 AM, Michal Kazior wrote: >> >> The current/old tx path design was that host, at >> its own leisure, pushed tx frames to the device. >> For HTT there was ~1000-1400 msdu queue depth. >> >> After reaching that limit the driver woul

Re: [PATCH 04/26] staging: wilc1000: add sdio resume/suspend

2016-01-21 Thread Dan Carpenter
You should be running checkpatch.pl on your patches. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] staging: wilc1000: pass vif to wilc_send_config_pkt

2016-01-21 Thread Glen Lee
This patch passes vif instead of wilc to wilc_send_config_pkt and it's related functions as well, because we need vif which is currently being used and vif has wilc as well. Change custom print with netdev_xxx format if there are custom print inside the functions we have changed. Function paramete

[PATCH 1/2] staging: wilc1000: move wilc_send_config_pkt to wilc_wlan.c

2016-01-21 Thread Glen Lee
This patch moves the function wilc_send_config_pkt to wilc_wlan.c which handles transport since the purpose of the function is sending/getting of config information. coreconfiguator.[ch] will be rename with frame.[ch] later. The print codes of the function is removed also and they will be implement

Re: wireless-drivers: random cleanup patches piling up

2016-01-21 Thread Dan Carpenter
On Thu, Jan 21, 2016 at 04:52:45PM -0800, Joe Perches wrote: > Whitespace patches, where git diff -w does not show > any difference and objdiff on the objects for a few > randconfigs are identical, maybe could be sifted > into a separate category from other patches. > Maybe the kbuild test robot co

[PATCH] ath9k: do not limit the number of DFS channel interfaces to 1

2016-01-21 Thread Felix Fietkau
I think this limit was added when CSA with multiple interfaces wasn't working yet. It should no longer be necessary Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath9k/init.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/net/wi

Re: wireless-drivers: random cleanup patches piling up

2016-01-21 Thread Joe Perches
On Thu, 2016-01-21 at 16:58 +0200, Kalle Valo wrote: > Hi, > > I have quite a lot of random cleanup patches from new developers waiting > in my queue: > > https://patchwork.kernel.org/project/linux-wireless/list/?state=10&delegate=25621&order=date > > (Not all of them are cleanup patches, there

Re: [PATCH 00/13] ath10k: implement push-pull tx model

2016-01-21 Thread Ben Greear
On 01/21/2016 05:46 AM, Michal Kazior wrote: This adds support for the new logic where host tells firmware how many frames are queued for each station/tid and then firmware asks host to submit frames for given station/tid. Just FYI, with your tree (including this patch-set), the non-upstream 10

Re: wireless-drivers: random cleanup patches piling up

2016-01-21 Thread Julian Calaby
Hi Kalle, On Fri, Jan 22, 2016 at 1:58 AM, Kalle Valo wrote: > Hi, > > I have quite a lot of random cleanup patches from new developers waiting > in my queue: > > https://patchwork.kernel.org/project/linux-wireless/list/?state=10&delegate=25621&order=date > > (Not all of them are cleanup patches,

Re: wireless-drivers: random cleanup patches piling up

2016-01-21 Thread Larry Finger
On 01/21/2016 08:58 AM, Kalle Valo wrote: Hi, I have quite a lot of random cleanup patches from new developers waiting in my queue: https://patchwork.kernel.org/project/linux-wireless/list/?state=10&delegate=25621&order=date (Not all of them are cleanup patches, there are also few patches defe

Re: [PATCH 13/13] ath10k: implement push-pull tx

2016-01-21 Thread Peter Oh
On 01/21/2016 05:46 AM, Michal Kazior wrote: The current/old tx path design was that host, at its own leisure, pushed tx frames to the device. For HTT there was ~1000-1400 msdu queue depth. After reaching that limit the driver would request mac80211 to stop queues. There was little control over

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

2016-01-21 Thread Kalle Valo
Helmut Schaa writes: > On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa > wrote: >> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade wrote: >>> Removed empty spaces before/after parenthesis >>> >>> Signed-off-by: Paul McQuade >> >> Just noticed these did not get applied by Kalle yet. > > Kalle, can

Re: [PATCH 3/3] net: wireless: rt2x00: Space Required

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 11:11 PM, Paul McQuade wrote: > Space needed before open parenthesis > > Signed-off-by: Paul McQuade Looks valid to me. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 1/3] net: wireless: rt2x00: Space issue

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade wrote: > Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade Looks valid to me as well. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt2x00.h | 24 > 1 file changed, 12 insertions(

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

2016-01-21 Thread Helmut Schaa
On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa wrote: > On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade wrote: >> Removed empty spaces before/after parenthesis >> >> Signed-off-by: Paul McQuade > > Just noticed these did not get applied by Kalle yet. Kalle, can you fix up the path (ralink/rt2x00

Re: [PATCH 2/3] net: wireless: rt2x00: Pointer issue

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade wrote: > Code Style: pointer is declared wrong > > Signed-off-by: Paul McQuade Thanks for fixing this code style issue. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt2x00.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade wrote: > Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade Just noticed these did not get applied by Kalle yet. Looks good to me. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt61pci.h | 20 ++--

Re: [PATCH] ath9k_hw: ignore eeprom magic mismatch on flash based devices

2016-01-21 Thread Martin Blumenstingl
On Thu, Jan 21, 2016 at 4:34 PM, Felix Fietkau wrote: > Many AR913x based devices (maybe others too) do not have a valid EEPROM > magic in their calibration data partition. > > Fixes: 6fa658fd5ab2 ("ath9k: Simplify and fix eeprom endianness swapping") > Signed-off-by: Felix Fietkau Acked-by: Mart

[PATCH] ath9k_hw: ignore eeprom magic mismatch on flash based devices

2016-01-21 Thread Felix Fietkau
Many AR913x based devices (maybe others too) do not have a valid EEPROM magic in their calibration data partition. Fixes: 6fa658fd5ab2 ("ath9k: Simplify and fix eeprom endianness swapping") Signed-off-by: Felix Fietkau --- drivers/net/wireless/ath/ath9k/eeprom.c | 12 ++-- 1 file changed

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-21 Thread Kalle Valo
Julia Lawall writes: > On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> >> Move the jump label directly before the desired log statement >> >> so that the variable "err" will not be checked once more >> >> after it was determined that a function call failed. >> >> Use the identifier "report_fail

wireless-drivers: random cleanup patches piling up

2016-01-21 Thread Kalle Valo
Hi, I have quite a lot of random cleanup patches from new developers waiting in my queue: https://patchwork.kernel.org/project/linux-wireless/list/?state=10&delegate=25621&order=date (Not all of them are cleanup patches, there are also few patches deferred due to other reasons, but you get the i

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

2016-01-21 Thread Kalle Valo
Pali Rohár writes: > On Thursday 21 January 2016 15:48:14 Kalle Valo wrote: >> Pali Rohár writes: >> >> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: >> >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote: >> >> > On 12/26/2015 12:45 PM, Pali Rohár wrote: >> >> > >Port the bt_coe

Re: [PATCH 6/7] ath10k: Enable periodic peer stats update

2016-01-21 Thread Mohammed Shafi Shajakhan
On Thu, Jan 21, 2016 at 02:48:13PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > Register for 500ms as periodic peer stats update period, > > and parameters like rx_duration that needs to be tracked > > in host can be achieved by this pr

Re: [PATCH] wlcore: fix return value of wlcore_event_fw_logger

2016-01-21 Thread Mishol, Guy
Cool. Thanks! Sent from my iPhone > On Jan 21, 2016, at 15:52, Kalle Valo wrote: > > Guy Mishol writes: > >> The function can return negative values in case of error. >> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") >> >> Signed-off-by: Guy Mishol > > Andrzej already submitted

Re: [PATCH] wlcore: fix return value of wlcore_event_fw_logger

2016-01-21 Thread Kalle Valo
Guy Mishol writes: > The function can return negative values in case of error. > Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") > > Signed-off-by: Guy Mishol Andrzej already submitted identical patch: https://patchwork.kernel.org/patch/7977461/ So I'm dropping this. -- Kalle Val

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

2016-01-21 Thread Pali Rohár
On Thursday 21 January 2016 15:48:14 Kalle Valo wrote: > Pali Rohár writes: > > > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: > >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote: > >> > On 12/26/2015 12:45 PM, Pali Rohár wrote: > >> > >Port the bt_coex_mode sysfs interface from w

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

2016-01-21 Thread Kalle Valo
Pali Rohár writes: > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote: >> > On 12/26/2015 12:45 PM, Pali Rohár wrote: >> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included >> > >in the Maemo Fremantle kernel t

[PATCH 06/13] ath10k: add new htt message generation/parsing logic

2016-01-21 Thread Michal Kazior
This merely adds some parsing, generation and sanity checks with placeholders for real code/functionality to be added later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt.h| 5 + drivers/net/wireless/ath/ath10k/htt_rx.c | 198 ++- drivers/

[PATCH 13/13] ath10k: implement push-pull tx

2016-01-21 Thread Michal Kazior
The current/old tx path design was that host, at its own leisure, pushed tx frames to the device. For HTT there was ~1000-1400 msdu queue depth. After reaching that limit the driver would request mac80211 to stop queues. There was little control over what packets got in there as far as DA/RA was c

[PATCH 04/13] ath10k: maintain peer_id for each sta and vif

2016-01-21 Thread Michal Kazior
The 10.4.3 firmware with congestion control guarantees that each peer has only a single peer_id mapping. The 1:1 mapping isn't the case for older firmwares (e.g. 10.4.1, 10.2, 10.1) but it should not matter. This 1:1 mapping is going to be only used by future code which inherently (flow-wise) is f

[PATCH 03/13] ath10k: refactor tx pending management

2016-01-21 Thread Michal Kazior
Tx pending counter logic assumed that the sk_buff is already known and hence was performed in HTT functions themselves. However, for the sake of future wake_tx_queue() usage the driver must be able to tell whether it can submit more frames to firmware before it dequeues frame from ieee80211_txq (a

[PATCH 12/13] ath10k: keep track of queue depth per txq

2016-01-21 Thread Michal Kazior
This will be necessary for later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 2 +- drivers/net/wireless/ath/ath10k/mac.c | 5 + drivers/net/wireless/ath/ath10k/txrx.c | 7 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/wirel

[PATCH 09/13] ath10k: add txq placeholder

2016-01-21 Thread Michal Kazior
Driver will make use of this in the future. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 4 drivers/net/wireless/ath/ath10k/mac.c | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/cor

[PATCH 11/13] ath10k: store txq in skb_cb

2016-01-21 Thread Michal Kazior
This will be necessary for later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 1 + drivers/net/wireless/ath/ath10k/mac.c | 32 ++-- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.h

[PATCH 07/13] ath10k: implement wake_tx_queue

2016-01-21 Thread Michal Kazior
This actually prepares a few knobs for new firmware supporting pull-push Tx model where firmware asks host to submit frames for given stations and tids. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 89 +++ 1 file changed, 89 insertions(

[PATCH 08/13] ath10k: implement updating shared htt txq state

2016-01-21 Thread Michal Kazior
Firmware 10.4.3 onwards can support a pull-push Tx model where it shares a Tx queue state with the host. The host updates the DMA region it pointed to during HTT setup whenever number of software queued from (on host) changes. Based on this information firmware issues fetch requests to the host te

[PATCH 01/13] ath10k: refactor tx code

2016-01-21 Thread Michal Kazior
This prepares the code for future reuse with ieee80211_txq and wake_tx_queue() in mind. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 151 +- 1 file changed, 96 insertions(+), 55 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[PATCH 10/13] ath10k: implement flushing of pending frames in txqs

2016-01-21 Thread Michal Kazior
Firmware supporting pull-push tx model may request a switch between modes. When switching from pull-push to push-only it will be necessary to flush all pending frames. The code will do that once other bits that actually trigger it are added. Signed-off-by: Michal Kazior --- drivers/net/wireless/

[PATCH 05/13] ath10k: add fast peer_map lookup

2016-01-21 Thread Michal Kazior
The pull-push functionality of 10.4 will be based on peer_id and tid. These will need to be mapped, eventually, to ieee80211_txq to be used with ieee80211_tx_dequeue(). Iterating over existing stations every time peer_id needs to be mapped to a station would be inefficient wrt CPU time. The new f

[PATCH 02/13] ath10k: unify txpath decision

2016-01-21 Thread Michal Kazior
Some future changes will need to determine final tx method early on. Prepare the code. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 58 +++ 1 file changed, 45 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/

[PATCH 00/13] ath10k: implement push-pull tx model

2016-01-21 Thread Michal Kazior
This adds support for the new logic where host tells firmware how many frames are queued for each station/tid and then firmware asks host to submit frames for given station/tid. The patch count is a bit high but I tried splitting the patches as much as possible to keep them short and easy to revie

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

2016-01-21 Thread Kalle Valo
Pali Rohár writes: > Port the bt_coex_mode sysfs interface from wl1251 driver version included > in the Maemo Fremantle kernel to allow bt-coexistence mode configuration. > This enables userspace applications to set one of the modes > WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_M

Re: [PATCH 0/5] ath10k: add basic hostq support

2016-01-21 Thread Michal Kazior
On 21 January 2016 at 14:13, Michal Kazior wrote: > There's a new firmware feature which uses a shared > DMA memory so host can share it's per-sta per-tid > queue size which is then subsequently used for > firmware to assist in deciding which frames to put > on the intermediate host-device tx queu

[PATCH 2/2] mac80211: expose txq queue depth and size to drivers

2016-01-21 Thread Michal Kazior
This will allow drivers to make more educated decisions whether to defer transmission or not. Relying on wake_tx_queue() call count implicitly was not possible because it could be called without queued frame count actually changing on software tx aggregation start/stop code paths. It was also not

[PATCH 1/2] mac80211: fix txq queue related crashes

2016-01-21 Thread Michal Kazior
The driver can access the queue simultanously while mac80211 tears down the interface. Without spinlock protection this could lead to corrupting sk_buff_head and subsequently to an invalid pointer dereference. Fixes: ba8c3d6f16a1 ("mac80211: add an intermediate software queue implementation") Sig

Re: [PATCH v3] rt2x00: fix monitor mode regression

2016-01-21 Thread Kalle Valo
Eli Cooper writes: > Since commit df1404650ccb ("mac80211: remove support for IFF_PROMISC") > monitor mode for rt2x00 has been made effectively useless because the > hardware filter is configured to drop packets whose intended recipient is > not the device, regardless of the presence of monitor m

[PATCH 2/5] ath10k: add new htt definitions

2016-01-21 Thread Michal Kazior
These definitions are associated with some improvements upcomming for 10.4 and QCA99X0. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt.h | 153 +- 1 file changed, 150 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[PATCH 0/5] ath10k: add basic hostq support

2016-01-21 Thread Michal Kazior
There's a new firmware feature which uses a shared DMA memory so host can share it's per-sta per-tid queue size which is then subsequently used for firmware to assist in deciding which frames to put on the intermediate host-device tx queue. This patchset adds only basic support to make the firmwar

[PATCH 3/5] ath10k: add new FW_FEATURE_PEER_FLOW_CONTROL

2016-01-21 Thread Michal Kazior
This feature flag will be used for firmware which supports pull-push model where host shares it's software queue state with firmware and firmware generates fetch requests telling host which queues to dequeue tx from. Primary function of this is improved MU-MIMO performance with multiple clients.

[PATCH 1/5] ath10k: rename some HTT events

2016-01-21 Thread Michal Kazior
New names make a bit more sense. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt.c| 8 drivers/net/wireless/ath/ath10k/htt.h| 8 drivers/net/wireless/ath/ath10k/htt_rx.c | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/driv

[PATCH 5/5] ath10k: implement basic support for new tx path firmware

2016-01-21 Thread Michal Kazior
This allows to use the new firmware which implements the new tx data path. Without this patch firmware supporting new tx path stops responding shortly after booting. This patch doesn't implement the entire pull-push logic available in the new firmware. This will be done in subsequent patches. Sig

[PATCH 4/5] ath10k: clean up cont frag desc init code

2016-01-21 Thread Michal Kazior
This makes the code easier to extend and re-use. While at it fix _warn to _err. Other than that there are no functional changes. Signed-off-by: Michal Kazior --- Notes: v2: * fix gfp allocation [Ben] drivers/net/wireless/ath/ath10k/htt_tx.c | 58 ++-- 1 fi

Re: [PATCH v2 2/2] ath9k: use min rate when MCC and nullfunc

2016-01-21 Thread Kalle Valo
Janusz Dziedzic writes: > In case of nullfunc and MCC case use lowest > possible rates. > > Signed-off-by: Janusz Dziedzic So what should I do with this patch? The mac80211 patch from this series was dropped, should I do the same? https://patchwork.kernel.org/patch/7953631/ Also please try to

Re: [PATCH 6/7] ath10k: Enable periodic peer stats update

2016-01-21 Thread Kalle Valo
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > Register for 500ms as periodic peer stats update period, > and parameters like rx_duration that needs to be tracked > in host can be achieved by this provision, also periodic > stats update is the future of fw_stats and shall

Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block

2016-01-21 Thread Kalle Valo
Rob Herring writes: > On Wed, Jan 13, 2016 at 11:26:44AM +0530, Raja Mani wrote: >> Add device tree binding documentation details for wifi block present >> in Qualcomm IPQ4019 SoC into "qcom,ath10k.txt". >> >> Right now, ath10k wireless driver has support for PCI based wlan devices. >> There is

[PATCH V2 22/27] staging: wilc1000: rename u32RecvBufferSize in wilc_mq_recv

2016-01-21 Thread Chaehyun Lim
This patch renames u32RecvBufferSize to recv_buf_size to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc100

[PATCH V2 23/27] staging: wilc1000: rename pu32ReceivedLength in wilc_mq_recv

2016-01-21 Thread Chaehyun Lim
This patch renames pu32ReceivedLength to recv_len to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 7 +++ drivers/staging/wilc1000/wilc_msgqueue.h | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wi

[PATCH V2 27/27] staging: wilc1000: remove over-commenting

2016-01-21 Thread Chaehyun Lim
There are over-commenting in wilc_msgqueue.h file. This comment is not explain exactly what codes do and make checkpatch warning about "line over 80 charcters". If necessary, comment will be added later with preferred coding style. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_ms

[PATCH V2 25/27] staging: wilc1000: fix coding style of kmalloc usage

2016-01-21 Thread Chaehyun Lim
This patch fixes coding style of kmalloc usage found by checkpatch. CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct message)...) Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH V2 24/27] staging: wilc1000: rename pstrMessage in wilc_mq_recv

2016-01-21 Thread Chaehyun Lim
This patch renames pstrMessage to msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_

[PATCH V2 26/27] staging: wilc1000: fix logical continuations

2016-01-21 Thread Chaehyun Lim
This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgq

[PATCH V2 07/27] staging: wilc1000: rename strCriticalSection in struct message_queue

2016-01-21 Thread Chaehyun Lim
This patch renames strCriticalSection to lock to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/w

[PATCH V2 11/27] staging: wilc1000: rename pHandle in wilc_mq_create

2016-01-21 Thread Chaehyun Lim
This patch renames pHandle to mq to avoid camelcase Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.

[PATCH V2 09/27] staging: wilc1000: rename u32ReceiversCount in struct message_queue

2016-01-21 Thread Chaehyun Lim
This patch renames u32ReceiversCount to recv_count to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc10

[PATCH V2 03/27] staging: wilc1000: rename u32Length in struct message

2016-01-21 Thread Chaehyun Lim
This patch renames u32Length to len to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH V2 08/27] staging: wilc1000: rename bExiting in struct message_queue

2016-01-21 Thread Chaehyun Lim
This patch renames bExiting to exiting to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue

[PATCH V2 15/27] staging: wilc1000: rename pvSendBuffer in wilc_mq_send

2016-01-21 Thread Chaehyun Lim
This patch renames pvSendBuffer to send_buf to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msg

[PATCH V2 17/27] staging: wilc1000: rename pstrMessage in wilc_mq_send

2016-01-21 Thread Chaehyun Lim
This patch renames pstrMessage to new_msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/

[PATCH V2 06/27] staging: wilc1000: rename hSem in struct message_queue

2016-01-21 Thread Chaehyun Lim
This patch renames hSem to sem to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH V2 16/27] staging: wilc1000: rename u32SendBufferSize in wilc_mq_send

2016-01-21 Thread Chaehyun Lim
This patch renames u32SendBufferSize to send_buf_size to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc100

[PATCH V2 05/27] staging: wilc1000: rename struct WILC_MsgQueueHandle

2016-01-21 Thread Chaehyun Lim
This patch removes typedef from struct WILC_MsgQueueHandle and renames it to struct message_queue. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.c | 14 +++--- drivers/staging/wilc1000/wilc_msgqueue.h | 18

[PATCH V2 04/27] staging: wilc1000: rename pstrNext in struct message

2016-01-21 Thread Chaehyun Lim
This patch renames pstrNext to next to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqu

[PATCH V2 21/27] staging: wilc1000: rename pvRecvBuffer in wilc_mq_recv

2016-01-21 Thread Chaehyun Lim
This patch renames pvRecvBuffer to recv_buf to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msg

[PATCH V2 20/27] staging: wilc1000: rename pHandle in wilc_mq_recv

2016-01-21 Thread Chaehyun Lim
This patch renames pHandle to mq to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 34 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/

[PATCH V2 19/27] staging: wilc1000: fix return error code

2016-01-21 Thread Chaehyun Lim
Three argument are checked at the beginning of wilc_mq_send whether they are valid arguments or not. It is correct to use return error code as -EINVAL, not -EFAULT. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH V2 18/27] staging: wilc1000: rename pstrTailMsg in wilc_mq_send

2016-01-21 Thread Chaehyun Lim
This patch renames pstrTailMsg to tail_msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH V2 13/27] staging: wilc1000: rename pstrMessge in wilc_mq_destroy

2016-01-21 Thread Chaehyun Lim
This patch renames pstrMessge to msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 103

[PATCH V2 10/27] staging: wilc1000: rename pstrMessageList in struct message_queue

2016-01-21 Thread Chaehyun Lim
This patch renames pstrMessageList to msg_list to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 20 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/stagin

[PATCH V2 12/27] staging: wilc1000: rename pHandle in wilc_mq_destroy

2016-01-21 Thread Chaehyun Lim
This patch renames pHandle to mq to avoid camelcase Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_m

[PATCH V2 14/27] staging: wilc1000: rename pHandle in wilc_mq_send

2016-01-21 Thread Chaehyun Lim
This patch renames pHandle to mq to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 22 +++--- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/w

[PATCH V2 01/27] staging: wilc1000: rename struct __Message_struct

2016-01-21 Thread Chaehyun Lim
This patch renames typedef from struct __Message_struct and renames it to struct message. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH V2 02/27] staging: wilc1000: rename pvBuffer in struct message

2016-01-21 Thread Chaehyun Lim
This patch renames pvBuffer to buf to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue

[PATCH V2 00/27] rename variables in wilc1000 driver

2016-01-21 Thread Chaehyun Lim
V2: A 18/27 patch of series has a wrong name as tail_msg, which is should be changed to pstrTailMsg. I fixed it in V2. Chaehyun Lim (27): staging: wilc1000: rename struct __Message_struct staging: wilc1000: rename pvBuffer in struct message staging: wilc1000: rename u32Length in struct messa

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

2016-01-21 Thread Chaehyun Lim
On Thu, Jan 21, 2016 at 7:04 PM, Dan Carpenter wrote: > On Thu, Jan 21, 2016 at 07:01:45PM +0900, Chaehyun Lim wrote: >> On Thu, Jan 21, 2016 at 5:55 PM, Dan Carpenter >> wrote: >> > On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: >> >> On Thu, Jan 21, 2016 at 10:20:28AM +0900,

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

2016-01-21 Thread Dan Carpenter
On Thu, Jan 21, 2016 at 07:01:45PM +0900, Chaehyun Lim wrote: > On Thu, Jan 21, 2016 at 5:55 PM, Dan Carpenter > wrote: > > On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: > >> On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > >> > This patch fixes coding style of k

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

2016-01-21 Thread Chaehyun Lim
On Thu, Jan 21, 2016 at 5:55 PM, Dan Carpenter wrote: > On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: >> On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: >> > This patch fixes coding style of kmalloc usage found by checkpatch. >> > CHECK: Prefer kmalloc(sizeof(*new_

[RFC/RFT v4 2/2] mac80211: add NEED_ALIGNED4_SKBS hw flag

2016-01-21 Thread Janusz Dziedzic
HW/driver should set NEED_ALIGNED4_SKBS flag in case require aligned skbs to four-byte boundaries. Before we have to do memmove() in the driver before pass this to HW and memmove() back in tx completion. This patch allow to save CPU and skip such memmoves. For each skb we call memmove(ieee80211_hd

[RFC/RFT v4 1/2] mac80211: add hdrlen to ieee80211_tx_data

2016-01-21 Thread Janusz Dziedzic
Add hdrlen to ieee80211_tx_data and use this when wep/ccmd/tkip. This is preparation for aligned4 code. Signed-off-by: Janusz Dziedzic --- net/mac80211/ieee80211_i.h | 1 + net/mac80211/tx.c | 6 +++--- net/mac80211/util.c| 5 - net/mac80211/wep.c | 11 ++-

Re: [PATCH] rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

2016-01-21 Thread Larry Finger
On 01/21/2016 02:52 AM, Kalle Valo wrote: Larry Finger writes: Recently, it has been reported that D-Link DWA-582 cards, which use an RTL8812AE chip are not able to scan for 5G networks. The problems started with kernel 4.2, which is the first version that had commit d10101a60372 ("rtlwifi: rt

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

2016-01-21 Thread Dan Carpenter
On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: > On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > > This patch fixes coding style of kmalloc usage found by checkpatch. > > CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct > > message)...) > > >

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

2016-01-21 Thread Pali Rohár
On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: > On Wed 2016-01-13 23:32:47, Arend van Spriel wrote: > > On 12/26/2015 12:45 PM, Pali Rohár wrote: > > >Port the bt_coex_mode sysfs interface from wl1251 driver version included > > >in the Maemo Fremantle kernel to allow bt-coexistence mode

Re: [PATCH] rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

2016-01-21 Thread Kalle Valo
Larry Finger writes: > Recently, it has been reported that D-Link DWA-582 cards, which use an > RTL8812AE chip are not able to scan for 5G networks. The problems started > with kernel 4.2, which is the first version that had commit d10101a60372 > ("rtlwifi: rtl8821ae: Fix problem with regulatory

Re: [PATCH] NFC: microread: Drop platform data header file

2016-01-21 Thread Jean Delvare
On Thu, 21 Jan 2016 09:20:12 +0100, Jean Delvare wrote: > Originally I only wanted to drop the unneeded inclusion of > , but then noticed that struct > microread_nfc_platform_data isn't actually used, and > MICROREAD_DRIVER_NAME is redefined in the only file where it is used, > so we can get rid of

[PATCH] NFC: microread: Drop platform data header file

2016-01-21 Thread Jean Delvare
Originally I only wanted to drop the unneeded inclusion of , but then noticed that struct microread_nfc_platform_data isn't actually used, and MICROREAD_DRIVER_NAME is redefined in the only file where it is used, so we can get rid of the header file and dead code altogether. Signed-off-by: Jean De

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

2016-01-21 Thread Sudip Mukherjee
On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > This patch fixes coding style of kmalloc usage found by checkpatch. > CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct > message)...) > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_msgque