Re: [PATCH v1 1/2] ath10k: Add support for ath10k_sta_statistics support

Hi Mohammed, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20160309] [cannot apply to v4.5-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

[PATCH] brcmfmac: Remove waitqueue_active check

We met a problem of pm_suspend when repeated closing/opening the lid on a Lenovo laptop (1/20 reproduce rate), below is the log: [ 199.735876] PM: Entering mem sleep [ 199.750516] e1000e: EEE TX LPI TIMER: 0011 [ 199.856638] Trying to free nonexistent resource

[PATCH v2] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

From: Mohammed Shafi Shajakhan Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is an approximate total air time(usecs) for all the frames frames from a connected client.

[PATCH v2] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

From: Mohammed Shafi Shajakhan Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration (approximate total air time(usecs) for all the frames from a connected client) via 'drv_sta_statistics' callback

Re: [PATCH v1] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

On Wed, Mar 09, 2016 at 12:09:15PM +0530, Mohammed Shafi Shajakhan wrote: > Hi Johannes, > > On Tue, Mar 08, 2016 at 05:52:23PM +0100, Johannes Berg wrote: > > On Mon, 2016-03-07 at 16:33 +0530, Mohammed Shafi Shajakhan wrote: > > > From: Mohammed Shafi Shajakhan > > >

Re: [PATCH v4] ath10k: move mgmt descriptor limit handle under mgmt_tx

On 8 March 2016 at 18:25, Rajkumar Manoharan wrote: [...] > +int ath10k_htt_tx_mgmt_inc_pending(struct ath10k_htt *htt, bool is_mgmt, > + bool is_presp) > +{ > + struct ath10k *ar = htt->ar; > + > +

Re: [PATCH v4] ath10k: move mgmt descriptor limit handle under mgmt_tx

On 8 March 2016 at 18:25, Rajkumar Manoharan wrote: [...] > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c > @@ -2326,7 +2326,12 @@ void ath10k_htt_t2h_msg_handler(struct ath10k *ar, > struct sk_buff *skb) >

Re: [PATCH] mac80211: Allow probe response frame rx to user space in AP mode

On Tuesday 08 March 2016 10:25 PM, Johannes Berg wrote: > On Mon, 2016-03-07 at 12:42 +0530, Vasanthakumar Thiagarajan wrote: >> Especially during off-channel scan user space might be interested >> in probe reponse frames along with beacon to build a list >> of preferred channel and bssid which

Re: [PATCH] Fix typo in cfg80211.h

Hi All, On Wed, Mar 9, 2016 at 1:17 AM, Moroo Akira wrote: > From: Akira Moroo > > This patch fix a structure name typo in cfg80211.h. > > Signed-off-by: Moroo Akira Looks right to me. Reviewed-by: Julian Calaby

[RFC 5/7] wlcore: avoid fragile snprintf use

Appending to a buffer like this is not guaranteed to work (passing overlapping src and dst buffers to snprintf is undefined behaviour). The standard and safe idiom is to keep track of the current string length. Signed-off-by: Rasmus Villemoes ---

Re: [PATCH] ath10k: parse Rx MAC timestamp in mgmt frame for FW 10.4

On 03/08/2016 01:31 AM, Valo, Kalle wrote: > Peter Oh writes: > >> Check and parse Rx MAC timestamp when firmware sets its flag >> to status variable. >> 10.4 firmware adds it in Rx beacon frame only at this moment. >> Drivers and mac80211 may utilize it to detect such

[PATCH] ath10k: handle channel change htt event

Whenever firmware is configuring operating channel during scan or home channel, channel change event will be indicated to host. In some cases (device probe/ last vdev down), target will be configured to default channel whereas host is unaware of target's operating channel. This leads to packet

[PATCH v4] ath10k: move mgmt descriptor limit handle under mgmt_tx

Firmware reserves few descriptors for management frames transmission. In 16 MBSSID scenario, these slots will be easy exhausted due to frequent probe responses. So for 10.4 based solutions, probe responses are limited by a threshold (24). management tx path is separate for all except tlv based

Re: [PATCH] iw: add libnl-tiny support

This: > -#if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30) > +#if !defined(CONFIG_LIBNL20) && !defined(CONFIG_LIBNL30) && > !defined(CONFIG_LIBNL_TINY) > -#endif /* CONFIG_LIBNL20 && CONFIG_LIBNL30 */ > +#endif /* CONFIG_LIBNL20 && CONFIG_LIBNL30 && CONFIG_LIBNL_TINY */ can be handled

Re: [PATCH] mac80211: Allow probe response frame rx to user space in AP mode

On Mon, 2016-03-07 at 12:42 +0530, Vasanthakumar Thiagarajan wrote: > Especially during off-channel scan user space might be interested > in probe reponse frames along with beacon to build a list > of preferred channel and bssid which could be sent to the stations > around for better spectrum

Re: [PATCH v1] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

On Mon, 2016-03-07 at 16:33 +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' > This flag will be set when drivers can fill rx_duration (vendor > specific total air

Re: [PATCH v3] ath10k: move mgmt descriptor limit handle under mgmt_tx

On , Michal Kazior wrote: On 8 March 2016 at 13:54, Rajkumar Manoharan wrote: On , Michal Kazior wrote: On 8 March 2016 at 12:54, Rajkumar Manoharan wrote: ...] skb_cb = ATH10K_SKB_CB(msdu); txq = skb_cb->txq;

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

Hello Johannes, On 1 March 2016 at 11:15, João Paulo Rechi Vita wrote: > On 1 March 2016 at 08:43, Johannes Berg wrote: >> >> I'm fine with Jouni's change, preserving the original behaviour of >> requiring TYPE_ALL or the correct type, but I'm

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On 8 March 2016 at 14:14, Bob Copeland wrote: > On Tue, Mar 08, 2016 at 08:12:21AM +0100, Michal Kazior wrote: >> However other drivers (e.g. ath10k) have offloaded rate control on >> device. There's currently no way of doing this calculation. I was >> thinking of drivers

Re: About adding support for MT76x2U to Linux kernel

On Tue, Mar 08, 2016 at 01:58:03PM +0100, Felix Fietkau wrote: > On 2016-03-08 13:49, Johannes Stezenbach wrote: > > On Mon, Mar 07, 2016 at 10:22:38PM +0100, Felix Fietkau wrote: > >> On 2016-03-07 13:41, Johannes Stezenbach wrote: > >> > http://www.mediatek.com/en/downloads1/downloads/mt7612u/ >

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On Tue, Mar 08, 2016 at 08:12:21AM +0100, Michal Kazior wrote: > However other drivers (e.g. ath10k) have offloaded rate control on > device. There's currently no way of doing this calculation. I was > thinking of drivers exporting tx_rate to mac80211 in some way - either > via a simple

Re: About adding support for MT76x2U to Linux kernel

On Mon, Mar 07, 2016 at 10:22:38PM +0100, Felix Fietkau wrote: > On 2016-03-07 13:41, Johannes Stezenbach wrote: > > http://www.mediatek.com/en/downloads1/downloads/mt7612u/ > I checked, they simply use a software timer for it and stuff buffered > multicast packets into the BE queue. I don't think

Re: [PATCH v3] ath10k: move mgmt descriptor limit handle under mgmt_tx

On 8 March 2016 at 12:54, Rajkumar Manoharan wrote: [...] > +int ath10k_htt_tx_mgmt_inc_pending(struct ath10k_htt *htt, bool is_mgmt, > + bool is_presp) > { > struct ath10k *ar = htt->ar; > >

[patch] libertas: fix an error code in probe

We accidentally return success instead of a negative error code. Signed-off-by: Dan Carpenter diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c index b35b8bc..8541cbe 100644 ---

RE: [PATCH] mac80211: Set global RRM capability

> Subject: [PATCH] mac80211: Set global RRM capability > > Allow publishing RRM capabilities for features that are not HW dependent. > > Signed-off-by: Emmanuel Grumbach > --- Err... please ignore.. > net/mac80211/main.c | 3 ++- > 1 file changed, 2

[PATCH v3] ath10k: move mgmt descriptor limit handle under mgmt_tx

Firmware reserves few descriptors for management frames transmission. In 16 MBSSID scenario, these slots will be easy exhausted due to frequent probe responses. So for 10.4 based solutions, probe responses are limited by a threshold (24). management tx path is separate for all except tlv based

[PATCH] mac80211: Set global RRM capability

Allow publishing RRM capabilities for features that are not HW dependent. Signed-off-by: Emmanuel Grumbach --- net/mac80211/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/main.c b/net/mac80211/main.c index 8190bf2..0c9b621

[PATCH] mac80211: Fix BW upgrade for TDLS peers

From: Ilan Peer It is possible that the station is connected to an AP with bandwidth of 80+80MHz or 160MHz. In such cases there is no need to perform an upgrade as the maximal supported bandwidth is 80MHz. In addition, when upgrading and setting center_freq1 and bandwidth

[PATCH v2] mwifiex: Empty Tx queue during suspend

In cfg80211 suspend handler, stop the netif queue and wait until all the Tx queues become empty. Start the queues in resume handler. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 28 ++--- 1 file changed, 25

Re: [PATCH v2] ath10k: move mgmt descriptor limit handle under mgmt_tx

On 6 March 2016 at 08:47, Rajkumar Manoharan wrote: > Firmware reserves few descriptors for management frames transmission. > In 16 MBSSID scenario, these slots will be easy exhausted due to frequent > probe responses. So for 10.4 based solutions, probe responses are

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On 8 March 2016 at 00:06, Dave Taht wrote: > Dear Michal: > > Going through this patchset... (while watching it compile) > > > + if (!local->hw.txq_cparams.target) > + local->hw.txq_cparams.target = MS2TIME(5); > > MS2TIME(20) for now and/or add something

Re: rtlwifi: Fix size of wireless mode variable

> Smatch reports the following warning: > > CHECK drivers/net/wireless/realtek/rtlwifi/rc.c > drivers/net/wireless/realtek/rtlwifi/rc.c:144 _rtl_rc_rate_set_series() warn: > impossible condition '(wireless_mode == 256) => (0-255 == 256)' > > This warning arises because commit acc6907b87a9

Re: [10/14] wireless: cw1200: use __maybe_unused to hide pm functions_

> The cw1200 uses #ifdef to check for CONFIG_PM, but then > uses SIMPLE_DEV_PM_OPS, which leaves the references out when > CONFIG_PM_SLEEP is not defined, so we get a warning with > PM=y && PM_SLEEP=n: > > drivers/net/wireless/st/cw1200/cw1200_spi.c:450:12: error: > 'cw1200_spi_suspend' defined

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

Michal Kazior writes: >> With large values for flows_cnt, fq, dominates, for small values, aqm >> does. We did quite a lot of testing at 16 and 32 queues in the early >> days, with pretty good results, except when we didn't. Cake went whole >> hog with an 8 way set

Re: [RFC v1] mac80211: Add support for per station rx stats histogram

Hi Johannes, On Tue, Mar 08, 2016 at 09:07:31AM +0100, Johannes Berg wrote: > On Mon, 2016-03-07 at 21:53 +0530, Mohammed Shafi Shajakhan wrote: > >  > > +#define IEEE80211_HT_MCS_NUM 32 > > +#define IEEE80211_VHT_MCS_NUM 10 > > +#define IEEE80211_BW_NUM 4 > >

Re: [PATCH] ath10k: parse Rx MAC timestamp in mgmt frame for FW 10.4

Peter Oh writes: > Check and parse Rx MAC timestamp when firmware sets its flag > to status variable. > 10.4 firmware adds it in Rx beacon frame only at this moment. > Drivers and mac80211 may utilize it to detect such clockdrift > or beacon collision and use the result