Re: rtl8xxxu 4.4.5(from f23): I get a panic adding a new device to the driver

2016-03-19 Thread Jes Sorensen
Jes Sorensen writes: > Xose Vazquez Perez writes: >> Hi, >> >> If I do: >> # echo "0bda 8176" > /sys/bus/usb/drivers/rtl8xxxu/new_id > > Hi Xose, > > Yes please don't do that. The rtl8xxxu driver relies on the .driver_info > field in struct use_device_id to carry information for the different > t

[PATCH 1/4] mac80211: don't start dynamic PS timer if not needed

2016-03-19 Thread Emmanuel Grumbach
From: Johannes Berg If the device implements dynamic PS itself, there's no need to ever start the dynamic powersave timer on RX. While at it, fix up some indentation in this code. Signed-off-by: Johannes Berg --- net/mac80211/rx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(

RE: [PATCH v7] Add new mac80211 driver mwlwifi.

2016-03-19 Thread David Lin
> From: Julian Calaby [mailto:julian.cal...@gmail.com] Thursday, March 17, 2016 > 7:24 AM > > Hi David, > > On Thu, Nov 12, 2015 at 2:51 PM, David Lin wrote: > > This patch provides the mwlwifi driver for Marvell 8863, 8864 and 8897 > > chipsets. > > This driver was developed as part of the ope

[PATCH 05/19] rtlwifi: use to_delayed_work()

2016-03-19 Thread Julian Calaby
From: Geliang Tang Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang [Update commit message] Signed-off-by: Julian Calaby --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek

Re: [PATCH] staging: refresh TODO for rtl8723au

2016-03-19 Thread Joe Perches
On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote: > Xose Vazquez Perez writes: > > People should not waste time and energy working on this staging driver. > > A replacement(rtl8xxxu) using the kernel wireless stack already was merged > > in the 4.3 kernel. [] > >  drivers/staging/rtl8723au/TO

[PATCH] staging: wilc1000: fixed kernel panic when firmware is not started

2016-03-19 Thread Leo Kim
This patch fixed the problems caused by if firmware is not started. That is why, in nl80211 put current TX power in interface info. If firmware is not started, this function(get_tx_power) does not work. Signed-off-by: Leo Kim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++ 1 f

[PATCH 3/4] mac80211: clean up station flags debugfs

2016-03-19 Thread Emmanuel Grumbach
From: Johannes Berg Avoid the really strange %s%s%s expression, use an array of flag names and check that all flags are present. Signed-off-by: Johannes Berg --- net/mac80211/debugfs_sta.c | 63 +++--- net/mac80211/sta_info.h| 4 +++ 2 files changed

Re: [RFCv2 0/3] mac80211: implement fq codel

2016-03-19 Thread Dave Taht
On Thu, Mar 17, 2016 at 1:55 AM, Michal Kazior wrote: > I suspect the BK/BE latency difference has to do with the fact that > there's bulk traffic going on BE queues (this isn't reflected > explicitly in the plots). The `bursts` flent test includes short > bursts of traffic on tid0 (BE) which is

Re: rtl8xxxu 4.4.5(from f23): I get a panic adding a new device to the driver

2016-03-19 Thread Jes Sorensen
Greg KH writes: > On Thu, Mar 17, 2016 at 09:01:25PM +0100, poma wrote: >> On 17.03.2016 19:02, Jes Sorensen wrote: >> > Jes Sorensen writes: >> >> Xose Vazquez Perez writes: >> >>> Hi, >> >>> >> >>> If I do: >> >>> # echo "0bda 8176" > /sys/bus/usb/drivers/rtl8xxxu/new_id >> >> >> >> Hi Xose, >

[PATCH 0/9] Fix Smatch warnings in rtlwifi family of drivers

2016-03-19 Thread Larry Finger
Today's patch by Arndt Bergman showing an indentation problem in rtl8821ae told me that it was time for rechecking all the code for indentation and other problems. Along with Arndt's patch, there are no remaining Smatch warnings. As with all other cleanup patches, these have low priority. Larry -

re: nfc: st21nfca: Add support for acpi probing for i2c device.

2016-03-19 Thread Dan Carpenter
Hello Christophe Ricard, The patch dfa8070d7f64: "nfc: st21nfca: Add support for acpi probing for i2c device." from Dec 23, 2015, leads to the following static checker warning: drivers/nfc/st21nfca/i2c.c:530 st21nfca_hci_i2c_acpi_request_resources() error: 'gpiod_ena' dereferencin

Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

2016-03-19 Thread Julian Calaby
Hi Stanislaw, On Fri, Mar 18, 2016 at 9:48 PM, Stanislaw Gruszka wrote: > On Fri, Mar 18, 2016 at 01:28:33PM +1100, Julian Calaby wrote: >> From: Jia-Ju Bai >> >> When il4965_hw_nic_init in __il4965_up fails, the memory allocated by >> iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not f

Re: The mac80211 softmac driver subsystem and handling of monitor interfaces

2016-03-19 Thread Roger James
Johannes Berg writes: > > On Tue, 2016-03-15 at 13:01 +, Roger James wrote: > >  > > roger dragon:~/linux-mainline$ find . -name "*.[ch]" -exec grep -n  > > IEEE80211_HW_WANT_MONITOR_VIF {} \; -print > > 1851: * IEEE80211_HW_WANT_MONITOR_VIF: The driver would like to be  > > informed of >

Re: [PATCH] ath10k: free cached fw bin contents when get board id fails

2016-03-19 Thread Valo, Kalle
Raja Mani writes: > ath10k_core_probe_fw() simply returns error without freeing > cached firmware file content when get board id operation fails. > Free cached fw bin data in failure case to avoid memory leak. > > Fixes: db0984e51a18 ("ath10k: select board data based on BMI chip id and > board i

我的联系方式在

2016-03-19 Thread 我的联系方式在
你的老朋友邀你来Q群:343257759

Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

2016-03-19 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 10:12:34PM +1100, Julian Calaby wrote: > I don't think you're right. Looking closely at the code, > il->num_stations gets incremented in il_prep_station() which is called > unconditionally from il4965_alloc_bcast_station(). > > So I think this and the following patch are fi

Re: iwlwifi incomplete initialization in Linux 4.5?

2016-03-19 Thread Grumbach, Emmanuel
Hi Linus, On 03/16/2016 10:48 PM, Linus Torvalds wrote: > So I upgraded the firmware on my Intel NUC (NUC6i3SYK), and that made > the wireless no longer work with a 4.5 kernel. I could get the > occasional packets through, but not many, and ti would hang for ten > seconds at a time, and then outpu

[PATCH v4] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Vishal Thanki
With current driver, it is observed that a URB is not completed while the USB disconnect is initiated. Due to that, the URB completion hanlder is trying to access the resource which was freed as a part of USB disconnect. Managing the URBs with anchor will make sure that all the URBs are handled gra

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Vishal Thanki
On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka wrote: > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: >> >> @@ -1001,6 +1002,9 @@ struct rt2x00_dev { >> >> /* Extra TX headroom required for alignment purposes. */ >> unsigned int extra_tx_headroom; >> + >> + str

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Luis de Bethencourt
On 18/03/16 17:46, Luis de Bethencourt wrote: > On 18/03/16 16:49, Johannes Berg wrote: >> On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: >>> Fix order of mac80211_rx_flags description to match the enum. >>> >>> Signed-off-by: Luis de Bethencourt >>> --- >>> Hi, >>> >>> I want ahead

Re: [PATCH v2] ath10k: fix debugfs pktlog_filter write

2016-03-19 Thread Valo, Kalle
writes: > From: Anilkumar Kolli > > It is observed that, we are disabling the packet log if we write same > value to the pktlog_filter for the second time. Always enable pktlogs > on non zero filter. > > Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter") > Cc: sta...@vger.ker

RE: [PATCH] mwifiex: bridged packets cause wmm_tx_pending counter to go negative

2016-03-19 Thread Amitkumar Karwar
> From: Marty Faltesek [mailto:mfalte...@google.com] > Sent: Tuesday, March 15, 2016 4:51 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org > Subject: [PATCH] mwifiex: bridged packets cause wmm_tx_pending counter > to go negative > > When a packet is queued from the bridge, wmm_tx_pen

RE: [PATCH v2 0/7] mwifiex: cleanups

2016-03-19 Thread Amitkumar Karwar
Hi Andreas, > From: Andreas Fenkart [mailto:afenk...@gmail.com] > Sent: Thursday, March 10, 2016 2:14 PM > To: linux-wireless@vger.kernel.org > Cc: Amitkumar Karwar; Nishant Sarmukadam; Julian Calaby; Kalle Valo; > Andreas Fenkart > Subject: [PATCH v2 0/7] mwifiex: cleanups > > v2: > - addressed

Re: [PATCH] ath10k: Advertise force AP scan feature

2016-03-19 Thread Valo, Kalle
Vasanthakumar Thiagarajan writes: > Results obtained from scan can be used for spectrum management by > doing something like building information of preferred channel > lists and sharing them with stations around. It is to be noted > that traffic to the connected stations would be affected during

[PATCH 4/5] cfg80211: allow userspace to specify client P2P PS support

2016-03-19 Thread Emmanuel Grumbach
From: Ayala Beker Legacy clients don't support P2P power save mechanisms, and thus if a P2P GO has a legacy client connected to it, it has to make some changes in the PS behavior. To handle this, add an attribute to specify whether a station supports P2P PS or not. If the attribute was not speci

Re: [PATCH 08/19] iwlegacy: Return directly if allocation fails in il_eeprom_init()

2016-03-19 Thread Julian Calaby
Hi Markus, On Sat, Mar 19, 2016 at 12:41 AM, SF Markus Elfring wrote: >> Also remove an unused label. > > Is such a commit message a bit too short? I don't think so, but I don't decide these sorts of things. Does anyone else have an opinion on this? Thanks, -- Julian Calaby Email: julian.ca

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Sat, Mar 19, 2016 at 09:21:52AM +0100, Vishal Thanki wrote: > On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka > wrote: > > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: > >> > >> @@ -1001,6 +1002,9 @@ struct rt2x00_dev { > >> > >> /* Extra TX headroom required for ali

[PATCH 2/4] ieee80211: support parsing Fine Timing Measurement action frame

2016-03-19 Thread Emmanuel Grumbach
From: Avraham Stern Add definition for Fine Timing Measurement (FTM) frame format as defined in IEEE802.11-REVmcD5.0 section 9.6.8.33 Signed-off-by: Avraham Stern Signed-off-by: Emmanuel Grumbach --- include/linux/ieee80211.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/in

[PATCH 04/19] wl1251: use to_delayed_work()

2016-03-19 Thread Julian Calaby
From: Geliang Tang Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang [Update commit message] Signed-off-by: Julian Calaby --- drivers/net/wireless/ti/wl1251/ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wl1251/ps.c

Re: [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init()

2016-03-19 Thread Julian Calaby
Hi Stanislaw, On Fri, Mar 18, 2016 at 9:31 PM, Stanislaw Gruszka wrote: > On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote: >> From: Markus Elfring >> >> Rename a jump label according to the current Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> [Rewrote comm

Re: [PATCH 2/2] ath10k: Enable parsing per station rx duration for 10.4

2016-03-19 Thread Mohammed Shafi Shajakhan
On Wed, Mar 16, 2016 at 10:22:22AM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > Rx duration support for per station is part of extended peer > > stats, enable provision to parse the same and provide backward > > compatibility based on

[PATCH 2/2] bcma: use of_dma_configure() to set initial dma mask

2016-03-19 Thread Arnd Bergmann
While fixing another bug, I noticed that bcma manually sets up a dma_mask pointer for its child devices. We have a generic helper for that now, which should be able to cope better with any variations that might be needed to deal with cache coherency, unusual DMA address offsets, iommus, or limited

[PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

2016-03-19 Thread Julian Calaby
From: Jia-Ju Bai When il4965_hw_nic_init in __il4965_up fails, the memory allocated by iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not freed. This patches adds il_dealloc_bcast_stations in the error handling code of __il4965_up to fix this problem. This patch has been tested in real

Re: [PATCH v4] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread kbuild test robot
-anchor-to-manage-URB/20160319-000203 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: xtensa-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O

[PATCH 06/19] ath9k_htc: Delete unnecessary variable initialisation

2016-03-19 Thread Julian Calaby
From: Markus Elfring In ath9k_hif_usb_rx_stream(), i is initialised in the for loop it's used in. Signed-off-by: Markus Elfring Reviewed-by: Oleksij Rempel [Rewrote commit message] Signed-off-by: Julian Calaby --- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH 4.4 24/50] wext: fix message delay/ordering

2016-03-19 Thread Ben Hutchings
On Mon, 2016-03-14 at 10:50 -0700, Greg Kroah-Hartman wrote: [ > 4.4-stable review patch.  If anyone has any objections, please let me know. I don't have any objections, so I dropped Greg and stable from the recipients. [...] > --- a/net/wireless/wext-core.c > +++ b/net/wireless/wext-core.c [...]

[PATCH 0/2] ath10k: fix tx hangs

2016-03-19 Thread Michal Kazior
Hi, My recent wake-tx-queue/pull-push related patches introduced a regression that can cause tx to hang under certain circumstances. Michal Kazior (2): ath10k: fix tx hang ath10k: fix pull-push tx threshold handling drivers/net/wireless/ath/ath10k/mac.c | 22 +++--- 1 file

[PATCH 1/2] ath10k: fix tx hang

2016-03-19 Thread Michal Kazior
The wake_tx_queue/push_pending logic had a bug which could stop queues indefinitely effectivelly breaking traffic. Fixes: 299468782d94 ("ath10k: implement wake_tx_queue") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 8 1 file changed, 4 insertions(+), 4 delet

[PATCH DETAIL 12/19] rsi: Delete unnecessary variable initialisation

2016-03-19 Thread Julian Calaby
From: Markus Elfring In rsi_send_mgmt_pkt(), the following variables are assigned to before they're used: * wh - Assigned on line 161, first used on line 180 * bss - Assigned on line 160, first used on line 196 * msg - Assigned on line 168, first used on line 175 * extnd_size - Assigned on l

Re: [PATCH 2/5] mac80211: add an option to not disconnect on beacon loss

2016-03-19 Thread Johannes Berg
On Thu, 2016-03-17 at 15:41 +0200, Emmanuel Grumbach wrote: >   ifmgd->probe_send_count = 0; > + sdata->u.mgd.flags &= ~IEEE80211_STA_BEACON_LOSS_REPORTED; This is very racy, concurrent RX will corrupt the flags value since this requires a read-modify-write and cannot be done with locking

Re: [PATCH] rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

2016-03-19 Thread Kalle Valo
Joe Perches writes: > On Thu, 2016-03-17 at 21:54 -0500, Larry Finger wrote: >> On 03/17/2016 07:00 PM, Joe Perches wrote: >> > Use a more common logging style. > > [ 300K+ quote without comment ] Yeah, please try to avoid that. For example this makes the patchwork page for the patch really hard

[PATCH v6] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Vishal Thanki
With current driver, it is observed that a URB is not completed while the USB disconnect is initiated. Due to that, the URB completion handler is trying to access the resource which was freed as a part of USB disconnect. Managing the URBs with anchor will make sure that all the URBs are handled gra

[PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Provide a debugfs entry to enable/ disable Peer Stats feature. Peer Stats feature is for developers/users who are more interested in studying in Rx/Tx stats with multiple clients connected, hence disable this by default. Enabling this feature by default results in u

Re: [PATCH] mwifiex: parse hscfg_gpio info from device tree

2016-03-19 Thread Julian Calaby
Hi Amitkumar, On Fri, Dec 11, 2015 at 8:23 PM, Amitkumar Karwar wrote: > Hi Kalle, > >> -Original Message- >> From: Kalle Valo [mailto:kv...@codeaurora.org] >> Sent: Friday, December 11, 2015 2:04 PM >> To: Amitkumar Karwar >> Cc: linux-wireless@vger.kernel.org; Nishant Sarmukadam; Xinmin

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-19 Thread kbuild test robot
Hi Mohammed, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20160317] [cannot apply to v4.5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Mohammed-Sha

Re: [PATCH 7/9] rtlwifi: rtl8723ae: Fix Smatch warning

2016-03-19 Thread Dan Carpenter
On Thu, Mar 17, 2016 at 01:41:02PM -0500, Larry Finger wrote: > Smatch reports the following: > > CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c:137 > rtl8723e_dm_bt_need_to_dec_bt_pwr() warn: inconsistent indenting >

Re: [PATCH MOREWORK 16/19] rtlwifi: Implement 'rtl_addr_delay()' with a switch statement

2016-03-19 Thread Julian Calaby
Hi Larry, On Fri, Mar 18, 2016 at 1:38 PM, Larry Finger wrote: > On 03/17/2016 09:28 PM, Julian Calaby wrote: >> >> From: Byeoungwook Kim >> >> Doing it this way improves readability. >> >> Signed-off-by: Byeoungwook Kim >> [Rewrote commit message] >> Signed-off-by: Julian Calaby >> >> --- >>

[PATCH 1/5] nl80211: add an option to set driver action for beacon loss

2016-03-19 Thread Emmanuel Grumbach
From: Avraham Stern When beacon loss is detected the driver will try to probe the AP and if the AP does not respond, it will disconnect. However, userspace may not want to disconnect immediately but look for a roaming candidate first. So add a flag to connect and association commands that indicat

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: > > @@ -1001,6 +1002,9 @@ struct rt2x00_dev { > > /* Extra TX headroom required for alignment purposes. */ > unsigned int extra_tx_headroom; > + > + struct usb_anchor *anchor; > + void (*kill_anchored_urbs)(struc

[PATCH 09/19] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free

2016-03-19 Thread Julian Calaby
From: Jia-Ju Bai If "txq->cmd = kzalloc(...)" in il_tx_queue_init fails, "kfree(txq->cmd[i])" in il_tx_queue_free and il_cmd_queue_free in iwl4965_hw_txq_ctx_free will causes a null pointer dereference, because txq->cmd is NULL at that time. This patch fixes this problem by adding a if-check bef

[PATCH 4/4] mac80211: fix cipher scheme function name

2016-03-19 Thread Emmanuel Grumbach
From: Johannes Berg The code is only used with iwlwifi, but still should have proper mac80211 naming scheme; fix that. Signed-off-by: Johannes Berg --- net/mac80211/rx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 3746

[PATCH 00/19] Pending Cleanup patches for 4.7

2016-03-19 Thread Julian Calaby
Hi Kalle, This is a set of all patches in patchwork which were pending when the 4.6 merge window opened that meet the following criteria: 1. They're sane 2. They're either obviously correct, I can review them, or they've been reviewed or ACK'd by someone else. 3. They don't require any code ch

Re: [PATCH] rtlwifi: fix gcc-6 indentation warning

2016-03-19 Thread Larry Finger
On 03/17/2016 05:03 AM, Arnd Bergmann wrote: The rtl8821ae_dm_txpower_tracking_callback_thermalmeter function contains a call to RT_TRACE() that is indented in a misleading way, as pointed out by a gcc-6 warning: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function 'rtl8821ae_dm_txp

[PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up()

2016-03-19 Thread Julian Calaby
In some of the non-success return paths, the memory allocated by iwl4965_sta_alloc_lq() in iwl4965_alloc_bcast_station() is not freed. In particular: - if the card isn't ready after il4965_prepare_card_hw() - if the card is hardware-rfkilled In the hardware rfkilled path, the driver enables the

Re: [PATCH MOREWORK 16/19] rtlwifi: Implement 'rtl_addr_delay()' with a switch statement

2016-03-19 Thread Larry Finger
On 03/17/2016 09:28 PM, Julian Calaby wrote: From: Byeoungwook Kim Doing it this way improves readability. Signed-off-by: Byeoungwook Kim [Rewrote commit message] Signed-off-by: Julian Calaby --- ... or does it. Honesltly, this is only in this list as Byeoungwook asked about it and I can

[PATCH DETAIL 13/19] rsi: Delete unnecessary variable initialisation

2016-03-19 Thread Julian Calaby
From: Markus Elfring In rsi_send_data_pkt(), the following variables are assigned to before they're used: * tmp_hdr - Assigned on line 47, first used on line 48 * bss - Assigned on line 41, first used on line 44 * extnd_size - Assigned on line 50, first used on line 52 * seq_num - Assigned o

[PATCH 3/9] rtlwifi: rtl8188ee: Fix Smatch warnings

2016-03-19 Thread Larry Finger
Smatch reports the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c:1140 rtl88e_dm_check_txpower_tracking() warn: inconsistent indenting CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c drivers/net/wireless/

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-19 Thread Mohammed Shafi Shajakhan
Hi Michal, thanks for the comments .. On Thu, Mar 17, 2016 at 12:35:00PM +0100, Michal Kazior wrote: > On 17 March 2016 at 12:20, Mohammed Shafi Shajakhan > wrote: > > Hi Michal, > > > > On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: > >> On 17 March 2016 at 11:48, Mohammed Shafi

Re: wireless-drivers: random cleanup patches piling up

2016-03-19 Thread Julian Calaby
Hi Kalle, On Wed, Mar 16, 2016 at 8:42 PM, Julian Calaby wrote: > Hi Kalle, > > On Wed, Mar 16, 2016 at 8:22 PM, Kalle Valo wrote: >> Julian Calaby writes: >> >>> Hi Kalle, >>> >>> On Mon, Feb 1, 2016 at 7:21 PM, Kalle Valo wrote: Sudip Mukherjee writes: > Sure, I am starting th

RE: RE

2016-03-19 Thread Robert
Please confirm receipt of my previous mail..When can i call you -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

2016-03-19 Thread t...@kernel.org
Hello, On Thu, Mar 17, 2016 at 12:43:35PM +, Grumbach, Emmanuel wrote: > > > > Use alloc_workqueue() to allocate the workqueue instead of > > create_singlethread_workqueue() since the latter is deprecated and is > > scheduled > > for removal. > > I can't see any indication of that in the cod

[PATCH 2/5] mac80211: add an option to not disconnect on beacon loss

2016-03-19 Thread Emmanuel Grumbach
From: Avraham Stern Add the option to set mac80211 to not disconnect on beacon loss. If this option is set, mac80211 will send a beacon loss event to userspace but will not disconnect. The beacon loss event is sent only once as long as no response is received from the AP. If after receiving respo

[PATCH] rt2x00usb: Use usb anchors to manage URB

2016-03-19 Thread Vishal Thanki
With current driver, it is observed that a URB is not completed while the USB disconnect is initiated. Due to that, the URB completion hanlder is trying to access the resource which was freed as a part of USB disconnect. Managing the URBs with anchors will make sure that all the URBs are handled gr

RE: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

2016-03-19 Thread Grumbach, Emmanuel
> > Use alloc_workqueue() to allocate the workqueue instead of > create_singlethread_workqueue() since the latter is deprecated and is > scheduled > for removal. I can't see any indication of that in the code of workqueue. Can you share details about that? > > There are work items doing relate

[PATCH 3/5] mac80211: avoid useless memory write on each frame RX

2016-03-19 Thread Emmanuel Grumbach
From: Johannes Berg In the likely case that probe_count is 0 and the flag is clear, don't write to the memory there. This will avoid cache bouncing when adding parallel RX support. Also use ifmgd consistently in the function, instead of using sdata->u.mgd as well. Signed-off-by: Johannes Berg

Re: [RFCv2 0/3] mac80211: implement fq codel

2016-03-19 Thread Bob Copeland
On Thu, Mar 17, 2016 at 09:55:03AM +0100, Michal Kazior wrote: > If you consider Wi-Fi is half-duplex and latency in the entire stack > (for processing ICMP and UDP_RR) is greater than 11e contention window > timings you can get your BE flow responses with extra delay (since > other queues might ha

Re: [PATCH DETAIL 13/19] rsi: Delete unnecessary variable initialisation

2016-03-19 Thread SF Markus Elfring
> In rsi_send_data_pkt(), the following variables are assigned to > before they're used: Thanks for your interest in this update suggestion. How do you think about to add the function name also to such a mail subject so that the potential for confusion with an other change can be eventually reduce

Re: rtl8xxxu 4.4.5(from f23): I get a panic adding a new device to the driver

2016-03-19 Thread Alan Stern
On Thu, 17 Mar 2016, poma wrote: > On 17.03.2016 19:02, Jes Sorensen wrote: > > Jes Sorensen writes: > >> Xose Vazquez Perez writes: > >>> Hi, > >>> > >>> If I do: > >>> # echo "0bda 8176" > /sys/bus/usb/drivers/rtl8xxxu/new_id > >> > >> Hi Xose, > >> > >> Yes please don't do that. The rtl8xxxu

[RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-19 Thread Tejun Heo
Hello, Years ago, workqueue got reimplemented to use common worker pools across different workqueues and a new set of more expressive workqueue creation APIs, alloc_*workqueue() were introduced. The old create_*workqueue() became simple wrappers around alloc_*workqueue() with the most conservativ

Re: iwlwifi incomplete initialization in Linux 4.5?

2016-03-19 Thread Grumbach, Emmanuel
On 03/16/2016 11:23 PM, Linus Torvalds wrote: > On Wed, Mar 16, 2016 at 2:13 PM, Grumbach, Emmanuel > wrote: >> >> This ... typically means that the firmware got stuck while sending >> packets. Can you tell me on what band your router operates? 2.4GHz or >> 5.2GHz? > > Both. > >> Do you use 20

[PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Luis de Bethencourt
Fix order of mac80211_rx_flags description to match the enum. Signed-off-by: Luis de Bethencourt --- Hi, I want ahead and fixed the order of the descriptions. checkpatch.pl was giving a warning to my previous patch and I had a hunch it was because the wrong order breaks the parser. Indeed it doe

[PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag

2016-03-19 Thread Luis de Bethencourt
Add documentation for the flag for duplication check. Fixes the following warning when running make htmldocs: warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags' Signed-off-by: Luis de Bethencourt --- Hi, While running make htmldocs I noticed a warning about R

Re: [PATCH DETAIL 13/19] rsi: Delete unnecessary variable initialisation

2016-03-19 Thread Julian Calaby
Hi Markus, On Sat, Mar 19, 2016 at 11:27 PM, SF Markus Elfring wrote: >> In rsi_send_data_pkt(), the following variables are assigned to >> before they're used: > > Thanks for your interest in this update suggestion. > How do you think about to add the function name also to such > a mail subject

Re: [PATCH 08/19] iwlegacy: Return directly if allocation fails in il_eeprom_init()

2016-03-19 Thread Julian Calaby
Hi Dan, On Sat, Mar 19, 2016 at 1:53 AM, Dan Carpenter wrote: > On Sat, Mar 19, 2016 at 01:33:16AM +1100, Julian Calaby wrote: >> Hi Markus, >> >> On Sat, Mar 19, 2016 at 12:41 AM, SF Markus Elfring >> wrote: >> >> Also remove an unused label. >> > >> > Is such a commit message a bit too short?

RE: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

2016-03-19 Thread Grumbach, Emmanuel
> Hello, > > On Thu, Mar 17, 2016 at 01:43:22PM +0100, Johannes Berg wrote: > > On Thu, 2016-03-17 at 20:37 +0800, Eva Rachel Retuya wrote: > > > Use alloc_workqueue() to allocate the workqueue instead of > > > create_singlethread_workqueue() since the latter is deprecated and > > > is scheduled f

[PATCH] mac80211: remove description of dropped member

2016-03-19 Thread Luis de Bethencourt
Commit 976bd9efdae6 ("mac80211: move beacon_loss_count into ifmgd") removed the member from the sta_info struct but the description stayed lingering. Remove it. Signed-off-by: Luis de Bethencourt --- Hi, A second patch fixing a warning in make htmldocs. Thanks :) Luis net/mac80211/sta_info.h

Re: rtl8xxxu 4.4.5(from f23): I get a panic adding a new device to the driver

2016-03-19 Thread poma
On 17.03.2016 19:02, Jes Sorensen wrote: > Jes Sorensen writes: >> Xose Vazquez Perez writes: >>> Hi, >>> >>> If I do: >>> # echo "0bda 8176" > /sys/bus/usb/drivers/rtl8xxxu/new_id >> >> Hi Xose, >> >> Yes please don't do that. The rtl8xxxu driver relies on the .driver_info >> field in struct use

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Joe Perches
On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: > Fix order of mac80211_rx_flags description to match the enum. > > Signed-off-by: Luis de Bethencourt > --- > Hi, > > I want ahead and fixed the order of the descriptions. checkpatch.pl was giving > a warning to my previous patch and

RE: [PATCH v7] Add new mac80211 driver mwlwifi.

2016-03-19 Thread David Lin
> From: Julian Calaby [mailto:julian.cal...@gmail.com] Thursday, March 17, 2016 > 9:32 AM> > Hi David, > > On Thu, Mar 17, 2016 at 12:23 PM, David Lin wrote: > >> From: Julian Calaby [mailto:julian.cal...@gmail.com] Thursday, March > >> 17, 2016 7:24 AM > >> > >> Hi David, > >> > >> On Thu, Nov

Re: [PATCH v5] ath10k: move mgmt descriptor limit handle under mgmt_tx

2016-03-19 Thread Valo, Kalle
Rajkumar Manoharan writes: > Frames that are transmitted via MGMT_TX are using reserved descriptor > slots in firmware. This limitation is for the htt_mgmt_tx path itself, > not for mgmt frames per se. In 16 MBSSID scenario, these reserved slots > will be easy exhausted due to frequent probe resp

[PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init()

2016-03-19 Thread Julian Calaby
From: Markus Elfring Rename a jump label according to the current Linux coding style convention. Signed-off-by: Markus Elfring [Rewrote commit title] Signed-off-by: Julian Calaby --- This was controversial when introduced, however the change is obvious and harmless and is, in the worst case,

[PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan --- [v2] fixed condition for ath10k state D

Re: [PATCH 2/2] bcma: use of_dma_configure() to set initial dma mask

2016-03-19 Thread Arnd Bergmann
On Thursday 17 March 2016 10:20:21 Arnd Bergmann wrote: > While fixing another bug, I noticed that bcma manually sets up > a dma_mask pointer for its child devices. We have a generic > helper for that now, which should be able to cope better with > any variations that might be needed to deal with c

[PATCH] mac80211: Remove unused variable in per STA debugfs struct

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Remove unused variable in per STA debugfs structure, 'commit 34e895075e21 ("mac80211: allow station add/remove to sleep")' removed the only user of 'add_has_run'. Signed-off-by: Mohammed Shafi Shajakhan --- net/mac80211/debugfs_sta.c |2 -- net/mac80211/sta_i

Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

2016-03-19 Thread Johannes Berg
On Thu, 2016-03-17 at 20:37 +0800, Eva Rachel Retuya wrote: > Use alloc_workqueue() to allocate the workqueue instead of > create_singlethread_workqueue() since the latter is deprecated and is > scheduled for removal. Scheduled where? >  static void iwl_setup_deferred_work(struct iwl_priv *priv)

[PATCH 2/2] mac80211: close the SP when we enqueue frames during the SP

2016-03-19 Thread Emmanuel Grumbach
Since we enqueued the frame that was supposed to be sent during the SP, and that frame may very well cary the IEEE80211_TX_STATUS_EOSP bit, we may never close the SP (WLAN_STA_SP will never be cleared). If that happens, we will not open any new SP and will never respond to any poll frame from the c

Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

2016-03-19 Thread Julian Calaby
Hi Jandy, On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou wrote: > make C=1 M=drivers/staging/rtl8723au/ > > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to > restricted __le16 > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to > restricted __le32 > > Signed-o

Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

2016-03-19 Thread Jes Sorensen
Julian Calaby writes: > Hi Jandy, > > On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou > wrote: >> make C=1 M=drivers/staging/rtl8723au/ >> >> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to >> restricted __le16 >> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Joe Perches
On Fri, 2016-03-18 at 17:40 +, Luis de Bethencourt wrote: > On 18/03/16 17:29, Joe Perches wrote: > > On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: > > > Fix order of mac80211_rx_flags description to match the enum. [] > > > I want ahead and fixed the order of the descriptions.

[PATCH 1/2] bcma: fix building without OF_IRQ

2016-03-19 Thread Arnd Bergmann
The bcma driver core can be built with or without DT support, but it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which can happen on platforms that do not support IRQ domains. ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined! ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko]

[PATCH 9/9] rtlwifi: rtl8821ae: Fix Smatch warnings

2016-03-19 Thread Larry Finger
Smatch reports the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1960 rtl8812ae_dm_txpower_tracking_callback_thermalmeter() warn: inconsistent indenting CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.c d

[PATCH] wl12xx: remove redundant null check on wl->scan.ssid

2016-03-19 Thread Colin King
From: Colin Ian King ssid is an array of u8, so it can never be null, so the null check on wl->scan.ssid is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/net/wireless/ti/wl12xx/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wire

[PATCH 4/9] rtlwifi: rtl8192c-common: Fix Smatch warning

2016-03-19 Thread Larry Finger
Smatch lists the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c:243 rtl92c_dm_false_alarm_counter_statistics() warn: inconsistent indenting Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtl

Re: [PATCH] staging: refresh TODO for rtl8723au

2016-03-19 Thread Jes Sorensen
Xose Vazquez Perez writes: > People should not waste time and energy working on this staging driver. > A replacement(rtl8xxxu) using the kernel wireless stack already was merged > in the 4.3 kernel. > > Cc: Jes Sorensen > Cc: Larry Finger > Cc: Kalle Valo > Cc: Greg Kroah-Hartman > Cc: Linux D

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Luis de Bethencourt
On 18/03/16 17:29, Joe Perches wrote: > On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: >> Fix order of mac80211_rx_flags description to match the enum. >> >> Signed-off-by: Luis de Bethencourt >> --- >> Hi, >> >> I want ahead and fixed the order of the descriptions. checkpatch.pl wa

Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

2016-03-19 Thread Stanislaw Gruszka
Hi On Wed, Mar 16, 2016 at 06:28:51PM +0100, Vishal Thanki wrote: > +struct rt2x00usb_anchors { > + struct usb_anchor async_urb; > + struct usb_anchor tx_submitted; > + struct usb_anchor rx_submitted; > +}; I don't think we need 3 different usb_anchor's, one should be enough. > +stat

[PATCH 5/5] mac80211: track and tell driver about GO client P2P PS abilities

2016-03-19 Thread Emmanuel Grumbach
From: Ayala Beker Legacy clients don't support P2P power save mechanism, and thus if a P2P GO has a legacy client connected to it, it should disable P2P PS mechanisms. Let the driver know about this with a new bss_conf parameter. Signed-off-by: Ayala Beker Signed-off-by: Emmanuel Grumbach ---

[PATCH v5] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Vishal Thanki
With current driver, it is observed that a URB is not completed while the USB disconnect is initiated. Due to that, the URB completion hanlder is trying to access the resource which was freed as a part of USB disconnect. Managing the URBs with anchor will make sure that all the URBs are handled gra

[PATCH v1 2/3] ath10k: Introduce Extended Resource Config support for 10.4

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Raja Mani Add API support for Extended Resource Configuration for 10.4. This is useful to enable new features like Peer Stats, LTEU etc if the firmware advertises support for the service. This is also done to provide backward compatibility with older firmware. Also for clarity send default

[PATCH 11/19] rtl818x_pci: Disable pci device in error handling code

2016-03-19 Thread Julian Calaby
From: Jia-Ju Bai When pci_request_regions in rtl8180_probe fails, pci_disable_device is not called to disable the device which is enabled by pci_enbale_device. This patch fixes the problem by adding a new lable in error handling code. Signed-off-by: Jia-Ju Bai Acked-by: Andrea Merello Signed-

  1   2   >