Re: hardware restart on Intel 7260

2016-04-11 Thread Johann Haarhoff
> Meh... So what happens here is that the firmware is stuck while > transmitting. The driver detects this and as a workaround, resets the > firmware. The detection takes 10 seconds. > The only way to understand what is going on here is to take the > firmware from [1] and to run the steps to collec

RE: iwlwifi monitor mode: No data frame captured on 5 Ghz

2016-04-11 Thread Grumbach, Emmanuel
> On Sun, Apr 10, 2016 at 1:28 PM, Grumbach, Emmanuel > wrote: > >> > On Tue, 2016-04-05 at 16:25 +0300, Gucea Doru wrote: > >> Is the iwlwifi driver capable of capturing data frames when the > >> channel bonding is set to 80Mhz? > > > > dev set freq [20|40|80|80+80|160] [ > freq 1>] [] > > > >

[PATCH v2] qcom: ipq4019: add wifi nodes to ipq4019 SoC device tree

2016-04-11 Thread tamizhchelvam
From: Raja Mani Include dts support for two wifi block present on ipq4019 SoC. Corresponding dt binding documentation has been added in ath.git as below commit id a47aaa69 and the commit message is "dt: bindings: add new dt entry for pre calibration in qcom, ath10k.txt". Signed-off-by: Raja Mani

[PATCH] qcom: ipq4019: add wifi nodes to ipq4019 SoC device tree

2016-04-11 Thread tamizhchelvam
From: Raja Mani Include dts support for two wifi block present on ipq4019 SoC. Corresponding dt binding documentation has been added in below commit id a47aaa69. Signed-off-by: Tamizh chelvam --- arch/arm/boot/dts/qcom-ipq4019.dtsi | 98 +++ 1 file changed, 98

Re: [PATCH] Revert regression in ath9k on AR9281

2016-04-11 Thread Gustav Frederiksen
On 2016-04-11 19:04, Oleksij Rempel wrote: Hi Gustav, thank you for your work. Can you please test attached patch. Hi Oleksij, this report isn't much, on the other hand you were very quick to come up with a patch, well done. The patch does work as expected. Laptop seems to enjoy its new ze

Re: iwlwifi monitor mode: No data frame captured on 5 Ghz

2016-04-11 Thread Gucea Doru
On Sun, Apr 10, 2016 at 1:28 PM, Grumbach, Emmanuel wrote: >> > On Tue, 2016-04-05 at 16:25 +0300, Gucea Doru wrote: >> Is the iwlwifi driver capable of capturing data frames when the channel >> bonding is set to 80Mhz? > > dev set freq [20|40|80|80+80|160] [] > [] > > You can take center_freq1

Re: [PATCH] Revert regression in ath9k on AR9281

2016-04-11 Thread Oleksij Rempel
Hi Gustav, thank you for your work. Can you please test attached patch. Am 11.04.2016 um 04:28 schrieb Gustav Frederiksen: > Hi, > thank you for taking the time to answer my previous email and for > providing those useful tips. -- Regards, Oleksij diff --git a/drivers/net/wireless/ath/ath9

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-11 Thread Christian Daudt
On Mon, Apr 11, 2016 at 8:27 AM, Sudip Mukherjee wrote: > > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. > > Signed-off-by: Sudip Mukherjee

Re: hardware restart on Intel 7260

2016-04-11 Thread Emmanuel Grumbach
Hi, On Mon, Apr 11, 2016 at 5:09 PM, Johann Haarhoff wrote: > > Hi > > (Please CC as I am not subscribed to the list) > > I'm seeing the following trace on a Lenovo Yoga 2 Pro with an Intel 7260 (rev > 6b). > > Kernel is 4.5 on using the latest -16 firmware from wireless.wiki.kernel.org. > I tr

Re: pull-request: wireless-drivers-next 2016-04-11

2016-04-11 Thread David Miller
From: Kalle Valo Date: Mon, 11 Apr 2016 15:48:48 +0300 > here's a pull request for 4.7. More features, but nothing really > standing out. Please let me know if you have any problems. Pulled, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a mes

[PATCH] mwifiex: fix possible NULL dereference

2016-04-11 Thread Sudip Mukherjee
From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++- 1 file change

rfkill LED not working on HP ProBook 640 G2 (Intel Corporation Wireless 8260 (rev 3a))

2016-04-11 Thread Joakim Tjernlund
Got this fairly new laptop(skylake based) where the rfkill switch works. I can see the kernel(4.4.6) bringing wifi up and down whenever I toggle rfkill, also: ~ # rfkill list 0: phy0: Wireless LAN Soft blocked: no Hard blocked: no 1: hci0: Bluetooth Soft blocked: no

[PATCH 2/5] mwifiex: add pcie usb/uart firmware download support

2016-04-11 Thread Amitkumar Karwar
From: Shengzhen Li This patch adds support for downloading usb/uart firmware for 8997 chipset by reading the chip version. Signed-off-by: Shengzhen Li Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/pcie.c | 17 +++-- drivers/net/wireless/marvell/mwifiex/p

[PATCH 3/5] mwifiex: add default setting for pcie firmware download

2016-04-11 Thread Amitkumar Karwar
From: Shengzhen Li This patch adds default setting for pcie firmware download name in case that there are newer chipset version. Signed-off-by: Shengzhen Li Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +++ drivers/net/wireless/marvell/mwifiex/pcie.h | 2

[PATCH 5/5] mwifiex: fix incorrect ht capability problem

2016-04-11 Thread Amitkumar Karwar
IEEE80211_CHAN_NO_HT40PLUS and IEEE80211_CHAN_NO_HT40PLUS channel flags tell if HT40 operation is allowed on a channel or not. This patch ensures ht_capability information is modified accordingly so that we don't end up creating a HT40 connection when it's not allowed for current regulatory domain

[PATCH 1/5] mwifiex: missing break statement

2016-04-11 Thread Amitkumar Karwar
This patch adds missing break statement at the end of PCIE_DEVICE_ID_MARVELL_88W8897 switch section. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/pcie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wire

[PATCH 4/5] mwifiex: do not wait on semaphore during card removal

2016-04-11 Thread Amitkumar Karwar
From: Xinming Hu Host hang is observed if card is removed before firmware download gets completed. In this case, firmware will be failed to download and adapter structure gets freed. In other thread, mwifiex_remove_card() waits on semaphore until the firmware download fails. This wait is not nec

hardware restart on Intel 7260

2016-04-11 Thread Johann Haarhoff
Hi (Please CC as I am not subscribed to the list) I'm seeing the following trace on a Lenovo Yoga 2 Pro with an Intel 7260 (rev 6b). Kernel is 4.5 on using the latest -16 firmware from wireless.wiki.kernel.org. I tried the -17 firmware from git.kernel.org with a very similar result. module wa

pull-request: wireless-drivers-next 2016-04-11

2016-04-11 Thread Kalle Valo
Hi Dave, here's a pull request for 4.7. More features, but nothing really standing out. Please let me know if you have any problems. Kalle The following changes since commit 4da46cebbd3b4dc445195a9672c99c1353af5695: net/core/dev: Warn on a too-short GRO frame (2016-04-05 19:58:39 -0400) are

Re: Kernel crash on startup - bisected to commit 3b24d854cb35

2016-04-11 Thread Kalle Valo
Larry Finger writes: >> Can you double check you have this fix ? >> >> commit 8501786929de4616b10b8059ad97abd304a7dddf >> Author: Eric Dumazet >> Date: Wed Apr 6 22:07:34 2016 -0700 >> >> tcp/dccp: fix inet_reuseport_add_sock() >> >> David Ahern reported panics in __inet_hash() cause

Re: [PATCH] staging: wilc1000: move initialization of the config values

2016-04-11 Thread Dan Carpenter
That may work, but I think it would be simpler to do this next to the kzalloc() before we do the wilc->vif[i]->hif_drv = hif_drv; assignment. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org M

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-11 Thread Machani, Yaniv
On Mon, Apr 11, 2016 at 14:41:18, Pali Rohár wrote: > Mishol, Guy; Arik Nemtsov; Gery Kahn; Felipe Balbi; David Woodhouse; > Aaro Koskinen; Ben Hutchings; David Gnedt; Ivaylo Dimitrov; Sebastian > Reichel; Tony Lindgren; Menon, Nishanth; > linux-wireless@vger.kernel.org; net...@vger.kernel.org;

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-11 Thread Pali Rohár
On Sunday 10 April 2016 13:51:41 Pavel Machek wrote: > Is it "hardware can't do AP", "firmware can't do AP" or "current drivers > do not support AP"? We know that current linux TI wl1251.ko driver does not support AP. And I'm still do not know if "hardware can do AP" or not. Also I'm not sure...

RE: [PATCH v6 1/2] dt: bindings: add MARVELL's sd8xxx wireless device

2016-04-11 Thread Amitkumar Karwar
Hi Rob, Thanks for the review. > From: Rob Herring [mailto:r...@kernel.org] > Sent: Wednesday, March 30, 2016 7:46 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > devicet...@vger.kernel.org; Wei-Ning Huang; Xinming Hu > Subject: Re: [PATCH v6 1/2]

Re: [PATCH 0/8] brcmfmac: event handling and other fixes

2016-04-11 Thread Rafał Miłecki
On 11 April 2016 at 11:35, Arend van Spriel wrote: > This series provides the following: > > * avoid unexpected firmware events. > * allow passing events explicitly for PCIe and SDIO devices. > * fix issue with boardrev entry in nvram. > * fix for wowl. > * fix possible null pointer access upon ab

[PATCH 1/3] cfg80211: Add option to report the bss entry in connect result

2016-04-11 Thread Kanchanapally, Vidyullatha
From: "Kanchanapally, Vidyullatha" Since cfg80211 maintains separate BSS table entries for APs if the same BSSID, SSID pair is seen on multiple channels, it is possible that it can map the current_bss to a BSS entry on the wrong channel. This current_bss will not get flushed unless disconnected a

[PATCH 8/8] brcmfmac: create common function for handling brcmf_proto_hdrpull()

2016-04-11 Thread Arend van Spriel
In receive path brcmf_proto_hdrpull() needs to be called and handled similar in brcmf_rx_frame() and brcmf_rx_event(). Move that duplicated code in separate function. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- ...

[PATCH 2/8] brcmfmac: fix clearing wowl wake indicators

2016-04-11 Thread Arend van Spriel
From: Hante Meuleman Newer firmwares require the usage of the wowl wakeind struct as size for the iovar to clear the wake indicators. Older firmwares do not care, so change the used size. Reviewed-by: Arend Van Spriel Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Hante Meuleman Signed-off

[PATCH 1/8] brcmfmac: clear eventmask array before using it

2016-04-11 Thread Arend van Spriel
From: Hante Meuleman When the event_msgs iovar is set an array is used to configure the enabled events. This arrays needs to nulled before configuring otherwise unhandled events will be enabled. This solves a problem where in case of wowl the host got woken by an incorrectly enabled event. Revie

[PATCH 6/8] brcmfmac: cleanup ampdu-rx host reorder code

2016-04-11 Thread Arend van Spriel
The code for ampdu-rx host reorder is related to the firmware signalling supported in BCDC protocol. This change moves the code to fwsignal module. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../wireless/broadcom/

[PATCH 3/8] brcmfmac: insert default boardrev in nvram data if missing

2016-04-11 Thread Arend van Spriel
From: Hante Meuleman Some nvram files/stores come without the boardrev information, but firmware requires this to be set. When not found in nvram then add a default boardrev string to the nvram data. Reported-by: Rafal Milecki Reviewed-by: Arend Van Spriel Reviewed-by: Franky (Zhenhui) Lin Re

[PATCH 4/8] brcmfmac: fix p2p scan abort null pointer exception

2016-04-11 Thread Arend van Spriel
From: Hante Meuleman When p2p connection setup is performed without having ever done an escan a null pointer exception can occur. This is because the ifp to abort scanning is taken from escan struct while it was never initialized. Fix this by using the primary ifp for scan abort. The abort should

[PATCH 0/8] brcmfmac: event handling and other fixes

2016-04-11 Thread Arend van Spriel
This series provides the following: * avoid unexpected firmware events. * allow passing events explicitly for PCIe and SDIO devices. * fix issue with boardrev entry in nvram. * fix for wowl. * fix possible null pointer access upon aborting p2p scan. The series is intended for v4.7 kernel and appl

[PATCH 7/8] brcmfmac: revise handling events in receive path

2016-04-11 Thread Arend van Spriel
Move event handling out of brcmf_netif_rx() avoiding the need to pass a flag. This flag is only ever true for USB hosts as other interface use separate brcmf_rx_event() function. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spri

[PATCH 5/8] brcmfmac: screening firmware event packet

2016-04-11 Thread Arend van Spriel
From: Franky Lin Firmware uses asynchronized events as a communication method to the host. The event packets are marked as ETH_P_LINK_CTL protocol type. For SDIO and PCIe bus, this kind of packets are delivered through virtual event channel not data channel. This patch adds a screening logic to m

[patch v2] ath10k: add some sanity checks

2016-04-11 Thread Dan Carpenter
Smatch complains that since "ev->peer_id" comes from skb->data that means we can't trust it and have to do a bounds check on it to prevent an array overflow. Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup') Signed-off-by: Dan Carpenter --- v2: Add a warning message. There is a checkpatch

Re: [patch] ath10k: add some sanity checks

2016-04-11 Thread Michal Kazior
On 11 April 2016 at 09:44, Dan Carpenter wrote: > Smatch complains that since "ev->peer_id" comes from skb->data that > means we can't trust it and have to do a bounds check on it to prevent > an array overflow. > > Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup') > Signed-off-by: Dan Carp

[patch] ath10k: add some sanity checks

2016-04-11 Thread Dan Carpenter
Smatch complains that since "ev->peer_id" comes from skb->data that means we can't trust it and have to do a bounds check on it to prevent an array overflow. Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup') Signed-off-by: Dan Carpenter diff --git a/drivers/net/wireless/ath/ath10k/txrx.c

Re: [PATCH 1/2] mac80211: implement fair queuing per txq

2016-04-11 Thread Michal Kazior
On 8 April 2016 at 06:37, Avery Pennarun wrote: > On Fri, Mar 25, 2016 at 5:27 AM, Michal Kazior > wrote: >> mac80211's software queues were designed to work >> very closely with device tx queues. They are >> required to make use of 802.11 packet aggregation >> easily and efficiently. >> >> Howe