Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote: > > The patch was build-tested / debugged by removing the > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or less) dead > code, since I don't think anyone really ever touches this

Re: [PATCHv3 4/5] mac80211: implement codel on fair queuing flows

On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote: >  > + struct ieee80211_vif *vif; > + > + /* When packets are enqueued on txq > it's easy > +  * to re-construct the vif pointer. > There's no > +

Re: [PATCHv3 2/5] mac80211: implement fair queueing per txq

On Sun, 2016-04-17 at 00:23 +0200, Johannes Berg wrote: > On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote: > > > >   > > +++ b/net/mac80211/fq.h > > > Now that you've mostly rewritten it, why keep it in a .h file? > I think I just confused this with codel.h, but still - why a .h file

Re: [PATCHv3 2/5] mac80211: implement fair queueing per txq

On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote: >  > +++ b/net/mac80211/fq.h > Now that you've mostly rewritten it, why keep it in a .h file? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More

Re: [PATCHv3 1/5] mac80211: skip netdev queue control with software queuing

> +static void ieee80211_txq_enqueue(struct ieee80211_local *local, > +   struct txq_info *txqi, > +   struct sk_buff *skb) > +{ > + lockdep_assert_held(>queue.lock); [...] > + atomic_inc(>num_tx_queued); This global kinda bothers me

Re: [PATCH] cfg80211: Advertise extended capabilities per interface type to userspace

On Fri, 2016-04-15 at 16:57 +0530, Kanchanapally, Vidyullatha wrote: >  > +struct wiphy_iftype_ext_capab { > + enum nl80211_iftype iftype; > + const u8 *ext_capab; > + const u8 *ext_capab_mask; > + u8 ext_capab_len; I think you should reuse the struct member names that we used

Re: [PATCH] netlink: don't send NETLINK_URELEASE for unbound sockets

On Sat, 2016-04-16 at 14:30 +0800, Herbert Xu wrote: > Johannes Berg wrote: > > > > > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > > index 215fc08c02ab..330ebd600f25 100644 > > --- a/net/netlink/af_netlink.c > > +++ b/net/netlink/af_netlink.c >

Re: WARNING: CPU: 1 PID: 2485 at drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1752 iwl_trans_pcie_grab_nic_access+0x110/0x120 [iwlwifi]

On Sat, 2016-04-16 at 17:43 +0200, Borislav Petkov wrote: > On Fri, Apr 15, 2016 at 04:16:02AM +, Grumbach, Emmanuel wrote: > > [1] > > https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/backport-iwlwi > > fi.git/ > > It is very strange to pull from this repo, git fetch is doing >

Re: [PATCH] ath9k: remove repetitions of mask array size

Thank you! Kalle should be in CC. Am 16.04.2016 um 16:54 schrieb Bob Copeland: > The constant "123", which is the number of elements in > mask_m / mask_p, is repeated several times in this function. > > Replace memsets with array initialization, and replace a loop > conditional with

Re: WARNING: CPU: 1 PID: 2485 at drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1752 iwl_trans_pcie_grab_nic_access+0x110/0x120 [iwlwifi]

On Fri, Apr 15, 2016 at 04:16:02AM +, Grumbach, Emmanuel wrote: > [1] https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/backport-iwlwi > fi.git/ It is very strange to pull from this repo, git fetch is doing something for a while now without any forward progress. In any case, 4.5 is bad

Re: [PATCH v2] carl9170: Clarify kconfig text

On Saturday, April 16, 2016 05:18:56 PM Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. >

[PATCH] ath9k: remove repetitions of mask array size

The constant "123", which is the number of elements in mask_m / mask_p, is repeated several times in this function. Replace memsets with array initialization, and replace a loop conditional with ARRAY_SIZE() so that we don't repeat ourselves. Signed-off-by: Bob Copeland

Re: [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation

On Sat, Apr 16, 2016 at 08:01:59AM +0200, Oleksij Rempel wrote: > > For a future patch, "sizeof(mask_m)" or even just: > > > > u8 mask_m[123] = {0}; > > > > ... would be better here. I looked at this bit and thought, no way is > > "123" actually correct. Lo and behold, that is actually the

[PATCH v2] carl9170: Clarify kconfig text

The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- v2: Remove the mention of

[PATCH] carl9170: Clarify kconfig text

The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen ---

Re: [PATCH 3/8] brcmfmac: insert default boardrev in nvram data if missing

On 11 April 2016 at 11:35, Arend van Spriel wrote: > From: Hante Meuleman > > Some nvram files/stores come without the boardrev information, > but firmware requires this to be set. When not found in nvram then > add a default boardrev string to

Re: [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation

Am 15.04.2016 um 22:59 schrieb Bob Copeland: > On Tue, Apr 12, 2016 at 07:37:44PM +0200, Oleksij Rempel wrote: >> by moving common code to ar5008_hw_cmn_spur_mitigate i forgot to move >> mask_m & mask_p initialisation. This coused a performance regression >> on ar9281. >> >> Fixes: f911085ffa88