Re: ath9k gpio request

2016-05-31 Thread Pan, Miaoqing
which chip ? And what's the GPIO number ? Thanks, Miaoqing From: Sudip Mukherjee Sent: Tuesday, May 31, 2016 3:35 PM To: Kalle Valo Cc: Stephen Rothwell; ath9k-devel; linux-n...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-wireless@vger.kernel.o

[PATCH V3 iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Rafał Miłecki
Channels (frequencies) are getting more details that users may want to know about. E.g. it's important to know which frequencies allow using 40/80/160 MHz channels to setup AP properly. We list channels in "info" command output but it's already quite big and it was agreed to introduce new command

Re: [PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT > binding document lists the possible compatible strings that a SDIO child > node can have, so the driver checks if the defined in the node matches.

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT > binding document say that the "interrupts" property in the child node is > optional. So the property being missed shouldn't be treated as an error

Re: [PATCH 6/8] mwifiex: check if mwifiex_sdio_probe_of() fails and return error

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > The function can fail so the returned value should be checked > and the error propagated to the caller in case of a failure. > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Ca

Re: [PATCH 4/8] mwifiex: consolidate mwifiex_sdio_probe() error paths

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > Instead of duplicating part of the cleanups needed in case of an error > in .probe callback, have a single error path and use goto labels as is > common practice in the kernel. > > This also has the nice side effect that

Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe()

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > There's only a check if mwifiex_add_card() returned a nonzero value, but > the actual error code is neither stored nor propagated to the caller. So > instead of always returning -1 (which is -EPERM and not a suitable errn

Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > It's better to have the device name prefixed in the error message. > > Signed-off-by: Javier Martinez Canillas This looks right to me. Reviewed-by: Julian Calaby > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c

Re: [PATCH 2/8] mwifiex: propagate sdio_enable_func() errno code in mwifiex_sdio_probe()

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > If the sdio_enable_func() function fails on .probe, the -EIO errno code > is always returned but that could make more difficult to debug and find > the cause of why the function actually failed. > > Since the driver/devic

Re: [PATCH 1/8] mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > SDIO is an auto enumerable bus so the SDIO devices are matched using the > sdio_device_id table and not using compatible strings from a OF id table. > > However, commit ce4f6f0c353b ("mwifiex: add platform specific wakeup

Re: wireless-testing on 4.7

2016-05-31 Thread Reinoud Koornstra
Today I compiled 4.6+ and pulled sources today iwlwifi isn't super smooth. [ 112.345457] wlp4s0: authenticate with 00:30:44:1d:cf:2b [ 112.349002] wlp4s0: send auth to 00:30:44:1d:cf:2b (try 1/3) [ 112.349647] wlp4s0: authenticated [ 112.352456] wlp4s0: associate with 00:30:44:1d:cf:2b (try 1/

Re: [PATCH] cfg80211: remove extra space on alpha2 definition

2016-05-31 Thread Julian Calaby
Hi All, On Fri, May 27, 2016 at 9:25 PM, Eduardo Abinader wrote: > Just small adjustment. > > Signed-off-by: Eduardo Abinader This looks right to me. Reviewed-by: Julian Calaby > --- > net/wireless/reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, -- Julian Calaby Em

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Valo, Kalle
Mohammed Shafi Shajakhan writes: >> > +void ath10k_sta_update_rx_duration(struct ath10k *ar, >> > + struct ath10k_fw_stats *stats) >> > +{ >> > + struct ath10k_fw_file *fw_file = &ar->normal_mode_fw.fw_file; >> > + >> > + if (fw_file->wmi_op_version < ATH10K_FW_WMI_O

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-31 Thread Jes Sorensen
Daniel Lenski writes: > On Tue, May 31, 2016 at 8:04 AM, Jes Sorensen wrote: >> Given your follow-on discoveries, do you still want me to apply the poll >> timeout patch, or should we wait until we nail down the reset code issue >> first? > > No, I don't think the timeout patch is worth appying.

Re: [PATCH V2 iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Johannes Berg
On Tue, 2016-05-31 at 18:28 +0200, Rafał Miłecki wrote: >  > +static int print_channels_handler(struct nl_msg *msg, void *arg) > +{ > + struct genlmsghdr *gnlh = nlmsg_data(nlmsg_hdr(msg)); > + extra blank line > + struct nlattr *tb_msg[NL80211_ATTR_MAX + 1]; > + struct nlattr *tb_ban

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-31 Thread Daniel Lenski
On Tue, May 31, 2016 at 8:04 AM, Jes Sorensen wrote: > Given your follow-on discoveries, do you still want me to apply the poll > timeout patch, or should we wait until we nail down the reset code issue > first? No, I don't think the timeout patch is worth appying. I believe it was just dumb luck

[PATCH V2 iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Rafał Miłecki
Channels (frequencies) are getting more details that users may want to know about. E.g. it's important to know which frequencies allow using 40/80/160 MHz channels to setup AP properly. We list channels in "info" command output but it's already quite big and it was agreed to introduce new command

Re: [PATCH iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Rafał Miłecki
On 31 May 2016 at 17:58, Rafał Miłecki wrote: > On 31 May 2016 at 15:14, Johannes Berg wrote: >> On Tue, 2016-05-31 at 15:10 +0200, Rafał Miłecki wrote: >> >>> > Unfortunately, I get compiler warnings about width_* being possibly >>> > used uninitialized. Can you address that please? >>> It's nic

Re: [PATCH iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Rafał Miłecki
On 31 May 2016 at 15:14, Johannes Berg wrote: > On Tue, 2016-05-31 at 15:10 +0200, Rafał Miłecki wrote: > >> > Unfortunately, I get compiler warnings about width_* being possibly >> > used uninitialized. Can you address that please? >> It's nice your compiled got this mistake, my didn't. There wer

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-31 Thread Jes Sorensen
Jes Sorensen writes: > Dan Lenski writes: >> Here is a patch to increase the polling timeout for rtl8xxxu firmware >> startup. >> >> This patch now applies cleanly to Jes Sorensen's rtl8xxxu-devel tree >> (86c89dd4782030c4f9e0c82424a8b92f9fdb35aa). >> >> The patch to make this a module parameter

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Mohammed Shafi Shajakhan
Hi Kalle, thanks for the review On Tue, May 31, 2016 at 12:18:49PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > 10.4 'extended peer stats' will be not be appended with normal peer stats > > data and they shall be coming in separate

Re: [PATCH v2] cfg80211: Advertise extended capabilities per interface type to userspace

2016-05-31 Thread Johannes Berg
On Mon, 2016-05-16 at 10:41 +0530, Kanchanapally, Vidyullatha wrote: > From: "Kanchanapally, Vidyullatha" > > The driver extended capabilities may differ for different > interface types which the userspace needs to know (for > example the fine timing measurement initiator and responder > bits mig

Re: [PATCH v4] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-05-31 Thread Mohammed Shafi Shajakhan
On Tue, May 31, 2016 at 11:41:08AM +0200, Johannes Berg wrote: > On Thu, 2016-04-07 at 20:00 +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. > > 'NL80211_STA_INFO_RX_DURATION' accounts for aggr

Re: [PATCH] cfg80211: Allow cfg80211_connect_result() errors to be distinguished

2016-05-31 Thread Johannes Berg
On Tue, 2016-05-31 at 00:16 +0300, Jouni Malinen wrote: > Previously, the status parameter to cfg80211_connect_result() was > documented as using WLAN_STATUS_UNSPECIFIED_FAILURE (1) when the real > status code for the failure is not known. This value can be used by > an > AP (and often is) and as s

Re: [PATCH iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Johannes Berg
On Tue, 2016-05-31 at 15:10 +0200, Rafał Miłecki wrote: > > Unfortunately, I get compiler warnings about width_* being possibly > > used uninitialized. Can you address that please? > It's nice your compiled got this mistake, my didn't. There were > actually meant to be static. I'll fix that. I ac

Re: [PATCH iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Rafał Miłecki
On 31 May 2016 at 12:16, Johannes Berg wrote: > On Fri, 2016-05-20 at 12:13 +0200, Rafał Miłecki wrote: >> Channels (frequencies) are getting more details that users may want >> to >> know about. E.g. it's important to know which frequencies allow using >> 40/80/160 MHz channels to setup AP proper

Re: [PATCH v2] mac80211: add vht cap decode to debugfs.

2016-05-31 Thread Johannes Berg
On Fri, 2016-05-13 at 11:29 -0700, gree...@candelatech.com wrote: > From: Ben Greear > > This makes it a lot easier to understand the capabilities used > by the station: > Applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to

Re: [PATCH] net/wireless: Fix 'multiple blank lines' check

2016-05-31 Thread Julian Calaby
Hi All, On Tue, May 31, 2016 at 3:58 PM, Kirtika Ruchandani wrote: > This patch fixes the checkpatch.pl check "Please don't use multiple > blank lines" for all files in net/wireless, except nl80211.c which > is covered in a separated patch. > > Signed-off-by: Kirtika Ruchandani Looks right to m

Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Tue, May 31, 2016 at 11:09:38AM +, Valo, Kalle wrote: > "Shajakhan, Mohammed Shafi (Mohammed Shafi)" > writes: > > seems the change got merged in pending branch > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=2a872321e07506e339fc1b3ca81a

Re: [PATCH] wireless-regdb: Republic of Korea: Add 60GHz regulatory rules

2016-05-31 Thread Seth Forshee
On Sat, May 21, 2016 at 12:25:08PM +0300, Maya Erez wrote: > Add 60GHz regulatory rules for Korea (KR). > Source is > http://www.law.go.kr/%ED%96%89%EC%A0%95%EA%B7%9C%EC%B9%99/%EB%AC%B4%EC%84%A0%EC%84%A4%EB%B9%84%EA%B7%9C%EC%B9%99 > > Signed-off-by: Maya Erez > --- > db.txt | 4 > 1 file ch

Re: [Make-wifi-fast] [PATCHv5 0/5] mac80211: implement fq_codel

2016-05-31 Thread Michal Kazior
On 31 May 2016 at 14:12, Toke Høiland-Jørgensen wrote: > Michal Kazior writes: > >> This patchset disables qdiscs for drivers >> using software queuing and performs fq_codel-like >> dequeuing on txqs. > > Hi Michal > > Is this version in a git repo somewhere I can pull from? :) Just pushed, enjo

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Valo, Kalle
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > 10.4 'extended peer stats' will be not be appended with normal peer stats > data and they shall be coming in separate chunks. Fix this by maintaining > a separate linked list 'extender peer stats' for 10.4 and update > rx_dura

Re: [Make-wifi-fast] [PATCHv5 0/5] mac80211: implement fq_codel

2016-05-31 Thread Toke Høiland-Jørgensen
Michal Kazior writes: > This patchset disables qdiscs for drivers > using software queuing and performs fq_codel-like > dequeuing on txqs. Hi Michal Is this version in a git repo somewhere I can pull from? :) -Toke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

4.7-rc1 wifi driver bug report

2016-05-31 Thread Grey Christoforo
Hi, I found the following in my dmesg today when I tried out 4.7-rc1 on my Dell XPS15 9550. My WiFi doesn't work. Relevant bits of my lsusb & lspci are: $ lsusb ... Bus 001 Device 002: ID 0a5c:6410 Broadcom Corp. ... $ lspci ... 02:00.0 Network controller: Broadcom Corporation BCM43602 802.11ac

Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Valo, Kalle
"Shajakhan, Mohammed Shafi (Mohammed Shafi)" writes: > seems the change got merged in pending branch > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=2a872321e07506e339fc1b3ca81aa3e88628cd6e > > Request if you can send the patch to address this(incase the pa

Re: [PATCH 1/3] nl80211: Fix checkpatch warnings

2016-05-31 Thread Johannes Berg
On Mon, 2016-05-30 at 10:30 +1000, Julian Calaby wrote: > Hi All, > > On Sun, May 29, 2016 at 1:30 PM, Kirtika Ruchandani > wrote: > > > > This patch fixes the following checkpatch.pl warnings about > > comments in nl80211.c : > > - networking block comments don't use an empty '/*' line > > - bl

Re: [PATCH] iw: support setting frame subtype and reason code when deleting station

2016-05-31 Thread Johannes Berg
On Tue, 2016-05-31 at 12:03 +0200, Rafał Miłecki wrote: > On 31 May 2016 at 11:44, Johannes Berg > wrote: > > > > Applied. > > > > On Wed, 2016-05-04 at 17:38 +0200, Rafał Miłecki wrote: > > > > > > Signed-off-by: Rafał Miłecki > > Oddly enough, patchwork corrupted *this*, but not the From: li

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

2016-05-31 Thread Johannes Berg
> The requirement is to be __aligned(2). I've added 4 instances of > ether_addr_copy with 8 addresses as arguments.  Of these, the 4 > src arguments are really the same type (i.e. nla_data acting on a > const nlattr*), so I'll try to reason about the 5 total cases below - > 1. cfg->dst_mac should

Re: [PATCH] wext: Fix 32 bit iwpriv compatibility issue with 64 bit Kernel

2016-05-31 Thread Johannes Berg
Hi, I must say, this is a bit of a surprise - where is iwpriv actually still relevant? What driver could this possibly matter for? Anyway ... > + if (dev->netdev_ops->ndo_do_ioctl) { > + if ((info->flags & IW_REQUEST_FLAG_COMPAT) && > + (cmd >= SIOCIWF

Re: [PATCH iw] add "channels" PHY command listing frequencies with more details

2016-05-31 Thread Johannes Berg
On Fri, 2016-05-20 at 12:13 +0200, Rafał Miłecki wrote: > Channels (frequencies) are getting more details that users may want > to > know about. E.g. it's important to know which frequencies allow using > 40/80/160 MHz channels to setup AP properly. > > We list channels in "info" command output bu

Re: [PATCH] mac80211: fix fast_tx header alignment

2016-05-31 Thread Johannes Berg
On Thu, 2016-05-19 at 17:34 +0200, Felix Fietkau wrote: > The header field is defined as u8[] but also accessed as struct > ieee80211_hdr. Enforce an alignment of 2 to prevent unnecessary > unaligned accesses, which can be very harmful for performance on many > platforms. > > Applied, thanks. jo

Re: [PATCH v2] mac80211: mesh: flush mesh paths unconditionally

2016-05-31 Thread Johannes Berg
On Sun, 2016-05-15 at 13:19 -0400, Bob Copeland wrote: > Currently, the mesh paths associated with a nexthop station are > cleaned > up in the following code path: > > __sta_info_destroy_part1 > synchronize_net() > __sta_info_destroy_part2 >  -> cleanup_single_sta >    -> mesh_

Re: [PATCH] mac80211_hwsim: Add missing check for HWSIM_ATTR_SIGNAL

2016-05-31 Thread Johannes Berg
On Fri, 2016-05-13 at 12:41 +0200, Martin Willi wrote: > A wmediumd that does not send this attribute causes a NULL pointer > dereference, as the attribute is accessed even if it does not exist. > > The attribute was required but never checked ever since userspace > frame > forwarding has been int

Re: [PATCH] iw: support setting frame subtype and reason code when deleting station

2016-05-31 Thread Rafał Miłecki
On 31 May 2016 at 11:44, Johannes Berg wrote: > Applied. > > On Wed, 2016-05-04 at 17:38 +0200, Rafał Miłecki wrote: >> Signed-off-by: Rafał Miłecki > > Oddly enough, patchwork corrupted *this*, but not the From: line ... This patch was sent before patchwork update, I guess crazy things could ha

Re: [PATCH 1/1] version.sh: update to get version with git correctly

2016-05-31 Thread Johannes Berg
On Tue, 2016-05-03 at 13:48 +0800, Yongqin Liu wrote: > update to get the version information from the > git repository where this file is located instead of the > the current directory where it is executed, otherwise if > there is .git directory in the current directory, it will > get the wrong ve

Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

2016-05-31 Thread Johannes Berg
Applied. However, note that I had to do it manually, so if you're planning to send any more patches please fix your mailer to not corrupt whitespace (the tabs were replaced by spaces, so the patch couldn't apply automatically) johannes -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] iw: support setting frame subtype and reason code when deleting station

2016-05-31 Thread Johannes Berg
Applied. On Wed, 2016-05-04 at 17:38 +0200, Rafał Miłecki wrote: > Signed-off-by: Rafał Miłecki Oddly enough, patchwork corrupted *this*, but not the From: line ... johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.k

Re: [PATCH] iw: add vendor command response support

2016-05-31 Thread Johannes Berg
On Mon, 2016-05-02 at 21:55 +0200, Erik Stromdahl wrote: > Introduced two new commands for reading vendor command responses: > recv and recvbin > Both will send a vendor command (typically some kind of GET request) > in the same way as the current send command and print the received > response in A

Re: [PATCH v4] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-05-31 Thread Johannes Berg
On Thu, 2016-04-07 at 20:00 +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. > 'NL80211_STA_INFO_RX_DURATION' accounts for aggregate PPDU duration > in microseconds for all the frames from a peer. Dri

Re: [PATCH] iw: Change socket configuration to avoid buffer allocation error

2016-05-31 Thread Johannes Berg
On Wed, 2016-05-18 at 11:22 +, Tribush, Gil wrote: > Move  nl_socket_set_buffer_size() to be called after genl_connect(), > otherwise nl_socket_set_buffer_size() always returns an NLE_BAD_SOCK > error because sk->s_fd is equal to -1 at that stage. > Applied. johannes -- To unsubscribe from t

ath9k gpio request

2016-05-31 Thread Kalle Valo
(Changing subject to a more descriptive one, was "Re: linux-next: Tree for May 30") Sudip Mukherjee writes: > Hi All, > I have just built and booted with next-20160530 and my dmesg is full > of warnings from ath9k. Last kernel tested was v4.6 and there was no > problem with that. > > The traces