On 27 June 2016 at 16:36, Mohammed Shafi Shajakhan
wrote:
> Hi Michal,
>
> thanks for the review ..
>
> On Mon, Jun 27, 2016 at 11:27:27AM +0200, Michal Kazior wrote:
>> On 23 June 2016 at 18:40, Mohammed Shafi Shajakhan
>> wrote:
>> > From: Mohammed Shafi Shajakhan
>> >
>> > For chipsets like Q
On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote:
> On 06/25/2016 05:46 PM, Joe Perches wrote:
> >
> > This debugging macro can expand to a lot of code.
> > Make it a function to reduce code size.
> >
> > (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig)
> > $ size drivers/net/wirel
Hello,
Sorry if this is not the proper way to report this but I noticed
something that has to be an error in commit
"baa1702290953295e421f0f433e2b1ff4815827c"
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=baa1702290953295e421f0f433e2b1ff4815827c
in the file "
PATCH v8 changes since PATCH v7:
- Used scnprintf() to replace sprintf() for debugfs output messages to avoid
overwriting buffer boundary.
- Used mutex to replace spinlock for the protection of firmware command.
- Used NL80211_BAND_ instead of IEEE80211_BAND_ (in order to work with
updated
On 06/27/2016 04:23 PM, Joe Perches wrote:
On Mon, 2016-06-27 at 10:52 -0500, Larry Finger wrote:
This driver contains some complicated if ... else if ... else
constructions. These are replaced by switch statements to improve
readability.
[]
diff --git a/drivers/net/wireless/realtek/rtlwifi/r
On 06/25/2016 05:46 PM, Joe Perches wrote:
This debugging macro can expand to a lot of code.
Make it a function to reduce code size.
(x86-64 defconfig w/ all rtlwifi drivers and allyesconfig)
$ size drivers/net/wireless/realtek/rtlwifi/built-in.o*
text data bss dec hex
broken patch
CC [M]
/home/seg/DEV/pb42/src/router/private/compat-wireless-2016-05-12/drivers/net/wireless/ath/ath10k/htt_tx.o
/home/seg/DEV/pb42/src/router/private/compat-wireless-2016-05-12/drivers/net/wireless/ath/ath10k/htt_tx.c:
In function 'ath10k_htt_tx_free':
/home/seg/DEV/pb42/src/rou
forget about it. it was caused by another patch here on this list.
Am 28.06.2016 um 00:45 schrieb Sebastian Gottschall:
broken patch
CC [M]
/home/seg/DEV/pb42/src/router/private/compat-wireless-2016-05-12/drivers/net/wireless/ath/ath10k/htt_tx.o
/home/seg/DEV/pb42/src/router/private/compat-w
On Mon, 2016-06-27 at 10:52 -0500, Larry Finger wrote:
> This driver contains some complicated if ... else if ... else
> constructions. These are replaced by switch statements to improve
> readability.
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
> b/drivers/net/wireless/
On Monday, June 27, 2016 10:52:29 AM CEST Larry Finger wrote:
> All of the rtlwifi family of drivers have a similar routine that acquires
> the hardware info from efuse and initializes a number of variables in the
> driver's private area. A common routine is created for all drivers to use.
>
> Rep
There were a some others as well:
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26511
wlc_phy_rxcal_radio_setup_nphy() warn: mask and shift to zero
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26585
wlc_phy_rxcal_radio_setup_nphy() warn: mask and shift to zero
driv
From: Jes Sorensen
This adds support for allocating larger skbs for devices which
indicate they support it.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 ++
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 13 +
2 files changed,
From: Jes Sorensen
Hi
This patchset enabled RX packet DMA aggregation, batching multiple
received packets into larger buffers. This should reduce the number of
DMA transactions and the number of USB interrupts due to DMA complete
notifications.
Since this is new code, I am leaving it disabled p
From: Jes Sorensen
Implement rtl8xxxu_gen1_init_aggregation(). Aggregation should be the
same for all gen1 parts. We may want to allow for tuning parameters in
the fileopes struct. For now this is based allocating 16KB RX buffers,
leaving 16000 bytes for actual packets, and the rest for the skb
o
From: Jes Sorensen
When handling aggregated packets, we'll get a new ieee80211_rx_status
for each cloned skb, so passing in the pointer from the outside
doesn't make sense.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 9 +++--
drivers/net/wireles
From: Jes Sorensen
This is another prepatory patch to be able to handle aggregated RX
packets.
In order to avoid adding a prototype, this also moves the
rtl8723bu_handle_c2h() function.
Signed-off-by: Jes Sorensen
---
.../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 104 ++
From: Jes Sorensen
The old allocation didn't leave space for phystats in the buffer,
allowing the packet to be rejected if a frame size of size
IEEE80211_MAX_FRAME_LEN was received.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 7 ---
1 file change
From: Jes Sorensen
This enables aggregation on rtl8192cu and derivative parts. This uses
the same parameters as for rtl8723au.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realt
From: Jes Sorensen
This needs to be handled locally in the parse_rx_desc() function in
order to be able to handle aggregated packets in the future.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 17 -
1 file changed, 12 insertions(+), 5
From: Jes Sorensen
This implements support for demuxing aggregated RX packets on gen1
devices, using the rxdesc16 format.
So far this has only been tested with rtl8723au devices.
Signed-off-by: Jes Sorensen
---
.../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 103 ++---
1
From: Jes Sorensen
Let the default to off until we have more data on the right default
tuning values.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realt
From: Jes Sorensen
This corrects the definition of rxdesc16 to correctly specify pkt_cnt
for aggregated packets. This is based on the code of the vendor
rtl8723au driver, as opposed to the struct definitions they use.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xx
From: Jes Sorensen
This allows the user to specify DMA aggregation timout and block
count. Blocks are presumably always 512 bytes, so the minimum block
count is 6 for 802.11 packets.
Signed-off-by: Jes Sorensen
---
.../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 28 ++
From: Jes Sorensen
gen2 chips as well as 8188eu seems to use this register for setting
DMA timeout threshold values, however the 8192cu is using
REG_USB_DMA_AGG_TO. Set both to be on the safe side.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 11 +
This driver contains some complicated if ... else if ... else
constructions. These are replaced by switch statements to improve
readability.
Signed-off-by: Larry Finger
---
V2 - Changes suggested by Joe Perches were incorporated
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE ca
The driver for RTL8192DE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
The rtlwifi family of drivers use similar routines to extract hardware
information from EFUSE. This set of patches create a common routine to
extract this data, and converts most of the drivers to use this routine.
In addition, a complicated set of if ... else if ... else statements are
present in
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
The driver for RTL8192CE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
The driver for RTL8192CU chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
The driver for RTL8723BE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
All of the rtlwifi family of drivers have a similar routine that acquires
the hardware info from efuse and initializes a number of variables in the
driver's private area. A common routine is created for all drivers to use.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
The driver for RTL8188EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
The driver for RTL8192EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
The driver for RTL8723AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_TRACE
On Mon, Jun 27, 2016 at 2:57 PM, Mark Rutland wrote:
>> > Please find a better way to identify relevant FW. What exactly affects
>> > which FW can be used, or would ideally be used? Are different FWs
>> > required for the same HW in some contexts?
>> >
>> > Can we not figure out the relevant FW na
Hi Michal,
thanks for the review ..
On Mon, Jun 27, 2016 at 11:27:27AM +0200, Michal Kazior wrote:
> On 23 June 2016 at 18:40, Mohammed Shafi Shajakhan
> wrote:
> > From: Mohammed Shafi Shajakhan
> >
> > For chipsets like QCA99X0, IPQ4019 and later we are not getting proper
> > NULL func status
We normally return an unitialized value, but no one checks it so it
doesn't matter. Anyway, let's silence the static checker warning.
Signed-off-by: Dan Carpenter
diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
index 1c7d45a..b5d28f1 100644
--- a/net/mac80211/tdls.c
+++ b/net/mac80211/td
On 27/06/16 15:10, Nicolas Ferre wrote:
> From: Aditya Shankar
>
> Take the maintenance of the Atmel WIFI staging driver wilc1000.
> Former maintainers are no more with Atmel.
>
> Reported-by: Loic Lefort
> Signed-off-by: Aditya Shankar
> Signed-off-by: Ganesh Krishna
> Signed-off-by: Nicolas
From: Aditya Shankar
Take the maintenance of the Atmel WIFI staging driver wilc1000.
Former maintainers are no more with Atmel.
Reported-by: Loic Lefort
Signed-off-by: Aditya Shankar
Signed-off-by: Ganesh Krishna
Signed-off-by: Nicolas Ferre
---
Hi Luis, Greg,
I'd like that we don't delete
Hello Rafał Miłecki,
The patch 6f98e62a9f1b: "b43: update cordic code to match current
specs" from Jan 25, 2010, leads to the following static checker
warning:
drivers/net/wireless/broadcom/b43/phy_lp.c:1803 lpphy_start_tx_tone()
warn: mask and shift to zero
drivers/net/wireless/
Changed the configuration to support 64bit instead of 32bit
this in order to offload the driver from handling a wraparound.
Signed-off-by: Yaniv Machani
---
V2 - Update the interface parameters type to le16 from u16.
drivers/net/wireless/ti/wl18xx/event.c | 26 +-
driver
Hello Arend van Spriel,
The patch 5b435de0d786: "net: wireless: add brcm80211 drivers" from
Oct 5, 2011, leads to the following static checker warning:
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26460
wlc_phy_rxcal_radio_setup_nphy()
warn: mask and shift to zero
When sending an email regarding a patch to wilc1000, you get the following
automatic replies:
"Sung_hoon Cho is no longer with Atmel Corporation."
"Kang_hee Park is no longer with Atmel Corporation."
"Dong_ho Shin is no longer with Atmel Corporation."
"Bo_moon Kim is no longer with Atmel Corporatio
On 2016-06-27 14:57, Mark Rutland wrote:
> On Thu, Jun 23, 2016 at 08:14:29PM +0200, Martin Blumenstingl wrote:
>> On Thu, Jun 23, 2016 at 7:58 PM, Mark Rutland wrote:
>> > On Thu, Jun 23, 2016 at 07:45:35PM +0200, Martin Blumenstingl wrote:
>> >> +- qca,eeprom-name: The name of the file which con
On 25/06/16 23:16, Greg KH wrote:
> On Sat, Jun 25, 2016 at 10:43:33PM +0100, Luis de Bethencourt wrote:
>> On 25/06/16 22:36, Greg KH wrote:
>>> On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote:
The common format to check if a function returned an error pointer is to
u
We can just ignore the return value from debugfs_create_dir() and
debugfs_create_file(). The second one already interanlly checks the dentry
created by the first before creating the file.
debugfs was written so it would be easy to use, no need for error checking.
Signed-off-by: Luis de Bethencour
On Thu, Jun 23, 2016 at 08:14:29PM +0200, Martin Blumenstingl wrote:
> On Thu, Jun 23, 2016 at 7:58 PM, Mark Rutland wrote:
> > On Thu, Jun 23, 2016 at 07:45:35PM +0200, Martin Blumenstingl wrote:
> >> +- qca,eeprom-name: The name of the file which contains the EEPROM data
> >> (which
> >> +
Some lockdep assertions were not fulfilled and
resulted in a kernel warning/call trace.
Existing code sequences should've guranteed safety
but it's always good to be extra careful.
The call trace could look like this:
[ 237.335805] [ cut here ]
[ 237.335852] WARNING: CP
Prasun Maiti writes:
>> If you send a new version of the patch mark it as [PATCH v2] and always
>> include a change log so that people don't need to guess what has
>> changed:
>>
>> http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb
>>
>> So now you should sen
On 2016-06-24 14:34, Martin Blumenstingl wrote:
> Signed-off-by: Martin Blumenstingl
> ---
> this is a new patch which didn't exist in v2 yet, it prepares the new
> function ath_bus_type_to_string which will be used in patch #3
>
> drivers/net/wireless/ath/ath.h | 2 ++
> drivers/net/wireless/
For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS,
HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are
saved to driver. So, "leX_to_cpu" conversion is required too many
times afterwards in driver.
This patch reduces the endian: conversion without saving "cpu_to_le
From: Chaitanya T K
If peer support reception of STBC and LDPC, enable them for better
performance.
Signed-off-by: Chaitanya TK
---
include/linux/ieee80211.h |1 +
net/mac80211/rc80211_minstrel_ht.c | 25 +
2 files changed, 18 insertions(+), 8 deletions(-
Martin Blumenstingl writes:
> Add documentation how devicetree can be used to configure ath9k based
> devices.
>
> Signed-off-by: Martin Blumenstingl
> ---
> changes in v2 -> v3:
> - improved wording of the qca,disable-2ghz and qca,disable-5ghz properties
> - replaced qca,eeprom-name with qca,no
On 23 June 2016 at 18:40, Mohammed Shafi Shajakhan
wrote:
> From: Mohammed Shafi Shajakhan
>
> For chipsets like QCA99X0, IPQ4019 and later we are not getting proper
> NULL func status (always acked/successs !!) when hostapd does a
> PROBE_CLIENT via nullfunc frames when the station is powered of
From: Tamizh chelvam
This patch adds testmode support for QCA99X0 chipsets which uses
10.4 firmware and added code swap support for UTF binary.
Signed-off-by: Tamizh chelvam
---
drivers/net/wireless/ath/ath10k/testmode.c | 23 +++
1 file changed, 23 insertions(+)
diff --
From: Tamizh chelvam
Currently testmode events for 10.x firmware are processed from
10.1 wmi event processing. This patch is used to handle testmode
events in 10.2 and 10.4 based firmware.
Signed-off-by: Tamizh chelvam
---
drivers/net/wireless/ath/ath10k/wmi.c | 26 ++
From: Tamizh chelvam
*The below patches add testmode support for 10.4.
*Some of the codeswap related code in ath10k for example code
which initializes the code swap segment works only on normal fw,
below patches make such code generic so that it can be used
for utf binary as well.
Tamizh chel
From: Tamizh chelvam
Preparation to make use of firmware_swap_code_seg_info for
UTF binary.
Signed-off-by: Tamizh chelvam
---
drivers/net/wireless/ath/ath10k/core.c |6 +++---
drivers/net/wireless/ath/ath10k/core.h |6 ++
drivers/net/wireless/ath/ath10k/swap.c | 26 ++
This patch fixes below NULL pointer dereference observed in suspend
stress test. When scan is cancelled during system suspend, we may end
up aceesing "priv->scan_request" in corner case.
[ 3035.304682] BUG: KASAN: null-ptr-deref on address 0008
[ 3035.304704] Read of size 4 by task ksd
The flag should be cleaned along with other scan operation variables.
This was missing at some places.
Signed-off-by: Amitkumar Karwar
---
drivers/net/wireless/marvell/mwifiex/scan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c
b/drivers/net
We will derive sta_priv at the beginning of suspend handler.
This will be useful for next patch in this series.
Signed-off-by: Amitkumar Karwar
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wirel
From: Tamizh chelvam
This patch adds testmode support for QCA99X0 chipsets which uses
10.4 firmware and added code swap support for UTF binary.
Signed-off-by: Tamizh chelvam
---
drivers/net/wireless/ath/ath10k/testmode.c | 23 +++
1 file changed, 23 insertions(+)
diff --
From: Tamizh chelvam
Currently testmode events for 10.x firmware are processed from
10.1 wmi event processing. This patch is used to handle testmode
events in 10.2 and 10.4 based firmware.
Signed-off-by: Tamizh chelvam
---
drivers/net/wireless/ath/ath10k/wmi.c | 26 ++
From: Tamizh chelvam
*The below patches add testmode support for 10.4.
*Some of the codeswap related code in ath10k for example code
which initializes the code swap segment works only on normal fw,
below patches make such code generic so that it can be used
for utf binary as well.
Tamizh chel
From: Tamizh chelvam
Preparation to make use of firmware_swap_code_seg_info for
UTF binary.
Signed-off-by: Tamizh chelvam
---
drivers/net/wireless/ath/ath10k/core.c |6 +++---
drivers/net/wireless/ath/ath10k/core.h |6 ++
drivers/net/wireless/ath/ath10k/swap.c | 26 ++
Mirco Tischler writes:
>>Thanks, 1 patch applied to ath-current branch of ath.git:
>>
>>e024111f6946 ath9k: fix GPIO mask for AR9462 and AR9565
>
> I see this warning in 4.7-rc4. Could the fix please go into 4.7? if I
> understand correctly it is only queued for 4.8?
The patch is queued for 4.7
From: Tamizh chelvam
*The below patches add testmode support for 10.4.
*Some of the codeswap related code in ath10k for example code
which initializes the code swap segment works only on normal fw,
below patches make such code generic so that it can be used
for utf binary as well.
Tamizh chel
Kalle Valo wrote:
>miaoqing pan wrote:
>> From: Miaoqing Pan
>>
>> The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
>> Also fix the mask for AR9565.
>>
>> WARNING: CPU: 1 PID: 199 at ../drivers/net/wireless/ath/ath9k/hw.c:2778
>> ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw
Hi Prasun,
> From: Prasun Maiti [mailto:prasunmait...@gmail.com]
> Sent: Thursday, June 23, 2016 10:59 AM
> To: Amitkumar Karwar
> Cc: Nishant Sarmukadam; Linux Wireless; Linux Next; Linux Kernel; Kalle
> Valo
> Subject: [PATCH v3] mwifiex: Reduce endian conversion for REG Host
> Commands
>
> For
70 matches
Mail list logo
