Re: [PATCH] ath10k: disable wake_tx_queue for older devices

2016-07-31 Thread Roman Yeryomin
On 7 July 2016 at 19:30, Valo, Kalle wrote: > Michal Kazior writes: > >> Ideally wake_tx_queue should be used regardless as >> it is a requirement for reducing bufferbloat and >> implementing airtime fairness in the future. >> >> However some setups (typically low-end platforms >> hosting QCA988X

Re: [PATCH 1/1] rtlwifi: remove superfluous condition

2016-07-31 Thread Larry Finger
On 07/31/2016 05:30 AM, Heinrich Schuchardt wrote: If sta == NULL, the changed line will not be reached. So no need to check if stat == NULL here. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I agree.

[PATCH 1/1] mwifiex: key_material_v2 remove superfluous condition

2016-07-31 Thread Heinrich Schuchardt
We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/marvell/mwi

Re: [PATCH 1/1] mwifiex: remove superfluous condition (2)

2016-07-31 Thread Kalle Valo
Heinrich Schuchardt writes: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt Please try to make the commit titles unique, for example you can use function names or something else. Adding "(2)" is not the

[PATCH 1/1] mwifiex: remove superfluous condition (2)

2016-07-31 Thread Heinrich Schuchardt
We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/marvell/mwi

[PATCH 1/1] mwifiex: remove superfluous condition

2016-07-31 Thread Heinrich Schuchardt
for_each_property_of_node is only executed if the property prop is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/wir

[PATCH 1/1] rtlwifi: remove superfluous condition

2016-07-31 Thread Heinrich Schuchardt
If sta == NULL, the changed line will not be reached. So no need to check if stat == NULL here. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/dr

Re: Dell Venue 8 Pro "Dell Wireless" (Atheros 6k) chipset with SDIO ID 0271:0418 not recognized/supported

2016-07-31 Thread Kalle Valo
russianneuroman...@ya.ru writes: > Please look into commentary 50 from bugreport > https://bugzilla.kernel.org/show_bug.cgi?id=67921#c50 > There is patch for enabling support of Atheros Wireless adapter in Dell Venue > 8 Pro tablet. > > Please review if this possible to include this patch int

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-07-31 Thread Dmitry Torokhov
On July 30, 2016 9:58:17 AM PDT, "Luis R. Rodriguez" wrote: >On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: >> + Luis (again) ;-) >> >> On 29-07-16 08:13, Daniel Wagner wrote: >> > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >> >> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokho

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-07-31 Thread Dmitry Torokhov
On July 30, 2016 5:42:41 AM PDT, Arend van Spriel wrote: >+ Luis (again) ;-) > >On 29-07-16 08:13, Daniel Wagner wrote: >> On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >>> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: >>> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote