Re: [PATCHv3 1/3] ath10k: move firmware_swap_code_seg_info to ath10k_fw_file

2016-08-31 Thread Valo, Kalle
Julian Calaby writes: > Hi Tamizh, > > On Fri, Jul 1, 2016 at 5:06 PM, wrote: >> From: Tamizh chelvam >> >> Preparation to make use of firmware_swap_code_seg_info for UTF binary. >> >> Signed-off-by: Tamizh chelvam >> --- >> drivers/net/wireless/ath/ath10k/core.c |6 +++--- >> drivers/ne

Re: ath10k: fix get rx_status from htt context

2016-08-31 Thread Kalle Valo
Ashok Raj Nagarajan wrote: > On handling amsdu on rx path, get the rx_status from htt context. Without this > fix, we are seeing warnings when running DBDC traffic like this. > > WARNING: CPU: 0 PID: 0 at net/mac80211/rx.c:4105 ieee80211_rx_napi+0x88/0x7d8 > [mac80211]() > > [ 1715.878248] CPU:

Re: [PATCHv3, 1/3] ath10k: move firmware_swap_code_seg_info to ath10k_fw_file

2016-08-31 Thread Kalle Valo
c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > Preparation to make use of firmware_swap_code_seg_info for UTF binary. > > Signed-off-by: Tamizh chelvam Thanks, 3 patches applied to ath-next branch of ath.git: 5459c5d47608 ath10k: move firmware_swap_code_seg_info to ath10k_fw_file

Re: ath10k: Remove driver log suggesting QCA9887 support is experimental

2016-08-31 Thread Kalle Valo
Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Support for QCA9887 is no longer experimental and if there are any issues > we need to address them > > Signed-off-by: Mohammed Shafi Shajakhan Thanks, 1 patch applied to ath-current branch of ath.git: 4e80ffab0e72 ath10k:

Re: [1/4] ath10k: implement wmi echo command

2016-08-31 Thread Kalle Valo
Michal Kazior wrote: > Will be useful for implementing command barriers. > > Signed-off-by: Michal Kazior Thanks, 4 patches applied to ath-next branch of ath.git: e25854f2404c ath10k: implement wmi echo command 84d4911b7184 ath10k: implement wmi echo event 20ddca21dcf8 ath10k: add wmi command

Re: [1/4] wil6210: fix protection of wil->scan_request

2016-08-31 Thread Kalle Valo
Maya Erez wrote: > From: Lior David > > Currently the places that check wil->scan_request and > call cfg80211_scan_done are not consistently protected, > so there is a risk that cfg80211_scan_done will be called > with NULL scan_request, causing a kernel crash. > Fix this by using p2p_wdev_mutex

Re: [RESEND, v4] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-08-31 Thread Kalle Valo
Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > For chipsets like QCA99X0, IPQ4019 and later we are not getting proper > NULL func status (always acked/successs !!) when hostapd does a > PROBE_CLIENT via nullfunc frames when the station is powered off > abruptly (inactive ti

Re: ath10k: fix throughput regression in multi client mode

2016-08-31 Thread Kalle Valo
Rajkumar Manoharan wrote: > commit 7a0adc83f34d ("ath10k: improve tx scheduling") is causing > severe throughput drop in multi client mode. This issue is originally > reported in veriwave setup with 50 clients with TCP downlink traffic. > While increasing number of clients, the average throughput

Re: [patch] ath9k: indent an if statement

2016-08-31 Thread Kalle Valo
Dan Carpenter writes: > It looks like this code is correct, but it just needs to be indented a > bit. > > Signed-off-by: Dan Carpenter Doesn't apply anymore: Importing patch "ath9k-indent-an-if-statement" ... error: patch failed: drivers/net/wireless/ath/ath9k/main.c:919 error: drivers/net/wi

Re: [RFD] mac80211: Handling local operating class in (E)CSA

2016-08-31 Thread Krishna Chaitanya
On Mon, Jul 25, 2016 at 12:56 PM, Krishna Chaitanya wrote: > > Hi, > > Some AP's use local operating class in (E)CSA IE's. Currently > mac80211 fails the parsing of those IE's and results in a > disconnection. > > What is the best way to add support for local operating classes? > > a) Maintaining

RE: [PATCH] mwifiex: handle edmac vendor command

2016-08-31 Thread Amitkumar Karwar
> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Amitkumar Karwar > Sent: Wednesday, August 03, 2016 4:51 PM > To: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Subject: RE: [PATCH] mwifiex: handle edmac vendor command > > Hi Kalle, >

[PATCHv8 1/4] add basic register-field manipulation macros

2016-08-31 Thread Jakub Kicinski
Common approach to accessing register fields is to define structures or sets of macros containing mask and shift pair. Operations on the register are then performed as follows: field = (reg >> shift) & mask; reg &= ~(mask << shift); reg |= (field & mask) << shift; Defining shift and mask sepa

[PATCHv8 0/4] register-field manipulation macros

2016-08-31 Thread Jakub Kicinski
Hi! Small improvement suggested by Daniel Borkmann - use two underscore prefix. https://www.mail-archive.com/netdev@vger.kernel.org/msg125423.html -- v6 blurb: This set moves to a global header file macros which I find very useful and worth popularising. The basic problem is that since C bitfi

[PATCHv8 4/4] mt7601u: use linux/bitfield.h

2016-08-31 Thread Jakub Kicinski
Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena --- drivers/net/wireless/mediatek/mt7601u/dma.c | 2 +- drivers/net/wireless/mediatek/mt7601u/dma.h | 10 ++-- drivers/net/wireless/mediatek/mt7601u/eeprom.c | 12 ++-- drivers/net/wirel

[PATCHv8 2/4] mt7601u: remove redefinition of GENMASK

2016-08-31 Thread Jakub Kicinski
Remove redefinition of GENMASK which should not be there in the upstream version of the code. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena --- drivers/net/wireless/mediatek/mt7601u/regs.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601

[PATCHv8 3/4] mt7601u: remove unnecessary include

2016-08-31 Thread Jakub Kicinski
There is no need to include linux/version.h in a in-tree driver. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena --- drivers/net/wireless/mediatek/mt7601u/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/main.c b/drivers/net/wireless/

[PATCH] mwifiex: scan: Simplify code

2016-08-31 Thread Christophe JAILLET
This patch: - improves code layout - removes a useless memset(0) for some memory allocated with kzalloc - removes a useless if. We know that 'if (chan_band_tlv)' will succeed because it has been tested a few lines above Signed-off-by: Christophe JAILLET --- drivers/net/wireless/mar

[PATCH v8] cfg80211: Provision to allow the support for different beacon intervals

2016-08-31 Thread Purushottam Kushwaha
This commit provides a mechanism for the host drivers to advertise the support for different beacon intervals among the respective interface combinations in a group, through diff_beacon_int_gcd_min (u32). Following sets the expectation for diff_beacon_int_gcd_min. = 0 - all beacon intervals for d

Re: [PATCH v2] cfg80211: Remove deprecated create_singlethread_workqueue

2016-08-31 Thread Tejun Heo
On Wed, Aug 31, 2016 at 12:35:07AM +0530, Bhaktipriya Shridhar wrote: > The workqueue "cfg80211_wq" is involved in cleanup, scan and event related > works. It queues multiple work items &rdev->event_work, > &rdev->dfs_update_channels_wk, > &wiphy_to_rdev(request->wiphy)->scan_done_wk, > &wiphy_to_r

Re: [PATCH] mwifiex: scan: Simplify code

2016-08-31 Thread Joe Perches
On Wed, 2016-08-31 at 13:50 +0200, Christophe JAILLET wrote: > This patch: >    - improves code layout >    - removes a useless memset(0) for some memory allocated with kzalloc >    - removes a useless if. We know that 'if (chan_band_tlv)' will succeed >  because it has been tested a few lines

Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test

2016-08-31 Thread Matthias Beyer
Pinging here as nobody responded yet. Maybe this was overlooked. On 23-08-2016 21:44:16, Matthias Beyer wrote: > As reported by David Binderman, this test is useless as of > > if (a < 3) { > /* ... */ > } else if (a >= 3) { > /* ... */ > } > > so this patch removes t

Re: [v4,1/2] mwifiex: add manufacturing mode support

2016-08-31 Thread Brian Norris
Hi, On Tue, Jul 26, 2016 at 03:09:19PM +0530, Amitkumar Karwar wrote: > By default normal mode is chosen when driver is loaded. This > patch adds a provision to choose manufacturing mode via module > parameters. > > Below command loads driver in manufacturing mode > insmod mwifiex.ko mfg_mode=1.

Re: [v4,2/2] mwifiex: add cfg80211 testmode support

2016-08-31 Thread Brian Norris
On Tue, Jul 26, 2016 at 03:09:20PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > This patch adds cfg80211 testmode support so that userspace tools can > download necessary commands to firmware during manufacturing mode tests. > > Signed-off-by: Xinming > Signed-off-by: Amitkumar Karwar

Re: [PATCH v4] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue.

2016-08-31 Thread Johannes Berg
On Tue, 2016-08-30 at 15:15 +0200, Toke Høiland-Jørgensen wrote: > @@ -829,10 +844,16 @@ ieee80211_tx_h_sequence(struct > ieee80211_tx_data *tx) >    */ >   if (!ieee80211_is_data_qos(hdr->frame_control) || >   is_multicast_ether_addr(hdr->addr1)) { > - /* driver should

linux-4.8-rcX: ath9k traceback

2016-08-31 Thread Mimi Zohar
Hi, There weren't any problems on linux-4.7 kernels. I'm getting the following traceback on linux-4.8-rc1/-rc4 kernels. Let me know if you need any additional information. [ 64.006529] WARNING: CPU: 3 PID: 94 at drivers/net/wireless/ath/ath9k/beacon.c:642 ath9k_beacon_config+0x12c/0x140 [at