[PATCH] mac80211: fix CMD_FRAME for AP_VLAN

2016-09-24 Thread Michael Braun
When using IEEE 802.11r FT OVER-DS roaming with AP_VLAN, hostapd needs to send out a frame using CMD_FRAME for a station assigned to an AP_VLAN interface. Right now, the userspace needs to give the exact AP_VLAN interface index for CMD_FRAME; hostapd does not do this. Additionally, userspace canno

device stops working ("failed to install key for vdev" error in kernel log)

2016-09-24 Thread Martin Blumenstingl
Hello, sometimes my AP simply stops working. Typical situation: - (me coming home from work) - client (Nexus 5, Xperia Z3 Compact or another ath10k device) can see my ath10k AP for a brief moment - AP is gone, errors from below show up in the kernel log - reboot of my AP is required to fix this [

[PATCH 2/2] brcmfmac: compile fws(ignal) code only with BCDC support enabled

2016-09-24 Thread Rafał Miłecki
From: Rafał Miłecki It's not needed by the other (msgbuf) protocol, so let's save some size and compile it conditionally. Signed-off-by: Rafał Miłecki --- .../wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 +- .../broadcom/brcm80211/brcmfmac/fwsignal.h | 59 ++

[PATCH 1/2] brcmfmac: initialize fws(ignal) for BCDC protocol only

2016-09-24 Thread Rafał Miłecki
From: Rafał Miłecki There are two protocols used by Broadcom FullMAC devices: BCDC and msgbuf. They use different ways for (some part of) communication with the firmware. Firmware Signaling is required for the first one only (BCDC). So far we were always initializing fws and always calling it's

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to me, but if you want

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: > On 09/24/2016 12:32 PM, Joe Perches wrote: [] > o Reindent all the switch/case blocks to a more normal > kernel style (git diff -w would show no changes here) > That sounds like busy work to me, but if you want to do it, go ahead. It's rea

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is rtl8192cu. Jes only has USB I/

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 12:32 PM, Joe Perches wrote: (adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the drivers, and one that sets the enum values for that particular statement to hex values. I

Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

2016-09-24 Thread Larry Finger
On 09/24/2016 12:43 PM, Joe Perches wrote: On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote: The entries in this enum may be referenced in debug output. Adding explicit values simplifies the lookup. A negative aspect to this style is forced renumbering if a HW_VAR entry is inserted. Is t

Re: [PATCH 1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote: > Only rtl8821ae implements WOWLAN; however, the other drivers may receive > a call requesting information about this mode. The other drivers need to > ignore the request rather than logging that the default branch of the > switch statement has

Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote: > The entries in this enum may be referenced in debug output. Adding explicit > values simplifies the lookup. A negative aspect to this style is forced renumbering if a HW_VAR entry is inserted. Is that possible?

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
(adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: > I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the > drivers,  > and one that sets the enum values for that particular statement to hex > values. I  > also looked at the other large

[PATCH 1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines

2016-09-24 Thread Larry Finger
Only rtl8821ae implements WOWLAN; however, the other drivers may receive a call requesting information about this mode. The other drivers need to ignore the request rather than logging that the default branch of the switch statement has been reached. Reported by: Jean Delvare Signed-off-by: Larry

[PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

2016-09-24 Thread Larry Finger
The entries in this enum may be referenced in debug output. Adding explicit values simplifies the lookup. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 208 ++-- 1 file changed, 104 insertions(+), 104 deletions(-) diff --git a/drivers/net/

[PATCH 0/2] rtlwifi: Add missing values to case statements and simplify debugging

2016-09-24 Thread Larry Finger
Routines *_get_hw_reg() for some of the drivers were missing entries for HAL_DEF_WOWLAN. No action should be taken for these drivers. Patch 1 depends on "realtek: Add switch variable to 'switch case not processed' messages" submitted by Joe Perches. That patch will log missing cases with the hex v

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 11:15 AM, Joe Perches wrote: On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: Would it make sense to explicitly set the enum values, or add them as comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: > Would it make sense to explicitly set the enum values, or add them as > comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please be my guest. otherwise, hex is at least a

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jean Delvare
Hi Joe, Larry, On Fri, 23 Sep 2016 12:02:43 -0700, Joe Perches wrote: > On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > > I'm not familiar with the %#x format. What does it do? > > Outputs SPECIAL prefix, it's the same as "0x%x" > > lib/vsprintf.c: > #define SPECIAL 64

Re: rtl8192ce:rtl92ce_get_hw_reg():<0-0> switch case not processed

2016-09-24 Thread Jean Delvare
Hi Larry, On Fri, 23 Sep 2016 13:10:28 -0500, Larry Finger wrote: > As the RTL8192CE does not support WOWLAN, the correct response is to ignore > that > call. Clearly, it has nothing to do with your network drops. One thing you > might > do is add the appropriate file in /etc/modprobe.d/ so th

Re: [PATCH 10/25] iwlwifi: mvm: support packet injection

2016-09-24 Thread Kalle Valo
Luca Coelho writes: > From: Sara Sharon > > For automatic testing packet injection can be useful. > Support injection through debugfs. > > Signed-off-by: Sara Sharon > Signed-off-by: Luca Coelho The commit log doesn't tell a lot. I started to wonder why use debugfs and not the proper interfac

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

2016-09-24 Thread Kalle Valo
Rafał Miłecki writes: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > > Signed-off-by: Rafał Miłecki > Fixes: 1f0dc59a6de ("brcmfmac: rework .get_station() callback") > C

RE RE

2016-09-24 Thread Mr.Campbell Neiman
This message is the last notification about U USD14.5 million bearing our Name as Beneficiary, all effort to reach you have not be successful, Please if you Receive this message kindly respond back stating your Desire to make the claim, Reconfirm your full name and age Mr. Mr.Campbell Neiman