Re: [v2,1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-12 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Tue, Oct 11, 2016 at 01:36:22PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > cleanup 'ath10k_htt_tx_alloc' by introducing the API's > > 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and > > re-use them whereever needed

Re: [PATCHv2 1/3] mac80211: fix CMD_FRAME for AP_VLAN

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-03 at 13:14 +0200, Michael Braun wrote: > When using IEEE 802.11r FT OVER-DS roaming with AP_VLAN, hostapd > needs to > send out a frame using CMD_FRAME for a station assigned to an AP_VLAN > interface. > > Right now, the userspace needs to give the exact AP_VLAN interface > index

[PATCH] ath10k: Fix failure to send NULL func frame for 10.4

2016-10-12 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan This partially reverts 'commit 2cdce425aa33 ("ath10k: Fix broken NULL func data frame status for 10.4")' Unfortunately this breaks sending NULL func and the existing issue of obtaining proper tx status for NULL function will be fixed. Also update the comments for fe

Re: [v2,1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-12 Thread Valo, Kalle
Mohammed Shafi Shajakhan writes: > Hi Kalle, > > On Tue, Oct 11, 2016 at 01:36:22PM +0200, Kalle Valo wrote: >> Mohammed Shafi Shajakhan wrote: >> > From: Mohammed Shafi Shajakhan >> > >> > cleanup 'ath10k_htt_tx_alloc' by introducing the API's >> > 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdon

Re: [PATCHv3 2/3] mac80211: check A-MSDU inner frame source address on AP interfaces

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-03 at 13:14 +0200, Michael Braun wrote: > When using WPA security, the station and thus the required key is > identified by its mac address when packets are received. So a > station usually cannot spoof its source mac address. > > But when a station sends an A-MSDU frame, port cont

Re: [PATCH] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Johannes Berg
On Wed, 2016-10-12 at 09:53 +0200, Johannes Berg wrote: > On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote: > > > > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > > values. > > "Need to" is perhaps a

Re: Revert "rtlwifi: rtl818x: constify local structures"

2016-10-12 Thread Kalle Valo
Larry Finger wrote: > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, > the Coccinelle script missed the fact that the code changes the firmware > name. When that happens, the kernel issues a BUG splat becaus

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-12 Thread Kalle Valo
Larry Finger writes: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name based on the exact model o

Re: TCP data throughput for BCM43362

2016-10-12 Thread Arend Van Spriel
On 11-10-2016 8:14, Jörg Krause wrote: > > > Hi Arend, > > Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel > : >> Op 22 sep. 2016 14:52 schreef "Jörg Krause" >> : >>> >>> On Do, 2016-09-22 at 10:09 +0200, Arend Van Spriel wrote: On 19-9-2016 8:36, Jörg Krause wrote: > >>>

Re: [PATCH] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > values. "Need to" is perhaps a bit strongly worded, but whatever :) I was going to write a long reply

[bug report] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue

2016-10-12 Thread Dan Carpenter
Hello Toke Høiland-Jørgensen, This is a semi-automatic email about new static checker warnings. The patch bb42f2d13ffc: "mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue" from Sep 22, 2016, leads to the following Smatch complaint: net/mac80211/tx.c:3242 ieee80211_xmit_fast_fin

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Johannes Berg
Hi, Sorry - I meant to look into this yesterday but forgot. > Andy, can this be related to CONFIG_VMAP_STACK? I think it is. > > current -git kills my system. Can you elaborate on how exactly it kills your system? > > adding > > > > if (!virt_addr_valid(&aad[2])) { > > WARN_

Re: [PATCH v2] mac80211: enable to inject a-msdu frames using monitor interface

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-10 at 18:48 +0200, Michael Braun wrote: > Problem: When injecting an A-MSDU using a PF_PACKET socket, the qos > flag > IEEE80211_QOS_CTL_A_MSDU_PRESENT is cleared. > > How to reproduce: Inject a frame on a mac80211 hwsim monitor > interface and > have tshark sniffing on this monito

Re: [PATCH] cfg80211: Create structure for combination check/iter function parameters

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-10 at 17:36 +0530, Purushottam Kushwaha wrote: > Move growing parameter list to a structure for check/iter combination > functions in cfg80211 and mac80211. Looking at this, and how it changes brcmfmac, I'd prefer you did this as the first patch in the series so we only have to tou

Re: [PATCH v2] mac80211: enable to inject a-msdu frames using monitor interface

2016-10-12 Thread michael-dev
Am 12.10.2016 09:33, schrieb Johannes Berg: However, re-reading *p looks strange to me. Why don't we just refactor this to preserve everything but the TID and ACK policy, after all, we have just previous created this all zeroed in most cases, so it won't really matter. Looks good to me. I've r

[PATCH v2] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Michael Braun
According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS values. Signed-off-by: Michael Braun -- v2: - avoid the extra write to amsdu_hdr - avoid copy of asmdu_hdr into skb, use ptr instead --- net/mac80211/tx.c | 45

Re: [PATCH v6 2/4] mac80211: filter multicast data packets on AP / AP_VLAN

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-10 at 19:12 +0200, Michael Braun wrote: > This patch adds filtering for multicast data packets on AP_VLAN > interfaces >  [...] Applied patches 1 and 2 for now, I'll look at the others again later. johannes

[PATCH] mac80211: preserve more bits when building QoS header

2016-10-12 Thread Johannes Berg
From: Johannes Berg Michael Braun reported that when trying to inject A-MSDUs over monitor interfaces, the frame doesn't come out right since the QoS header A-MSDU bit is overwritten. Rather than adding that bit specifically simply preserve those bits that we don't set here, since we typically g

USB WiFi driver for AP mode

2016-10-12 Thread Simon Wunderlich
Hi, we are looking for well supported USB WiFi chips/modules with the following requirements * Be able to support AP mode * Support at least 20 concurrent clients (stations) * Support multiple SSIDs * (preferred, optional: Support 2x2 802.11gn) We did a survey through the various wiki pages

Re: [PATCH v2] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Johannes Berg
On Wed, 2016-10-12 at 12:57 +0200, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > values. actually ... >   struct ieee80211_hdr *hdr; 802.11 header > - struct ethhdr amsdu_hd

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Luca Coelho
On Tue, 2016-10-11 at 23:32 -0500, Chris Rorvick wrote: > On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > > For what it's worth, on my machine I have twenty (!) SPLX entries, all > > reading: > > Name (SPLX, Package (0x04) > > { > > Zero, > > Package (0x03) > >

Re: [PATCH] mac80211: fix sequence number allocation regression

2016-10-12 Thread Bob Copeland
On Wed, Oct 12, 2016 at 08:49:45AM +0200, Johannes Berg wrote: > On Tue, 2016-10-11 at 11:28 +0200, Felix Fietkau wrote: > > The recent commit that moved around TX handlers dropped the sequence > > number allocation at the end of ieee80211_tx_dequeue and calls > > ieee80211_tx_h_sequence instead (f

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Okay... Actually this is a structure in the BIOS and the actual method > we call is SPLC.  The SPLC method may return one item from this table, > or something entirely different, possible one of the three values > depending on a configuration

[PATCH v10] cfg80211: Provision to allow the support for different beacon intervals

2016-10-12 Thread Purushottam Kushwaha
This commit provides a mechanism for the host drivers to advertise the support for different beacon intervals among the respective interface combinations in a group, through beacon_int_min_gcd (u32). This beacon_int_min_gcd will be compared against GCD of all beaconing interfaces of matching combin

[PATCH v2] cfg80211: Create structure for combination check/iter function parameters

2016-10-12 Thread Purushottam Kushwaha
Move growing parameter list to a structure for check/iter combination functions in cfg80211 and mac80211. Signed-off-by: Purushottam Kushwaha --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 26 ++- include/net/cfg80211.h | 46 ++-- net

[PATCH v2] cfg80211: Check radar_detect and num_different_channels with beacon interface combinations.

2016-10-12 Thread Purushottam Kushwaha
This commit enhances the current beacon interval validation to also consider the "radar_detect" and "num_different_channels". Rename "cfg80211_validate_beacon_int" to "cfg80211_validate_beacon_combination" as the validation considers other parameters. Signed-off-by: Purushottam Kushwaha --- net

Re: [v2] rt2x00: add support for mac addr from device tree

2016-10-12 Thread Kalle Valo
Kalle Valo writes: >> I thought about _adding_ a devicetree binding document before sending >> the patch. But in the end it would be an empty file, since I neither >> add any bindings nor introduce a compatible string. I'm just add >> support for the generic of_get_mac_address() devicetree proper

Re: [PATCH v2 0/7] ath9k: EEPROM swapping improvements

2016-10-12 Thread Kalle Valo
Martin Blumenstingl writes: > There are two types of swapping the EEPROM data in the ath9k driver. > Before this series one type of swapping could not be used without the > other. > > The first type of swapping looks at the "magic bytes" at the start of > the EEPROM data and performs swab16 on th

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Luca Coelho
On Wed, 2016-10-12 at 14:36 +0200, Paul Bolle wrote: > On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > > Okay... Actually this is a structure in the BIOS and the actual method > > we call is SPLC.  The SPLC method may return one item from this table, > > or something entirely different, pos

[PATCH v3 2/2] ath10k: Remove extraneous error message in tx alloc

2016-10-12 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/htt_tx.c |4 +--- 1 file changed, 1 in

[PATCH v3 1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-12 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/htt_tx.c | 75 --

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Kalle Valo
"Vittorio Gambaletta (VittGam)" writes: > Hello, > > On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: >> "Vittorio Gambaletta (VittGam)" writes: >> >>> If generic entries are positioned above specific ones, then the >>> former will be matched first and used instead of the latter. >>> >>> Cc: >>>

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

2016-10-12 Thread Yeoh Chun-Yeow
> > My understanding is that 10.2 branch does not have this feature, > unfortunately. > Alright, noted. Is QCA988X going to have firmware 10.4 support? --- Chun-Yeow

Re: QCA9887 Firmware Memory Usage

2016-10-12 Thread Valo, Kalle
David Hutchison writes: > I am using a Mikrotik hAP AC Lite which has a QCA9887 radio. It > appears to be working; however ath10k ( or the qca9887 firmware ) is > utilizing 15 - 20mb of memory. I applied the kfree(caldata) patch, to > insure there is no memory leak. > > It doesn't appear to be le

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

2016-10-12 Thread Valo, Kalle
Yeoh Chun-Yeow writes: >> My understanding is that 10.2 branch does not have this feature, >> unfortunately. >> > > Alright, noted. > > Is QCA988X going to have firmware 10.4 support? I wish it would have but I don't know the current status. -- Kalle Valo

Re: QCA9887 Firmware Memory Usage

2016-10-12 Thread Sebastian Gottschall
Am 12.10.2016 um 15:51 schrieb Valo, Kalle: David Hutchison writes: I am using a Mikrotik hAP AC Lite which has a QCA9887 radio. It appears to be working; however ath10k ( or the qca9887 firmware ) is utilizing 15 - 20mb of memory. I applied the kfree(caldata) patch, to insure there is no memo

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Sergey Senozhatsky
Hello, On (10/12/16 11:05), Johannes Berg wrote: > Sorry - I meant to look into this yesterday but forgot. > > > Andy, can this be related to CONFIG_VMAP_STACK? > > I think it is. yeah, the system works fine with !CONFIG_VMAP_STACK. > > > current -git kills my system. > > Can you elaborate on

Re: [PATCH] rsi: fix memory lean in module unload

2016-10-12 Thread Kalle Valo
Prameela Rani Garnepudi writes: > Moved debugfs entry removal under CONFIG_RSI_DEBUGFS flag > Added freeing of below structures > * channels list in each supported band > * rsi debugfs info > > Signed-off-by: Prameela Rani Garnepudi There are four similar patches without any version informati

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Vittorio Gambaletta (VittGam)
Hello, On 12/10/2016 15:34:46 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: Hello, On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: If generic entries are positioned above specific ones, then the former will be matched first and use

Re: [PATCH] rsi: fix memory leak in module unload

2016-10-12 Thread Kalle Valo
Prameela Rani Garnepudi writes: > debugfs entry removal statement moved inside CONFIG_RSI_DEBUGSFS flag > added freeing of below structures > * channel list for each supported band > * rsi debugfs info > > Signed-off-by: Prameela Rani Garnepudi [...] > --- a/drivers/net/wireless/rsi/rsi_91x_

Re: bcmdhd: Strange Power Save messages

2016-10-12 Thread Gucea Doru
On Tue, Oct 11, 2016 at 10:12 PM, Arend van Spriel wrote: > On 07-10-16 16:33, Gucea Doru wrote: >> On Thu, Oct 6, 2016 at 10:25 AM, Arend Van Spriel >> wrote: >>> On 6-10-2016 10:07, Gucea Doru wrote: On Wed, Oct 5, 2016 at 11:12 AM, Arend Van Spriel wrote: > On 4-10-2016 13:39, G

Re: [PATCH] rsi: update in vap_capabilities frame to device

2016-10-12 Thread Kalle Valo
Prameela Rani Garnepudi writes: > added vap status(add/delete) field in vap capabilities frame to device > added sending vap capabilites frame(with vap status 'delete') in remove > interface > > Signed-off-by: Prameela Rani Garnepudi Why? How is this better now? I'm sure there is a good reason

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Johannes Berg
> > Can you elaborate on how exactly it kills your system? > > the last time I saw it it was a NULL deref at > ieee80211_aes_ccm_decrypt. Hm. I was expecting something within the crypto code would cause the crash, this seems strange. Anyway, I'm surely out of my depth wrt. the actual cause. Som

Re: [PATCH] rsi: update in vap_capabilities frame to device

2016-10-12 Thread Valo, Kalle
Kalle Valo writes: > Prameela Rani Garnepudi writes: > >> added vap status(add/delete) field in vap capabilities frame to device >> added sending vap capabilites frame(with vap status 'delete') in remove >> interface >> >> Signed-off-by: Prameela Rani Garnepudi > > Why? How is this better now?

Re: [PATCH] rsi: update in boot parameters

2016-10-12 Thread Kalle Valo
Prameela Rani Garnepudi writes: > Added more clock switch fields in boot parameters configured to device > > Signed-off-by: Prameela Rani Garnepudi Why? How does this help? > .tapll_info_g = { > - .pll_reg_1 = cpu_to_le16((TA_PLL_N_VAL_20 << 8)

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Valo, Kalle
"Vittorio Gambaletta (VittGam)" writes: >>> So, after seeing that the rest of the file is sorted this way (generic >>> section after the specific ones), I concluded that the 0x002A sorting >>> was wrong in the first place, and so is 0x0029. Then I sent this patch >>> to fix this. >> >> I can't se

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-12 Thread Larry Finger
On 10/12/2016 02:53 AM, Kalle Valo wrote: Larry Finger writes: In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), the configuration struct for most of the drivers was changed to be constant. The problem is that five of the modified drivers need to be able to update the fir

Re: [bug report] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue

2016-10-12 Thread Toke Høiland-Jørgensen
Dan Carpenter writes: > Hello Toke Høiland-Jørgensen, > > This is a semi-automatic email about new static checker warnings. > > The patch bb42f2d13ffc: "mac80211: Move reorder-sensitive TX handlers > to after TXQ dequeue" from Sep 22, 2016, leads to the following > Smatch complaint: > > net/mac

Re: TCP data throughput for BCM43362

2016-10-12 Thread Jörg Krause
On Mi, 2016-10-12 at 10:11 +0200, Arend Van Spriel wrote: > On 11-10-2016 8:14, Jörg Krause wrote: > > > > > > > > Hi Arend, > > > > Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel > d.vanspr...@broadcom.com>: > > > > > > Op 22 sep. 2016 14:52 schreef "Jörg Krause" > > > : > > >

Re: [PATCH v2] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread michael-dev
Am 12.10.2016 14:25, schrieb Johannes Berg: So, I actually think my first instinct that you were erroneously changing the inner header *was* right. You're right. Seems like this code should be inserted towards the end of ieee80211_amsdu_aggregate() instead, where it's adding the RFC 1042 head

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-12 Thread Kalle Valo
Larry Finger writes: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name based on the exact model o

Re: [PATCH] docs-rst: sphinxify 802.11 documentation

2016-10-12 Thread Jonathan Corbet
On Wed, 12 Oct 2016 00:08:30 +0200 Johannes Berg wrote: > > As an alternative, one or the other of us could just send it up in > > the next couple of days and be done with it.  I'd say the chances of > > regressions are pretty small...:)  If you want to do that, feel free > > to add my ack.  If y

Re: rtlwifi: Fix regression caused by commit d86e64768859

2016-10-12 Thread Kalle Valo
Larry Finger wrote: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name based on the exact model of

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Chris Rorvick
Hi Luca, FYI, It seems that Google does not like your email as I'm not receiving any of your messages in gmail. Some responses below: On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Hi Chris, > On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote: > > On Tue, Oct 11, 2016 at 5:11 AM, P

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: > This may already be apparent, but Dell sells two versions of the 9350: > one with the Broadcom adapter and one with the AC 8260. Off topic, for most readers: my version (with the AC 8260) came with Ubuntu preinstalled. Perhaps Chris' versio

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Chris Rorvick
On Wed, Oct 12, 2016 at 1:05 PM, Paul Bolle wrote: > On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: >> This may already be apparent, but Dell sells two versions of the 9350: >> one with the Broadcom adapter and one with the AC 8260. > > Off topic, for most readers: my version (with the AC

Re: bcmdhd: Strange Power Save messages

2016-10-12 Thread Arend van Spriel
On 12-10-16 16:26, Gucea Doru wrote: > On Tue, Oct 11, 2016 at 10:12 PM, Arend van Spriel > wrote: >> On 07-10-16 16:33, Gucea Doru wrote: >>> On Thu, Oct 6, 2016 at 10:25 AM, Arend Van Spriel >>> wrote: On 6-10-2016 10:07, Gucea Doru wrote: > On Wed, Oct 5, 2016 at 11:12 AM, Arend Van S

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-12 Thread Larry Finger
On 10/12/2016 11:54 AM, Kalle Valo wrote: Larry Finger writes: In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), the configuration struct for most of the drivers was changed to be constant. The problem is that five of the modified drivers need to be able to update the fir

[PATCH V2] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-12 Thread Larry Finger
In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), the configuration struct for most of the drivers was changed to be constant. The problem is that five of the modified drivers need to be able to update the firmware name based on the exact model of the card. As the file names w

[PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

2016-10-12 Thread Alan
From: Adam Williamson SDIO ID 0271:0418 Signed-off-by: Alan Cox Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921 diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index eab0ab9..76eb336 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.

Re: TCP data throughput for BCM43362

2016-10-12 Thread Arend van Spriel
On 12-10-16 16:27, Jörg Krause wrote: > On Mi, 2016-10-12 at 10:11 +0200, Arend Van Spriel wrote: >> On 11-10-2016 8:14, Jörg Krause wrote: >>> >>> >>> >>> Hi Arend, >>> >>> Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel >> d.vanspr...@broadcom.com>: Op 22 sep. 2016 14:52 s

Re: TCP data throughput for BCM43362

2016-10-12 Thread Jörg Krause
On Mi, 2016-10-12 at 21:08 +0200, Arend van Spriel wrote: [snip] > On 12-10-16 16:27, Jörg Krause wrote: > > > > It is running the iperf server. It is running in station mode as > > well > > as in AP mode, depending on the use case. The wireshark dump was > > taken > > when the bcm43362 is opera

Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

2016-10-12 Thread Steve deRosier
Hi Alan, Sorry to quibble, but the subsystem label on the commit subject line should be "ath6kl:" it's a lower-case "L", not a one. On Wed, Oct 12, 2016 at 11:08 AM, Alan wrote: > From: Adam Williamson > > SDIO ID 0271:0418 > > Signed-off-by: Alan Cox > Bugzilla-ID: https://bugzilla.kernel.o

Re: TCP data throughput for BCM43362

2016-10-12 Thread Jörg Krause
On Wed, 2016-10-12 at 21:08 +0200, Arend van Spriel wrote: [snip] > > You referred to 20 Mbps claim on wiced dev kit page at mouser so I > assumed you were using that and it includes firmware. As you > confirmed > using firmware from linux-firmware repo this question does not > matter. Note, th

Re: TCP data throughput for BCM43362

2016-10-12 Thread Jörg Krause
On Wed, 2016-10-12 at 23:08 +0200, Arend Van Spriel wrote: > Op 12 okt. 2016 21:30 schreef "Jörg Krause" cks>: > > > > On Mi, 2016-10-12 at 21:08 +0200, Arend van Spriel wrote: > > > > [snip] > > > > > On 12-10-16 16:27, Jörg Krause wrote: > > > > > > > > It is running the iperf server. It is

Re: TCP data throughput for BCM43362

2016-10-12 Thread Jörg Krause
On Thu, 2016-10-13 at 00:25 +0200, Arend Van Spriel wrote: > Op 12 okt. 2016 23:19 schreef "Jörg Krause" cks>: > > > > On Wed, 2016-10-12 at 23:08 +0200, Arend Van Spriel wrote: > > > Op 12 okt. 2016 21:30 schreef "Jörg Krause" > > d.ro > > > cks>: > > > > > > > > On Mi, 2016-10-12 at 21:08 +02

Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

2016-10-12 Thread Kalle Valo
Steve deRosier writes: > Sorry to quibble, but the subsystem label on the commit subject line > should be "ath6kl:" it's a lower-case "L", not a one. Heh, I missed that :) I can fix it before I commit. >> --- a/drivers/net/wireless/ath/ath6kl/sdio.c >> +++ b/drivers/net/wireless/ath/ath6kl/sdi

[PATCHv4] mac80211: fix A-MSDU outer SA/DA

2016-10-12 Thread Michael Braun
According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS values. Signed-off-by: Michael Braun -- v4: - h_80211_src/dst has been memmove'd and thus needs to be fixed v3: - write to outer 802.11 header instead of inner a

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Andy Lutomirski
On Wed, Oct 12, 2016 at 7:22 AM, Johannes Berg wrote: > >> > Can you elaborate on how exactly it kills your system? >> >> the last time I saw it it was a NULL deref at >> ieee80211_aes_ccm_decrypt. > > Hm. I was expecting something within the crypto code would cause the > crash, this seems strange

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Johannes Berg
On Wed, 2016-10-12 at 22:39 -0700, Andy Lutomirski wrote: > In a pinch, I have these patches sitting around: > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack&id=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > https://git.kernel.org/cgit/linux/kernel/git/luto/lin