Re: Intel Wireless 7260 Microcode SW error detected

2016-10-19 Thread Luca Coelho
Hi Tibor, On Sun, 2016-10-16 at 20:08 +0200, Billes Tibor wrote: > I have Lenovo laptop with an Intel Wireless 7260 wifi module and the > latest stable kernel 4.8.1. I was playing a movie from an sshfs mounted > file system, when the movie just froze and my network stopped working. > Dmesg said

Re: [char-misc-next 2/5] watchdog: mei_wdt: use module_mei_cl_driver macro

2016-10-19 Thread Guenter Roeck
On 10/19/2016 06:33 AM, Tomas Winkler wrote: Replace boilerplate driver registration with module_mei_cl_driver macro. Signed-off-by: Tomas Winkler Acked-by: Guenter Roeck --- drivers/watchdog/mei_wdt.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git

crypto: aesni - add ccm(aes) algorithm implementation

2016-10-19 Thread greearb
From: Yauhen Kharuzhy Add ccm(aes) implementation from linux-wireless mailing list (see http://permalink.gmane.org/gmane.linux.kernel.wireless.general/126679). This eliminates FPU context store/restore overhead existing in more general ccm_base(ctr(aes-aesni),aes-aesni) case in MAC calculation.

Re: crypto: aesni - add ccm(aes) algorithm implementation

2016-10-19 Thread Ben Greear
On 10/19/2016 09:37 AM, gree...@candelatech.com wrote: From: Yauhen Kharuzhy Add ccm(aes) implementation from linux-wireless mailing list (see http://permalink.gmane.org/gmane.linux.kernel.wireless.general/126679). This eliminates FPU context store/restore overhead existing in more general ccm

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-19 Thread Johannes Berg
On Wed, 2016-10-19 at 08:59 -0700, Ben Greear wrote: >  > Do you actually expect performance regressions?  I'll be complaining > if so, but will test first :) I think we can expect this to use a bit more CPU time, but unless you're very tight on that you probably shouldn't expect any throughput di

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-19 Thread Ben Greear
On 10/19/2016 08:08 AM, Ard Biesheuvel wrote: On 19 October 2016 at 08:43, Johannes Berg wrote: On Wed, 2016-10-19 at 11:31 +0800, Herbert Xu wrote: We could probably make mac80211 do that too, but can we guarantee in- order processing? Anyway, it's pretty low priority, maybe never happeni

Re: [PATCH net-next 2/6] net: use core MTU range checking in wireless drivers

2016-10-19 Thread Johannes Berg
On Tue, 2016-10-18 at 22:33 -0400, Jarod Wilson wrote: > - set max_mtu in wil6210 driver > - set max_mtu in atmel driver > - set min/max_mtu in cisco airo driver, remove airo_change_mtu > - set min/max_mtu in ipw2100/ipw2200 drivers, remove > libipw_change_mtu > - set min/max_mtu in p80211netdev, r

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-19 Thread Johannes Berg
On Wed, 2016-10-19 at 11:31 +0800, Herbert Xu wrote: > On Mon, Oct 17, 2016 at 06:21:14PM +0100, Ard Biesheuvel wrote: > > > > > > Annoyingly, all this complication with scatterlists etc is for > > doing > > asynchronous crypto via DMA capable crypto accelerators, and the > > networking code (ips

Re: sequence diagrams in rst documentation

2016-10-19 Thread Johannes Berg
On Tue, 2016-10-18 at 17:52 -0600, Jonathan Corbet wrote: > In summary, I think we can consider taking on a module if it's what > we need to do the docs right.  And if somebody agrees to maintain it! > :) :) I think for the ones that we carry, they're probably specific? > I've heard others say

[char-misc-next 4/5] nfc: mei_phy: get phy from the driver data

2016-10-19 Thread Tomas Winkler
In order to remove rather redundant context from the callback signature we the get nfc mei_phy from the driver's data. Signed-off-by: Tomas Winkler --- drivers/nfc/mei_phy.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/mei_phy.c b/drivers/nfc/mei_phy.c inde

[PATCH 00/10] iwlwifi: updates intended for v4.10 2016-10-19

2016-10-19 Thread Luca Coelho
From: Luca Coelho Hi, Here's my first series for v4.10. These are the changes: * Finalize and enable dynamic queue allocation; * Use dev_coredumpmsg() to prevent locking the driver; * Small fix to pass the AID to the FW; * Use FW PS decisions with multi-queue; As usual, I'm pushing this to a

[PATCH 08/10] iwlwifi: mvm: assign cab queue to the correct station

2016-10-19 Thread Luca Coelho
From: Sara Sharon Currently when configuring the cab queue the scheduler is configured without station id - which results in station id 0. In DQA mode this causes firmware to assert later on when the actual station 0 is added with an empty tfd_queue_mask. Fix that by configuring the queue to the

[PATCH 01/10] iwlwifi: mvm: update txq metadata to current owner

2016-10-19 Thread Luca Coelho
From: Liad Kaufman When a TXQ's owner is changed, the FW is indeed notified, but the driver doesn't update the current metadata to reflect the owner change. Fix that. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 13 + 1

[PATCH 06/10] iwlwifi: pcie: give a meaningful name to interrupt request

2016-10-19 Thread Luca Coelho
From: Sharon Dvir Instead of passing DRV_NAME pass a string that represents the reason for the interrupt. Signed-off-by: Sharon Dvir Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-)

[PATCH 07/10] iwlwifi: mvm: tell the firmware about the AID of the peer

2016-10-19 Thread Luca Coelho
From: Emmanuel Grumbach When a peer associates, the firmware will soon want to know its AID to be able to compute the TIM IE by itself. In DQA, the firmware has all the information it needs to update the TIM internally. The only missing part is the AID. Signed-off-by: Emmanuel Grumbach Signed-o

[PATCH 09/10] iwlwifi: mvm: operate in dqa mode

2016-10-19 Thread Luca Coelho
From: Liad Kaufman Run DQA flows by default, as long as the FW supports it. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/m

[PATCH 03/10] iwlwifi: mvm: support MONITOR vif in DQA mode

2016-10-19 Thread Luca Coelho
From: Liad Kaufman In DQA mode the TXQs are allocated on demand, so make sure the sniffer STA tfd_queue_msk isn't set. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) di

[PATCH 05/10] iwlwifi: mvm: use firmware station PM notification for AP_LINK_PS

2016-10-19 Thread Luca Coelho
From: Johannes Berg When using RSS on 9000 series devices, we can't rely on processing the received frames for station powersave handling, since they could be processed on different CPUs and out of order. In order to still manage the powersave of stations, the firmware sends a notification on sl

[PATCH 02/10] iwlwifi: mvm: fix reserved txq freeing

2016-10-19 Thread Luca Coelho
From: Liad Kaufman If a TXQ's marking as a reserved queue is removed, when removing the STA the driver might try to access out of bounds memory. Make sure the reserved queue is freed only if it is still reserved. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho --- drivers/net/wireless/

Re: sequence diagrams in rst documentation

2016-10-19 Thread Jani Nikula
On Wed, 19 Oct 2016, Markus Heiser wrote: > Am 18.10.2016 um 16:52 schrieb Jani Nikula : > >>> *Only* adding the PNG would be awful, I'd have to keep track of the >>> corresponding source elsewhere, and perhaps couldn't even GPL it >>> because then I couldn't distribute the PNG without correspondi

[PATCH 10/10] iwlwifi: mvm: use dev_coredumpsg()

2016-10-19 Thread Luca Coelho
From: Aviya Erenfeld iwlmvm currently uses dev_coredumpm() to collect multiple buffers, but this has the downside of pinning the module until the coredump expires, if the data isn't read by any userspace. Avoid this by using the new dev_coredumpsg() method. We still copy the data from the old wa

[PATCH 04/10] iwlwifi: mvm: fix dqa deferred frames marking

2016-10-19 Thread Luca Coelho
From: Liad Kaufman When a STA has deferred traffic to TX, an appropriate bit is turned on in %deferred_tx_frames to indicate deferred traffic. This marking is never turned off, resulting in iterating over TIDs with no deferred traffic. Although this didn't cause any failures/errors/bugs, there i

[char-misc-next 3/5] nfc: mei: use module_mei_cl_driver macro

2016-10-19 Thread Tomas Winkler
Replace boilerplate driver registration with module_mei_cl_driver macro in pn544 and microread devices. Signed-off-by: Tomas Winkler --- drivers/nfc/microread/mei.c | 23 +-- drivers/nfc/pn544/mei.c | 23 +-- 2 files changed, 2 insertions(+), 44 deleti

[char-misc-next 1/5] mei: bus: add module_mei_cl_driver helper macro

2016-10-19 Thread Tomas Winkler
Add module_mei_cl_driver helper macro for eliminating the boilerplate code from mei_cl drivers registration. The macro is intended for drivers which in their init/exit sections does only register/unregister of a mei_cl driver. Signed-off-by: Tomas Winkler --- include/linux/mei_cl_bus.h | 13

[char-misc-next 2/5] watchdog: mei_wdt: use module_mei_cl_driver macro

2016-10-19 Thread Tomas Winkler
Replace boilerplate driver registration with module_mei_cl_driver macro. Signed-off-by: Tomas Winkler --- drivers/watchdog/mei_wdt.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c index 630bd189f167

Re: [PATCH net-next 2/6] net: use core MTU range checking in wireless drivers

2016-10-19 Thread Johannes Berg
> > I guess we should do the same in net/mac80211/iface.c? > > Yeah. I thought I'd located all places this needed to happen, but > obviously not. I'll get this added and do another sweep for others I > might have missed. No worries. I can also do it if you prefer, just wanted to ask :) johannes

[PATCH 4/7] iwlwifi: mvm: comply with fw_restart mod param on suspend

2016-10-19 Thread Luca Coelho
From: Haim Dreyfuss If the suspend flow fails, we restart the hardware to go back to the D0 image (with non-unified images), but we don't comply with the fw_restart module parameter. If something goes wrong when starting the D3 image, we may want to debug it, so we should comply with the fw_rest

[PATCH 5/7] iwlwifi: mvm: wake the wait queue when the RX sync counter is zero

2016-10-19 Thread Luca Coelho
From: Sara Sharon When we sync the RX queues the driver waits to receive echo notification on all the RX queues. The wait queue is set with timeout until all queues have received the notification. However, iwl_mvm_rx_queue_notif() never woke up the wait queue, with the result of the counter value

[PATCH 6/7] iwlwifi: pcie: fix SPLC structure parsing

2016-10-19 Thread Luca Coelho
From: Luca Coelho The SPLC data parsing is too restrictive and was not trying find the correct element for WiFi. This causes problems with some BIOSes where the SPLC method exists, but doesn't have a WiFi entry on the first element of the list. The domain type values are also incorrect accordin

[PATCH 2/7] iwlwifi: mvm: use ssize_t for len in iwl_debugfs_mem_read()

2016-10-19 Thread Luca Coelho
From: Luca Coelho In iwl_dbgfs_mem_read(), the len variable may become negative and is compared to < 0 (an error case). Comparing size_t (which is unsigned) to < 0 causes a warning on certain platforms (like i386): drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561:5-8: WARNING: Unsigned ex

[PATCH 3/7] iwlwifi: mvm: fix d3_test with unified D0/D3 images

2016-10-19 Thread Luca Coelho
From: Luca Coelho When a unified D0/D3 image is used, we don't restart the FW in the D0->D3->D0 transitions. Therefore, the d3_test functionality should not call ieee8021_restart_hw() when the resuming either. Fixes: commit 23ae61282b88 ("iwlwifi: mvm: Do not switch to D3 image on suspend") Si

[PATCH 1/7] iwlwifi: pcie: mark command queue lock with separate lockdep class

2016-10-19 Thread Luca Coelho
From: Johannes Berg Emmanuel reports that when CMD_WANT_ASYNC_CALLBACK is used by mvm, the callback will be called with the command queue lock held, and mvm will try to stop all (other) TX queues, which acquires their locks - this caused a false lockdep recursive locking report. Suppress this re

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-19 Thread Ard Biesheuvel
On 19 October 2016 at 08:43, Johannes Berg wrote: > On Wed, 2016-10-19 at 11:31 +0800, Herbert Xu wrote: >> On Mon, Oct 17, 2016 at 06:21:14PM +0100, Ard Biesheuvel wrote: >> > >> > >> > Annoyingly, all this complication with scatterlists etc is for >> > doing >> > asynchronous crypto via DMA capa

Re: sequence diagrams in rst documentation

2016-10-19 Thread Markus Heiser
Am 18.10.2016 um 16:52 schrieb Jani Nikula : >> *Only* adding the PNG would be awful, I'd have to keep track of the >> corresponding source elsewhere, and perhaps couldn't even GPL it >> because then I couldn't distribute the PNG without corresponding >> source... >> >> Adding the source text wo

[char-misc-next 5/5] mei: bus: remove rx callback context

2016-10-19 Thread Tomas Winkler
The callback context is redunant as all the information can be retrived from the device struture of its private data. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6 ++ drivers/nfc/mei_phy.c | 5 ++--- drivers/watchdog/mei_wdt.c | 6 ++ include/linux/mei_cl_bus.h |

[char-misc-next 0/5] mei: mei client bus api changes

2016-10-19 Thread Tomas Winkler
We are adding a helper module macro for removing boilerplate code in driver registration, and removing redundant context argument from the event callback. The changes go over misc, nfc, and watchdog subtrees. I believe it should be conflict free to merge it to the misc tree. Tomas Winkler (5):

[PATCH 0/7] iwlwifi: updates intended for v4.9 2016-10-19

2016-10-19 Thread Luca Coelho
From: Luca Coelho Hi, Here are a few fixes that I'm planning to send for v4.9. Nothing major, here's what they are about: * some fixes for suspend/resume with unified FW images; * a fix for a false-positive lockdep report; * a fix for multi-queue that caused an unnecessary 1 second latency; *

[PATCH 7/7] iwlwifi: mvm: fix netdetect starting/stopping for unified images

2016-10-19 Thread Luca Coelho
From: Luca Coelho With unified images, we need to make sure the net-detect scan is stopped after resuming, since we don't restart the FW. Also, we need to make sure we check if there are enough scan slots available to run it, as we do with other scans. Fixes: commit 23ae61282b88 ("iwlwifi: mvm:

Re: [PATCH net-next 2/6] net: use core MTU range checking in wireless drivers

2016-10-19 Thread Jarod Wilson
On Wed, Oct 19, 2016 at 09:38:33AM +0200, Johannes Berg wrote: > On Tue, 2016-10-18 at 22:33 -0400, Jarod Wilson wrote: > > - set max_mtu in wil6210 driver > > - set max_mtu in atmel driver > > - set min/max_mtu in cisco airo driver, remove airo_change_mtu > > - set min/max_mtu in ipw2100/ipw2200 d

Re: BCM43602 firmware reports multiple BRCMF_E_DEAUTH

2016-10-19 Thread Rafał Miłecki
On 10/04/2016 08:15 PM, Rafał Miłecki wrote: # My smartphone remains in the same place (1 m from the AP) but there is some # connection/A-MPDU problem. Tue Oct 4 17:22:22 2016 kern.debug kernel: [ 247.509120] brcmfmac: CONSOLE: 026970.308 ampdu_dbg: wl0.0 scb:0035ee78 tid:0 Tue Oct 4 17:22:22

Re: [PATCH 0/7] patches for mac80211/cfg80211 2016-10-18

2016-10-19 Thread Johannes Berg
On Tue, 2016-10-18 at 23:12 +0300, Luca Coelho wrote: > From: Luca Coelho > > Hi Johannes, > > Here are a few patches for mac80211/cfg80211 from our internal tree. > You're probably familiar with most of them, I'm just adding a cover > letter to make it easier for you to reply "Applied all" > (h