Re: [PATCH] mwifiex: don't do unbalanced free()'ing in cleanup_if()

On Wed, Oct 26, 2016 at 04:43:54PM -0700, Brian Norris wrote: > On Wed, Oct 26, 2016 at 04:35:54PM -0700, Dmitry Torokhov wrote: > > On Wed, Oct 26, 2016 at 04:29:20PM -0700, Brian Norris wrote: > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c > > >

Re: [PATCH] mwifiex: don't do unbalanced free()'ing in cleanup_if()

On Wed, Oct 26, 2016 at 04:35:54PM -0700, Dmitry Torokhov wrote: > On Wed, Oct 26, 2016 at 04:29:20PM -0700, Brian Norris wrote: > > diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c > > b/drivers/net/wireless/marvell/mwifiex/sdio.c > > index 8718950004f3..f04cf5a551b3 100644 > > ---

Re: [PATCH] mwifiex: don't do unbalanced free()'ing in cleanup_if()

On Wed, Oct 26, 2016 at 04:29:20PM -0700, Brian Norris wrote: > The cleanup_if() callback is the inverse of init_if(). We allocate our > 'card' interface structure in the probe() function, but we free it in > cleanup_if(). That gives a few problems: > (a) we leak this memory if probe() fails

[PATCH] mwifiex: don't do unbalanced free()'ing in cleanup_if()

The cleanup_if() callback is the inverse of init_if(). We allocate our 'card' interface structure in the probe() function, but we free it in cleanup_if(). That gives a few problems: (a) we leak this memory if probe() fails before we reach init_if() (b) we can't safely utilize 'card' after

[PATCH v2 8/9] mac80211: FILS AEAD protection for station mode association frames

This adds support for encrypting (Re)Association Request frame and decryption (Re)Association Response frame when using FILS in station mode. Signed-off-by: Jouni Malinen --- net/mac80211/Makefile | 1 + net/mac80211/aes_cmac.c| 8 +- net/mac80211/aes_cmac.h

[PATCH v2 9/9] mac80211: Claim Fast Initial Link Setup (FILS) STA support

With the previous commits, initial FILS authentication/association support is now functional in mac80211-based drivers for station role (and FILS AP case is covered by user space in hostapd withotu requiring mac80211 changes). Signed-off-by: Jouni Malinen ---

[PATCH v2 5/9] cfg80211: Add Fast Initial Link Setup (FILS) auth algs

This defines authentication algorithms for FILS (IEEE 802.11ai). Signed-off-by: Jouni Malinen --- include/linux/ieee80211.h| 3 +++ include/uapi/linux/nl80211.h | 6 ++ net/wireless/nl80211.c | 21 +++-- 3 files changed, 28 insertions(+),

[PATCH v2 0/9] cfg80211/mac80211: Fast Initial Link Setup (IEEE 802.11ai)

This series adds support for using mac80211-based drivers with Fast Initial Link Setup as defined in IEEE 802.11ai (to be published early next year; no more technical changes are expected at this point). The fils branch in git://w1.fi/hostap.git includes matching commits for hostapd and

Re: [PATCH v6] mwifiex: parse device tree node for PCIe

On Wed, Oct 26, 2016 at 2:08 PM, Brian Norris wrote: > On Wed, Oct 26, 2016 at 02:06:48PM -0700, Dmitry Torokhov wrote: >> On Wed, Oct 26, 2016 at 01:56:34PM -0700, Brian Norris wrote: >> > On Wed, Oct 26, 2016 at 01:51:48PM -0700, Rajat Jain wrote: >> > >On Wed, Oct

Re: [PATCH v6] mwifiex: parse device tree node for PCIe

On Wed, Oct 26, 2016 at 02:06:48PM -0700, Dmitry Torokhov wrote: > On Wed, Oct 26, 2016 at 01:56:34PM -0700, Brian Norris wrote: > > On Wed, Oct 26, 2016 at 01:51:48PM -0700, Rajat Jain wrote: > > >On Wed, Oct 26, 2016 at 1:46 PM, Dmitry Torokhov > > > wrote: > >

Re: [PATCH v6] mwifiex: parse device tree node for PCIe

On Wed, Oct 26, 2016 at 01:56:34PM -0700, Brian Norris wrote: > On Wed, Oct 26, 2016 at 01:51:48PM -0700, Rajat Jain wrote: > >On Wed, Oct 26, 2016 at 1:46 PM, Dmitry Torokhov > > wrote: > > On Wed, Oct 26, 2016 at 01:17:36PM -0700, Brian Norris wrote: > >

Re: [PATCH 7/8] mac80211: FILS AEAD protection for station mode association frames

On Wed, Oct 26, 2016 at 07:49:59AM +0200, Johannes Berg wrote: > > +static u8 *fils_find_session(u8 *pos, u8 *end) > Hmm. I think we should try to write this in terms of cfg80211_find_ie, > or perhaps cfg80211_find_ie_match, maybe we need to extend those but > this won't be the only one using the

Re: [PATCH v6] mwifiex: parse device tree node for PCIe

On Wed, Oct 26, 2016 at 01:51:48PM -0700, Rajat Jain wrote: >On Wed, Oct 26, 2016 at 1:46 PM, Dmitry Torokhov > wrote: > On Wed, Oct 26, 2016 at 01:17:36PM -0700, Brian Norris wrote: > Sorry, I just saw this... Why do we need devicetree data for >

Re: [PATCH v6] mwifiex: parse device tree node for PCIe

On Wed, Oct 26, 2016 at 01:17:36PM -0700, Brian Norris wrote: > Hi Rajat, > > On Fri, Oct 21, 2016 at 02:21:09PM -0700, Rajat Jain wrote: > > From: Xinming Hu > > > > This patch derives device tree node from pcie bus layer framework, and > > fixes a minor memory leak in

Re: compex wle900vx (ath10k) problem on 4.4.24 / armv7

I (naively) went through pci/pm git log and found the following was applied on 4.7-rc2 (i.e. prior to 4.7 release): commit 006d44e49a259b39947366728d65a873a19aadc0 Author: Mika Westerberg Date: Thu Jun 2 11:17:15 2016 +0300 PCI: Add runtime PM

Re: [PATCH v6] mwifiex: parse device tree node for PCIe

Hi Rajat, On Fri, Oct 21, 2016 at 02:21:09PM -0700, Rajat Jain wrote: > From: Xinming Hu > > This patch derives device tree node from pcie bus layer framework, and > fixes a minor memory leak in mwifiex_pcie_probe() (in failure path). > Device tree bindings file has been

RE: [PATCH 2/5] mwifiex: use spinlock for 'mwifiex_processing' in shutdown_drv

Hi Dmitry, > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Wednesday, October 26, 2016 10:06 PM > To: Amitkumar Karwar > Cc: Brian Norris; linux-wireless@vger.kernel.org; Cathy Luo; Nishant > Sarmukadam > Subject: Re: [PATCH 2/5] mwifiex: use spinlock for 'mwifiex_processing' >

Re: [PATCH 2/5] mwifiex: use spinlock for 'mwifiex_processing' in shutdown_drv

Hi Amit, On Wed, Oct 26, 2016 at 03:23:08PM +, Amitkumar Karwar wrote: > > This race won't occur. At this point of time(i.e while calling > mwifiex_shutdown_drv() in deinit), following things are completed. We don't > expect mwifiex_main_process() to be scheduled. > 1) Connection to peer

Re: [PATCH 2/8] mac80211: Allow AUTH_DATA to be used for FILS

> This is admittedly a bit strange design with that special case needed > for SAE. If we were to design the SAE case now in combination with > FILS, I guess this would be quite different (e.g., separate > attributes for Authentication transaction sequence number and Status > code). Unlike the

Re: [PATCH] rtl8xxxu: Add D-Link DWA-131 rev E1

Barry Day writes: > This is a rtl8192eu dongle and has been tested > > Signed-off-by: Barry Day > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, I'll add it to my queue,

Re: [PATCH 2/8] mac80211: Allow AUTH_DATA to be used for FILS

On Wed, Oct 26, 2016 at 07:30:00AM +0200, Johannes Berg wrote: > > >   if (req->auth_data_len >= 4) { > > - __le16 *pos = (__le16 *) req->auth_data; > > - auth_data->sae_trans = le16_to_cpu(pos[0]); > > - auth_data->sae_status = le16_to_cpu(pos[1]); > > +

RE: [PATCH 2/5] mwifiex: use spinlock for 'mwifiex_processing' in shutdown_drv

Hi Dmitry, > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Tuesday, October 25, 2016 10:05 PM > To: Amitkumar Karwar > Cc: Brian Norris; linux-wireless@vger.kernel.org; Cathy Luo; Nishant > Sarmukadam > Subject: Re: [PATCH 2/5] mwifiex: use spinlock for 'mwifiex_processing' >

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

do a grep in the kernel: dual license bsd/gpl On 26/10/16 16:05, Kalle Valo wrote: Antonio Quartulli writes: From: Antonio Quartulli This patch was crafted long time ago to work around a key cache corruption problem on ath9k chipsets. The

Re: [NOT FOR MERGE] ath9k: work around key cache corruption

Antonio Quartulli writes: > From: Antonio Quartulli > > This patch was crafted long time ago to work around a key cache > corruption problem on ath9k chipsets. > > The workaround consists in periodically triggering a worker that > uploads all the keys to

Re: [NOT FOR MERGE] ath9k: work around key cache corruption

On Wed, Oct 26, 2016 at 05:05:14PM +0300, Kalle Valo wrote: > Antonio Quartulli writes: > > > From: Antonio Quartulli > > > > This patch was crafted long time ago to work around a key cache > > corruption problem on ath9k chipsets. > > > > The workaround

Re: [PATCH v2 2/2] mac80211: passively scan DFS channels if requested

On Wednesday, October 26, 2016 2:58:56 PM CEST Johannes Berg wrote: > > (NOTE: going off-channel while operating is a different topic). > > Why do you think it's different? > > Seems exactly the same to me, since you come back to the channel and > start sending without any new checking? There

Re: [PATCH][RFC] nl80211/mac80211: Rounded RSSI reporting

On Fri, 2016-10-21 at 19:03 +, Zaborowski, Andrew wrote: > > The problem is that you really want this to be offloaded to the > > device, *especially* if you care about low power usage, because you > > absolutely don't want to be processing each beacon (which is > > typically what we derive

[RFC] cfg80211: support 4-way-handshake offload with PSK and 802.1X

From: Avraham Stern TODO: * add a separate capability flag? and explain how the offload is supposed to work in 802.1X, EAPOL-Key messages are going to be processed by the supplicant, but then the 4-way-HS is done by the device after getting the PMK in the PMKSA

Re: [PATCH][RFC] nl80211/mac80211: Rounded RSSI reporting

On Fri, 2016-10-21 at 09:20 -0500, Denis Kenzior wrote: > > It's actually not clear to me that this is really how it should be. > > There's a point to be made that taking a more holistic "link > > quality" would be a better choice. That's related, but maybe can be > > a separate discussion. >

Re: [PATCH v2 2/2] mac80211: passively scan DFS channels if requested

On Mon, 2016-10-24 at 16:53 +0200, Simon Wunderlich wrote: > [snip] > > Again, no explicit "on installation" here, but there is also nothing > saying  that we can not check/operate on other channels in the > meantime. Yeah, ok. > (NOTE: going off-channel while operating is a different topic).

[PATCH] nl80211: use nla_parse_nested() instead of nla_parse()

From: Johannes Berg It's just an inline doing the same thing, but the code is nicer with it. Signed-off-by: Johannes Berg --- net/wireless/nl80211.c | 85 ++ 1 file changed, 37 insertions(+), 48

Re: [PATCH] cfg80211: add key management offload feature

Getting back to this ... as I was preparing my patch. > @@ -3687,6 +3692,9 @@ enum nl80211_key_attributes { >   NL80211_KEY_DEFAULT_MGMT, >   NL80211_KEY_TYPE, >   NL80211_KEY_DEFAULT_TYPES, > + NL80211_KEY_REPLAY_CTR, > + NL80211_KEY_KCK, > + NL80211_KEY_KEK, You made

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

Arnd Bergmann writes: > On Wednesday, October 26, 2016 9:49:58 AM CEST Kalle Valo wrote: >> Arnd Bergmann writes: >> >> > A bugfix added a sanity check around the assignment and use of the >> > 'is_11d' variable, which looks correct to me, but as the function is

Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

On Wed, 2016-10-26 at 11:52 +0200, Thomas Graf wrote: > On 10/26/16 at 10:59am, Johannes Berg wrote: > > > > > > > > > >  /** > > > + * nla_memdup - duplicate attribute memory (kmemdup) > > > + * @src: netlink attribute to duplicate from > > > + * @gfp: GFP mask > > > > Actually, is there any

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

On Wednesday, October 26, 2016 9:49:58 AM CEST Kalle Valo wrote: > Arnd Bergmann writes: > > > A bugfix added a sanity check around the assignment and use of the > > 'is_11d' variable, which looks correct to me, but as the function is > > rather complex already, this confuses the

Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

On 10/26/16 at 10:59am, Johannes Berg wrote: > > >  /** > > + * nla_memdup - duplicate attribute memory (kmemdup) > > + * @src: netlink attribute to duplicate from > > + * @gfp: GFP mask > > Actually, is there any point in passing a GFP mask? None of the current > users need it, and it seems

[PATCH] nl80211: move unsplit command advertising to a separate function

From: Johannes Berg When we split the wiphy dump because it got too large, I added a comment and asked that all new command advertising be done only for userspace clients capable of receiving split data, in order to not break older ones (which can't use the new commands

[PATCH] wireless: only ask about WDS if EXPERT is selected

From: Johannes Berg There won't be any users of this that really need it and aren't already experts in how the kernel functions, so require setting EXPERT to reach this setting. Signed-off-by: Johannes Berg --- drivers/net/wireless/Kconfig | 2

Re: [PATCH 8/8] mac80211: Claim Fast Initial Link Setup (FILS) support

On Wed, 2016-10-26 at 09:23 +, Malinen, Jouni wrote: > On Wed, Oct 26, 2016 at 07:50:36AM +0200, Johannes Berg wrote: > > > > On Wed, 2016-10-26 at 01:44 +0300, Jouni Malinen wrote: > > > > > > With the previous commits, initial FILS support is now functional > > > in > > > mac80211-based

Re: [PATCH 8/8] mac80211: Claim Fast Initial Link Setup (FILS) support

On Wed, Oct 26, 2016 at 07:50:36AM +0200, Johannes Berg wrote: > On Wed, 2016-10-26 at 01:44 +0300, Jouni Malinen wrote: > > With the previous commits, initial FILS support is now functional in > > mac80211-based drivers for both AP and stations roles. > > That's a bit misleading, I guess AP role

Re: [PATCH 5/8] cfg80211: Add KEK/nonces for FILS association frames

On Wed, Oct 26, 2016 at 07:36:27AM +0200, Johannes Berg wrote: > > +++ b/net/wireless/nl80211.c > > + [NL80211_ATTR_FILS_KEK] = { .type = NLA_BINARY, > > + .len = FILS_MAX_KEK_LEN }, > > + [NL80211_ATTR_FILS_NONCES] = { .type = NLA_BINARY, > > +

Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h

On 2016-10-26 at 11:00:12 +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of >

Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

On 10/26/2016 10:53 AM, Thomas Graf wrote: Wrap several common instances of: kmemdup(nla_data(attr), nla_len(attr), GFP_KERNEL); Signed-off-by: Thomas Graf Thanks! Acked-by: Daniel Borkmann

Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

>  /** > + * nla_memdup - duplicate attribute memory (kmemdup) > + * @src: netlink attribute to duplicate from > + * @gfp: GFP mask Actually, is there any point in passing a GFP mask? None of the current users need it, and it seems fairly unlikely to be needed since this is typically used on the

[PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h

Including linux/unaligned/access_ok.h causes the allmodconfig build on ia64 (and maybe others) to fail with the following warnings: include/linux/unaligned/access_ok.h:7:19: error: redefinition of 'get_unaligned_le16' include/linux/unaligned/access_ok.h:12:19: error: redefinition of

Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

On Wed, 2016-10-26 at 10:53 +0200, Thomas Graf wrote: > Wrap several common instances of: > kmemdup(nla_data(attr), nla_len(attr), GFP_KERNEL); Makes sense Acked-by: Johannes Berg johannes

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

On Wed, 2016-10-26 at 11:36 +0300, Jani Nikula wrote: > On Wed, 26 Oct 2016, Johannes Berg wrote: > > > > On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: > > > > > > It's easier to manage the kernel-doc for the fields when they > > > documentation is next to the

[PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

Wrap several common instances of: kmemdup(nla_data(attr), nla_len(attr), GFP_KERNEL); Signed-off-by: Thomas Graf --- include/net/netlink.h | 10 ++ net/sched/act_bpf.c| 4 +--- net/sched/cls_bpf.c| 4 +--- net/wireless/nl80211.c | 3 +-- 4 files

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

On Wed, 26 Oct 2016, Johannes Berg wrote: > On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: >> It's easier to manage the kernel-doc for the fields when they >> documentation is next to the field. > > Ok, actually, this doesn't apply. Perhaps I'll look into

pull-request: iwlwifi-next 2016-10-25-2

Hi Kalle, Here's an updated pull-request, replacing 2016-10-25, with one commit message reworded, as you requested. I sent v2 of that patch to the linux-wireless mailing list. Let me know if everything's fine (or not). :) Luca. The following changes since commit

[PATCH v2] iwlwifi: mvm: enable dynamic queue allocation mode

From: Liad Kaufman New firmwares support dynamic queue allocation (DQA), which enables on-demand allocation of queues per RA/TID, instead of allocating them statically per vif. This allows an AP to send, for instance, BE traffic to STA2 even if it also needs to send

Re: [PATCH 3/7] iwlwifi: mvm: fix d3_test with unified D0/D3 images

On Wed, 2016-10-26 at 09:59 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > On Wed, 2016-10-26 at 09:19 +0300, Kalle Valo wrote: > > > Luca Coelho writes: > > > > > > > From: Luca Coelho > > > > > > > > When a unified D0/D3 image

Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode

Kalle Valo writes: >> Since we've been working on this for so long and already use the term >> DQA broadly, we thought it wouldn't be necessary to explain more when >> we are finally enabling it by default. But of course I can change that >> if you prefer. > > I guessed I

Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode

"Coelho, Luciano" writes: > Hi Kalle, > > On Wed, 2016-10-26 at 09:32 +0300, Kalle Valo wrote: >> Luca Coelho writes: >> >> > From: Liad Kaufman >> > >> > Run DQA flows by default, as long as the FW supports it. >> > >> >

Re: [PATCH 3/7] iwlwifi: mvm: fix d3_test with unified D0/D3 images

Luca Coelho writes: > On Wed, 2016-10-26 at 09:19 +0300, Kalle Valo wrote: >> Luca Coelho writes: >> >> > From: Luca Coelho >> > >> > When a unified D0/D3 image is used, we don't restart the FW in the >> > D0->D3->D0 transitions.

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

Arnd Bergmann writes: > A bugfix added a sanity check around the assignment and use of the > 'is_11d' variable, which looks correct to me, but as the function is > rather complex already, this confuses the compiler to the point where > it can no longer figure out if the variable

Re: [PATCH 1/3] rsi: Fix memory leak in module unload

Prameela Rani Garnepudi writes: > On 10/13/2016 07:56 PM, Kalle Valo wrote: >> Kalle Valo writes: >> >>> Prameela Rani Garnepudi writes: >>> Observed crash when module is unloaded if

Re: [PATCH 3/7] iwlwifi: mvm: fix d3_test with unified D0/D3 images

On Wed, 2016-10-26 at 09:19 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Luca Coelho > > > > When a unified D0/D3 image is used, we don't restart the FW in the > > D0->D3->D0 transitions. Therefore, the d3_test functionality should > >

Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode

Hi Kalle, On Wed, 2016-10-26 at 09:32 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Liad Kaufman > > > > Run DQA flows by default, as long as the FW supports it. > > > > Signed-off-by: Liad Kaufman > >

Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode

Luca Coelho writes: > From: Liad Kaufman > > Run DQA flows by default, as long as the FW supports it. > > Signed-off-by: Liad Kaufman > Signed-off-by: Luca Coelho What's this DQA mode? A short summary

Re: [PATCH 8/8] mac80211: Claim Fast Initial Link Setup (FILS) support

On Wed, 2016-10-26 at 01:44 +0300, Jouni Malinen wrote: > With the previous commits, initial FILS support is now functional in > mac80211-based drivers for both AP and stations roles. That's a bit misleading, I guess AP role is handled entirely in hostapd? You documented the extended feature bit

Re: [PATCH 3/7] iwlwifi: mvm: fix d3_test with unified D0/D3 images

Luca Coelho writes: > From: Luca Coelho > > When a unified D0/D3 image is used, we don't restart the FW in the > D0->D3->D0 transitions. Therefore, the d3_test functionality should > not call ieee8021_restart_hw() when the resuming either. > > Fixes:

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: > It's easier to manage the kernel-doc for the fields when they > documentation is next to the field. Ok, actually, this doesn't apply. Perhaps I'll look into scripting this kind of conversion. johannes

Re: [PATCH 1/2] mac80211: fix some sphinx warnings

Applied. I'll take this into the RCs so we don't have warnings there, and the other patch into -next. johannes

[PATCH] cfg80211: process events caused by suspend before suspending

From: Johannes Berg When suspending without WoWLAN, cfg80211 will ask drivers to disconnect. Even when the driver does this synchronously, and immediately returns with a notification, cfg80211 schedules the handling thereof to a workqueue, and may then call back into the