Re: [PATCH] mac80211: Remove unused 'struct rate_control_ref' variable

On Mon, 2016-11-21 at 22:54 -0800, Kirtika Ruchandani wrote: > Commit 3b17fbf87d5d introduced sta_get_expected_throughput() > leaving variable 'struct rate_control_ref* ref' set but unused. > Compiling with W=1 gives the following warning, fix it. > > net/mac80211/sta_info.c: In function

Re: [PATCH] RFC: Universal scan proposal

Hi Dmitry, On Wed, 2016-11-16 at 22:47 +, dimitr...@google.com wrote: > From 68a9d37a4c7e9dc7a90a6e922cdea52737a98d66 Mon Sep 17 00:00:00 2001 > From: Dmitry Shmidt > Date: Wed, 16 Nov 2016 14:27:26 -0800 > Subject: [PATCH] RFC: Universal scan proposal > >Currently

[PATCH] mac80211: Remove unused 'struct rate_control_ref' variable

Commit 3b17fbf87d5d introduced sta_get_expected_throughput() leaving variable 'struct rate_control_ref* ref' set but unused. Compiling with W=1 gives the following warning, fix it. net/mac80211/sta_info.c: In function ‘sta_set_sinfo’: net/mac80211/sta_info.c:2052:27: warning: variable ‘ref’ set

[PATCH] mac80211: Remove unused 'rates_idx' variable

Commit f027c2aca0cf introduced 'rates_idx' in ieee80211_tx_status_noskb but did not use it. Compiling with W=1 gives the following warning, fix it. mac80211/status.c: In function ‘ieee80211_tx_status_noskb’: mac80211/status.c:636:6: warning: variable ‘rates_idx’ set but not used

Re: scheduled scan interval

Hi Arend, On Mon, 2016-11-21 at 20:34 +0100, Arend Van Spriel wrote: > On 21-11-2016 16:08, Luca Coelho wrote: > > Hi Arend, > > > > On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: > > > On 21-11-2016 12:30, Arend Van Spriel wrote: > > > > On 21-11-2016 12:19, Arend Van Spriel wrote: >

[PATCH] mac80211: Remove unused 'struct ieee80211_rx_status' ptr

Commit 554891e63a29 introduced 'struct ieee80211_rx_status' in ieee80211_rx_h_defragment but did not use it. Compiling with W=1 gives the following warning, fix it. net/mac80211/rx.c: In function ‘ieee80211_rx_h_defragment’: net/mac80211/rx.c:1911:30: warning: variable ‘status’ set but not used

Re: scheduled scan interval

On 21-11-2016 16:08, Luca Coelho wrote: > Hi Arend, > > On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: >> On 21-11-2016 12:30, Arend Van Spriel wrote: >>> On 21-11-2016 12:19, Arend Van Spriel wrote: Hi Johannes, Luca, The gscan work made me look at scheduled scan and

Re: scheduled scan interval

On 21-11-2016 17:59, Dave Taht wrote: > On Mon, Nov 21, 2016 at 7:08 AM, Luca Coelho wrote: >> Hi Arend, >> >> On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: >>> On 21-11-2016 12:30, Arend Van Spriel wrote: On 21-11-2016 12:19, Arend Van Spriel wrote: > Hi

Re: [PATCH v3 4/5] mwifiex: wait firmware dump complete during card remove process

Hi, On Wed, Nov 16, 2016 at 06:39:08PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > Wait for firmware dump complete in card remove function. > For sdio interface, there are two diffenrent cases, > card reset trigger sdio_work and firmware dump trigger sdio_work. > Do

Re: [PATCH v3 01/11] mwifiex: check tx_hw_pending before downloading sleep confirm

On Thu, Nov 17, 2016 at 02:41:11PM +0200, Kalle Valo wrote: > Patchwork link for the same: > > https://patchwork.kernel.org/project/linux-wireless/list/?state=2=mwifiex > > Does that look ok? FWIW, your merges (since you made the above comments) look sane to me. Thanks! Brian

Re: Break-it testing for wifi

On 11/21/2016 08:55 AM, Steve deRosier wrote: On Mon, Nov 21, 2016 at 8:10 AM, Ben Greear > wrote: Hello! I am thinking about adding some sort of framework to wpa_supplicant and/or the mac80211 stack to allow purposefully

Re: [PATCH 0/7] rtl8xxxu: Pending patches

Barry Day writes: > On Sat, Nov 19, 2016 at 06:53:42PM -0500, Jes Sorensen wrote: >> Barry Day writes: >> > On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote: >> >> Barry Day writes: >> >> > On Fri, Nov 18, 2016 at

Re: scheduled scan interval

On Mon, Nov 21, 2016 at 7:08 AM, Luca Coelho wrote: > Hi Arend, > > On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: >> On 21-11-2016 12:30, Arend Van Spriel wrote: >> > On 21-11-2016 12:19, Arend Van Spriel wrote: >> > > Hi Johannes, Luca, >> > > >> > > The gscan work

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

Jes Sorensen writes: > Barry Day writes: >> The rtl8192e and rtl8723 fail to reconnect to an AP after being >> disconnected. Ths patch fixes that without affecting the rtl8192cu. >> I don't have a rtl8723 to test but it has been tested on a rtl8192eu.

Re: Break-it testing for wifi

Hi Ben, just googled out 'wifi fuzzy testing' and found something relevant as below https://www.blackhat.com/presentations/bh-europe-07/Butti/Presentation/bh-eu-07-Butti.pdf regards, shafi On Mon, Nov 21, 2016 at 08:10:37AM -0800, Ben Greear wrote: > Hello! > > I am thinking about adding some

Re: [ath9k-devel] [PATCH] ath9k: Prevent radar detection and spectral scan to be used concurrently

On 11/21/2016 04:10 PM, Michal Kazior wrote: > On 21 November 2016 at 15:41, Zefir Kurtisi wrote: >> On 11/21/2016 03:04 PM, Benjamin Berg wrote: >>> In the case that a spectral scan is enabled the PHY errors sent by the >>> hardware as part of the scanning might

Break-it testing for wifi

Hello! I am thinking about adding some sort of framework to wpa_supplicant and/or the mac80211 stack to allow purposefully creating bad station behaviour in order to test robustness of APs. Some ideas so far: 1) Allow supplicant to do bad state-machine transitions (start 4-way before

Re: wl1251 & mac address & calibration data

On Friday 11 November 2016 18:20:50 Pali Rohár wrote: > Hi! I will open discussion about mac address and calibration data for > wl1251 wireless chip again... > > Problem: Mac address & calibration data for wl1251 chip on Nokia N900 > are stored on second nand partition (mtd1) in special

Re: [ath9k-devel] [PATCH] ath9k: Prevent radar detection and spectral scan to be used concurrently

On 21 November 2016 at 15:41, Zefir Kurtisi wrote: > On 11/21/2016 03:04 PM, Benjamin Berg wrote: >> In the case that a spectral scan is enabled the PHY errors sent by the >> hardware as part of the scanning might trigger the radar detection and >> channels might be

Re: scheduled scan interval

Hi Arend, On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: > On 21-11-2016 12:30, Arend Van Spriel wrote: > > On 21-11-2016 12:19, Arend Van Spriel wrote: > > > Hi Johannes, Luca, > > > > > > The gscan work made me look at scheduled scan and the implementation of > > > it in brcmfmac.

Re: [PATCH] ath9k: Prevent radar detection and spectral scan to be used concurrently

On 11/21/2016 03:04 PM, Benjamin Berg wrote: > In the case that a spectral scan is enabled the PHY errors sent by the > hardware as part of the scanning might trigger the radar detection and > channels might be marked as 'unusable' incorrectly. This patch fixes > the issue by preventing the

Re: [PATCH] nl80211: fix logic inversion in start_nan()

On 21-11-2016 13:57, Arend Van Spriel wrote: > On 21-11-2016 13:55, Johannes Berg wrote: >> From: Johannes Berg >> >> Arend inadvertedly inverted the logic while converting to >> wdev_running(), fix that. > > It was indeed inadvertedly. Actually spelling checker

Re: [PATCH] nl80211: fix logic inversion in start_nan()

On 21-11-2016 13:55, Johannes Berg wrote: > From: Johannes Berg > > Arend inadvertedly inverted the logic while converting to > wdev_running(), fix that. It was indeed inadvertedly. Thanks, Arend > Fixes: 73c7da3dae1e ("cfg80211: add generic helper to check interface

[PATCH] nl80211: fix logic inversion in start_nan()

From: Johannes Berg Arend inadvertedly inverted the logic while converting to wdev_running(), fix that. Fixes: 73c7da3dae1e ("cfg80211: add generic helper to check interface is running") Signed-off-by: Johannes Berg --- net/wireless/nl80211.c

Re: ath10k stuck in mesh mode

Yes, I noticed it, in fact it seems to be the reg. domain of the ath9k (there is also an ath9k card plugged on the same board). But it is in contrast with what I found in the syslog: Nov 21 07:53:23 MrProper kernel: [9.591563] ath: Regpair used: 0x3a Nov 21 07:53:23 MrProper kernel: [

Re: [PATCH v7 1/2] nl80211: multicast_to_unicast can be changed while IFF_UP

On Mon, 2016-10-31 at 14:40 +0100, Michael Braun wrote: > There is no need to prevent toggling multicast_to_unicast while > interface is already up. This change simplifies reconfiguration > from hostapd. Applied. This check never should've been there anyway, if desired, NEED_NETDEV_UP should've

Re: [PATCH 2/2] nl80211: check NL80211_ATTR_SCHED_SCAN_INTERVAL only once

On Thu, 2016-11-17 at 09:02 +, Arend van Spriel wrote: > The presence of the NL80211_ATTR_SCHED_SCAN_INTERVAL attribute was > checked in nl80211_parse_sched_scan() and > nl80211_parse_sched_scan_plans() which might be a bit redundant > so removing one. > makes sense, applied. johannes

Re: [PATCH V2] cfg80211: get rid of name indirection trick for ieee80211_get_channel()

On Thu, 2016-11-17 at 12:48 +, Arend van Spriel wrote: > The comment on the name indirection suggested an issue but turned out > to be untrue. Digging in older kernel version showed issue with > ipw2x00 > but that is no longer true so get rid on the name indirection. > Applied, thanks.

Re: scheduled scan interval

On 21-11-2016 12:19, Arend Van Spriel wrote: > Hi Johannes, Luca, > > The gscan work made me look at scheduled scan and the implementation of > it in brcmfmac. The driver ignored the interval parameter from > user-space. Now I am fixing that. One thing is that our firmware has a > minimum

scheduled scan interval

Hi Johannes, Luca, The gscan work made me look at scheduled scan and the implementation of it in brcmfmac. The driver ignored the interval parameter from user-space. Now I am fixing that. One thing is that our firmware has a minimum interval which can not be indicated in struct wiphy. The other

Re: ath10k stuck in mesh mode

On 21 November 2016 at 10:46, Matteo Grandi wrote: > Dear Bob, Michal, all, > > I've just tried your advices (actually I already tried it following > the wireless.wiki.kernel web pages) and I had a look at the syslog > while I was typing the commands > At the beginning I have

Re: ath10k stuck in mesh mode

Dear Bob, Michal, all, I've just tried your advices (actually I already tried it following the wireless.wiki.kernel web pages) and I had a look at the syslog while I was typing the commands At the beginning I have this root@MrProper:~# tail -f -n 200 /var/log/syslog Nov 21 07:53:23 MrProper

Re: BCM4356 + Ubuntu 16.10

+ linux-wireless On 20-11-2016 14:26, Familie Stepniak wrote: > Hi, > > I try run Ubuntu 16.10 on the Trekstor W2 Tablet but Wi-Fi donts work.. > that find WLAN-Network, I give to Passwort and Nothing.. the chip ist > BCM4356B.. please Help me to install the true Driver on the Linux-Ubuntu..

Re: [ath9k-devel] [RFC v2 2/2] ath9k: Reset chip on potential deaf state

On 21/11/16 10:10, Sven Eckelmann wrote: On Montag, 21. November 2016 10:07:43 CET Ferry Huberts wrote: [...] v2: - reduce amount of possible goto-raptor attacks by one (thanks Kalle Valo) This problem was discovered in mesh setups. It was noticed that some nodes What kind of setup?

Re: [ath9k-devel] [RFC v2 2/2] ath9k: Reset chip on potential deaf state

On 17/11/16 09:36, Sven Eckelmann wrote: From: Simon Wunderlich The chip is switching seemingly random into a state which can be described as "deaf". No or nearly no interrupts are generated anymore for incoming packets. Existing links either break down after

form factor subsystem (Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support)

Hi, I'm revisiting this since we're asked to do the same for iwlwifi. On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: > Recent new hardware has the ability to switch between tablet mode and > clamshell mode. To optimize WiFi performance, we want to be able to > use different power table