[PATCH] mac80211: fix Tx BA session stuck issue during sw scanning

2016-11-23 Thread Chris Chiu
ieee80211_iface_work() will check if sw scanning is in progress before handling block ack session. In our case, the RTL8821AE operate in station mode, when tx session expired, DELBA packet stuck during sw scanning and so do other data packets. ieee80211_scan_state_decision() will take lots of time

Re: wl1251 & mac address & calibration data

2016-11-23 Thread Arend Van Spriel
On 22-11-2016 18:05, Pali Rohár wrote: > On Tuesday 22 November 2016 17:14:28 Michal Kazior wrote: >> On 22 November 2016 at 16:31, Pali Rohár wrote: >>> On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: On 21 November 2016 at 16:51, Pali Rohár wrote: > On Friday 11 November

Re: [PATCH] RFC: Universal scan proposal

2016-11-23 Thread Arend Van Spriel
On 22-11-2016 21:54, Dmitry Shmidt wrote: > On Tue, Nov 22, 2016 at 12:41 PM, Arend Van Spriel > wrote: >> On 22-11-2016 18:29, Dmitry Shmidt wrote: >>> Hi Luca, >>> >>> On Mon, Nov 21, 2016 at 11:24 PM, Luca Coelho wrote: Hi Dmitry, On Wed, 2016-11-16 at 22:47 +, dimitr...@google.c

Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt

2016-11-23 Thread Tamizh chelvam
Thanks for the comments. On 2016-11-18 20:14, Rob Herring wrote: On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_tr...@qti.qualcomm.com wrote: From: Tamizh chelvam There two things done in this patch. 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. 2) 'wlan_btcoex_gpio' is u

[PATCH 06/12] brcmfmac: make internal escan more generic

2016-11-23 Thread Arend van Spriel
For scheduled scan we initiate an escan in firmware to obtain more info missing from the scheduled scan notification we get from firmware. For upcoming functionality this is also required so make it a bit more generic. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: F

[PATCH 09/12] brcmfmac: use provided channels for scheduled scan

2016-11-23 Thread Arend van Spriel
User-space can provide list of channels in the schedule scan request. This was ignored so all channels supported and allowed by the device were used. This patch configures the device to use the channels as listed in the request. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Revi

[PATCH 05/12] brcmfmac: change prototype for brcmf_do_escan()

2016-11-23 Thread Arend van Spriel
Reduce the number of parameters as the removed ones can be obtained through struct brcmf_if parameter. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++

[PATCH 10/12] brcmfmac: remove restriction from .sched_scan_start() callback

2016-11-23 Thread Arend van Spriel
In the .sched_scan_start() callback a condition was checked whether a normal scan was ongoing. However, there is no need for this check as it is ok to start the scheduled scan irrespective whether or not a normal scan is ongoing. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Rev

[PATCH 07/12] brcmfmac: split up brcmf_pno_config() function

2016-11-23 Thread Arend van Spriel
The brcmf_pno_config() function handles two configurations in firmware. Split it and have caller sort out what is needed. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../broadcom/brcm80211/brcmfmac/cfg80211.c

[PATCH 11/12] brcmfmac: use requested scan interval in scheduled scan

2016-11-23 Thread Arend van Spriel
User-space can specify the interval for the scheduled scan. This interval is found in scheduled scan plan. The driver supports only one plan, which is legacy behaviour. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- d

[PATCH 08/12] brcmfmac: move scheduled scan activation to pno source file

2016-11-23 Thread Arend van Spriel
Rework .sched_scan_start() callback moving actual configuration of the device in pno source file. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 65 +--- .

[PATCH 12/12] brcmfmac: fix scheduled scan result handling for newer chips

2016-11-23 Thread Arend van Spriel
The scan results for scheduled scan as retrieved from the device have changed. A field has been added which is not needed. However, the appended info is. Luckily they are versioned so check that to find out the location of the appended data. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Gi

[PATCH 04/12] brcmfmac: fix handling ssids in .sched_scan_start() callback

2016-11-23 Thread Arend van Spriel
The ssids list in the scheduled scan request were not properly taken into account when configuring in firmware. The hidden bit was set for any ssid resulting in active scanning for all. Only set it for ssids that are in the ssids list. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesbert

[PATCH 00/12] brcmfmac: scheduled scan cleanup and chip support

2016-11-23 Thread Arend van Spriel
This patch series contains: * cleanup of scheduled scan code. * fix handling schedules scan results for newer chips. * support for bcm43341 chipset with different chip id. * support rev6 of PCIe device interface. The series is intended for 4.10 and applies to the master branch of the wireless-driv

[PATCH 02/12] brcmfmac: add support for 43341 chip

2016-11-23 Thread Arend van Spriel
This chip was already supported, but seems a device came up giving a different chip identifier. So adding that effectively mapping to the same firmware file as for 43340 chip. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH 03/12] brcmfmac: move pno helper functions in separate source file

2016-11-23 Thread Arend van Spriel
Introducing new source file for pno related functionality. Moving existing pno functions. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmfmac/Makefile | 3 +- .../broadcom/brcm80

[PATCH 01/12] brcmfmac: add pcie host dongle interface rev6 support

2016-11-23 Thread Arend van Spriel
From: Franky Lin In rev6 of pcie host dongle interface protocol, host needs to maximum supported ring number from dongle shared memory and set up ring buffer and ring indices offset accordingly. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Arend van Spriel Signe

Re: ath10k: advertize hardware packet loss mechanism

2016-11-23 Thread Kalle Valo
Rajkumar Manoharan wrote: > Indicate hardware (or firmware) supports that CQM packet-loss report > will be generated based on station kickout algorithm. As of now mac80211 > tracks connection loss by missing msdu counts (50) whereas ath10k > firmware tracks them by missing ppdus (+ BAR tries). Whi

Re: [2/4] ath10k: implement offset_tsf ieee80211_op

2016-11-23 Thread Kalle Valo
"Pedersen, Thomas" wrote: > Current set_tsf is implemented in terms of TSF_INCREMENT > only. Instead support new WMI command TSF_DECREMENT and > export these through offset_tsf. Advantage is we get > more accurate TSF adjustments, and don't calculate wrong > offset in case absolute TSF was calcula

Re: ath10k: fix null deref on wmi-tlv when trying spectral scan

2016-11-23 Thread Kalle Valo
Michal Kazior wrote: > WMI ops wrappers did not properly check for null > function pointers for spectral scan. This caused > null dereference crash with WMI-TLV based firmware > which doesn't implement spectral scan. > > The crash could be triggered with: > > ip link set dev wlan0 up > echo

Re: ath10k: add spectral scan support to wmi-tlv

2016-11-23 Thread Kalle Valo
Michal Kazior wrote: > Command structure and event flow doesn't seem to > be any different compared to existing > implementation for other firmware branches. > > This patch effectively adds in-driver support for > spectral scanning on QCA61x4 and QCA9377. > > Tested QCA9377 w/ WLAN.TF.1.0-00267-

Re: ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success

2016-11-23 Thread Kalle Valo
Matthias Schiffer wrote: > Commit b2d70d4944c1 ("ath9k: make GPIO API to support both of WMAC and > SOC") refactored ath9k_hw_gpio_get() to support both WMAC and SOC GPIOs, > changing the return on success from 1 to BIT(gpio). This broke some callers > like ath_is_rfkill_set(). > > Instead of fix

Re: ath9k: fix NULL pointer dereference

2016-11-23 Thread Kalle Valo
miaoqing pan wrote: > From: Miaoqing Pan > > relay_open() may return NULL, check the return value to avoid the crash. > > BUG: unable to handle kernel NULL pointer dereference at 0040 > IP: [] ath_cmn_process_fft+0xd5/0x700 [ath9k_common] > PGD 41cf28067 PUD 41be92067 PMD 0 > Oops:

Re: [1/7] wil6210: fix net queue stop/wake

2016-11-23 Thread Kalle Valo
Maya Erez wrote: > From: Dedy Lansky > > Driver calls to netif_tx_stop_all_queues/netif_tx_wake_all_queues are > inconsistent. In several cases, driver can get to a situation where net > queues are stopped forever and data cannot be sent. > > The fix is to stop net queues if there is at least o

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-23 Thread Kalle Valo
IgorMitsyanko writes: > To clarify with you and Kalle, as persons involved with > linux-wireless: is my understanding correct that submitting firmware > into linux-fimware repository is a prerequisite to accepting new > driver into linux-wireless? In my opinion the most important is that the dev

Re: [1/7] mwifiex: Removed unused mwifiex_private* 'priv' variable

2016-11-23 Thread Kalle Valo
Kirtika Ruchandani wrote: > Commit bec568ff5107 removed the last remaining usage of struct > mwifiex_private* priv in mwifiex_fw_dpc(), by removing the call to > mwifiex_del_virtual_intf(). > Compiling mwifiex/ with W=1 gives the following warning, fix it. > mwifiex/main.c: In function ‘mwifiex_fw

Re: [v2,1/9] rt2800: correctly report MCS TX parameters

2016-11-23 Thread Kalle Valo
Stanislaw Gruszka wrote: > We should only set IEEE80211_HT_MCS_TX_RX_DIF when TX and RX MCS sets > are not equal, i.e. when number of tx streams is different than > number of RX streams. > > Signed-off-by: Stanislaw Gruszka 9 patches applied to wireless-drivers-next.git, thanks. cea5b03d8a10 r

Re: [V2] brcmfmac: update beacon IE after bss up and clear when AP stopped

2016-11-23 Thread Kalle Valo
Wright Feng wrote: > Firmware doesn't update beacon/Probe Response vendor IEs correctly when > bss is down, so we move brcmf_config_ap_mgmt_ie after BSS up. And host > driver should clear IEs when AP stopped so that the IEs in host side will > be synced with in firmware side. > > Signed-off-by: W

Re: rt2x00: Fix incorrect usage of CONFIG_RT2X00_LIB_USB

2016-11-23 Thread Kalle Valo
Vishal Thanki wrote: > In device removal routine, usage of "#ifdef CONFIG_RT2X00_LIB_USB" > will not cover the case when it is configured as module. This will > omit the entire if-block which does cleanup of URBs and cancellation > of pending work. Changing the #ifdef to #if IS_ENABLED() to fix it

Re: brcmsmac: fix array out-of-bounds access in qm_log10

2016-11-23 Thread Kalle Valo
Tobias Regnery wrote: > I get the following UBSAN warning during boot on my laptop: > > > UBSAN: Undefined behaviour in > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_qmath.c:280:21 > index 32 is out of

[RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-23 Thread igor.mitsyanko.os
From: Igor Mitsyanko QSR10G is Quantenna's 8x8, 160M, 11ac WiFi card. Signed-off-by: Kamlesh Rath Signed-off-by: Sergey Matyukevich Signed-off-by: Avinash Patil Signed-off-by: Igor Mitsyanko --- LICENCE.Quantenna_fmac | 74 + WHENCE

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-23 Thread IgorMitsyanko
On 11/23/2016 06:25 PM, Kalle Valo wrote: IgorMitsyanko writes: To clarify with you and Kalle, as persons involved with linux-wireless: is my understanding correct that submitting firmware into linux-fimware repository is a prerequisite to accepting new driver into linux-wireless? In my opini

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Kalle Valo
Jason Cooper writes: > All, > > I have a Ubiquiti SR-71 mini-pcie ath9k card in a Globalscale Mirabox > board (Marvell Armada 370 SoC). Every day or so I get a consistent > crash that brings down the whole board. I've attached three oops I > captured on the serial port. > > I looked at the comm

ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
All, I have a Ubiquiti SR-71 mini-pcie ath9k card in a Globalscale Mirabox board (Marvell Armada 370 SoC). Every day or so I get a consistent crash that brings down the whole board. I've attached three oops I captured on the serial port. I looked at the commits from v4.8.6 to v4.9-rc6, and noth

Re: [PATCHv3,1/2] ath10k: add per peer htt tx stats support for 10.4

2016-11-23 Thread Kalle Valo
ako...@qti.qualcomm.com wrote: > From: Anilkumar Kolli > > Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' > event, Firmware sends one HTT event for every four PPDUs. > HTT payload has success pkts/bytes, failed pkts/bytes, retry > pkts/bytes and rate info per ppdu. > Peer stats

Re: ath10k: fix monitor vdev for receiving other bss frames

2016-11-23 Thread Kalle Valo
"Manoharan, Rajkumar" wrote: > In order to receive other BSS entries in mesh mode, Monitor vdev > is created whenever filter flag is set with OTHER_BSS. Recently > it is root caused that setting promisc filter for Mesh interface > is causing performance and stability issues. To fix this issue, > f

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
Hi Kalle, On Wed, Nov 23, 2016 at 09:26:42PM +0200, Kalle Valo wrote: > Jason Cooper writes: > > I have a Ubiquiti SR-71 mini-pcie ath9k card in a Globalscale Mirabox > > board (Marvell Armada 370 SoC). Every day or so I get a consistent > > crash that brings down the whole board. I've attached

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Russell King - ARM Linux
On Wed, Nov 23, 2016 at 07:15:39PM +, Jason Cooper wrote: > --- oops from v4.8.6 #2 -- > [42059.303625] Unable to handle kernel NULL pointer dereference at virtual > address 0020 > [42059.311799] pgd = c0004000 > [42059.314522] [0020] *pgd=00

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
Hi Russell, On Wed, Nov 23, 2016 at 07:51:20PM +, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 07:15:39PM +, Jason Cooper wrote: > > --- oops from v4.8.6 #2 -- > > [42059.303625] Unable to handle kernel NULL pointer dereference at vi

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
On Wed, Nov 23, 2016 at 07:51:20PM +, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 07:15:39PM +, Jason Cooper wrote: > > --- oops from v4.8.6 #2 -- > > [42059.303625] Unable to handle kernel NULL pointer dereference at virtual > > ad

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Russell King - ARM Linux
On Wed, Nov 23, 2016 at 08:59:17PM +, Jason Cooper wrote: > As requested on irc: Thanks. > 7f0: ea02b 800 > 7f4: e7970102ldr r0, [r7, r2, lsl #2] > 7f8: ebfebl 0 > 7fc: e0844000add r4, r4, r0 >

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
On Wed, Nov 23, 2016 at 09:17:45PM +, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 08:59:17PM +, Jason Cooper wrote: > > As requested on irc: > > Thanks. > > > 7f0: ea02b 800 > > 7f4: e7970102ldr r0, [r7, r2, lsl #2] > > 7f8:

[PATCH 1/2] nl80211: Use different attrs for BSSID and random MAC addr in scan req

2016-11-23 Thread Jouni Malinen
From: Vamsi Krishna NL80211_ATTR_MAC was used to set both the specific BSSID to be scanned and the random MAC address to be used when privacy is enabled. When both the features are enabled, both the BSSID and the local MAC address were getting same value causing Probe Request frames to go with un

[PATCH 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-11-23 Thread Jouni Malinen
From: vamsi krishna Enhance sched scan to support option of finding a better BSS while in connected state. Firmware scans the medium and reports when it finds a known BSS which has a significantly better RSSI than the current connected BSS. Signed-off-by: vamsi krishna Signed-off-by: Jouni Mali

Re: wl1251 & mac address & calibration data

2016-11-23 Thread Pavel Machek
Hi! > > > As wl1251.ko does not accept mac_address as module parameter, such > > > modprobe hook does not help -- as there is absolutely no way from > > > userspace to set or change (permanent) mac address. > > > > Quoting modprobe.d manual: > > > install modulename command... > > >

Re: Break-it testing for wifi

2016-11-23 Thread Jouni Malinen
On Tue, Nov 22, 2016 at 08:59:39AM -0800, Ben Greear wrote: > On 11/22/2016 02:56 AM, Johannes Berg wrote: > >On Mon, 2016-11-21 at 08:10 -0800, Ben Greear wrote: > >>1) Allow supplicant to do bad state-machine transitions (start 4-way > >>before associating, for instance). > > > >Why would you do

Re: wl1251 & mac address & calibration data

2016-11-23 Thread Pali Rohár
On Wednesday 23 November 2016 23:23:35 Pavel Machek wrote: > Hi! > > > > > As wl1251.ko does not accept mac_address as module parameter, > > > > such modprobe hook does not help -- as there is absolutely no > > > > way from userspace to set or change (permanent) mac address. > > > > > > Quoting m

[PATCH v2 1/7] mwifiex: Removed unused mwifiex_private* 'priv' variable

2016-11-23 Thread Kirtika Ruchandani
Commit bec568ff5107 removed the last remaining usage of struct mwifiex_private* priv in mwifiex_fw_dpc(), by removing the call to mwifiex_del_virtual_intf(). Compiling mwifiex/ with W=1 gives the following warning, fix it. mwifiex/main.c: In function ‘mwifiex_fw_dpc’: mwifiex/main.c:520:26: warning

[PATCH v2 2/7] mwifiex: Remove unused 'chan_num' variable

2016-11-23 Thread Kirtika Ruchandani
Commit b5413e6b2228 removed all uses of chan_num in mwifiex_config_scan(). Compiling mwifiex with W=1 gives the following warning, fix it. mwifiex/scan.c: In function ‘mwifiex_config_scan’: mwifiex/scan.c:830:6: warning: variable ‘chan_num’ set but not used [-Wunused-but-set-variable] Fixes: b54

[PATCH v2 0/7] Fix -Wunused-but-set-variable in mwifiex/

2016-11-23 Thread Kirtika Ruchandani
This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Acked-by: Arnd Bergmann Signed-off-by: Kirtika Ruchandani --- Ch

[PATCH v2 3/7] mwifiex: Remove unused 'sta_ptr' variable

2016-11-23 Thread Kirtika Ruchandani
Commit 429d90d2212b introduced mwifiex_cmd_tdls_oper() which initializes struct mwifiex_sta_node* sta_ptr, but does not use it. Compiling with W=1 gives the following warning, fix it. mwifiex/sta_cmd.c: In function ‘mwifiex_cmd_tdls_oper’: mwifiex/sta_cmd.c:1732:27: warning: variable ‘sta_ptr’ set

[PATCH v2 4/7] mwifiex: Remove unused 'adapter'variable

2016-11-23 Thread Kirtika Ruchandani
Commit 3935ccc14d2c introduced mwifiex_tm_cmd() which initializes struct mwifiex_adapter* adapter, but doesn't use it. Compiling with W=1 gives the following warning, fix it. mwifiex/cfg80211.c: In function ‘mwifiex_tm_cmd’: mwifiex/cfg80211.c:3973:26: warning: variable ‘adapter’ set but not used

[PATCH v2 6/7] mwifiex: Removed unused 'pkt_type' variable

2016-11-23 Thread Kirtika Ruchandani
Commit 92263a841b15 introduced mwifiex_deaggr_sdio_pkt which initializes variable pkt_type but does not use it. Compiling with W=1 gives the following warning, fix it. mwifiex/sdio.c: In function ‘mwifiex_deaggr_sdio_pkt’: mwifiex/sdio.c:1198:6: warning: variable ‘pkt_type’ set but not used [-Wunu

[PATCH v2 7/7] mwifiex: Remove unused 'bcd_usb' variable

2016-11-23 Thread Kirtika Ruchandani
mwifiex_usb_probe() defines and sets bcd_usb but does not use it, Compiling with W=1 gives the following warning, fix it. mwifiex/usb.c: In function ‘mwifiex_usb_probe’: mwifiex/usb.c:383:41: warning: variable ‘bcd_usb’ set but not used [-Wunused-but-set-variable] The unused variable seems to be

[PATCH v2 5/7] mwifiex: Remove unused 'pm_flag' variable

2016-11-23 Thread Kirtika Ruchandani
mwifiex_sdio_resume() intializes pm_flag, just like mwifiex_sdio_suspend(), but does not use it. Compiling with W=1 gives the following warning, fix it. mwifiex/sdio.c: In function ‘mwifiex_sdio_resume’: mwifiex/sdio.c:234:16: warning: variable ‘pm_flag’ set but not used [-Wunused-but-set-variable

[PATCH 0/4] Fix -Wunused-but-set-variable in net/mac80211/

2016-11-23 Thread Kirtika Ruchandani
This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Kirtika Ruchandani (4): mac80211: Removed unused 'i' variable m

[PATCH 1/4] mac80211: Removed unused 'i' variable

2016-11-23 Thread Kirtika Ruchandani
Commit 5bcae31d9 (mac80211: implement multi-vif in-place reservations) introduced ieee80211_vif_use_reserved_switch() with a counter variable 'i' that is set but not used. Compiling with W=1 gives the following warning, fix it. net/mac80211/chan.c: In function ‘ieee80211_vif_use_reserved_switch’: n

[PATCH 2/4] mac80211: Remove unused 'len' variable

2016-11-23 Thread Kirtika Ruchandani
Commit 633e27132625 (mac80211: split sched scan IEs) introduced the len variable to keep track of the return value of ieee80211_build_preq_ies() but did not use it. Compiling with W=1 gives the following warning, fix it. net/mac80211/scan.c: In function ‘__ieee80211_request_sched_scan_start’: net/

[PATCH 4/4] mac80211: Remove unused 'beaconint_us' variable

2016-11-23 Thread Kirtika Ruchandani
Commit 4a733ef1bea7 (mac80211: remove PM-QoS listener) removed all use of 'beaconint_us' from ieee80211_recalc_ps() but left the variable intact. Compiling with W=1 gives the following warning, fix it. net/mac80211/mlme.c: In function ‘ieee80211_recalc_ps’: net/mac80211/mlme.c:1481:7: warning: vari

[PATCH 3/4] mac80211: Removed unused 'struct ieee80211_supported_band*' variable

2016-11-23 Thread Kirtika Ruchandani
Commit b1bce14a7954 (mac80211: update opmode when adding new station) refactored ieee80211_vht_handle_opmode into __ieee80211_vht_handle_opmode and ieee80211_vht_handle_opmode leaving a set but unused variable (sband) in the former. Compiling with W=1 gives the following warning, fix it. net/mac80

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread miaoqing
Okay, so i was 0, so running UP probably isn't going to help. r7 is also spec_priv->rfs_chan_spec_scan. So, I think the question is... how is this NULL - and has it always been NULL... The problem appears to be that ath_cmn_process_fft() isn't called that often. When it is, it crashes in at

[PATCH] adm80211: Removed unused 'io_addr' 'mem_addr' variables

2016-11-23 Thread Kirtika Ruchandani
Initial commit cc0b88cf5ecf ([PATCH] Add adm8211 802.11b wireless driver) introduced variables mem_addr and io_addr in adm80211_probe() that are set but not used. Compiling with W=1 gives the following warnings, fix them. drivers/net/wireless/admtek/adm8211.c: In function ‘adm8211_probe’: drivers/

[PATCH 3/3] ath9k: disable ACK_CTS for SOC chips in PTA mode

2016-11-23 Thread miaoqing
From: Miaoqing Pan If the ACK_CTS is enabled, MAC will send an ACK or CTS in response to a received frame, but it is a interfering packet for the BT(or other) in the PTA cycle, which will sufficient corrupt the received packets. Only disable it for SOC chips in PTA(slotted) mode. Signed-off-by:

[PATCH 2/3] ath9k: export configurable parameters of PTA

2016-11-23 Thread miaoqing
From: Miaoqing Pan Export time_extend, pritority_time, first_slot_time, wl_active_time and wl_qc_time those PTA(aka slotted mode) configurable parameters, allow user to change/debug the timing easily. Also set wl_active_time and wl_qc_time default value to 0, as in this period WLAN chip may send

[PATCH 1/3] ath9k: Add a module parameter to set btcoex duty cycle

2016-11-23 Thread miaoqing
From: Miaoqing Pan btcoex duty cyle allows user to balance the performance between WLAN and BT. Signed-off-by: Miaoqing Pan --- drivers/net/wireless/ath/ath9k/gpio.c | 4 +--- drivers/net/wireless/ath/ath9k/init.c | 10 ++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git

Re: wl1251 & mac address & calibration data

2016-11-23 Thread Pavel Machek
Hi! > > "ifconfig hw ether XX" normally sets the address. I guess that's > > ioctl? > > This sets temporary address and it is ioctl. IIRC same as what ethtool > uses. (ifconfig is already deprecated). > > > And I guess we should use similar mechanism for permanent > > address. > > I'm not sure

RE: [PATCH v2 0/7] Fix -Wunused-but-set-variable in mwifiex/

2016-11-23 Thread Amitkumar Karwar
> From: Kirtika Ruchandani [mailto:kirtika.ruchand...@gmail.com] > Sent: Thursday, November 24, 2016 6:54 AM > To: Amitkumar Karwar > Cc: Arnd Bergmann; Kalle Valo; linux-wireless@vger.kernel.org; Nishant > Sarmukadam; Zhaoyang Liu; Bing Zhao; Xinming Hu; Avinash Patil > Subject: [PATCH v2 0/7] Fix