Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX

2016-12-19 Thread Tamizh chelvam
Hi Johannes, Thanks for your comments. On 2016-12-16 15:07, Johannes Berg wrote: > > is it fine to have as WIPHY_BTCOEX_BE_PREFERRED ? > > It's not really clear to me what you intend to do this - if it's > really support flags then you really should name those better. > This is support flags a

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Johannes Berg
Hi Mike, Thanks for the report. I'm sorry I missed this in review - obviously we can't call something that acquires the mutex from rfkill_set_sw_state() which clearly states, in the documentation:  * This function can be called in any context, even from within rfkill  * callbacks. I've reverted

Re: [PATCH 1/2] brcm: add firmware for the BCM4356 SDIO device

2016-12-19 Thread Arend Van Spriel
On 19-12-2016 1:28, Rafał Miłecki wrote: > Hi Arend, > > On 18 December 2016 at 21:16, Arend van Spriel > wrote: >> This patch adds firmware for the BCM4356 2x2 11ac SDIO device. > > I'm really happy to see Broadcom submitting firmwares again! Is this a > good moment to re-request for 4366c0 one

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-19 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by:

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

2016-12-19 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/bluetooth/Makefile| 2 -- > drivers/net/can/Makefile | 1

[PATCH 05/11] rt2800: rename adjust_freq_offset function

2016-12-19 Thread Stanislaw Gruszka
We have different modes of adjusting freq offset on different chips. Call current adjustment similarly like vendor driver - mode1 . Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 04/11] rt2800: set MAX_PSDU len according to remote STAs capabilities

2016-12-19 Thread Stanislaw Gruszka
MAX_LEN_CFG_MAX_PSDU specify maximum transmitted by HW AMPDU length (0 - 8kB, 1 - 16kB, 2 - 32kB, 3 - 64kB). Set this option according to remote stations capabilities (based on HT ampdu_factor). However limit the value based our hardware TX capabilities as some chips can not send more than 16kB (fa

[PATCH 06/11] rt2800: warn if doing VCO recalibration for unknow RF chip

2016-12-19 Thread Stanislaw Gruszka
Since we reset TX_PIN_CFG register, we have to finish recalibration. Warn if this is not possible. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt28

[PATCH v2] cfg80211: add set/get link loss profile

2016-12-19 Thread Lazar, Alexei Avshalom
>From 7e41d45179a8762a7d2e1653db35751c19c8c747 Mon Sep 17 00:00:00 2001 From: Alexei Avshalom Lazar Date: Sun, 18 Dec 2016 15:06:38 +0200 Subject: [PATCH] cfg80211: add set/get link loss profile Introduce NL80211_CMD_SET_LINK_LOSS_PROFILE and NL80211_CMD_GET_LINK_LOSS_PROFILE needed by user space

Re: cfg80211: add set/get link loss profile

2016-12-19 Thread Lazar, Alexei Avshalom
On 11/28/2016 4:52 PM, Johannes Berg wrote: > >> Introduce NL80211_CMD_SET_LINK_LOSS_PROFILE and >> NL80211_CMD_GET_LINK_LOSS_PROFILE as it required by the user space >> to configure the link loss profile. > > I'm not convinced. > >> The link loss profile represents the priority of maintaining l

Re: cfg80211: add set/get link loss profile

2016-12-19 Thread Lazar, Alexei Avshalom
On 11/18/2016 1:05 PM, Kalle Valo wrote: > Hi Alexei, > > "Lazar, Alexei Avshalom" writes: > >> In this context the term "link" does mean connection to AP. There are >> scenarios that require to lose connection faster once reduced link >> quality detected in order maintain better user experience

[PATCH 07/11] rt2800: perform VCO recalibration for RF5592 chip

2016-12-19 Thread Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 5ceb006..615eaf8 100644 --- a/driver

[PATCH 08/11] rt2x00: merge agc and vco works with link tuner

2016-12-19 Thread Stanislaw Gruszka
We need to perform different actions (AGC and VCO calibrations and VGC tuning) periodically at different intervals. We don't need separate works for those, we can use link tuner work and just check for proper interval on it. This fixes performing AGC and VCO calibration when scanning on STA mode.

[PATCH 10/11] rt2800: replace msleep() with usleep_range() on channel switch

2016-12-19 Thread Stanislaw Gruszka
msleep(1) can sleep much more time then requested 1ms, this is not good on channel switch, which we want to be performed fast (i.e. to make scan faster). Replace msleep() with usleep_range(), which has much smaller maximum sleeping time boundary. Signed-off-by: Stanislaw Gruszka --- drivers/net/

[PATCH 09/11] rt2800: replace mdelay by usleep on vco calibration.

2016-12-19 Thread Stanislaw Gruszka
This procedure can sleep, hence mdelay is not needed. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00

[PATCH 00/11] rt2800 patches 19.12.2016

2016-12-19 Thread Stanislaw Gruszka
Random fixes for rt2800 driver. Stanislaw Gruszka (11): rt2800: make rx ampdu_factor depend on number of rx chains rt2800: don't set ht parameters for non-aggregated frames rt2800: set minimum MPDU and PSDU lengths to sane values rt2800: set MAX_PSDU len according to remote STAs capabiliti

[PATCH 11/11] rt2x00: add mutex to synchronize config and link tuner

2016-12-19 Thread Stanislaw Gruszka
Do not perform mac80211 config and link_tuner at the same time, this can possibly result in wrong RF or BBP configuration. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2x00.h |4 drivers/net/wireless/ralink/rt2x00/rt2x00dev.c |1 + drivers/net/wirel

[PATCH 03/11] rt2800: set minimum MPDU and PSDU lengths to sane values

2016-12-19 Thread Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 62bb9a6..ef71722 100644 --- a/driv

[PATCH 01/11] rt2800: make rx ampdu_factor depend on number of rx chains

2016-12-19 Thread Stanislaw Gruszka
Initalize max ampdu_factor supported by us based on rx chains, vendor driver do the same. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH 02/11] rt2800: don't set ht parameters for non-aggregated frames

2016-12-19 Thread Stanislaw Gruszka
Do not set ampdu_density and ba_size for frames without AMPDU bit i.e. frames that will not be aggregated to AMPDU. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/ne

Re: [RFC 2/3] mac80211: Implement data xmit for 802.11 encap offload

2016-12-19 Thread Kalle Valo
"Thiagarajan, Vasanthakumar" writes: > On Thursday 15 December 2016 07:23 PM, Johannes Berg wrote: >> I agree. Dynamic switch part is buggy, we can start with not allowing interfaces resulting in dynamic switch. >>> >>> Does this mean that when bringing up multiple interfaces, users wou

Re: [RFC 2/3] mac80211: Implement data xmit for 802.11 encap offload

2016-12-19 Thread Thiagarajan, Vasanthakumar
On Monday 19 December 2016 05:15 PM, Kalle Valo wrote: > "Thiagarajan, Vasanthakumar" writes: > >> On Thursday 15 December 2016 07:23 PM, Johannes Berg wrote: >>> > I agree. Dynamic switch part is buggy, we can start with not > allowing interfaces resulting in dynamic switch. Doe

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Michał Kępień
Mike, Johannes, sorry for the trouble caused. > Thanks for the report. I'm sorry I missed this in review - obviously we > can't call something that acquires the mutex from rfkill_set_sw_state() > which clearly states, in the documentation: > >  * This function can be called in any context, even f

Re: [PATCH] ath10k: merge extended peer info data with existing peers info

2016-12-19 Thread Mohammed Shafi Shajakhan
Hi Christian, On Sat, Dec 17, 2016 at 06:46:34PM +0100, Christian Lamparter wrote: > The 10.4 firmware adds extended peer information to the > firmware's statistics payload. This additional info is > stored as a separate data field. During review of > "ath10k: add accounting for the extended peer

Re: [PATCH] ath10k: merge extended peer info data with existing peers info

2016-12-19 Thread Mohammed Shafi Shajakhan
On Mon, Dec 19, 2016 at 10:19:57PM +0530, Mohammed Shafi Shajakhan wrote: > Hi Christian, > > On Sat, Dec 17, 2016 at 06:46:34PM +0100, Christian Lamparter wrote: > > The 10.4 firmware adds extended peer information to the > > firmware's statistics payload. This additional info is > > stored as a

Re: [PATCH] ath10k: merge extended peer info data with existing peers info

2016-12-19 Thread Christian Lamparter
Hello Shafi, On Monday, December 19, 2016 10:19:57 PM CET Mohammed Shafi Shajakhan wrote: > On Sat, Dec 17, 2016 at 06:46:34PM +0100, Christian Lamparter wrote: > > The 10.4 firmware adds extended peer information to the > > firmware's statistics payload. This additional info is > > stored as a se

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-19 Thread Rob Herring
On Thu, Dec 15, 2016 at 05:30:42PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > --- > .../devicetree/bindings/net/nfc/trf7970a.txt | 3 ++ > drivers/nfc/trf7970a.c | 42 > -- > 2 files changed, 34 insertions(+), 11 deletions(-)

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-19 Thread Rob Herring
On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > --- > Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ > drivers/nfc/trf7970a.c | 13 - > 2 files changed, 14 insertions(+), 1 deletion(-) > >

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-19 Thread Geoff Lansberry
I can make that change, however, I worry that it may be a bit misleading, since there are only two supported clock frequencies, but a number like that to me implies that it could be set to any number you want. I'm new at this, and so I'll go ahead and change it as you request, but I'd like to hea

[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

2016-12-19 Thread Larry Finger
With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb"), the method used to free an skb was changed because the kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() guards against a NULL value for the argument. Routine dev_kfree_skb_irq() does not, and

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Johannes Berg
> Just to ensure things get cleaned up properly, as of now it looks > like you only reverted patch 2/2 of my v2 and Arnd's fix to patch > 1/2, not patch 1/2 itself. Oops. I've fixed that up to only revert your patch - I wanted the revert in the tree to document the issue, rather than just droppin