RE: [PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs

2017-01-10 Thread Vamsi, Krishna
> -Original Message- > > + * @relative_rssi_set: Indicates whether @relative_rssi is set or not. > > So you see a use-case for doing a scan with @relative_rssi being zero, right? Yes. Zero value for relative_rssi is also valid. > > + * @relative_rssi: Relative RSSI threshold in dB to

[REGRESSION, bisect] mesh: SAE connection causes kernel crash

2017-01-10 Thread Masashi Honma
I have encountered kernel crash when I have used mesh SAE connection with ath9k_htc device (Sony UWA-BR100). I have tried to connect 2 peers to each other, then only one peer crashes. By bisect, this commit looks causes this issue. commit d8da0b5d64d58f7775a94bcf12dda50f13a76f22 Author: Cedr

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Felix Fietkau
On 2017-01-10 11:56, Johannes Berg wrote: > On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >> > I wonder if MAC80211 should be doing IGMP snooping and not bridge >> > in this environment. >> >> In the long term, yes. Fo

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Dave Taht
On Tue, Jan 10, 2017 at 9:23 AM, Felix Fietkau wrote: > On 2017-01-10 18:17, Dave Taht wrote: >> In the case of wifi I have 3 issues with this line of thought. >> >> multicast in wifi has generally supposed to be unreliable. This makes >> it reliable. reliability comes at a cost - >> >> multicast

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Felix Fietkau
On 2017-01-10 18:17, Dave Taht wrote: > In the case of wifi I have 3 issues with this line of thought. > > multicast in wifi has generally supposed to be unreliable. This makes > it reliable. reliability comes at a cost - > > multicast is typically set at a fixed low rate today. unicast is > retr

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Dave Taht
In the case of wifi I have 3 issues with this line of thought. multicast in wifi has generally supposed to be unreliable. This makes it reliable. reliability comes at a cost - multicast is typically set at a fixed low rate today. unicast is retried at different rates until it succeeds - for every

Re: pull-request: wireless-drivers 2017-01-10

2017-01-10 Thread David Miller
From: Kalle Valo Date: Tue, 10 Jan 2017 08:18:40 +0200 > here's the pull request with the important rtlwifi fix, more info in the > tag below. > > During the long weekend we had here I finally updated Ubuntu on my > workstation and git was updated along that. If you see anything funny or > probl

Re: [bug report] rtlwifi: Remove some redundant code

2017-01-10 Thread Larry Finger
On 01/10/2017 07:43 AM, Kalle Valo wrote: Dan Carpenter writes: Hello Larry Finger, The patch c93ac39da006: "rtlwifi: Remove some redundant code" from Dec 15, 2016, leads to the following static checker warning: drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c:326 rtl92d_download

[PATCH] rtlwifi: rtl8192de: Remove a pointless goto

2017-01-10 Thread Larry Finger
In commit c93ac39da0064 ("rtlwifi: Remove some redundant code), a goto statement was inadvertently left in the code. Fixes: c93ac39da0064 ("rtlwifi: Remove some redundant code) Reported-by: kbuild test robot Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 1

[PATCH] ath10k: Fix Tx legacy rate reporting

2017-01-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Tx legacy rate is reported 10 fold, as below iw dev wlan#N station dump | grep "tx bitrate" tx bitrate: 240.0 MBit/s This is because by mistake we muliply by the hardware reported rate twice by 10, fix this. Fixes: cec17c382140 ("ath10k: add per peer

[PATCH] ath10k: Fix wifi connectivity and warning in Rx with channel 169

2017-01-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan In countries where basic operation of channel 169 is allowed, this fixes the below WARN_ON_ONCE in Rx and fixes the station connectivity failure in channel 169 as the packet is dropped in the driver as the current check limits to channel 165. As of now all the packe

Re: [bug report] rtlwifi: Remove some redundant code

2017-01-10 Thread Kalle Valo
Dan Carpenter writes: > Hello Larry Finger, > > The patch c93ac39da006: "rtlwifi: Remove some redundant code" from > Dec 15, 2016, leads to the following static checker warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c:326 > rtl92d_download_fw() > warn: curly braces in

Re: [PATCH 1/3] rsi: Renamed the file rsi_91x_pkt.c to rsi_91x_hal.c

2017-01-10 Thread Kalle Valo
Prameela Rani Garnepudi writes: > Can you please review these patches. You slipped through these patches > and reviewing resent patches. Is there a specific reason? As you are new, your patches just take more time to review than others and haven't had a good slot to look at those yet. -- Ka

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Johannes Berg
On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: > On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: > > I wonder if MAC80211 should be doing IGMP snooping and not bridge > > in this environment. > > In the long term, yes. For now, not quite sure. There's no "for now" in t

[PATCH next] rtlwifi: rtl8192de: fix missing curly braces

2017-01-10 Thread Vincent Stehlé
Cc: Larry Finger Cc: Kalle Valo Cc: Joe Perches Cc: Ping-Ke Shih --- Hi, I saw that in Linux next-20170110. Best regards, Vincent. drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwi

Re: [ath5k-devel] ath5k keep-alive

2017-01-10 Thread Sergey Ryazanov
Hello Denis. CC linux-wireless since ath5k-devel not so active for a long time. On Tue, Sep 13, 2016 at 10:30 AM, Denis Periša wrote: > I have issue with frequent disconnects so I have to add watchdog scripts in > cron which is really pain in.. > Is there any chance I can add some code to keep a

Re: kernel 4.9 iwlwifi startup error

2017-01-10 Thread Luca Coelho
On Tue, 2017-01-10 at 09:21 +0100, Fabio Coatti wrote: > In data martedì 10 gennaio 2017 00:21:51 CET, Luca Coelho ha scritto: > > On Tue, 2017-01-03 at 13:42 +1100, Andrew Donnellan wrote: > > > On 02/01/17 21:12, Fabio Coatti wrote: > > > > Hi all, > > > > I'm using kernel 4.9 and maybe half of t

Re: kernel 4.9 iwlwifi startup error

2017-01-10 Thread Fabio Coatti
In data martedì 10 gennaio 2017 00:21:51 CET, Luca Coelho ha scritto: > On Tue, 2017-01-03 at 13:42 +1100, Andrew Donnellan wrote: > > On 02/01/17 21:12, Fabio Coatti wrote: > > > Hi all, > > > I'm using kernel 4.9 and maybe half of the times I boot my laptop I get > > > the > > > error reported be