Re: [Outreachy kernel] [PATCH] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Tahia Khan wrote: > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: > > Avoid CamelCase: > Avoid CamelCase: > Avoid CamelCase: > > Signed-off-by: Tahia Khan > --- > drivers/staging/wilc1000/coreconfigurator.h | 8 > drivers/stagin

[PATCH] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-21 Thread Tahia Khan
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: Avoid CamelCase: Avoid CamelCase: Avoid CamelCase: Signed-off-by: Tahia Khan --- drivers/staging/wilc1000/coreconfigurator.h | 8 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +- 2 files

[PATCH v2 0/2] iwlwifi: corner case fix and request module changes

2017-02-21 Thread Luis R. Rodriguez
This v2 addresses the preference to keep things simple on iwlwifi when requesting modules and not implementing a verifier for loaing the opmode module. We now know what a verifier looks like for both sync and async approaches. The already established long standing practice of just doing best effort

[PATCH v2 0/2] iwlwifi: share opmode start code

2017-02-21 Thread Luis R. Rodriguez
. Lastly, since we are moving things to a workqueue naturally the module_init() for iwlmvm is not offloaded, and so this should reduce the boot time by a bit. As per the average of systemd-analyze on 5 boots using next-20170221 as base: next-20170221: Startup finished in 2.6142s (kernel

[PATCH v2 1/2] iwlwifi: share opmode start work code

2017-02-21 Thread Luis R. Rodriguez
The firmware async callback and the opmode registration share some functionality -- to start the drv's opmode. Move this work into a helper which is shared. This should help us share fixes should these diverging code paths change. Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/intel/i

[PATCH v2 2/2] iwlwifi: convert final opmode work into a workqueue

2017-02-21 Thread Luis R. Rodriguez
This lets us offload and share all the final opmode related work necessary for either an opmode driver or new device. This has the most impact for opmode drivers as this now offloads opmode start for each device onto the workqueue. Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/intel/

[PATCH v2 2/2] iwlwifi: simplify requesting ops module

2017-02-21 Thread Luis R. Rodriguez
The return value of request_module() being 0 does not mean that the driver which was requested has loaded. To properly check that the driver was loaded each driver can use internal mechanisms to vet the driver is now present. The helper try_then_request_module() was added to help with this, allowin

[PATCH v2 1/2] iwlwifi: fix drv cleanup on opmode registration failure

2017-02-21 Thread Luis R. Rodriguez
The firmware async callback handles the device's opmode start call, but optionally also allows opmode registration to take care of its opmode start. If the firmware callback handles it its error path in case of opmode start failure has a few pieces of code missing from the opmode registration. The

Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 09:17:15PM +0100, Luis R. Rodriguez wrote: > On Tue, Feb 21, 2017 at 07:15:41PM +0100, Luis R. Rodriguez wrote: > > On Tue, Feb 21, 2017 at 07:16:16AM +, Grumbach, Emmanuel wrote: > > > > > > > > a) just remove the print and use instead request_module_nowait() (this >

[PATCH] mac80211: Jitter HWMP MPATH reply frames to reduce collision, on dense networks.

2017-02-21 Thread Alexis Green
From: Jesse Jones When more than one station hears a broadcast request, it is possible that multiple devices will reply at the same time, potentially causing collision. This patch helps reduce this issue. Signed-off-by: Alexis Green Signed-off-by: Benjamin Morgan --- net/mac80211/ieee80211_i.

Usage of WoWLAN with iwlwifi driver (Device phy0 failed to suspend async: error -16)

2017-02-21 Thread Oliver Freyermuth
Dear wireless experts, I have been trying to get basic WoWLAN to work with the following configuration: - Intel Corporation Wireless 7260 (rev 73) with in-tree iwlwifi driver - Kernel 4.10.0 (on Gentoo Linux) - Very recent firmware version for the card and revision: iwlwifi :0a:00.0: loaded f

Regression with Intel 3160 AP: client not reconnecting

2017-02-21 Thread Jarek Kamiński
Hello, I have an accesspoint running on Intel 3160 (ZBOX RI-323). It was running just fine on 3.16 from Debian, but I recently tried upgrading it to 4.9 and noticed strange issues with wireless clients. With the recent versions of iwlwifi, when a client disconnects, it is not noticed by the acces

Re: ath10k regression on XPS13

2017-02-21 Thread David Miller
From: Linus Torvalds Date: Tue, 21 Feb 2017 10:52:33 -0800 > On Tue, Feb 21, 2017 at 10:18 AM, David Miller wrote: >> >> Kalle I really wanted to send my net-next pull request to Linus later >> today. But I guess I have to wait for this ath10k first. > > Feel free to send it to me - it sounds

Re: ath10k regression on XPS13

2017-02-21 Thread David Miller
From: Kalle Valo Date: Tue, 21 Feb 2017 21:49:09 +0200 > David Miller writes: > >> From: Kalle Valo >> Date: Tue, 21 Feb 2017 20:38:48 +0200 >> >>> David Miller writes: >>> From: Kalle Valo Date: Tue, 21 Feb 2017 11:32:49 +0200 > We are working on a fix so that ath10k con

Re: [PATCH] Revert "ath10k: Search SMBIOS for OEM board file extension"

2017-02-21 Thread David Miller
From: Kalle Valo Date: Tue, 21 Feb 2017 21:47:06 +0200 > This reverts commit f2593cb1b29185d38db706cbcbe22ed538720ae1. > > Paul reported that this patch with older board-2.bin ath10k initialisation > fails on Dell XPS 13: > > ath10k_pci :3a:00.0: failed to fetch board data for bus=pci,vendo

Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 07:15:41PM +0100, Luis R. Rodriguez wrote: > On Tue, Feb 21, 2017 at 07:16:16AM +, Grumbach, Emmanuel wrote: > > > > > > a) just remove the print and use instead request_module_nowait() (this is > > > more in alignment of what your code actually does today; or > > > >

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 13:37, Johannes Berg wrote: > >> What I am also missing is how to deal with NL80211_CMD_CONNECTED >> event signalling. Should that be given after (un)successful >> completion of the 4-way handshake or should we have a separate event >> for that? > > That's a good point. I don't thin

Re: ath10k regression on XPS13

2017-02-21 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Tue, 21 Feb 2017 20:38:48 +0200 > >> David Miller writes: >> >>> From: Kalle Valo >>> Date: Tue, 21 Feb 2017 11:32:49 +0200 >>> We are working on a fix so that ath10k continues to work with older board-2.bin, but that might take a day

[PATCH] Revert "ath10k: Search SMBIOS for OEM board file extension"

2017-02-21 Thread Kalle Valo
This reverts commit f2593cb1b29185d38db706cbcbe22ed538720ae1. Paul reported that this patch with older board-2.bin ath10k initialisation fails on Dell XPS 13: ath10k_pci :3a:00.0: failed to fetch board data for bus=pci,vendor=168c, device=003e,subsystem-vendor=1a56,subsystem-device=1535,varia

Problem with RTL8191SU driver

2017-02-21 Thread Marius Melzer
Hi, I have a usb wifi stick with a RTL8191SU chipset and the driver doesn't work for me (at least I think that's the problem). I'm using the following driver: [1] which refers on its page to this email address for reports. I listed all relevant information in a post [2] in the archlinux forum, es

Re: [PATCH V3 1/2] firmware: add more flexible request_firmware_async function

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 10:47:53AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we got only one function for loading firmware asynchronously: > request_firmware_nowait. It didn't allow much customization of firmware > loading process - there is only one bool uevent argument. Moreo

Re: ath10k regression on XPS13

2017-02-21 Thread David Miller
From: Kalle Valo Date: Tue, 21 Feb 2017 20:38:48 +0200 > David Miller writes: > >> From: Kalle Valo >> Date: Tue, 21 Feb 2017 11:32:49 +0200 >> >>> We are working on a fix so that ath10k continues to work with older >>> board-2.bin, but that might take a day or two still. >> >> Kalle I really

Re: ath10k regression on XPS13

2017-02-21 Thread Linus Torvalds
On Tue, Feb 21, 2017 at 10:18 AM, David Miller wrote: > > Kalle I really wanted to send my net-next pull request to Linus later > today. But I guess I have to wait for this ath10k first. Feel free to send it to me - it sounds like the regression is (a) easy to work around and (b) has a fix com

Re: TL-WN823N

2017-02-21 Thread Jes Sorensen
On 02/16/2017 10:20 AM, madmaxxx wrote: Hi, I have a problem with rtl8xxxu driver, which seems to not work with a dongle tp-link TL-WN823N model. I just filled out a 4.9.10 kernel and the device is not fully recognized .. I can only scan network and not link. Thank you There is nothing in thi

Re: ath10k regression on XPS13

2017-02-21 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Tue, 21 Feb 2017 11:32:49 +0200 > >> We are working on a fix so that ath10k continues to work with older >> board-2.bin, but that might take a day or two still. > > Kalle I really wanted to send my net-next pull request to Linus later > today. But

Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 07:16:16AM +, Grumbach, Emmanuel wrote: > > > > a) just remove the print and use instead request_module_nowait() (this is > > more in alignment of what your code actually does today; or > > > > b) fix the request_module() use so that the error print matches the > > exp

Re: ath10k regression on XPS13

2017-02-21 Thread David Miller
From: Kalle Valo Date: Tue, 21 Feb 2017 11:32:49 +0200 > We are working on a fix so that ath10k continues to work with older > board-2.bin, but that might take a day or two still. Kalle I really wanted to send my net-next pull request to Linus later today. But I guess I have to wait for this at

Re: [PATCH V2 1/2] firmware: add more flexible request_firmware_async function

2017-02-21 Thread Luis R. Rodriguez
On Thu, Feb 16, 2017 at 08:26:35AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we got only one function for loading firmware asynchronously: > request_firmware_nowait. It didn't allow much customization of firmware > loading process - there is only one bool uevent argument. Moreo

Re: [PATCH 1/2] firmware: add more flexible request_firmware_async function

2017-02-21 Thread Luis R. Rodriguez
On Wed, Feb 15, 2017 at 11:29:47PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we got only one function for loading firmware asynchronously: > request_firmware_nowait. It didn't allow much customization of firmware > loading process - there is only one bool uevent argument. Moreo

ANNOUNCE: Netdev 2.1 CFP extended

2017-02-21 Thread Jamal Hadi Salim
The tech committee has graciously extended the CFP to February 27th. Hurry o thee procastinators and submit early to avoid the hazards of last minute traffic. Refer to: https://netdevconf.org/2.1/submit-proposal.html Some reminders, again: -Registration is open. Register early so we can plan be

Re: [OpenWrt-Devel] ATH10K VLAN firmware issue

2017-02-21 Thread Bruno Antunes
On 21 February 2017 at 13:42, Tom Psyborg wrote: > have you tried this one > https://forum.lede-project.org/t/new-qca988x-firmware-with-mesh-support/1587 >From my testing it does not work. > > On 21 February 2017 at 14:19, Valo, Kalle wrote: >> >> voncken writes: >> >> > Do you know if the fir

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-02-21 Thread Rob Herring
On Sun, Feb 19, 2017 at 11:19 PM, Heiko Schocher wrote: > Hello all, > > Am 13.02.2017 um 22:31 schrieb Rob Herring: >> >> On Mon, Feb 13, 2017 at 12:38 AM, Heiko Schocher wrote: >>> >>> Hello Rob, >>> >>> >>> Am 10.02.2017 um 16:51 schrieb Rob Herring: On Tue, Feb 07, 2017 at 06:2

RE: [OpenWrt-Devel] ATH10K VLAN firmware issue

2017-02-21 Thread voncken
Kalle, Do you know if the firmware team planned to fix the VLAN issue on ath10k firmware? Thanks for your help. Cedric. > -Message d'origine- > De : linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] De la part de Valo, Kalle > Envoyé : mardi 1

[RFC v4 15/21] ath10k: per target configurablity of various items

2017-02-21 Thread Erik Stromdahl
Added ability to set bus type and configure the max number of peers in the ath10k_hw_params struct. With this functionality it is possible to have a different hw configuration depending on bus type for the same radio chipset. E.g. SDIO and USB devices using the same chipset as PCIe devices will p

[RFC v4 11/21] ath10k: usb support

2017-02-21 Thread Erik Stromdahl
usb HIF implementation Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/Kconfig |6 + drivers/net/wireless/ath/ath10k/Makefile |3 + drivers/net/wireless/ath/ath10k/usb.c| 1125 ++ drivers/net/wireless/ath/ath10k/usb.h| 128 4 f

[RFC v4 08/21] ath10k: sdio get target info

2017-02-21 Thread Erik Stromdahl
Special BMI get target info function for SDIO. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/bmi.c | 70 ++ drivers/net/wireless/ath/ath10k/bmi.h | 2 + drivers/net/wireless/ath/ath10k/core.c | 5 ++- 3 files changed, 76 insertions(+), 1 de

[RFC v4 17/21] ath10k: htt: High latency TX support

2017-02-21 Thread Erik Stromdahl
Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htt.h| 9 ++-- drivers/net/wireless/ath/ath10k/htt_tx.c | 72 +++- drivers/net/wireless/ath/ath10k/mac.c| 5 ++- 3 files chang

[RFC v4 18/21] ath10k: htt: High latency RX support

2017-02-21 Thread Erik Stromdahl
Special HTT RX handling for high latency interfaces. Since no DMA physical addresses are used in the RX ring config message (this is not supported by the high latency devices), no RX ring is allocated. All RX skb's are allocated by the driver and passed directly to mac80211 in the HTT RX indicatio

[RFC v4 20/21] ath10k: add QCA9377 sdio hw_param item

2017-02-21 Thread Erik Stromdahl
Hardware parameters for QCA9377 sdio devices. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.c | 25 + drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/

[RFC v4 07/21] ath10k: add sdio extra initializations

2017-02-21 Thread Erik Stromdahl
Extra initializations needed by all sdio boards. Derived from qcacld. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/c

[RFC v4 10/21] ath10k: various usb related definitions

2017-02-21 Thread Erik Stromdahl
Definitions for USB based chipsets Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.h | 3 +++ drivers/net/wireless/ath/ath10k/debug.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h in

[RFC v4 21/21] ath10k: dma fixes for high latency devices

2017-02-21 Thread Erik Stromdahl
Several DMA related functions (such as the dma_map_xxx functions) are not used with high latency devices and don't need to be invoked in this case. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.c| 13 - drivers/net/wireless/ath/ath10k/htt_rx.c | 3 ++- dr

[RFC v4 12/21] ath10k: high_latency detection

2017-02-21 Thread Erik Stromdahl
The setup of high latency chips (USB and SDIO) is sometimes different than for chips using low latency interfaces. The bus type is used to determine if the interface is a high latency interface. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.c | 1 + drivers/net/wireless

[RFC v4 13/21] ath10k: different fw file names for usb and sdio

2017-02-21 Thread Erik Stromdahl
Since both SDIO and USB based chipsets will use different firmware from the PCIe and AHB chipsets, the fw file name must be different depending on bus type. The new firmware names are: For PCIe and AHB: firmware-.bin (same as before) For SDIO: firmware-sdio-.bin For USB: firmware-usb-.bin Sign

[RFC v4 19/21] ath10k: add QCA9377 usb hw_param item

2017-02-21 Thread Erik Stromdahl
Hardware parameters for QCA9377 usb devices. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.c | 23 +++ drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net

[RFC v4 06/21] ath10k: sdio support

2017-02-21 Thread Erik Stromdahl
sdio/mailbox HIF implementation. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/Kconfig |6 + drivers/net/wireless/ath/ath10k/Makefile |3 + drivers/net/wireless/ath/ath10k/sdio.c | 2138 ++ drivers/net/wireless/ath/ath10k/sdio.h | 263

[RFC v4 14/21] ath10k: htt: RX ring config HL support

2017-02-21 Thread Erik Stromdahl
Special HTT RX ring config message used by high latency devices. The main difference between HL and LL is that HL devices do not use shared memory between device and host and thus, no host paddr's are added to the RX config message. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath

[RFC v4 05/21] ath10k: various sdio related definitions

2017-02-21 Thread Erik Stromdahl
Debug masks for SDIO HIF layer. Address definitions for SDIO/mbox based chipsets. Augmented struct host_interest with more members. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.h | 3 ++ drivers/net/wireless/ath/ath10k/debug.h | 2 ++ drivers/net/wireless/ath

[RFC v4 16/21] ath10k: add start_once support

2017-02-21 Thread Erik Stromdahl
Add possibility to configure the driver to only start target once. This can reduce startup time of SDIO devices significantly since loading the firmware can take a substantial amount of time. The patch is also necessary for high latency devices in general since it does not seem to be possible to r

[RFC v4 09/21] ath10k: htc: ready_ext msg support

2017-02-21 Thread Erik Stromdahl
Added support for extended ready message. The extended ready message contains the maximum bundle count supported by SDIO chipsets. It is transmitted by SDIO chipset only and replaces the "standard" ready message in this case. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc

[RFC v4 03/21] ath10k: htc: move htc ctrl ep connect to htc_init

2017-02-21 Thread Erik Stromdahl
This patch moves the HTC ctrl service connect from htc_wait_target to htc_init. This is done in order to make sure the htc ctrl service is setup properly before hif_start is called. The reason for this is that we want the HTC ctrl service callback to be initialized before the target sends the HTC

[RFC v4 04/21] ath10k: htc: refactorization

2017-02-21 Thread Erik Stromdahl
Code refactorization: Moved the code for ep 0 in ath10k_htc_rx_completion_handler to ath10k_htc_control_rx_complete. This eases the implementation of SDIO/mbox significantly since the ep_rx_complete cb is invoked directly from the SDIO/mbox hif layer. Since the ath10k_htc_control_rx_complete alr

[RFC v4 02/21] ath10k: htc: rx trailer lookahead support

2017-02-21 Thread Erik Stromdahl
The RX trailer parsing is now capable of parsing lookahead reports. A lookahead contains the first 4 bytes of the next HTC message (that will be read in the next SDIO read operation). Lookaheads are used by the SDIO/mbox HIF layer to determine if the next message is part of a bundle, which endpoint

[RFC v4 01/21] ath10k: htc: made static function public

2017-02-21 Thread Erik Stromdahl
Changed ath10k_htc_notify_tx_completion and ath10k_htc_process_trailer from static to non static. These functions are needed by SDIO/mbox. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.c | 14 -- drivers/net/wireless/ath/ath10k/htc.h | 6 ++ 2 files chan

[RFC v4 00/21] ath10k sdio and usb support

2017-02-21 Thread Erik Stromdahl
This is the 4th version of the sdio and usb RFC patch series. I have combined the sdio and usb patches into one series since they are inseparable (both series must be applied in order to have a working system). The main difference since last version (v3) is that QCA9377 sdio support was added. I h

Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Jouni Malinen
On Tue, Feb 21, 2017 at 01:37:57PM +0100, Johannes Berg wrote: > Add a new NL80211_ATTR_PMK attribute that might be passed as part > of NL80211_CMD_CONNECT command, and contain the PSK (which is the > PMK, hence the name.) > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h > +#de

Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
> The .len verifies that it's at least that long. We're thus ignoring > additional bytes in the PSK case if they're present, which I suppose > we should fix by checking the exact length in the code separately. > IOW, I'll add this: --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -80

Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
> While the existing WPA2-PSK cases all use 32 octet PMK, there are > also > 48 octet PMKs in use with EAP (Suite B 192-bit level and FILS with > SHA384). Patch 2/2 seemed to look at the PMK length as well.. Should > the same be done already with 1/2 so that the PSK case is separately > validating

[PATCH 07/10] wil6210: protect list of pending wmi events during flush

2017-02-21 Thread Maya Erez
From: Hamad Kadmany When flush is done, pending events list is manipulated without taking the proper spinlock, which could lead to memory corruption if list is manipulated by wmi worker or by interrupt routine. Signed-off-by: Hamad Kadmany Signed-off-by: Maya Erez --- drivers/net/wireless/ath

[PATCH 06/10] wil6210: store bss object and use cfg80211_connect_bss()

2017-02-21 Thread Maya Erez
From: Dedy Lansky In a fast disconnect/connect sequence, cfg80211_connect_result() can fail to find the bss object which the driver is connecting to. Detailed sequence of events: * Driver is connected in STA mode * Disconnect request arrives from user space. Driver disconnects and calls cfg8021

[PATCH 08/10] wil6210: use WMI_DISCONNECT_CMDID upon connect timeout

2017-02-21 Thread Maya Erez
From: Dedy Lansky Upon connect timeout driver invokes _wil6210_disconnect() which iterates over sta array and disconnects each connected sta. In practice, because the connection is still ongoing and because cid is not yet allocated, disconnect is not actually happening. This leaves FW in connecti

[PATCH 09/10] wil6210: correctly report locally generated disconnect in STA mode

2017-02-21 Thread Maya Erez
From: Dedy Lansky Driver always invoke cfg80211_disconnected() with locally_generated as false. Fix this by reporting true whenever the disconnect is triggered from upper layers (cfg80211) or from within the driver itself (reset, deinit). Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez ---

[PATCH 10/10] wil6210: add oob_mode for AP certification

2017-02-21 Thread Maya Erez
From: Lior David Add a new value to the oob_mode module parameter for supporting AP certification. All enabled values of oob_mode (>0) are intended only for debugging and diagnostics. Signed-off-by: Lior David Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/main.c| 24 ++

[PATCH 03/10] wil6210: bus_request platform operation refinement

2017-02-21 Thread Maya Erez
From: Lior David The driver uses the bus_request platform operation to request resources from the platform for a specific bandwidth. Currently the driver requests resources for the maximum theoretical bandwidth, when interface is brought up. Refine this process a bit: now the driver will request

[PATCH 04/10] wil6210: use print_hex_dump_debug instead of print_hex_dump_bytes

2017-02-21 Thread Maya Erez
From: Dedy Lansky Some dynamic debug printouts in driver are using print_hex_dump_bytes. However, with dynamic debug disabled, print_hex_dump_bytes outputs to log unconditionally. Use print_hex_dump_debug instead to prevent log pollution when dynamic debug disabled. Signed-off-by: Dedy Lansky S

[PATCH 05/10] wil6210: missing reinit_completion in HALP voting

2017-02-21 Thread Maya Erez
After setting HALP ICR bit, we keep it set until HALP unvote. Masking HALP ICR should protect the driver from hitting the HALP ICR over and over again. However, in case there is another MISC ICR we will read the HALP ICR and issue a completion. This can lead to a case where HALP voting is completed

[PATCH 00/10] wil6210 patches

2017-02-21 Thread Maya Erez
various wil6210 patches Dedy Lansky (4): wil6210: use print_hex_dump_debug instead of print_hex_dump_bytes wil6210: store bss object and use cfg80211_connect_bss() wil6210: use WMI_DISCONNECT_CMDID upon connect timeout wil6210: correctly report locally generated disconnect in STA mode Ham

[PATCH 01/10] wil6210: set dma mask to reflect device capability

2017-02-21 Thread Maya Erez
From: Hamad Kadmany device supports 48bit addresses, reflect that by setting the dma mask accordingly. Signed-off-by: Hamad Kadmany Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/pcie_bus.c | 16 drivers/net/wireless/ath/wil6210/pmc.c | 17

[PATCH 02/10] wil6210: do not start regular scan on stopped p2p device

2017-02-21 Thread Maya Erez
From: Lior David The driver should not allow starting any type of scan on a stopped P2P device. Current implementation only checked social scan. Signed-off-by: Lior David Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/cfg80211.c | 21 +++-- 1 file changed, 11 in

Re: [OpenWrt-Devel] ATH10K VLAN firmware issue

2017-02-21 Thread Valo, Kalle
voncken writes: > Do you know if the firmware team planned to fix the VLAN issue on ath10k > firmware? I reported it forward only this week. -- Kalle Valo

[RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
From: Eliad Peller Let drivers advertise support for station-mode 4-way handshake offloading with a new NL80211_EXT_FEATURE_4WAY_HANDSHAKE_OFFLOAD_STA flag. Add a new NL80211_ATTR_PMK attribute that might be passed as part of NL80211_CMD_CONNECT command, and contain the PSK (which is the PMK, he

[RFC v2 2/2] cfg80211: support 4-way handshake offloading for 802.1X

2017-02-21 Thread Johannes Berg
From: Avraham Stern Add API for setting the PMK to the driver. For FT support, allow setting also the PMK-R0 Name. This can be used by drivers that support 4-Way handshake offload while IEEE802.1X authentication is managed by upper layers. Signed-off-by: Avraham Stern Signed-off-by: Johannes B

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
> What I am also missing is how to deal with NL80211_CMD_CONNECTED > event signalling. Should that be given after (un)successful > completion of the 4-way handshake or should we have a separate event > for that? That's a good point. I don't think a new event really works well, but perhaps we sho

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 12:46, Johannes Berg wrote: > Would this work for you? We should have wpa_supplicant support too, but need to ask Andrei to look at that. >> >> Forgot to reply to this. Yes, this will work. Can come up with >> wpa_supp changes. > > No, we have them. Just need to see where

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
> > > Would this work for you? We should have wpa_supplicant support > > > too, but need to ask Andrei to look at that. > > Forgot to reply to this. Yes, this will work. Can come up with > wpa_supp changes. No, we have them. Just need to see where they are :) johannes

Re: [PATCH V3 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds

2017-02-21 Thread Kalle Valo
Arend Van Spriel writes: > On 21-2-2017 10:47, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> Failing to load NVRAM file isn't critical if we manage to get platform >> one in the fallback path. It means warnings like: >> [ 10.801506] brcmfmac :01:00.0: Direct firmware load for >> brcm/br

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 12:34, Arend Van Spriel wrote: > On 21-2-2017 11:40, Johannes Berg wrote: >> On Tue, 2017-02-21 at 11:32 +0100, Arend Van Spriel wrote: >>> On 21-2-2017 11:09, Johannes Berg wrote: From: Eliad Peller Let drivers advertise support for station-mode 4-way handshake

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 11:40, Johannes Berg wrote: > On Tue, 2017-02-21 at 11:32 +0100, Arend Van Spriel wrote: >> On 21-2-2017 11:09, Johannes Berg wrote: >>> From: Eliad Peller >>> >>> Let drivers advertise support for station-mode 4-way handshake >>> offloading with a new >>> NL80211_EXT_FEATURE_4WAY_HAN

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
On Tue, 2017-02-21 at 11:32 +0100, Arend Van Spriel wrote: > On 21-2-2017 11:09, Johannes Berg wrote: > > From: Eliad Peller > > > > Let drivers advertise support for station-mode 4-way handshake > > offloading with a new > > NL80211_EXT_FEATURE_4WAY_HANDSHAKE_OFFLOAD_STA > > flag. > > I find us

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 11:09, Johannes Berg wrote: > From: Eliad Peller > > Let drivers advertise support for station-mode 4-way handshake > offloading with a new NL80211_EXT_FEATURE_4WAY_HANDSHAKE_OFFLOAD_STA > flag. I find use of the term OFFLOAD a bit redundant as it is implied by its presence anyway.

[RFC] mac80211_hwsim: report survey data for scanned channels

2017-02-21 Thread Johannes Berg
From: Johannes Berg Currently, hwsim is reporting survey data (only a fake noise floor) for the current channel. This breaks when the multi-channel support is enabled since then there's no current channel. Make the dummy implementation closer to a real one and only report data while scanning, fo

[PATCH v2] ath10k: Remove return statement from a void function

2017-02-21 Thread Marcin Rokicki
The empty 'return;' statement in a void function should be used to return from somewhere else than the end. Signed-off-by: Marcin Rokicki --- Changes for v2 -remove only return statement instead of empty err label which can be used in the future --- drivers/net/wireless/ath/ath10k/core.c |

[RFC] nl80211/cfg80211: Add API for setting the PMK to the driver

2017-02-21 Thread Johannes Berg
From: Avraham Stern Add API for setting the PMK to the driver. For FT support, allow setting also the PMK-R0 Name. This can be used by drivers that support 4-Way handshake offload while IEEE802.1X authentication is managed by upper layers. Signed-off-by: Avraham Stern Signed-off-by: Johannes B

[PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Johannes Berg
From: Eliad Peller Let drivers advertise support for station-mode 4-way handshake offloading with a new NL80211_EXT_FEATURE_4WAY_HANDSHAKE_OFFLOAD_STA flag. Add a new NL80211_ATTR_PMK attribute that might be passed as part of NL80211_CMD_CONNECT command, and contain the PSK (which is the PMK, he

Re: [PATCH V3 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 10:47, Rafał Miłecki wrote: > From: Rafał Miłecki > > Failing to load NVRAM file isn't critical if we manage to get platform > one in the fallback path. It means warnings like: > [ 10.801506] brcmfmac :01:00.0: Direct firmware load for > brcm/brcmfmac43602-pcie.txt failed with

[PATCH V3 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds

2017-02-21 Thread Rafał Miłecki
From: Rafał Miłecki Failing to load NVRAM file isn't critical if we manage to get platform one in the fallback path. It means warnings like: [ 10.801506] brcmfmac :01:00.0: Direct firmware load for brcm/brcmfmac43602-pcie.txt failed with error -2 are unnecessary & disturbing for people wit

[PATCH V3 1/2] firmware: add more flexible request_firmware_async function

2017-02-21 Thread Rafał Miłecki
From: Rafał Miłecki So far we got only one function for loading firmware asynchronously: request_firmware_nowait. It didn't allow much customization of firmware loading process - there is only one bool uevent argument. Moreover this bool also controls user helper in an unclear way. Resolve this

Re: [PATCH] ath10k: Remove return statement from a void function

2017-02-21 Thread Arend Van Spriel
On 21-2-2017 10:04, Marcin Rokicki wrote: > The empty 'return;' statement in a void function should be > used to return from somewhere else then the end. > > Signed-off-by: Marcin Rokicki > --- > drivers/net/wireless/ath/ath10k/core.c | 11 +-- > 1 file changed, 5 insertions(+), 6 dele

Re: wpa psk offloading

2017-02-21 Thread Johannes Berg
On Tue, 2017-02-21 at 10:20 +0100, Arend Van Spriel wrote: > Hi Johannes, > > Internally I am asked to look at "pmk plumbing" patches allowing > firmware to deal with 4-way handshake. Now I noticed this topic being > discussed during last wireless workshop in Santa Fe [1]. > > I do not recall any

ath10k regression on XPS13

2017-02-21 Thread Kalle Valo
(Changing subject, adding Dave and relevant lists) Linus Torvalds writes: > On Mon, Feb 20, 2017 at 7:20 AM, Jiri Kosina wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus >> >> to receive HID subsystem updates for 4.11: > > The touchpad on my XPS13 no longer w

wpa psk offloading

2017-02-21 Thread Arend Van Spriel
Hi Johannes, Internally I am asked to look at "pmk plumbing" patches allowing firmware to deal with 4-way handshake. Now I noticed this topic being discussed during last wireless workshop in Santa Fe [1]. I do not recall any follow-up after that. At least no concrete patches, right? Also in wpa_s

[PATCH] ath10k: Remove return statement from a void function

2017-02-21 Thread Marcin Rokicki
The empty 'return;' statement in a void function should be used to return from somewhere else then the end. Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/core.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/cor

Re: [PATCH v6 1/3] cfg80211: Accept multiple RSSI thresholds for CQM

2017-02-21 Thread Kalle Valo
Andrew Zaborowski writes: > Hi, > > On 15 February 2017 at 09:58, Kalle Valo wrote: >> Johannes Berg writes: >>> On Fri, 2017-02-10 at 10:02 +0100, Andrew Zaborowski wrote: Change the SET CQM command's RSSI threshold attribute to accept any number of thresholds as a sorted array. The

Re: Monitor mode 'cook' flag meaning

2017-02-21 Thread Johannes Berg
(please quote properly) On Mon, 2017-02-20 at 18:46 -0700, Thomas d'Otreppe wrote: > Do you have any example of devices where control or otherbss would be > useful? Would both be for FullMAC devices? No, I don't really know. johannes