[PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Marcin Rokicki
Both macros are used internally to convert incomming parameters to strings in a switch case statement. Current implementation gives following output from checkpatch.pl: - ERROR: Macros with complex values should be enclosed in parentheses - WARNING: Macros with flow control statements should be

Re: [rtl8xxxu] rtl8192cu (0bda:8176) on linux-4.9.11 (arm) high sirq rate

2017-02-22 Thread Christian Hilberg
Hi again, Am Montag, 20. Februar 2017, 14:51:54 CET schrieb Christian Hilberg: > Hi all, > > currently I'm testing rtl8xxxu on an ARM device (i.mx28, armv5te) under > linux-4.9.11 with a RealTek 8192cu (0bda:8176) wifi dongle. Since > I had to set CONFIG_RTL8XXXU_UNTESTED, I'm prepared to see som

Re: [PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Joe Perches
On Wed, 2017-02-22 at 09:15 +0100, Marcin Rokicki wrote: > Both macros are used internally to convert incomming parameters > to strings in a switch case statement. > > Current implementation gives following output from checkpatch.pl: > - ERROR: Macros with complex values should be enclosed in par

Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-22 Thread Jithu Jance
Hi Jouni, Johannes et al., On Wed, Feb 22, 2017 at 1:27 AM, Arend Van Spriel wrote: > On 21-2-2017 13:37, Johannes Berg wrote: >> >>> What I am also missing is how to deal with NL80211_CMD_CONNECTED >>> event signalling. Should that be given after (un)successful >>> completion of the 4-way handsh

RE: [OpenWrt-Devel] ATH10K VLAN firmware issue

2017-02-22 Thread voncken
Thanks for your answer, How I can know when this issue will be fixed in ath10k firmware mainline? Do you know if Qualcomm publish a release note for this firmware? > -Message d'origine- > DeĀ : linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vg

[PATCH] mac80211: don't handle filtered frames within a BA session

2017-02-22 Thread Felix Fietkau
When running a BA session, the driver (or the hardware) already takes care of retransmitting failed frames, since it has to keep the receiver reorder window in sync. Adding another layer of retransmit around that does not improve anything. In fact, it can only lead to some strong reordering with h

[PATCH] ath10k: Disallow DFS simulation if DFS channel is not enabled

2017-02-22 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan If DFS is not enabled in hostapd (ieee80211h=0) DFS channels shall not be available for use even though the hardware may have the capability to support DFS. With this configuration (DFS disabled in hostapd) trying to bring up ath10k device in DFS channel for AP mode

Re: [PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Joe Perches
(fyi Marcin, the reason this isn't getting on the list is because your 3 tries have all included text and html) On Wed, 2017-02-22 at 14:31 +0100, Marcin Rokicki wrote: > > > > Here is an alternate style used a few times in the kernel > > > > Maybe it'd be nicer to change the macros to somethin

[PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-22 Thread Tahia Khan
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: Avoid CamelCase: Avoid CamelCase: Avoid CamelCase: Signed-off-by: Tahia Khan --- drivers/staging/wilc1000/coreconfigurator.h | 8 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +- 2 files

Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-22 Thread Arend Van Spriel
On 22-2-2017 18:14, Tahia Khan wrote: > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: > > Avoid CamelCase: > Avoid CamelCase: > Avoid CamelCase: Just a generic remark that may help you with other changes you will be making in the linux kernel. Warnings from checkpatch

Re: [PATCH v2] ath10k: Remove return statement from a void function

2017-02-22 Thread Arend Van Spriel
On 21-2-2017 11:28, Marcin Rokicki wrote: > The empty 'return;' statement in a void function should be > used to return from somewhere else than the end. > > Signed-off-by: Marcin Rokicki > --- > > Changes for v2 > -remove only return statement instead of empty err label > which can be used

Re: [PATCH] wireless-regdb: Update rules for Australia (AU) and add 60GHz rules

2017-02-22 Thread Seth Forshee
On Sat, Feb 18, 2017 at 05:05:15PM +1030, Ryan Mounce wrote: > Sourced from the latest legislation at > https://www.legislation.gov.au/Details/F2016C0043 This link isn't working for me. > The current rules exceed legal limits between 5250-5330MHz, and permit > illegal operation in 5600-5650MHz (r

Re: [PATCH] wireless-regdb: Update rules for Australia (AU) and add 60GHz rules

2017-02-22 Thread Ryan Mounce
On 23 February 2017 at 08:00, Seth Forshee wrote: > On Sat, Feb 18, 2017 at 05:05:15PM +1030, Ryan Mounce wrote: >> Sourced from the latest legislation at >> https://www.legislation.gov.au/Details/F2016C0043 > > This link isn't working for me. Oops, I truncated that URL. Working link (also in the

[PATCH] rtlwifi: fix spelling mistake: "conuntry" -> "country"

2017-02-22 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/regd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c b/drivers/net/wireless/realtek

Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-22 Thread Tahia Khan
On Wed, Feb 22, 2017 at 08:50:31PM +0100, Arend Van Spriel wrote: > On 22-2-2017 18:14, Tahia Khan wrote: > > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: > > > > Avoid CamelCase: > > Avoid CamelCase: > > Avoid CamelCase: > > Just a generic remark that may help you w

Re: [PATCH] wireless-regdb: Update rules for Australia (AU) and add 60GHz rules

2017-02-22 Thread Johannes Berg
> The frequency ranges have been "rounded down" to conform with the > apparent convention of only including ranges used by standard 802.11 > channels, rather than using the actual frequency ranges as has been > done for some countries (and most 60GHz rules). My preference is the > latter so that t

Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-22 Thread Joe Perches
On Wed, 2017-02-22 at 20:50 +0100, Arend Van Spriel wrote: > On 22-2-2017 18:14, Tahia Khan wrote: > > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: [] > Just a generic remark that may help you with other changes you will be > making in the linux kernel. Warnings from chec

Re: [Outreachy kernel] Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

2017-02-22 Thread Julia Lawall
> Thanks for the feedback Arend, I really appreciate it. I've decided to go with > these changes in my follow-up patch request: > > - rename tstrRSSI to 'rssi_history_buffer' as Aren suggested since it makes > the > purpose of the struct clear > - remove Hungarian notation from all tstrRSSI member