The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets
for bluetooth rfkill functionality.
Tested-by: russianneuroman...@ya.ru
Signed-off-by: Hans de Goede
---
net/rfkill/rfkill-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill
From: Johannes Berg
Pass the new extended ACK reporting struct to all of the
generic netlink parsing functions. For now, pass NULL in
almost all callers (except for some in the core.)
Signed-off-by: Johannes Berg
---
crypto/crypto_user.c | 2 +-
drivers/block/drbd
From: Johannes Berg
Add the base infrastructure and UAPI for netlink
extended ACK reporting. All "manual" calls to
netlink_ack() pass NULL for now and thus don't
get extended ACK reporting.
Big thanks goes to Pablo Neira Ayuso for not only
bringing up the whole topic at netconf (again) but
also
From: Johannes Berg
Now that we have extended error reporting and a new message format
for netlink ACK messages, also extend this to be able to return
arbitrary cookie data on success.
This will allow, for example, nl80211 to not send an extra message
for cookies identifying newly created object
From: Johannes Berg
This is an add-on to the previous patch that passes
the extended ACK structure where it's already available
by existing genl_info or extack function arguments.
This was done with this spatch (with some manual
adjustment of indentation):
@@
expression A, B, C, D, E;
identifie
From: Johannes Berg
Pass the extended ACK reporting struct down from
generic netlink to the families, using the existing
struct genl_info for simplicity.
Also add support to set the extended ACK information
from generic netlink users.
Signed-off-by: Johannes Berg
---
include/net/genetlink.h |
Changes since v2:
* add NUM_NLMSGERR_ATTRS, NLMSGERR_ATTR_MAX
* fix cookie length to 20 (sha-1 length)
* move struct members for cookie to patch 3 where they should be
* another cleanup suggested by David Ahern
johannes
On Sat, 2017-04-08 at 14:50 -0400, David Ahern wrote:
> On 4/8/17 1:48 PM, Johannes Berg wrote:
> > From: Johannes Berg
> >
> > Pass the new extended ACK reporting struct to all of the
> > generic netlink parsing functions. For now, pass NULL in
> > almost all callers (except for some in the core
On 4/8/17 1:48 PM, Johannes Berg wrote:
> diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
> index f3946a27bd07..d1564557d645 100644
> --- a/include/uapi/linux/netlink.h
> +++ b/include/uapi/linux/netlink.h
> @@ -101,6 +101,29 @@ struct nlmsghdr {
> struct nlmsgerr {
>
On Sat, 2017-04-08 at 20:40 +0200, Jiri Pirko wrote:
> > I think I'll leave it like this - if anyone really wants to say
> > "attribute 0 is missing" then we can add a flag later... The UAPI
> > does
> > take this into account by not including the attribute at all if the
> > data is invalid, so 0
since a v3 is coming another small cleanup ...
On 4/8/17 2:34 PM, Johannes Berg wrote:
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index c74f56a4fcf1..98e55a59c97e 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -2336,20 +2339,27 @@ void netl
On 4/8/17 1:48 PM, Johannes Berg wrote:
> From: Johannes Berg
>
> Pass the new extended ACK reporting struct to all of the
> generic netlink parsing functions. For now, pass NULL in
> almost all callers (except for some in the core.)
>
> Signed-off-by: Johannes Berg
fails to compile as well:
Sat, Apr 08, 2017 at 08:37:01PM CEST, johan...@sipsolutions.net wrote:
>On Sat, 2017-04-08 at 20:34 +0200, Jiri Pirko wrote:
>> nla_total_size(sizeof(u32));
>> > + if (extack &&
>> > + (extack->missing_attr || extack-
>> > >bad_attr))
>>
>> Attr could be 0, ri
On Sat, 2017-04-08 at 14:36 -0400, David Ahern wrote:
>
> I think v3 is in your future ...
>
> /home/dsa/kernel-4.git/include/linux/netlink.h:78:12: error:
> ‘NETLINK_MAX_COOKIE_LEN’ undeclared here (not in a function)
> u8 cookie[NETLINK_MAX_COOKIE_LEN];
> ^
>
> it's defined in pa
On Sat, 2017-04-08 at 20:34 +0200, Jiri Pirko wrote:
> nla_total_size(sizeof(u32));
> > + if (extack &&
> > + (extack->missing_attr || extack-
> > >bad_attr))
>
> Attr could be 0, right? I know that on the most of the places 0 is
> UNSPEC, but I'm pretty sur
On 4/8/17 1:48 PM, Johannes Berg wrote:
> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
> index da14ab61f363..47562e940e9c 100644
> --- a/include/linux/netlink.h
> +++ b/include/linux/netlink.h
> @@ -62,11 +62,41 @@ netlink_kernel_create(struct net *net, int unit, struct
> netlink
From: Johannes Berg
This is an add-on to the previous patch that passes
the extended ACK structure where it's already available
by existing genl_info or extack function arguments.
This was done with this spatch (with some manual
adjustment of indentation):
@@
expression A, B, C, D, E;
identifie
From: Johannes Berg
Now that we have extended error reporting and a new message format
for netlink ACK messages, also extend this to be able to return
arbitrary cookie data on success.
This will allow, for example, nl80211 to not send an extra message
for cookies identifying newly created object
From: Johannes Berg
Add the base infrastructure and UAPI for netlink
extended ACK reporting. All "manual" calls to
netlink_ack() pass NULL for now and thus don't
get extended ACK reporting.
Big thanks goes to Pablo Neira Ayuso for not only
bringing up the whole topic at netconf (again) but
also
From: Johannes Berg
Pass the new extended ACK reporting struct to all of the
generic netlink parsing functions. For now, pass NULL in
almost all callers (except for some in the core.)
Signed-off-by: Johannes Berg
---
crypto/crypto_user.c | 2 +-
drivers/block/drbd
From: Johannes Berg
Pass the extended ACK reporting struct down from
generic netlink to the families, using the existing
struct genl_info for simplicity.
Also add support to set the extended ACK information
from generic netlink users.
Signed-off-by: Johannes Berg
---
include/net/genetlink.h |
Changes since v1:
* credit Pablo and Jamal
* incorporate suggestion from David Ahern
* fix compilation in decnet
Sat, Apr 08, 2017 at 07:48:56PM CEST, johan...@sipsolutions.net wrote:
>From: Johannes Berg
>
>Add the base infrastructure and UAPI for netlink
>extended ACK reporting. All "manual" calls to
>netlink_ack() pass NULL for now and thus don't
>get extended ACK reporting.
Why so narrow? :)
>
>Signed
On 4/8/17 1:48 PM, Johannes Berg wrote:
> @@ -2267,21 +2284,37 @@ int __netlink_dump_start(struct sock *ssk, struct
> sk_buff *skb,
> }
> EXPORT_SYMBOL(__netlink_dump_start);
>
> -void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err)
> +void netlink_ack(struct sk_buff *in_skb
From: Johannes Berg
This is an add-on to the previous patch that passes
the extended ACK structure where it's already available
by existing genl_info or extack function arguments.
This was done with this spatch (with some manual
adjustment of indentation):
@@
expression A, B, C, D, E;
identifie
From: Johannes Berg
Add the base infrastructure and UAPI for netlink
extended ACK reporting. All "manual" calls to
netlink_ack() pass NULL for now and thus don't
get extended ACK reporting.
Signed-off-by: Johannes Berg
---
crypto/crypto_user.c | 3 +-
drivers/infiniband/core/netl
Hi,
After testing and fixing the ack message length calculation,
this now works.
The UAPI changes are like before - the ACK message format becomes
[nlmsg header]
[ack header]
[request nlmsg header]
[request nlmsg body (already optional) - length aligned]
[extended ACK TLVs - this is NEW]
Th
From: Johannes Berg
Pass the new extended ACK reporting struct to all of the
generic netlink parsing functions. For now, pass NULL in
almost all callers (except for some in the core.)
Signed-off-by: Johannes Berg
---
crypto/crypto_user.c | 2 +-
drivers/block/drbd
From: Johannes Berg
Now that we have extended error reporting and a new message format
for netlink ACK messages, also extend this to be able to return
arbitrary cookie data on success.
This will allow, for example, nl80211 to not send an extra message
for cookies identifying newly created object
From: Johannes Berg
Pass the extended ACK reporting struct down from
generic netlink to the families, using the existing
struct genl_info for simplicity.
Also add support to set the extended ACK information
from generic netlink users.
Signed-off-by: Johannes Berg
---
include/net/genetlink.h |
On Sat, 2017-04-08 at 11:28 -0400, Jiri Benc wrote:
> Perhaps the structure should be named just "netlink_ext" or so? It
> seems it'll pick up some non-error related usage, such as the cookies
> here or, in the future, flags indicating how the message should be
> parsed.
Fair point, I'll call it n
On Fri, 7 Apr 2017 21:44:02 +0200, Johannes Berg wrote:
> @@ -67,6 +67,8 @@ struct netlink_ext_err {
> u32 ext_code;
> u32 msg_offset;
> u16 attr;
> + const u8 *cookie;
> + u8 cookie_len;
> };
Perhaps the structure should be named just "netlink_ext" or so? It
seems it'l
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
nl-err
head: 9176318575481c0b2cf7b08c9253c98751dee303
commit: 9176318575481c0b2cf7b08c9253c98751dee303 [5/5] netlink: pass extended
error struct to parsing functions
config: i386-randconfig-x075-201714 (attached as
-Spriel/cfg80211-support-multiple-scheduled-scans/20170408-175235
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
master
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
>> include/net/cfg80211.h:1727: warning: No description found f
-scheduled-scans/20170408-175235
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin
-scheduled-scans/20170408-175235
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
master
config: i386-randconfig-x008-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
-scheduled-scans/20170408-175235
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
master
config: i386-randconfig-x008-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
On Fri, Apr 07, 2017 at 05:24:05PM +0530, Aditya Shankar wrote:
> With this update, the host driver is consistent with the
> implementation on the firmware side with respect to obtaining
> the driver handler for all modes.
> With this new format, the calls to set the wilc operation mode
> is simpli
Hi,
On 07-04-17 23:43, Arend Van Spriel wrote:
On 6-4-2017 14:14, Hans de Goede wrote:
Hi,
I noticed your patch-series on the lwn.net kernel page,
and I took a peek :)
I don't think that this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?h=20170329-dr
39 matches
Mail list logo