Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

2017-05-08 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > The name of an array used by itself will always return the array's address. > So these tests will always evaluate as false and therefore the _return_ > will never be executed. > > Signed-off-by: Gustavo A. R. Silva

[PATCH] net: wireless: ath: ath10k: remove unnecessary code

2017-05-08 Thread Gustavo A. R. Silva
The name of an array used by itself will always return the array's address. So these tests will always evaluate as false and therefore the _return_ will never be executed. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath10k/wmi.c | 9 - 1 file

[PATCH] wcn36xx: Close SMD channel on device removal

2017-05-08 Thread Bjorn Andersson
The SMD channel is not the primary WCNSS channel and must explicitly be closed as the device is removed, or the channel will already by open on a subsequent probe call in e.g. the case of reloading the kernel module. This issue was introduced because I simplified the underlying SMD implementation

[PATCH] net: wireless: ath: ath9k: remove unnecessary code

2017-05-08 Thread Gustavo A. R. Silva
The name of an array used by itself will always return the array's address. So this test will always evaluate as true. Addresses-Coverity-ID: 1364903 Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath9k/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drivers: net: wireless: rsi: rsi_91x_core: Use time_after time comparison

2017-05-08 Thread Karim Eshapa
Use time_after kernel macro for time comparison. Signed-off-by: Karim Eshapa --- drivers/net/wireless/rsi/rsi_91x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_core.c b/drivers/net/wireless/rsi/rsi_91x_core.c

Re: pull-request: mac80211 2017-05-08

2017-05-08 Thread David Miller
From: Johannes Berg Date: Mon, 8 May 2017 16:46:21 +0200 > Thanks for merging the rate fix quickly the other day. I've got a > few more fixes lined up, so this time as a pull request. > > Please pull and let me know if there's any problem. Pulled, thanks.

Ath10k Firmware crashes on QCA9888 board

2017-05-08 Thread Joan Josep
Hello everybody We bought some 11AC cards and we experienced some issues. We are using a qca9888 chipset 11AC mini pci card on a 4.9.0 kernel compiled for an ARM processor (imx6) using Ubuntu 14.04 as operating system. We are experiencing some problems when we try to load the ath10k_pci

Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-08 Thread Ian W MORRISON
On 9 May 2017 at 00:42, Andy Shevchenko wrote: > On Sun, May 7, 2017 at 1:04 PM, Ian W MORRISON wrote: > > What are you trying to achieve by posting this patch over and over so often? > > Version 5 look pretty good to me. Just stop posting it

pull-request: mac80211 2017-05-08

2017-05-08 Thread Johannes Berg
Hi Dave, Thanks for merging the rate fix quickly the other day. I've got a few more fixes lined up, so this time as a pull request. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 4ac4d584886a4f47f8ff3bca0f32ff9a2987d3e5: Merge

Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-08 Thread Andy Shevchenko
On Sun, May 7, 2017 at 1:04 PM, Ian W MORRISON wrote: > A kernel cloned from > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and > built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) > fails when booting on an Intel Atom device with the

Re: mwifiex won't connect to WPA2 anymore

2017-05-08 Thread Dan Williams
On Sat, 2017-05-06 at 22:22 +0200, Julien Cubizolles wrote: > Dan Williams writes: > > > > Ok, at this point the only thing I can think of is the MAC > > randomization that NM has.  Please see: > > > > https://blogs.gnome.org/thaller/2016/08/26/mac-address-spoofing-in- > >

[PATCH v6] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-08 Thread Ian W MORRISON
A re-positioned call to kfree() in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c causes a segmentation error. This patch removed the kfree() call. Fixes 6557ddfec348 ("staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c") Signed-off-by: Ian W Morrison

[PATCH] iwlwifi: fix merge damage in iwl_req_fw_callback()

2017-05-08 Thread Luca Coelho
From: Luca Coelho A merge damage happened when applying commit 06a1e85e66ba ("iwlwifi: remove module loading failure message") from our internal tree to iwlwifi-next.git. Fix it. Fixes: 06a1e85e66ba ("iwlwifi: remove module loading failure message") Reported-by: Pavel

mwifiex_pcie does not recover after suspend

2017-05-08 Thread Maxime Vincent
I am running the latest linux-next wireless stack, backported on 4.4, including the latest mwifiex patches that have been posted on this mailing list. (thanks!) Latest patch I applied is "mwifiex: pcie: add card_reset() support" from Brian Norris. I am running this kernel on a Microsoft Surface

[PATCH] nl80211: correctly validate MU-MIMO groups

2017-05-08 Thread Johannes Berg
From: Johannes Berg Since groups 0 and 63 are invalid, we should check for those bits. Note that the 802.11 spec specifies the *bit* order, but the CPU doesn't care about bit order since it can't address bits, so it's always treating BIT(0) as the lowest bit within a

[PATCH] mac80211: fix IBSS presp allocation size

2017-05-08 Thread Johannes Berg
From: Johannes Berg When VHT IBSS support was added, the size of the extra elements wasn't considered in ieee80211_ibss_build_presp(), which makes it possible that it would overrun the allocated buffer. Fix it by allocating the necessary space. Fixes: abcff6ef01f9

[PATCH] mac80211: bail out from prep_connection() if a reconfig is ongoing

2017-05-08 Thread Johannes Berg
From: Luca Coelho If ieee80211_hw_restart() is called during authentication, the authentication process will continue, causing the driver to be called in a wrong state. This ultimately causes an oops in the iwlwifi driver (at least). This fixes bugzilla 195299 partly.

Re: iwlwifi 8260 crash (4.11rc6)

2017-05-08 Thread Luca Coelho
Hi, On Sat, 2017-05-06 at 08:39 +0200, Janusz Dziedzic wrote: > 4.11.0-rc6-next-20170413+ > 04:00.0 Network controller: Intel Corporation Wireless 8260 (rev 3a) > iwlwifi :04:00.0: loaded firmware version 21.302800.0 op_mode iwlmvm > > Scenario: > - iwlwifi configured in monitor mode - up >