Re: WPA and WPA2

2017-05-26 Thread Johannes Berg
On Thu, 2017-05-25 at 08:40 +1000, Tobin C. Harding wrote: > On Wed, May 24, 2017 at 08:06:40PM +0200, Johannes Berg wrote: > > Just a small correction: > > > > On Wed, 2017-05-24 at 11:44 -0500, Dan Williams wrote: > > > > > > For RSN, they are 1 = PMK, 2 = GMK, 3 = GMK2, 4 seems unused. > > >

Re: [PATCH 1/7] rtlwifi: btcoex: update new btcoex version

2017-05-26 Thread kbuild test robot
Hi Yan-Hsuan, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20170526] [cannot apply to v4.12-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Larry

Re: [PATCH 1/7] rtlwifi: btcoex: update new btcoex version

2017-05-26 Thread kbuild test robot
Hi Yan-Hsuan, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20170526] [cannot apply to v4.12-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Larry

[PATCH resend 0/1] brcmfmac: p2p and normal ap access are not always possible at the same time

2017-05-26 Thread Hans de Goede
Hi, This is a resend of a patch which I send a while ago, back then there was some discussion to come up with a better fix, but that has not lead to anything and the driver is still periodically spamming the logs. As such I would like to move forward with this patch for now, which makes no functi

[PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

2017-05-26 Thread Hans de Goede
The firmware responding with -EBUSY when trying to add an extra virtual-if is a normal thing, do not print an error for this. Signed-off-by: Hans de Goede --- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c| 14 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c

[PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

2017-05-26 Thread Hans de Goede
From: Arend Van Spriel This fixes the following errors showing up in dmesg: [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8

Re: [PATCH resend 0/1] brcmfmac: p2p and normal ap access are not always possible at the same time

2017-05-26 Thread Kalle Valo
Hans de Goede writes: > This is a resend of a patch which I send a while ago, back then there > was some discussion to come up with a better fix, but that has not lead > to anything and the driver is still periodically spamming the logs. > > As such I would like to move forward with this patch fo

Re: [PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

2017-05-26 Thread Kalle Valo
Hans de Goede writes: > From: Arend Van Spriel > > This fixes the following errors showing up in dmesg: > > [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 > [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 > [ 33.063241] brcmfmac: brcmf_sdio_rxg

Re: [PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

2017-05-26 Thread Hans de Goede
Hi, On 26-05-17 13:15, Kalle Valo wrote: Hans de Goede writes: From: Arend Van Spriel Ah I see I set the Author to Arend when I added this to my tree a while back, that is fine as he did all the work for this one. I was under the impression Arend would submit this himself, but since I did

Re: [PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

2017-05-26 Thread Arend van Spriel
On 26-05-17 13:18, Hans de Goede wrote: > Hi, > > On 26-05-17 13:15, Kalle Valo wrote: >> Hans de Goede writes: >> >>> From: Arend Van Spriel > > Ah I see I set the Author to Arend when I added this to my > tree a while back, that is fine as he did all the work > for this one. I was under the i

Re: [PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

2017-05-26 Thread Kalle Valo
Arend van Spriel writes: Fixes: 6e84ab604bde ("properly align buffers ... with 64 bit DMA") Suggested-by: Arend van Spriel Signed-off-by: Hans de Goede >>> >>> I'll queue this to 4.12. >> >> Thank you, given that Arend is set as the Author you can add my: >> >> Tested-by: Hans

Re: [RFC] skbuff: introduce skb_put_zero()

2017-05-26 Thread David Miller
From: Johannes Berg Date: Fri, 26 May 2017 08:58:49 +0200 > On Thu, 2017-05-25 at 13:01 -0400, David Miller wrote: >> From: Johannes Berg >> Date: Wed, 24 May 2017 09:07:47 +0200 >> >> > From: Johannes Berg >> >  >> > This pattern was introduced a number of times in mac80211 just now, >> > and

[PATCH] rsi: use subdirectory for firmware file

2017-05-26 Thread Amitkumar Karwar
linux-firmware maintainers prefer to have a subdirectory for firmware files. Code is changed here to pick firmware file from a subdirectory. Firmware file with a new loading mechanism will be submitted inside rsi directory. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_hal

Re: [v3 10/11] rsi: Add new firmware loading method

2017-05-26 Thread amit karwar
On Wed, May 24, 2017 at 1:57 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> The older firmware loading method has been deprecated and not in use >> for any chipets. New method is introduced which works based on soft >> boot loader. In this method, compl

Re: [v3 10/11] rsi: Add new firmware loading method

2017-05-26 Thread Kalle Valo
amit karwar writes: > On Wed, May 24, 2017 at 1:57 PM, Kalle Valo wrote: >> Amitkumar Karwar writes: >> >>> From: Prameela Rani Garnepudi >>> >>> The older firmware loading method has been deprecated and not in use >>> for any chipets. New method is introduced which works based on soft >>> boo

Re: [PATCH] mwifiex: simplify the code around ra_list

2017-05-26 Thread Brian Norris
On Fri, May 26, 2017 at 09:41:49AM +0800, Shawn Lin wrote: > We don't need to check if the list is empty separately > as we could use list_first_entry_or_null to cover it. > > Signed-off-by: Shawn Lin Looks fine to me. Reviewed-by: Brian Norris

Re: [PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

2017-05-26 Thread Arend van Spriel
On 26-05-17 16:53, Kalle Valo wrote: > Arend van Spriel writes: > > Fixes: 6e84ab604bde ("properly align buffers ... with 64 bit DMA") > Suggested-by: Arend van Spriel > Signed-off-by: Hans de Goede I'll queue this to 4.12. >>> >>> Thank you, given that Arend is set as the

[PATCH v2 0/7] rtlwifi: btcoex: Final round of fixes

2017-05-26 Thread Larry Finger
These 7 patches finish this round of fixes for the various components of btcoex. In v2 of these patches, two problems noted by the kbuild test robot are corrected. Larry Larry Finger (4): rtlwifi: btcoex: Remove duplicate test in if statement rtlwifi: btcoex: Fix Sparse messages for undeclar

[PATCH v2 2/7] rtlwifi: btcoex: fix compiler warnings for unused functions

2017-05-26 Thread Larry Finger
From: Yan-Hsuan Chuang Delete unused is_wifi_status_changed for 21a 1 ant Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- v2 - no changes --- .../realtek/rtlwifi/btcoexist/halbtc8821a1ant.c| 33 --

[PATCH v2 1/7] rtlwifi: btcoex: update new btcoex version

2017-05-26 Thread Larry Finger
From: Yan-Hsuan Chuang This patch updates the btcoexist to a newer version with some callbacks. Specific issues fixed are pre_load_firmware() fix the unstable issues before FW is ready power_on_seting() fix the unstable issues before HW is ready Some notify finctions, check hardw

[PATCH v2 4/7] rtlwifi: btcoex: Remove duplicate test in if statement

2017-05-26 Thread Larry Finger
The kbuild test robot reported a duplicate test for value 101 in a complicated if statement. The extra test is removed. Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Ping-Ke Shih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting Cc: Julia Lawall Cc: kbuild test robot --- v2 - Moved origi

[PATCH v2 3/7] rtlwifi: btcoex: bind bt to the adapter when initialization

2017-05-26 Thread Larry Finger
From: Yan-Hsuan Chuang the bt need the information of the adapter, hook it on the callback for bt to operate and get properly initialized Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- v2 - no changes --- driver

[PATCH v2 7/7] rtlwifi: btcoex: Fix another edit mistake in 21a 1ant

2017-05-26 Thread Larry Finger
In routine btc8821a1ant_action_wifi_multi_port(), an edit that removed several lines was missed. Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Ping-Ke Shih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- v2 - no changes --- .../realtek/rtlwifi/btcoexist/halbtc8821a1ant.c| 27

[PATCH v2 5/7] rtlwifi: btcoex: Fix Sparse messages for undeclared symbols

2017-05-26 Thread Larry Finger
A number of functions can be set to static. Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Ping-Ke Shih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- v2 - no changes --- .../realtek/rtlwifi/btcoexist/halbtc8723b1ant.c| 1 + .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c|

[PATCH v2 6/7] rtlwifi: btcoex: Fix logic error in 21a 1ant

2017-05-26 Thread Larry Finger
An edit mistake introduced a logic error. Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Ping-Ke Shih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- v2 - no changes --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] Per chain RSSI reporting

2017-05-26 Thread Norik Dzhandzhapanyan
Add support for per chain RSSI reporting w/smoothing. Signed-off-by: Norik Dzhandzhapanyan nor...@ethertronics.com --- htt_rx.c.orig 2017-05-26 15:26:37.918504255 -0700 +++ htt_rx.c2017-05-26 12:10:33.139809025 -0700 @@ -825,14 +825,71 @@ static bool ath10k_htt_rx_h_channel(stru

[PATCH] mac80211: fix TX aggregation start/stop callback race

2017-05-26 Thread Johannes Berg
From: Johannes Berg When starting or stopping an aggregation session, one of the steps is that the driver calls back to mac80211 that the start/stop can proceed. This is handled by queueing up a fake SKB and processing it from the normal iface/sdata work. Since this isn't flushed when disassociat

Re: [PATCH] Per chain RSSI reporting

2017-05-26 Thread Adrian Chadd
[snip] hiya, I have something local that I've been meaning to push up to do this, but with no smoothing. Ideally (!) smoothing is done optionally in mac80211. What do you think about just committing the per-chain RSSI stuff to mac80211 so it shows up right now, and then we figure out how to expr

Re: [PATCH] Per chain RSSI reporting

2017-05-26 Thread Norik Dzhandzhapanyan
Hi Adrian, Inserting the smoothing function here is motivated by what we see as 'spikes' in rssi data under weak rssi conditions. Figured its best to get rid of the 'bogus' data as close to the source as possible. Also to minimize the impact on the changes. I believe the averaging that happe