Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 19:07:15 -0500 Larry Finger wrote: > On 05/31/2017 10:32 AM, Michael Büsch wrote: > > On Wed, 31 May 2017 13:26:43 +0300 > > Kalle Valo wrote: > > > >> Jia-Ju Bai writes: > >> > >>> The driver may sleep under a spin lock, and the function call path is: > >>> b43legacy_o

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Thu, 01 Jun 2017 07:27:20 +0300 Kalle Valo wrote: > Michael Büsch writes: > > >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c > >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c > >> > @@ -2859,7 +2859,9 @@ static void b43legacy_op_bss_info_changed(struct > >> > ieee80211_

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Kalle Valo
Michael Büsch writes: >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c >> > @@ -2859,7 +2859,9 @@ static void b43legacy_op_bss_info_changed(struct >> > ieee80211_hw *hw, >> >b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_MASK,

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Kalle Valo
Jia-Ju Bai writes: >> Did you actually observe the attempt to sleep under the spin lock, >> or did you discover this using some tool? In other words, have >> either of your patches been tested? > > In fact, my reported bugs are found by a static analysis tool written > by me, and they are checked

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Tobin C. Harding
On Thu, Jun 01, 2017 at 12:46:30PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Driver ks7010 does not currently have a maintainer. > > > > Add maintainers entry for ks7010. > > > > Signed-off-by: Tobin C. Harding > > --- > > MAINTAINERS | 7

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

2017-05-31 Thread Tobin C. Harding
On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > > Current driver implements the WEXT interface. WEXT is in maintenance > > mode, we need to re-write the driver using cfg80211. The current > > driver is handy as a referen

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Joe Perches
On Thu, 2017-06-01 at 12:46 +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Add maintainers entry for ks7010. [] > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -7429,6 +7429,13 @@ F: Documentation/auxdisplay/ks0108 > > F: drivers/auxdisplay/ks0

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Greg KH
On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > Driver ks7010 does not currently have a maintainer. > > Add maintainers entry for ks7010. > > Signed-off-by: Tobin C. Harding > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MA

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

2017-05-31 Thread Greg KH
On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > Current driver implements the WEXT interface. WEXT is in maintenance > mode, we need to re-write the driver using cfg80211. The current > driver is handy as a reference for the new implementation, we can keep > it in tree for now.

[RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL

2017-05-31 Thread Tobin C. Harding
Current ks7010 driver uses the WEXT interface. This series is the initial stage of re-writing the driver to use cfg80211. Patch set applies on Linus' mainline. 5ed02dbb497422bf225783f46e6eadd237d23d6b Linux 4.12-rc3 Throws 4 compiler warnings for functions defined and not used. As a first step

[RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Tobin C. Harding
Driver ks7010 does not currently have a maintainer. Add maintainers entry for ks7010. Signed-off-by: Tobin C. Harding --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e98464..75250ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7429,6

[RFC 2/3] staging: ks7010: add cfg80211 files

2017-05-31 Thread Tobin C. Harding
We are in the process of re-writing the current WEXT driver to use the cfg80211 configuration API. Currently driver root directory is empty. First step is to implement all the firmware interface in a single layer of abstraction, Firmware Interface Layer (FIL). We can add a skeleton implementation f

[PATCH] cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cw1200_tx_confirm_cb (acquire the lock by spin_lock) __cw1200_cqm_bssloss_sm cancel_work_sync --> may sleep cw1200_cqm_bssloss_sm __cw1200_cqm_bssloss_sm cancel_work_sync --> may sleep To fix it, the lock is releas

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Jia-Ju Bai
On 06/01/2017 08:07 AM, Larry Finger wrote: On 05/31/2017 10:32 AM, Michael Büsch wrote: On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: Jia-Ju Bai writes: The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by spin_lo

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Jia-Ju Bai
On 06/01/2017 01:33 AM, Larry Finger wrote: On 05/31/2017 05:29 AM, Jia-Ju Bai wrote: The driver may sleep under a spin lock, and the function call path is: b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) b43legacy_radio_set_interference_mitigation b43legacy_radio

Hello Dear Greetings from the Almighty God

2017-05-31 Thread elvir cerrato
Hello dear greetings to you from the almighty God , my name is Mrs Elvir Cerrato from Honduras i am 45 years old , i ma a dying woman who have decided to donate what i have to the churches , mosque , motherless homes , less privilege and the poor through you i was diagonsed for cancer two years a

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Larry Finger
On 05/31/2017 10:32 AM, Michael Büsch wrote: On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: Jia-Ju Bai writes: The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) b43legacy_synchronize_irq

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Adrian Chadd
On 31 May 2017 at 14:28, Arend van Spriel wrote: > On 31-05-17 22:23, Adrian Chadd wrote: >> On 31 May 2017 at 13:20, Arend van Spriel >> wrote: >>> On 31-05-17 14:16, Kalle Valo wrote: Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver deb

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Arend van Spriel
On 31-05-17 22:23, Adrian Chadd wrote: > On 31 May 2017 at 13:20, Arend van Spriel > wrote: >> On 31-05-17 14:16, Kalle Valo wrote: >>> Adrian Chadd writes: >>> This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * dri

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Adrian Chadd
On 31 May 2017 at 13:20, Arend van Spriel wrote: > On 31-05-17 14:16, Kalle Valo wrote: >> Adrian Chadd writes: >> >>> This adds a few configurable debugging options: >>> >>> * driver debugging and tracing is now configurable per device >>> * driver debugging and tracing is now configurable at ru

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Arend van Spriel
On 31-05-17 14:16, Kalle Valo wrote: > Adrian Chadd writes: > >> This adds a few configurable debugging options: >> >> * driver debugging and tracing is now configurable per device >> * driver debugging and tracing is now configurable at runtime >> * the debugging / tracing is not run at all (bes

Re: [RFT 0/3] brcmfmac: firmware loading rework

2017-05-31 Thread Arend van Spriel
On 31-05-17 14:45, Enric Balletbo Serra wrote: > 2017-05-31 14:00 GMT+02:00 Arend van Spriel : >> On 31-05-17 13:10, Enric Balletbo Serra wrote: >>> Hi Arend, >>> >>> 2017-05-30 14:35 GMT+02:00 Arend van Spriel : Hi Enric, Could you please try these patches and let me know if they re

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Arend van Spriel
On 31-05-17 18:31, Paul E. McKenney wrote: > On Wed, May 31, 2017 at 03:34:57PM +0200, Arnd Bergmann wrote: >> On Wed, May 31, 2017 at 3:12 PM, Paul E. McKenney >> wrote: >>> On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel

hi

2017-05-31 Thread griestkrist
-- Please contact me in the my e-mail addres,(griestkrist1...@gmail.com)

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Larry Finger
On 05/31/2017 05:29 AM, Jia-Ju Bai wrote: The driver may sleep under a spin lock, and the function call path is: b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) b43legacy_radio_set_interference_mitigation b43legacy_radio_interference_mitigation_disable b43le

Re: [PATCH 01/14] mwifiex: pcie: properly synchronize, disable interrupts in driver callbacks

2017-05-31 Thread Brian Norris
By the way, this had a few review comments elsewhere, which I'll summarize here, since I plan to resubmit a new version sometime. On Wed, May 24, 2017 at 05:11:06PM -0700, Brian Norris wrote: > It seems that the implicit assumption of the mwifiex > {enable,disable}_int() callbacks is that after ->

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Paul E. McKenney
On Wed, May 31, 2017 at 03:34:57PM +0200, Arnd Bergmann wrote: > On Wed, May 31, 2017 at 3:12 PM, Paul E. McKenney > wrote: > > On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: > >> On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel > >> wrote: > >> > On 5/30/2017 1:20 PM, Arnd Berg

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: > Jia-Ju Bai writes: > > > The driver may sleep under a spin lock, and the function call path is: > > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > > b43legacy_synchronize_irq > > synchronize_irq --> may sleep

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 18:29:07 +0800 Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) > b43legacy_radio_set_interference_mitigation > b43legacy_radio_interference_mitigation_dis

Re: [v4,1/5] mwifiex: use variable interface header length

2017-05-31 Thread Kalle Valo
Xinming Hu wrote: > From: Xinming Hu > > Usb tx aggregation feature will utilize 4-bytes bus interface header, > otherwise it will be set to zero in default case. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo > Signed-off-by: Ganapathi Bhat 5 patches applied to wireless-drivers-

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-31 Thread Ben Greear
On 05/31/2017 01:18 AM, Bastian Bittorf wrote: * Johannes Berg [31.05.2017 10:09]: Is there any way to dump out the socket information if we reproduce the problem? I have no idea, sorry. If you or Bastian can tell me how to reproduce the problem, I can try to investigate it. there was an

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Arnd Bergmann
On Wed, May 31, 2017 at 3:12 PM, Paul E. McKenney wrote: > On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: >> On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel >> wrote: >> > On 5/30/2017 1:20 PM, Arnd Bergmann wrote: >> >> >> >> An unknown change in the kernel headers caused a bu

[PATCH] linux-firmware: add firmware image for Redpine 9113 chipset

2017-05-31 Thread Amitkumar Karwar
This image will be loaded by rsi driver. Firmware version is 1.5.3 Signed-off-by: Amitkumar Karwar --- WHENCE | 3 +++ rsi/rs9113_wlan_qspi.rps | Bin 0 -> 199180 bytes 2 files changed, 3 insertions(+) create mode 100644 rsi/rs9113_wlan_qspi.rps diff --git a/WHENCE b/WHENCE

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Paul E. McKenney
On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: > On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel > wrote: > > On 5/30/2017 1:20 PM, Arnd Bergmann wrote: > >> > >> An unknown change in the kernel headers caused a build regression > >> in an MTD partition driver: > >> > >> In file

Re: [PATCH] Per chain RSSI reporting

2017-05-31 Thread Kalle Valo
Norik Dzhandzhapanyan writes: > Inserting the smoothing function here is motivated by what we see as > 'spikes' in rssi data under weak rssi conditions. Figured its best to > get rid of the 'bogus' data as close to the source as possible. Also > to minimize the impact on the changes. > > I believ

Re: [PATCH] Per chain RSSI reporting

2017-05-31 Thread Kalle Valo
Adrian Chadd writes: > I have something local that I've been meaning to push up to do this, > but with no smoothing. Ideally (!) smoothing is done optionally in > mac80211. > > What do you think about just committing the per-chain RSSI stuff to > mac80211 so it shows up right now, and then we fig

Re: [PATCH] Per chain RSSI reporting

2017-05-31 Thread Kalle Valo
Norik Dzhandzhapanyan writes: > Add support for per chain RSSI reporting w/smoothing. > > Signed-off-by: Norik Dzhandzhapanyan nor...@ethertronics.com > > > --- htt_rx.c.orig 2017-05-26 15:26:37.918504255 -0700 > +++ htt_rx.c2017-05-26 12:10:33.139809025 -0700 > @@ -825,14 +825,71 @@ sta

Re: [RFT 0/3] brcmfmac: firmware loading rework

2017-05-31 Thread Enric Balletbo Serra
2017-05-31 14:00 GMT+02:00 Arend van Spriel : > On 31-05-17 13:10, Enric Balletbo Serra wrote: >> Hi Arend, >> >> 2017-05-30 14:35 GMT+02:00 Arend van Spriel : >>> Hi Enric, >>> >>> Could you please try these patches and let me know if they resolve >>> the issue for you. >>> >>> Regards, >>> Arend

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) > unless the specific deb

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Arend van Spriel
On 31-05-17 12:26, Kalle Valo wrote: > Jia-Ju Bai writes: > >> The driver may sleep under a spin lock, and the function call path is: >> b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) >> b43legacy_synchronize_irq >> synchronize_irq --> may sleep >> >> To fix it, the l

Re: [RFT 0/3] brcmfmac: firmware loading rework

2017-05-31 Thread Arend van Spriel
On 31-05-17 13:10, Enric Balletbo Serra wrote: > Hi Arend, > > 2017-05-30 14:35 GMT+02:00 Arend van Spriel : >> Hi Enric, >> >> Could you please try these patches and let me know if they resolve >> the issue for you. >> >> Regards, >> Arend >> >> Arend van Spriel (3): >> brcmfmac: add parameter

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device So this means that there's a debugfs file /sys/kernel/debug/ieee80211/phy0/ath10k/debug for every ath10k device. Sounds like a good idea. I just don't like the

Re: [RFT 1/3] brcmfmac: add parameter to pass error code in firmware callback

2017-05-31 Thread Enric Balletbo Serra
2017-05-30 14:35 GMT+02:00 Arend van Spriel : > Extend the parameters in the firmware callback so it can be called > upon success and failure. This allows the caller to properly clear > all resources in the failure path. Right now the error code is > always zero, ie. success. > > Reviewed-by: Hante

Re: go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-31 Thread Kalle Valo
Adrian Chadd wrote: > This reverts commit b057886524be ("ath10k: do not use coherent memory for > allocated device memory chunks") in 2015 which converted this allocation from > dma_map_coherent() to kzalloc() / dma_map_single(). > > The current problem manifests when using later model NICs with

Re: [RFT 3/3] brcmfmac: unbind all devices upon failure in firmware callback

2017-05-31 Thread Enric Balletbo Serra
2017-05-30 14:35 GMT+02:00 Arend van Spriel : > In brcmf_sdio_firmware_callback() we need to unbind the driver from > both sdio_func devices. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Franky Lin > Signed-off-by: Arend van Spriel > --- > drivers/net/wir

Re: [RFT 0/3] brcmfmac: firmware loading rework

2017-05-31 Thread Enric Balletbo Serra
Hi Arend, 2017-05-30 14:35 GMT+02:00 Arend van Spriel : > Hi Enric, > > Could you please try these patches and let me know if they resolve > the issue for you. > > Regards, > Arend > > Arend van Spriel (3): > brcmfmac: add parameter to pass error code in firmware callback > brcmfmac: use firmw

[PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) b43legacy_radio_set_interference_mitigation b43legacy_radio_interference_mitigation_disable b43legacy_calc_nrssi_slope b43legacy_synth_p

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Kalle Valo
Jia-Ju Bai writes: > The driver may sleep under a spin lock, and the function call path is: > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > b43legacy_synchronize_irq > synchronize_irq --> may sleep > > To fix it, the lock is released before b43legacy_synchronize_ir

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Arnd Bergmann
On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel wrote: > On 5/30/2017 1:20 PM, Arnd Bergmann wrote: >> >> An unknown change in the kernel headers caused a build regression >> in an MTD partition driver: >> >> In file included from drivers/mtd/bcm47xxpart.c:12:0: >> include/linux/bcm47xx_nvram.h

[PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) b43legacy_synchronize_irq synchronize_irq --> may sleep To fix it, the lock is released before b43legacy_synchronize_irq, and the lock is acquired aga

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Arend van Spriel
On 5/30/2017 1:20 PM, Arnd Bergmann wrote: An unknown change in the kernel headers caused a build regression in an MTD partition driver: In file included from drivers/mtd/bcm47xxpart.c:12:0: include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem': include/linux/bcm47xx_nvram.h:2

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Boris Brezillon
On Tue, 30 May 2017 13:20:12 +0200 Arnd Bergmann wrote: > An unknown change in the kernel headers caused a build regression > in an MTD partition driver: > > In file included from drivers/mtd/bcm47xxpart.c:12:0: > include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem': > includ

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-31 Thread Bastian Bittorf
* Johannes Berg [31.05.2017 10:09]: > > Is there any way to dump out the socket information if we reproduce > > the problem? > > I have no idea, sorry. > > If you or Bastian can tell me how to reproduce the problem, I can try > to investigate it. there was an interesting fix regarding the shell