[PATCH] ipw2100: don't return positive values to PCI probe on error

2017-07-12 Thread Dan Williams
Causes the PCI stack to complain, and then eventually call the PCI remove function, which ipw2100 is not expecting. It then tries to unregister an already-released netdev and other nasty things, leading to a panic. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1185518 Signed-off-by: Dan Wil

Re: [PATCH V2] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-12 Thread David Miller
From: Arend van Spriel Date: Wed, 12 Jul 2017 13:49:23 +0200 > On 7/7/2017 10:09 PM, Arend van Spriel wrote: >> The lower level nl80211 code in cfg80211 ensures that "len" is between >> 25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HDR_LEN (24) >> from >> "len" so thats's max of 2280.

Re: [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()

2017-07-12 Thread Arend van Spriel
On 12-07-17 16:29, Bob Copeland wrote: > On Wed, Jul 12, 2017 at 10:32:48AM +0100, Arend van Spriel wrote: >> Recent change in brcmf_sdio_txpkt_hdalign() changed the >> behavior and now always returns 0. This resulted in a >> regression which basically renders the device useless. > > Should this g

Re: [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()

2017-07-12 Thread Bob Copeland
On Wed, Jul 12, 2017 at 10:32:48AM +0100, Arend van Spriel wrote: > Recent change in brcmf_sdio_txpkt_hdalign() changed the > behavior and now always returns 0. This resulted in a > regression which basically renders the device useless. Should this go via netdev as well, or just wait for Kalle (re

Re: [PATCH V2] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-12 Thread Arend van Spriel
On 7/7/2017 10:09 PM, Arend van Spriel wrote: The lower level nl80211 code in cfg80211 ensures that "len" is between 25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HDR_LEN (24) from "len" so thats's max of 2280. However, the action_frame->data[] buffer is only BRCMF_FIL_ACTION_FRAME_S

[PATCH] ath9k: fix debugfs file permission

2017-07-12 Thread Christoph Fritz
This patch fixes a trivial debugfs file permission issue. Debugfs file ack_to has no write function, so S_IWUSR gets purged. Signed-off-by: Christoph Fritz --- drivers/net/wireless/ath/ath9k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9

Re: [PATCH] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-12 Thread Sedat Dilek
On Fri, Jul 7, 2017 at 9:39 PM, Arend van Spriel wrote: > On 07-07-17 14:47, Sedat Dilek wrote: >> On Fri, Jul 7, 2017 at 2:01 PM, Arend van Spriel >> wrote: >>> The lower level nl80211 code in cfg80211 ensures that "len" is between >>> 25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HD

[PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()

2017-07-12 Thread Arend van Spriel
Recent change in brcmf_sdio_txpkt_hdalign() changed the behavior and now always returns 0. This resulted in a regression which basically renders the device useless. Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()") Reported-by: S. Gilles Tested-by: S. Gilles Signed-off-by:

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

2017-07-12 Thread Joe Perches
On Wed, 2017-07-12 at 08:12 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 12, 2017 at 10:23:02AM +0800, Rui Teng wrote: > > On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote: > > > On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: > > > > This patch sets memory to zero directly to avoid unne

[PATCH] iwlwifi: pcie: Fix error code in iwl_trans_pcie_alloc()

2017-07-12 Thread Dan Carpenter
We accidentally forgot to propogate the error code on this path. It means we return ERR_PTR(0) which is NULL and it results in a NULL dereference in the caller. Fixes: 2e5d4a8f61dc ("iwlwifi: pcie: Add new configuration to enable MSIX") Signed-off-by: Dan Carpenter diff --git a/drivers/net/wire

Re: [PATCH] rt2x00: make const array glrt_table static

2017-07-12 Thread Colin Ian King
On 12/07/17 07:49, Stanislaw Gruszka wrote: > On Tue, Jul 11, 2017 at 12:47:33PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Don't populate array glrt_table on the stack but make it static. >> Makes the object code a smaller by over 670 bytes: >> >> Before: >>text data b