Re: [PATCH] qtnfmac: pcie datapath optimizations and cleanups

2017-08-16 Thread Igor Mitsyanko
On 08/15/2017 06:06 AM, Sergey Matyukevich wrote: Hello Kalle and all, This patchset implements several optimizations and cleanups for pcie datapath in qtnfmac driver. Major changes include: - switch to kernel circ_buf implementation - modify tx reclaim locking - introduce counter for rx underfl

Re: [2/6] ath10k: refactor firmware crashdump code to coredump.c

2017-08-16 Thread Kalle Valo
Kalle Valo writes: > Kalle Valo wrote: > >> In preparation to add RAM dump support. No functional changes, only moving >> code >> and renaming function names. >> >> Signed-off-by: Kalle Valo > > With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a > build error: > > driv

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread Jay Vosburgh
Dan Williams wrote: [...] >You'll probably say "aim for the 75% case" or something like that, >which is fine, but then you're depending on your 75% case to be (a) >single AP, (b) never move (eg, only bond wifi + ethernet), (c) little >radio interference. I'm not sure I'd buy that. If I've put wo

Re: [2/6] ath10k: refactor firmware crashdump code to coredump.c

2017-08-16 Thread Kalle Valo
Kalle Valo wrote: > In preparation to add RAM dump support. No functional changes, only moving > code > and renaming function names. > > Signed-off-by: Kalle Valo With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a build error: drivers/net/wireless/ath/ath10k/coredump.

[mac80211] Mesh Remove VHT Capability IE and Remove OFDM in Supported Rates IE Question

2017-08-16 Thread Rock Chen
Hi Sirs, In mesh, beacon IE contents are generated in mac80211. If hardware reports VHT capable, then it seems there's no way to disable VHT Capability IE in some cases, for example vht_disable=1 in wpa_supplicant. On the other hand, if ht_disable=1 in wpa_supplicant, then both HT Capability and V

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread Ben Greear
On 08/16/2017 08:18 PM, Dan Williams wrote: On Wed, 2017-08-16 at 19:36 -0700, Ben Greear wrote: On 08/16/2017 07:11 PM, Dan Williams wrote: On Wed, 2017-08-16 at 14:31 -0700, David Miller wrote: From: Dan Williams Date: Wed, 16 Aug 2017 16:22:41 -0500 My biggest suggestion is that perhaps

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread Dan Williams
On Wed, 2017-08-16 at 19:36 -0700, Ben Greear wrote: > On 08/16/2017 07:11 PM, Dan Williams wrote: > > On Wed, 2017-08-16 at 14:31 -0700, David Miller wrote: > > > From: Dan Williams > > > Date: Wed, 16 Aug 2017 16:22:41 -0500 > > > > > > > My biggest suggestion is that perhaps bonding should gro

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread David Miller
From: Dan Williams Date: Wed, 16 Aug 2017 21:11:47 -0500 > You'll probably say "aim for the 75% case" or something like that, > which is fine, but then you're depending on your 75% case to be (a) > single AP, (b) never move (eg, only bond wifi + ethernet), (c) little > radio interference. I'm no

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread Ben Greear
On 08/16/2017 07:11 PM, Dan Williams wrote: On Wed, 2017-08-16 at 14:31 -0700, David Miller wrote: From: Dan Williams Date: Wed, 16 Aug 2017 16:22:41 -0500 My biggest suggestion is that perhaps bonding should grow hysteresis for link speeds. Since WiFi can change speed every packet, you pr

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread Dan Williams
On Wed, 2017-08-16 at 14:31 -0700, David Miller wrote: > From: Dan Williams > Date: Wed, 16 Aug 2017 16:22:41 -0500 > > > My biggest suggestion is that perhaps bonding should grow > hysteresis > > for link speeds. Since WiFi can change speed every packet, you > probably > > don't want the bond ch

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

2017-08-16 Thread Marc MERLIN
On Sat, Jun 03, 2017 at 09:59:50AM -0700, Marc MERLIN wrote: > On Fri, Jun 02, 2017 at 12:42:55PM +0300, Luca Coelho wrote: > > I kernel v4.9, we stopped supporting firmware versions smaller than 22 > > for the 8260. But unfortunately I made a mistake in the patch[1] when I > > removed support for

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread David Miller
From: Dan Williams Date: Wed, 16 Aug 2017 16:22:41 -0500 > My biggest suggestion is that perhaps bonding should grow hysteresis > for link speeds. Since WiFi can change speed every packet, you probably > don't want the bond characteristics changing every couple seconds just > in case your WiFi li

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread Dan Williams
On Wed, 2017-08-16 at 14:44 -0600, James Feeney wrote: > On 08/13/2017 11:42 AM, Andreas Born wrote: > > On a side note I would recommend some of my own reading to you > > about > > patch submission in general [1] and on netdev specifically [2]. > > Mmm - [2] and [3], I suspect.  Thanks Andreas.  

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread David Miller
From: James Feeney Date: Wed, 16 Aug 2017 14:44:27 -0600 > On 08/13/2017 11:42 AM, Andreas Born wrote: >> On a side note I would recommend some of my own reading to you about >> patch submission in general [1] and on netdev specifically [2]. > > Mmm - [2] and [3], I suspect. Thanks Andreas. I'

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-16 Thread James Feeney
On 08/13/2017 11:42 AM, Andreas Born wrote: > On a side note I would recommend some of my own reading to you about > patch submission in general [1] and on netdev specifically [2]. Mmm - [2] and [3], I suspect. Thanks Andreas. I'll be studying those. Yeah, I'm still learning what is needed and

Re: [PATCH] qtnfmac: pcie datapath optimizations and cleanups

2017-08-16 Thread Kalle Valo
Sergey Matyukevich writes: >> I don't see patch 9 in the mailing list. Did it get lost somewhere? > > No, this is my fault. The last patch was sort of experimental shuffling > dma memory barriers. I kept it for testing, but forgot to remove it > before sending. Let me know if it matters, then I w

Re: [PATCH] qtnfmac: pcie datapath optimizations and cleanups

2017-08-16 Thread Sergey Matyukevich
> I don't see patch 9 in the mailing list. Did it get lost somewhere? No, this is my fault. The last patch was sort of experimental shuffling dma memory barriers. I kept it for testing, but forgot to remove it before sending. Let me know if it matters, then I will resend a properly numbered patchs

Re: [PATCH 2/9] qtnfmac: switch to napi_gro_receive

2017-08-16 Thread Sergey Matyukevich
> >> Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. > > > > Yes, I can easily see that from the diff so no need to document that :) > > But the commit log should tell _why_ you did it. > > And no need to resend because of this, I can improve the commit log > during commi

Re: [PATCH 2/9] qtnfmac: switch to napi_gro_receive

2017-08-16 Thread Kalle Valo
Kalle Valo writes: > Sergey Matyukevich writes: > >> Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. > > Yes, I can easily see that from the diff so no need to document that :) > But the commit log should tell _why_ you did it. And no need to resend because of this, I

Re: [PATCH 2/9] qtnfmac: switch to napi_gro_receive

2017-08-16 Thread Kalle Valo
Sergey Matyukevich writes: > Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. Yes, I can easily see that from the diff so no need to document that :) But the commit log should tell _why_ you did it. -- Kalle Valo

Re: [PATCH] qtnfmac: pcie datapath optimizations and cleanups

2017-08-16 Thread Kalle Valo
Sergey Matyukevich writes: > Hello Kalle and all, > > This patchset implements several optimizations and cleanups for > pcie datapath in qtnfmac driver. Major changes include: > - switch to kernel circ_buf implementation > - modify tx reclaim locking > - introduce counter for rx underflow events

Re: [PATCH v2 2/2] rtlwifi: btcoex: Use seq_file to dump btcoex status

2017-08-16 Thread Kalle Valo
Larry Finger writes: > From: Ping-Ke Shih > > We use seq_file to replace RT_TRACE to dump status, then we can use 'cat' > to access btcoex's status through debugfs. > (i.e. /sys/kernel/debug/rtlwifi/00-11-22-33-44-55-66/btcoex) > Other related changes are > 1. implement btc_disp_dbg_msg() to acc

Re: [PATCH v2 1/2] rtlwifi: use debugfs to debug.

2017-08-16 Thread Kalle Valo
Larry Finger writes: > From: Ping-Ke Shih > > Use debugfs to dump register and btcoex status. > > We create topdir in /sys/kernel/debug/rtlwifi/, and use the MAC address > as subdirectory with several entries to dump mac_reg, bb_reg, rf_reg etc. > An example is > /sys/kernel/debug/rtlwifi/00

Re: [PATCH] brcmfmac: add CLM download support

2017-08-16 Thread Kalle Valo
Wright Feng writes: > From: Chung-Hsien Hsu > > The firmware for brcmfmac devices includes information regarding > regulatory constraints. For certain devices this information is kept > separately in a binary form that needs to be downloaded to the device. > This patch adds support to download t

Re: [v7 wlcore: add missing nvs file name info for wilink8

2017-08-16 Thread Kalle Valo
"Reizer, Eyal" writes: >> > + if (wl->fuse_oui_addr == 0 && wl->fuse_nic_addr == 0) { >> > + wl1271_warning("Fuse mac address is zero. using " >> > + "random mac\n"); >> >> This one should also go into one line. > > This will still excee

[v2 09/11] rsi: update tx auto rate command frame for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Auto rate frame is sent to firmware when a new station is connected. Station id and station's ht capabilities are updated in auto rate command frame. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mgmt.

[v2 11/11] rsi: security enhancements for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Station id should be set in load key frame configured to device. For WEP mode, key is configured once from mac80211. This key is saved and configured to device every time a station is connected. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/r

[v2 08/11] rsi: use common descriptor for auto rate frame

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi TX command frame auto rate request is modified to use common descriptor struture. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 18 +++--- drivers/net/wireless/rsi/rsi_mgmt.h |

[v2 10/11] rsi: aggregation parameters frame for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi TX command frame ampdu aggregation parameters is updated to include sta_id for AP mode. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 43 +++-- drivers/net/wireless

[v2 07/11] rsi: data and managemet path changes for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Station id needs to be get for data and management frames to fill in the descruptor for AP mode. Few other changes related to AP mode are covered here. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_cor

[v2 04/11] rsi: add beacon changes for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Mac80211 config parameter BEACON_ENABLE is handled. When VAP capabilities frame with AP mode is configured to firmware, beacon events start coming to host at each PreTBTT. At this time, beacon is taken from mac80211, descriptor is prepared and send to firmware. Sign

[v2 06/11] rsi: handle station disconnection in AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi When sta_remove of mac80211 is called, driver iterates through list of existing stations to get the station id. Then peer notify is prepared and send to firmare. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/r

[v2 05/11] rsi: handle station connection in AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Station structures are maintained in driver with required fields. When mac80211 callback sta_add is called, driver iterates through list of connected stations to check available index and assigns station id which is important for further communication to that station

[v2 03/11] rsi: remove interface changes for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi remove_interface callback of mac80211 is handled for AP mode. Same is notified to firmware through vap_capabilities frame with VAP status VAP_DELETE. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mac80

[v2 02/11] rsi: add interface changes for ap mode

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi AP mode is handled in add_interface callback of mac80211. Also for AP mode, sending rx filter frame to disallow beacons to host is added. Station structures are initialized to NULL. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- driver

[v2 00/11] rsi: support for AP mode

2017-08-16 Thread Amitkumar Karwar
From: Amitkumar Karwar This patchset contains enhancements for AP mode operation. Major changes are maintaining the station structures in driver and adding station id parameter to the Tx packets whenever required. Tests are performed to confirm aggregation, connections in WEP and WPA/WPA2 securit

[v2 01/11] rsi: advertise ap mode support

2017-08-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi AP mode support is advertised to cfg80211. Necessary wiphy parameters are initialized. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 28 +++- drivers/net/wireless/r

RE: [v7 wlcore: add missing nvs file name info for wilink8

2017-08-16 Thread Reizer, Eyal
> > > > + if (oui_addr == 0xdeadbe && nic_addr == 0xef) { > > + wl1271_warning("Detected unconfigured mac address in > nvs.\n" > > + "derive from fuse instead.\n" > > + "in case of using a wl12xx device, your " > > +