[PATCH 12/27] qtnfmac: let wifi card handle channel switch request to the same chan

From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index 501ece3..062189b 100644 -

[PATCH 15/27] qtnfmac: remove unused mac::status field

From: Igor Mitsyanko It is no longer used. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 1 - drivers/net/wireless/quantenna/qtnfmac/core.h | 5 - drivers/net/wireless/quantenna/qtnfmac/event.c| 2 -- 3 files changed, 8 deletions(-) diff --g

[PATCH 06/27] qtnfmac: pass full channel definition to device on start_ap command

From: Igor Mitsyanko Introduce chandef TLV and pass it to wireless card on start_ap command processing. No need to cache chandef in driver private structure as it is not used anywhere. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 9 -- drivers/net

[PATCH 07/27] qtnfmac: get rid of QTNF_STATE_AP_CONFIG

From: Igor Mitsyanko QTNF_STATE_AP_CONFIG is redundant and has no real meaning. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 8 drivers/net/wireless/quantenna/qtnfmac/commands.c | 3 --- drivers/net/wireless/quantenna/qtnfmac/core.h | 1 -

[PATCH 17/27] qtnfmac: do not report channel changes until wiphy is registered

From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/quantenna/qtnfmac/event.c b/drivers/net/wireless/quantenna/qtnfmac/event.c index 9befc9f..b2f6410 100644 --- a/drive

[PATCH 11/27] qtnfmac: make encryption info a part of "connect" command.

From: Igor Mitsyanko Encryption info is a constant part of STA settings, no point to pass it as an optional TLV. Remove QTN_TLV_ID_CRYPTO type as it's not used anymore. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 42 ++- drivers/net

[PATCH 16/27] qtnfmac: stop using private driver info about current channel

From: Igor Mitsyanko Linux Wireless device structure already has required info. Since driver's info is not used anymore, remove it. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 7 ++- drivers/net/wireless/quantenna/qtnfmac/core.h | 1 - drivers/

[PATCH 20/27] qtnfmac: get rid of PHYMODE capabilities flags

From: Igor Mitsyanko Supported WiFi operation modes are now identified per-band based on HT/VHT capabilities of each band. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 3 --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 1 - drivers/net/wireles

[PATCH 13/27] qtnfmac: pass VIF info to SendChannel command

From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +- drivers/net/wireless/quantenna/qtnfmac/commands.c | 5 +++-- drivers/net/wireless/quantenna/qtnfmac/commands.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/

[PATCH 26/27] qtnfmac: include HTCAP and VHTCAP into config AP command

From: Igor Mitsyanko Include HT/VHT caps directly into command so that they won't have to be searched for in IEs. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/wireless/qua

[PATCH 18/27] qtnfmac: use per-band HT/VHT info from wireless device

From: Igor Mitsyanko HT/VHT capabilities must be reported per each band supported on a radio, not for all bands on a radio. Furthermore, driver better not assume any capabilities and just use whetever is reported by device itself. To support this, convert "get channels" command into "get band in

[PATCH 24/27] qtnfmac: configure and start AP interface with a single command

From: Igor Mitsyanko Current logic artificially divides "start AP" procedure into three stages: - generic interface configuration (security, channel etc) - IE's processing - enable AP mode on interface This separation would not allow to do a proper device configuration as first stage needs to us

[PATCH 09/27] qtnfmac: do not cache BSS state in per-VIF structure

From: Igor Mitsyanko This cached state is unused, except for BSSID that we will keep. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 39 -- drivers/net/wireless/quantenna/qtnfmac/commands.c | 49 +++ drivers/net/wireles

[PATCH 22/27] qtnfmac: SCAN results: retreive frame type information from "IE set" TLV

From: Igor Mitsyanko "IE set" TLV carries the same information as qlink_event_scan_result::frame_type. Convert the event to make use of TLV and drop frame_type member. While at it, make qlink_event_scan_result structure alignement-safe. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/qu

[PATCH 25/27] nl80211: look for HT/VHT capabilities in beacon's tail

From: Igor Mitsyanko There are no HT/VHT capabilities in cfg80211_ap_settings::beacon_ies, these should be looked for in beacon's tail instead. Signed-off-by: Igor Mitsyanko --- net/wireless/nl80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.

[PATCH 19/27] qtnfmac: initialize HT/VHT caps "can override" masks

From: Igor Mitsyanko Information on which HT/VHT capabilities can be overridden is reported per-MAC by wireless device. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 ++ drivers/net/wireless/quantenna/qtnfmac/commands.c | 7 --- drivers/net/wireles

[PATCH 23/27] qtnfmac: convert "Append IEs" command to QTN_TLV_ID_IE_SET usage

From: Igor Mitsyanko Data contained within "Append IEs" command (QLINK_CMD_MGMT_SET_APPIE) duplicates QTN_TLV_ID_IE_SET TLV. Conver the command to use that TLV instead. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 12 ++-- drivers/net/wireless/q

[PATCH 21/27] qtnfmac: extend "IE set" TLV to include frame type info

From: Igor Mitsyanko Specifying frame type for "IE set" TLV will allow to use several TLVs in a single message. Modify users accordingly. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 25 +++--- drivers/net/wireless/quantenna/qtnfmac/event.c| 58

[PATCH 14/27] qtnfmac: do not cache CSA chandef info

From: Igor Mitsyanko It is never used for anything useful, and all logic is handled by either WiFi card or higher layers. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 12 drivers/net/wireless/quantenna/qtnfmac/commands.c | 2 -- drivers/ne

[PATCH 27/27] qtnfmac: pass all CONNECT cmd params to wireless card for processing

From: Igor Mitsyanko Specifically, following parameters are needed for wireless device configuration but were not available to it before: - HT/VHT capabilities and capabilities masks. - full channel info (not just IEEE number) - BSSID hint - previous BSSID for reassoc request Move Management Fra

[PATCH 10/27] qtnfmac: do not cache channel info from "connect" command

From: Igor Mitsyanko This makes no sense because real operational channel is choosen based on AP operation, not on what STA is configured to. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 14 -- drivers/net/wireless/quantenna/qtnfmac/commands

[PATCH 08/27] qtnfmac: get rid of QTNF_STATE_AP_START usage

From: Igor Mitsyanko QTNF_STATE_AP_START usage is redundant and imposes additional state synchronization maintenance. We may as well leave state checking up to network card and upper layers (cfg80211, nl80211 and userspace). Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnf

[PATCH 03/27] qtnfmac: retreive current channel info from EP

From: Igor Mitsyanko Do not try to cache current operational channel info in driver, this is a potential source of synchronization issues + driver does not really need that info. Introduce GET_CHANNEL command and process it appropriately. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless

[PATCH 04/27] qtnfmac: do not cache AP settings in driver structures

From: Igor Mitsyanko Cached AP setings are passed to WiFi card right away and never used. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 17 + drivers/net/wireless/quantenna/qtnfmac/commands.c | 46 +++ drivers/net/wireless/qua

[PATCH 01/27] qtnfmac: qlink: convert channel width from bitfiled to simple enum

From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/qlink.h | 16 drivers/net/wireless/quantenna/qtnfmac/qlink_util.c | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/quan

[PATCH 05/27] qtnfmac: pass all AP settings to wireless card for processing

From: Igor Mitsyanko "struct cfg80211_ap_settings" provides more information for AP mode configuration that is currently being passed on to network card for processing. Modify QLINK command to pass all AP settings. Make most of settings a constant part of "config AP" command instead of passing it

[PATCH 02/27] qtnfmac: make "Channel change" event report full channel info

From: Igor Mitsyanko Specifically, it has to report center frequency, secondary center frequency (for 80+80) and BW. Introduce channel definition structure to qlink and modify channel change event processing function accordingly. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna

[PATCH 00/27] qtnfmac: allow to configure channel, BW, HT/VHT caps

From: Igor Mitsyanko This patchset has a goal to make operational parameters (channel, BW, HT/VHT capabilities) configuration possible for qtnfmac driver. Basically the idea is to make driver level as thin as possible, and let everything to be handled by userspace/nl80211 and wireless device itse

[PATCH] cfg80211: Use tabs for identation

Removed whitespaces and added necessary tabs conforming to coding style. Issue found using checkpatch.pl Signed-off-by: Himanshu Jha --- net/wireless/chan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/chan.c b/net/wireless/chan.c index b8aa5a7..13c95e5

[PATCH] ath10k: activate user space firmware loading again

In commit 9f5bcfe93315 ("ath10k: silence firmware file probing warnings") the firmware loading was changed from request_firmware() to request_firmware_direct() to silence some warnings in case it fails. request_firmware_direct() directly searches in the file system only and does not send a hotplug

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

On Thu, 2017-08-24 at 21:56 +0200, Jiri Kosina wrote: > On Thu, 24 Aug 2017, Luca Coelho wrote: > > > > Work queues cannot be allocated when a mutex is held because the mutex > > > may be in use and that would make it sleep. Doing so generates the > > > following splat with 4.13+: > > > > > > [

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

On Thu, 24 Aug 2017, Luca Coelho wrote: > > Work queues cannot be allocated when a mutex is held because the mutex > > may be in use and that would make it sleep. Doing so generates the > > following splat with 4.13+: > > > > [ 19.513298] ==

Re: [PATCH] staging: rtlwifi: check for array overflow

On 08/24/2017 05:08 AM, Dan Carpenter wrote: Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? Anyway, I looked at other drivers and they added a bounds check and it seems like a harmless thing to have so I have added it her

Re: [PATCH] wireless-regdb: Update regulatory rules for Singapore (SG)

On Thu, Aug 24, 2017 at 09:13:42AM +0200, Sven Eckelmann wrote: > On Mittwoch, 23. August 2017 15:52:40 CEST Seth Forshee wrote: > [...] > > > +# Source > > > +# > > > https://www.imda.gov.sg/~/media/imda/files/regulation%20licensing%20and%20consultations/ict%20standards/telecommunication%20standa

Re: Two rtlwifi drivers?

On 08/24/2017 07:14 AM, Kalle Valo wrote: Dan Carpenter writes: Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? Anyway, I looked at other drivers and they added a bounds check and it seems like a harmless thing to have

Re: ath10k: fix napi_poll budget overflow

On 08/24/2017 02:07 AM, Kalle Valo wrote: > ryan...@qti.qualcomm.com wrote: > >> From: Ryan Hsu >> >> In napi_poll, the budget number is used to control the amount of packets >> we should handle per poll to balance the resource in the system. >> >> In the list of the amsdu packets reception, we c

Re: [v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

Luciano Coelho wrote: > From: Luca Coelho > > Work queues cannot be allocated when a mutex is held because the mutex > may be in use and that would make it sleep. Doing so generates the > following splat with 4.13+: > > [ 19.513298] == > [

Two rtlwifi drivers?

Dan Carpenter writes: > Smatch is distrustful of the "capab" value and marks it as user > controlled. I think it actually comes from the firmware? Anyway, I > looked at other drivers and they added a bounds check and it seems like > a harmless thing to have so I have added it here as well. > >

[PATCH] staging: rtlwifi: check for array overflow

Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? Anyway, I looked at other drivers and they added a bounds check and it seems like a harmless thing to have so I have added it here as well. Signed-off-by: Dan Carpenter diff

Re: wireless: ipw2x00: make iw_handler_def const

Bhumika Goyal wrote: > Make these const as they are only stored in the const field of a > net_device structure. > > Signed-off-by: Bhumika Goyal Patch applied to wireless-drivers-next.git, thanks. 2c1dca3c6b22 wireless: ipw2x00: make iw_handler_def const -- https://patchwork.kernel.org/patc

Re: [1/3] net: rtlwifi: constify rate_control_ops

Arvind Yadav wrote: > rate_control_ops are not supposed to change at runtime. All functions > working with rate_control_ops provided by work with > const rate_control_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav 2 patches applied to wireless-drivers-next.git, t

Re: [RESEND,v12,7/8] wireless: ipw2200: Replace PCI pool old API

Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Reviewed-by: Peter Senna Tschudin > Acked-by: Stanislav Yakovlev Patch applied to wireless-drivers-next.git

Re: rtlwifi: rtl8821ae: fix spelling mistake: "faill" -> "failed"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 2cc8918eb987 rtlwifi: rtl8821ae: fix spelling mistake: "faill" -> "failed" -- https://patchwork.kernel

Re: [v2] mt7601u: check memory allocation failure

Christophe Jaillet wrote: > Check memory allocation failure and return -ENOMEM in such a case, as > already done a few lines below. > > As 'dev->tx_q' can be NULL, we also need to check for that in > 'mt7601u_free_tx()', and return early. > > Signed-off-by: Christophe JAILLET > Acked-by: Jakub

Re: rtlwifi: make a couple arrays larger

Dan Carpenter wrote: > This is a static checker fix. "cal_num" is 10. We're declaring the > tx_dt[] and rx_td[] arrays as 3 element arrays. The static checker > complains that we do: > > tx_dt[cal] = (vdf_y[1]>>20)-(vdf_y[0]>>20); > > "cal" is the iterator and it is in the 0-9 range so

Re: rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

"Gustavo A. R. Silva" wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1415177 > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. 14cc696c0

Re: [v9] wlcore: add missing nvs file name info for wilink8

"Reizer, Eyal" wrote: > The following commits: > commit c815fdebef44 ("wlcore: spi: Populate config firmware data") > commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") > > Populated the nvs entry for wilink6 and wilink7 only while it is > still needed for wilink8 as well. > Thi

Re: ath10k: fix napi_poll budget overflow

ryan...@qti.qualcomm.com wrote: > From: Ryan Hsu > > In napi_poll, the budget number is used to control the amount of packets > we should handle per poll to balance the resource in the system. > > In the list of the amsdu packets reception, we check if there is budget > count left and handle th

Re: linux-next: manual merge of the wireless-drivers-next tree with Linus' tree

(Adding Dave so that he is also aware of this) Stephen Rothwell writes: > As expetced, today's linux-next merge of the wireless-drivers-next tree > got a conflict in: > > drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c > > between commit: > > 92b0f7b26b31 ("iwlwifi: split the regulatory r

Re: [PATCH] wireless-regdb: Update regulatory rules for Singapore (SG)

On Mittwoch, 23. August 2017 15:52:40 CEST Seth Forshee wrote: [...] > > +# Source > > +# > > https://www.imda.gov.sg/~/media/imda/files/regulation%20licensing%20and%20consultations/ict%20standards/telecommunication%20standards/radio-comms/imdatssrd.pdf?la=en > > +# page 12-14 > > +# The EIRP for