Re: [PATCH 1/2] iwlwifi: fix long debug print

2017-09-01 Thread Kalle Valo
Joe Perches writes: > On Fri, 2017-09-01 at 08:37 +0300, Luca Coelho wrote: >> On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote: >> > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote: >> > > From: Liad Kaufman >> > > >> > > There is a debug print that sometimes reaches over >> > > 110 c

Re: [PATCH 1/2] iwlwifi: fix long debug print

2017-09-01 Thread Joe Perches
On Fri, 2017-09-01 at 11:15 +0300, Kalle Valo wrote: > Joe Perches writes: > > On Fri, 2017-09-01 at 08:37 +0300, Luca Coelho wrote: > > > On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote: > > > > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote: > > > > > From: Liad Kaufman > > > > > The

[bug report] iwlwifi: mvm: add station before allocating a queue

2017-09-01 Thread Dan Carpenter
Hello Shaul Triebitz, The patch 732d06e9d9cf: "iwlwifi: mvm: add station before allocating a queue" from Jul 10, 2017, leads to the following static checker warning: drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1312 iwl_mvm_add_int_sta_common() error: uninitialized symbol 'status

Re: RT2870 failure in kernel 4.12.8

2017-09-01 Thread Stanislaw Gruszka
On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote: > Should the patch to wireless-drivers be annotated with a Stable reference so > that it is added to 4.12 and 4.13? According to Documentation/networking/netdev-FAQ.txt networking patches should not be marked cc:stable, instead a decent

Re: [PATCH v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend

2017-09-01 Thread Eric Bentley
Return error when failing to set power management capabilities flag. This will cause the suspend to fail but the radio will continue to operate. Allowing this to fail without reporting error will cause the radio to be non-functional on resume as it will have lost power. Signed-off-by: Eric Bent

Re: RT2870 failure in kernel 4.12.8

2017-09-01 Thread Kalle Valo
Stanislaw Gruszka writes: > On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote: >> Should the patch to wireless-drivers be annotated with a Stable reference so >> that it is added to 4.12 and 4.13? > > According to Documentation/networking/netdev-FAQ.txt networking patches > should not

pull-request: wireless-drivers-next 2017-09-01

2017-09-01 Thread Kalle Valo
Hi Dave, here's a pull request to net-next for 4.14. If the merge window opens on Sunday I'm planning to have this as the last one. Please let me know if there are any problems. Kalle The following changes since commit d081a16db80ef7a260fb178aa1199e01f7432625: net: bcmgenet: Do not return fr

Re: RT2870 failure in kernel 4.12.8

2017-09-01 Thread Larry Finger
On 09/01/2017 09:31 AM, Kalle Valo wrote: Stanislaw Gruszka writes: On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote: Should the patch to wireless-drivers be annotated with a Stable reference so that it is added to 4.12 and 4.13? According to Documentation/networking/netdev-FAQ.

Re: [PATCH] Documentation: dt-binding: net: wireless: add bcm43430-fmac

2017-09-01 Thread Rob Herring
On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote: > hi, > > On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote: > > On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote: > > > > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > > +++ b/Documentatio

Re: pull-request: wireless-drivers-next 2017-09-01

2017-09-01 Thread David Miller
From: Kalle Valo Date: Fri, 01 Sep 2017 17:34:43 +0300 > here's a pull request to net-next for 4.14. If the merge window opens on > Sunday I'm planning to have this as the last one. > > Please let me know if there are any problems. Ok, pulled, thanks.

Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

2017-09-01 Thread Krzysztof Halasa
Kees Cook writes: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For *wan/hdlc* Acked-by: Krzysztof Halasa > --- a/drivers/net/wan

Re: [PATCH] Documentation: dt-binding: net: wireless: add bcm43430-fmac

2017-09-01 Thread Arend van Spriel
On 01-09-17 18:49, Rob Herring wrote: On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote: hi, On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote: On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote: a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.tx

Re: [PATCH v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend

2017-09-01 Thread Arend van Spriel
On 01-09-17 15:00, Eric Bentley wrote: Return error when failing to set power management capabilities flag. This will cause the suspend to fail but the radio will continue to operate. Allowing this to fail without reporting error will cause the radio to be non-functional on resume as it will ha

Re: [PATCH v2] brcmfmac: feature check for multi-scheduled scan fails on bcm4345 devices

2017-09-01 Thread Arend van Spriel
On 31-08-17 00:51, Ian W MORRISON wrote: The firmware feature check introduced for multi-scheduled scan is also failing for bcm4345 devices resulting in a firmware crash. The reason for this crash has not yet been root cause so this patch avoids the feature check for those device as a short-term

Re: Incorrect mesh path seq num

2017-09-01 Thread Thomas Pedersen
On Thu, Aug 31, 2017 at 11:30 PM, Greg Maitz wrote: > Hi guys, > > I'm seeing a problem when I work on the wireless mesh between two > linux devices. The root node has 3.18 kernel while the next hop > station runs 2.6.37 kernel. I found the mpath->sn value is incorrect > most of the time on the de

Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

2017-09-01 Thread Jens Axboe
On 08/31/2017 05:29 PM, Kees Cook wrote: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For amiflop: Acked-by: Jens Axboe -- Jens

Re: [PATCH] Documentation: dt-binding: net: wireless: add bcm43430-fmac

2017-09-01 Thread Antony Antony
On Fri, Sep 01, 2017 at 09:10:41PM +0200, Arend van Spriel wrote: > On 01-09-17 18:49, Rob Herring wrote: > > On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote: > > > hi, > > > > > > On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote: > > > > On Wed, Aug 30, 2017 at 5:43 AM,

Re: [PATCH] Documentation: dt-binding: net: wireless: add bcm43430-fmac

2017-09-01 Thread Arend van Spriel
On 01-09-17 22:40, Antony Antony wrote: On Fri, Sep 01, 2017 at 09:10:41PM +0200, Arend van Spriel wrote: On 01-09-17 18:49, Rob Herring wrote: On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote: hi, On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote: On Wed, Aug 30, 201

Re: [PATCH] Documentation: dt-binding: net: wireless: add bcm43430-fmac

2017-09-01 Thread Rob Herring
On Fri, Sep 1, 2017 at 2:10 PM, Arend van Spriel wrote: > On 01-09-17 18:49, Rob Herring wrote: >> >> On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote: >>> >>> hi, >>> >>> On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote: On Wed, Aug 30, 2017 at 5:43 AM, Antony A

Re: [PATCH] Documentation: dt-binding: net: wireless: add bcm43430-fmac

2017-09-01 Thread Arend van Spriel
On 01-09-17 23:38, Rob Herring wrote: On Fri, Sep 1, 2017 at 2:10 PM, Arend van Spriel wrote: On 01-09-17 18:49, Rob Herring wrote: On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote: hi, On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote: On Wed, Aug 30, 2017 at 5

Re: [v3,1/2] ath10k: add the PCI PM core suspend/resume ops

2017-09-01 Thread Ryan Hsu
On 08/31/2017 05:52 AM, Kalle Valo wrote: > This had a warning: > > drivers/net/wireless/ath/ath10k/pci.c:3651:1: warning: symbol > 'ath10k_pci_pm_ops' was not declared. Should it be static? > > I fixed it in the pending branch by making it static: > > static SIMPLE_DEV_PM_OPS(ath10k_pci_pm_ops,

[PATCH V2 0/9] qtnfmac: more info on current channel from device

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko This patchset has a goal to start using full current channel information as reported by wireless device (specifically, center freq 1 and 2 and operational BW). It was part of bigger changeset when it was V1. Changelist V1->V2: PATCH 2: - do not rename "chandef" local vari

[PATCH V2 6/9] qtnfmac: pass VIF info to SendChannel command

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +- drivers/net/wireless/quantenna/qtnfmac/commands.c | 5 +++-- drivers/net/wireless/quantenna/qtnfmac/commands.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/

[PATCH V2 9/9] qtnfmac: do not report channel changes until wiphy is registered

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/quantenna/qtnfmac/event.c b/drivers/net/wireless/quantenna/qtnfmac/event.c index b1acc24..7481d5b 100644 --- a/drive

[PATCH V2 3/9] qtnfmac: retrieve current channel info from EP

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko Do not try to cache current operational channel info in driver, this is a potential source of synchronization issues + driver does not really need that info. Introduce GET_CHANNEL command and process it appropriately. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless

[PATCH V2 8/9] qtnfmac: remove unused mac::status field

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko It is no longer used. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 1 - drivers/net/wireless/quantenna/qtnfmac/core.h | 5 - drivers/net/wireless/quantenna/qtnfmac/event.c| 2 -- 3 files changed, 8 deletions(-) diff --g

[PATCH V2 5/9] qtnfmac: let wifi card handle channel switch request to the same chan

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index 17b323e..4590f30 100644 -

[PATCH V2 7/9] qtnfmac: do not cache CSA chandef info

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko It is never used for anything useful, and all logic is handled by either WiFi card or higher layers. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 12 drivers/net/wireless/quantenna/qtnfmac/commands.c | 2 -- drivers/ne

[PATCH V2 4/9] qtnfmac: do not cache channel info from "connect" command

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko This makes no sense because real operational channel is choosen based on AP operation, not on what STA is configured to. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 15 +-- drivers/net/wireless/quantenna/qtnfmac/command

[PATCH V2 2/9] qtnfmac: make "Channel change" event report full channel info

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko Specifically, it has to report center frequency, secondary center frequency (for 80+80) and BW. Introduce channel definition structure to qlink and modify channel change event processing function accordingly. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna

[PATCH V2 1/9] qtnfmac: qlink: convert channel width from bitfiled to simple enum

2017-09-01 Thread igor . mitsyanko . os
From: Igor Mitsyanko Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/qlink.h | 16 drivers/net/wireless/quantenna/qtnfmac/qlink_util.c | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/quan