[TDLS PATCH V3 5/5] ath10k: Avoid to set WEP key for TDLS peer

2017-09-18 Thread yintang
From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wire

[TDLS PATCH V3 4/5] ath10k: Avoid to set WEP key for TDLS peer

2017-09-18 Thread yintang
From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[TDLS PATCH V3 3/5] ath10k: Enable TDLS peer inactivity detection

2017-09-18 Thread yintang
From: Yingying Tang Enable TDLS peer inactivity detetion feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS link inactivity detecting. Set related parameters in TDLS WMI command to enable this feature. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 52

[TDLS PATCH V3 2/5] ath10k: Enable TDLS peer buffer STA feature

2017-09-18 Thread yintang
From: Yingying Tang Enable TDLS peer buffer STA feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS peer buffer STA, it reports this capability through wmi service map in wmi service ready event. Set related parameter in TDLS WMI command to enable this feature. Signed-off-by: Yingying T

[TDLS PATCH V3 1/5] mac80211: Enable TDLS peer buffer STA feature

2017-09-18 Thread yintang
From: Yingying Tang Enable TDLS peer buffer STA feature. Set extended capability bit to enable buffer STA when driver support it. Signed-off-by: Yingying Tang --- include/net/cfg80211.h |3 +++ net/mac80211/tdls.c|5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[TDLS PATCH V3 0/5] Add TDLS feature for ath10k

2017-09-18 Thread yintang
From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Yingying Tang (5): mac80211: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer inactivity detection ath10k: Avoid to set WEP key for TDLS peer

Re: [TDLS PATCH V2 1/5] mac80211: Enable TDLS peer buffer STA feature

2017-09-18 Thread James Cameron
On Tue, Sep 19, 2017 at 10:51:04AM +0800, yint...@qti.qualcomm.com wrote: > From: Yingying Tang > > Enable TDLS peer buffer STA feature. > Set extended capability bit to enable buffer STA when driver > support it. > > Signed-off-by: Yingying Tang > --- > include/net/cfg80211.h |3 +++ > ne

[TDLS PATCH V2 5/5] ath10k: Avoid to set WEP key for TDLS peer

2017-09-18 Thread yintang
From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wire

[TDLS PATCH V2 3/5] ath10k: Enable TDLS peer inactivity detection

2017-09-18 Thread yintang
From: Yingying Tang Enable TDLS peer inactivity detetion feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS link inactivity detecting. Set related parameters in TDLS WMI command to enable this feature. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 52

[TDLS PATCH V2 2/5] ath10k: Enable TDLS peer buffer STA feature

2017-09-18 Thread yintang
From: Yingying Tang Enable TDLS peer buffer STA feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS peer buffer STA, it reports this capability through wmi service map in wmi service ready event. Set related parameter in TDLS WMI command to enable this feature. Signed-off-by: Yingying T

[TDLS PATCH V2 1/5] mac80211: Enable TDLS peer buffer STA feature

2017-09-18 Thread yintang
From: Yingying Tang Enable TDLS peer buffer STA feature. Set extended capability bit to enable buffer STA when driver support it. Signed-off-by: Yingying Tang --- include/net/cfg80211.h |3 +++ net/mac80211/tdls.c|5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[TDLS PATCH V2 4/5] ath10k: Avoid to set WEP key for TDLS peer

2017-09-18 Thread yintang
From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[TDLS PATCH V2 0/5] Add TDLS feature for ath10k

2017-09-18 Thread yintang
From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Yingying Tang (5): mac80211: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer inactivity detection ath10k: Avoid to set WEP key for TDLS peer

[PATCH] nl80211: fix null-ptr dereference on invalid mesh configuration

2017-09-18 Thread Johannes Berg
From: Johannes Berg If TX rates are specified during mesh join, the channel must also be specified. Check the channel pointer to avoid a null pointer dereference if it isn't. Reported-by: Jouni Malinen Fixes: 8564e38206de ("cfg80211: add checks for beacon rate, extend to mesh") Signed-off-by: J

Re: [PATCH 1/2] mac80211: Add rcu read side critical sections

2017-09-18 Thread Johannes Berg
> I got the following lockdep warning about the rcu_dereference()s in > ieee80211_tx_h_select_key(). After tracing all callers of > ieee80211_tx_h_select_key() I discovered that > ieee80211_get_buffered_bc() > and ieee80211_build_data_template() had the rcu_read_lock/unlock() > but > three other pl

[PATCH 2/2] ath9k: Avoid a potential deadlock

2017-09-18 Thread Ville Syrjala
From: Ville Syrjälä Lockdep warns us that sc_pm_lock and cc_lock can cause a deadlock when cc_lock is acquired by itself with interrupts enabled. Disable irqs whenever taking cc_lock to avoid this. [ 19.094524] kworker/u2:0/5 just changed the state of lock: [ 19.094578] (&(&sc->sc_pm_lock)-

[PATCH 1/2] mac80211: Add rcu read side critical sections

2017-09-18 Thread Ville Syrjala
From: Ville Syrjälä I got the following lockdep warning about the rcu_dereference()s in ieee80211_tx_h_select_key(). After tracing all callers of ieee80211_tx_h_select_key() I discovered that ieee80211_get_buffered_bc() and ieee80211_build_data_template() had the rcu_read_lock/unlock() but three

Re: [PATCH] mwifiex: avoid storing random_mac in private

2017-09-18 Thread Brian Norris
On Mon, Sep 18, 2017 at 12:25:02PM +0530, Ganapathi Bhat wrote: > Application will keep track of whether MAC address randomization > is enabled or not during scan. But at present driver is storing > 'random_mac' in mwifiex_private which implies even after scan is > done driver has some reference to

reminder: wireless workshop

2017-09-18 Thread Johannes Berg
Hi, Just as a reminder, the wireless workshop is coming up at netdev 2.2 in Seoul: https://wireless.wiki.kernel.org/en/developers/summits/seoul-2017 Of course, netdev 2.2 is also highly recommended in general, there are lots of interesting talks and other sessions lined up: https://www.netdevco

Re: [PATCH 3/3] Revert "ath10k: QCA988X hw2.0: update firmware to 10.2.4.70.63-2"

2017-09-18 Thread Matteo Croce
On Mon, Sep 18, 2017 at 5:00 PM, Kalle Valo wrote: > This reverts commit c7370e2728c72e5e87f63a48911a925330485a8e. > > 10.2.4.70.63-2 was buggy and lots of people have been reporting crashes, Hauke > Mehrtens among others: > > http://lists.infradead.org/pipermail/ath10k/2017-September/010138.html

[PATCH 2/3] ath10k: QCA6174 hw3.0: update board-2.bin

2017-09-18 Thread Kalle Valo
Signed-off-by: Kalle Valo --- ath10k/QCA6174/hw3.0/board-2.bin | Bin 477060 -> 501748 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ath10k/QCA6174/hw3.0/board-2.bin b/ath10k/QCA6174/hw3.0/board-2.bin index a442315503bfc70f5a5fbfaa6f04004702d8474c..10960ba28975ed1c7c4e9fb91

[PATCH 3/3] Revert "ath10k: QCA988X hw2.0: update firmware to 10.2.4.70.63-2"

2017-09-18 Thread Kalle Valo
This reverts commit c7370e2728c72e5e87f63a48911a925330485a8e. 10.2.4.70.63-2 was buggy and lots of people have been reporting crashes, Hauke Mehrtens among others: http://lists.infradead.org/pipermail/ath10k/2017-September/010138.html This reverts the firmware back to 10.2.4.70.54. --- WHENCE

[PATCH 0/3] linux-firmware: ath10k update 20170918

2017-09-18 Thread Kalle Valo
Few firmware fixes to user reported issues for ath10k, but the other "fix" being a revert back to older firmware. Also a small board-2.bin update. Kalle Valo (3): ath10k: QCA6174 hw3.0: update firmware-6.bin to WLAN.RM.4.4.1-00051-QCARMSWP-1 ath10k: QCA6174 hw3.0: update board-2.bin Reve

RE: [PATCH 2/2] mwifiex: use get_random_mask_addr() helper

2017-09-18 Thread Ganapathi Bhat
Hi Kalle, > > > Avoid calculating random MAC address in driver. Instead make use of > > 'get_random_mask_addr()' function. > > > > Signed-off-by: Ganapathi Bhat > > I don't see 1/2 anywhere. Did it get lost? Actually there is no 1/2. What I did is: 'git send-email'; CTRL + C (to correct a typo)

[PATCH v2] mac80211_hwsim: use dyndbg for debug messages

2017-09-18 Thread Lubomir Rintel
The mac80211_hwsim doesn't offer a way to disable the debugging output. Unfortunately, it's pretty chatty, dumping a lot of stuff into the message buffer. This patch changes it to use dyndbg for controlling the debug output. It's disabled by default, but can be enabled by a module parameter (1),

Re: [PATCH 2/2] mwifiex: use get_random_mask_addr() helper

2017-09-18 Thread Kalle Valo
Ganapathi Bhat writes: > Avoid calculating random MAC address in driver. Instead make > use of 'get_random_mask_addr()' function. > > Signed-off-by: Ganapathi Bhat I don't see 1/2 anywhere. Did it get lost? -- Kalle Valo

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Kalle Valo
Sergey Matyukevich writes: > By the way, is it ok to send corrected single patch in reply to this > discussion ? Or the appropriate way is to resend the whole patch set ? This has been a common question so I documented it: https://wireless.wiki.kernel.org/en/developers/documentation/submittingp

Re: [TDLS PATCH V1 0/5] Add TDLS feature for ath10k

2017-09-18 Thread Kalle Valo
writes: > From: Yingying Tang > > This patchset is for Rome PCIE chip, it will not affect other hardware > > Yingying Tang (5): > mac80211: Enable TDLS peer buffer STA feature > ath10k: Enable TDLS peer buffer STA feature > ath10k: Enable TDLS peer inactivity detection > ath10k: Avoid to

[PATCH v2 2/2] qtnfmac: cancel scans on wireless interface changes

2017-09-18 Thread Sergey Matyukevich
Cancel active scans and deactivate firmware scan watchdog timer when wireless interface configuration is changed. The usecases include wireless interface mode change, interface down, AP stop, virtual interface removal. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/

[PATCH v2 1/2] qtnfmac: lock access to h/w in tx path

2017-09-18 Thread Sergey Matyukevich
Fix tx path regression. Lock should be held when queuing packets to h/w fifos in order to properly handle configurations with multiple enabled interfaces. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 9 - drivers/net/wireless/quante

[PATCH v2 0/2] qtnfmac: misc fixes intended for 4.14

2017-09-18 Thread Sergey Matyukevich
Hello Kalle, Igor, and all Here is the second version of the two patches intended for 4.14. The first patch fixes tx path regression. Lock should be held when queuing packets to h/w fifos in order to properly handle configurations with two enabled interfaces or multiple enabled mbss. The second pa

Re: pull-request: iwlwifi 2017-09-15

2017-09-18 Thread Kalle Valo
Luca Coelho writes: > Here is the first set of fixes for 4.14. More details in the tag > description. > > I have sent this out before and kbuildbot didn't find any issues. > Please let me know if there are any issues. > > Cheers, > Luca. > > > The following changes since commit 2eabc84d2f8e4f36

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Sergey Matyukevich
> > > > > > - if (timer_pending(&mac->scan_timeout)) > > > > > > - del_timer_sync(&mac->scan_timeout); > > > I don't quite understand the question. Do you mean it makes sense to > > call cfg80211_scan_done first and then cancel timer ? > > No, I'm just not sure why you call timer_

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Johannes Berg
On Mon, 2017-09-18 at 13:16 +0300, Sergey Matyukevich wrote: > > > > > > - if (timer_pending(&mac->scan_timeout)) > > > > > - del_timer_sync(&mac->scan_timeout); > I don't quite understand the question. Do you mean it makes sense to > call cfg80211_scan_done first and then cancel

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Sergey Matyukevich
On Mon, Sep 18, 2017 at 12:03:07PM +0200, Johannes Berg wrote: > > > > - if (timer_pending(&mac->scan_timeout)) > > > > - del_timer_sync(&mac->scan_timeout); > > > > qtnf_scan_done(mac, le32_to_cpu(status->flags) & > > > > QLINK_SCAN_ABORTED); > > > > > > and that's related p

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Johannes Berg
Hi, > > >  static int qtnf_netdev_close(struct net_device *ndev) > > >  { > > > - netif_carrier_off(ndev); > > >   qtnf_virtual_intf_cleanup(ndev); > > >   qtnf_netdev_updown(ndev, 0); > > > + netif_carrier_off(ndev); > > >   return 0; > > >  } > > > > This seems unrelated? >

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Sergey Matyukevich
On Mon, Sep 18, 2017 at 10:41:08AM +0200, Johannes Berg wrote: Hello Johannes, > On Mon, 2017-09-18 at 11:04 +0300, Sergey Matyukevich wrote: > > > > */ > > static int qtnf_netdev_close(struct net_device *ndev) > > { > > - netif_carrier_off(ndev); > > qtnf_virtual_intf_cleanup(ndev)

Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Johannes Berg
On Mon, 2017-09-18 at 11:04 +0300, Sergey Matyukevich wrote: > >   */ >  static int qtnf_netdev_close(struct net_device *ndev) >  { > - netif_carrier_off(ndev); >   qtnf_virtual_intf_cleanup(ndev); >   qtnf_netdev_updown(ndev, 0); > + netif_carrier_off(ndev); >   return 0; >  }

[PATCH 1/2] qtnfmac: lock access to h/w in tx path

2017-09-18 Thread Sergey Matyukevich
Fix tx path regression. Lock should be held when queuing packets to h/w fifos in order to properly handle configurations with multiple enabled interfaces. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 9 - drivers/net/wireless/quante

[PATCH RESEND 0/2] qtnfmac: misc fixes intended for 4.14

2017-09-18 Thread Sergey Matyukevich
Hello Kalle, Igor, and all Here are two patches intended for 4.14. The first patch fixes tx path regression. Lock should be held when queuing packets to h/w fifos in order to properly handle configurations with two enabled interfaces or multiple enabled mbss. The second patch fixes scan issues add

[PATCH 2/2] qtnfmac: abort scans on wireless interface changes

2017-09-18 Thread Sergey Matyukevich
Abort active scans when wireless interface configuration is changed. The usecases include wireless interface mode change, interface down, AP stop, virtual interface removal. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 9 ++--- drivers/net/wireles

[PATCH 2/2] mwifiex: use get_random_mask_addr() helper

2017-09-18 Thread Ganapathi Bhat
Avoid calculating random MAC address in driver. Instead make use of 'get_random_mask_addr()' function. Signed-off-by: Ganapathi Bhat --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/marvell/mw