Re: [PATCH 0/3] linux-firmware: ath10k update 20170918

2017-10-04 Thread Kalle Valo
Kalle Valo writes: > Few firmware fixes to user reported issues for ath10k, but the other "fix" > being a revert back to older firmware. Also a small board-2.bin update. > > Kalle Valo (3): > ath10k: QCA6174 hw3.0: update firmware-6.bin to > WLAN.RM.4.4.1-00051-QCARMSWP-1 > ath10k: QCA617

Re: QCA988x and kernel 4.13

2017-10-04 Thread Kalle Valo
Ben Greear writes: > On 10/01/2017 07:06 AM, Sebastian Gottschall wrote: >> you have to update to the latest mac80211 code. there is a well >> known bug in mac80211 which causes a deadlock with ath10k > > Do you have a pointer to the patch that fixes this? I'd like to check if it > has > made i

Re: [PATCH 01/11] ath10k_sdio: sdio htt data transfer fixes

2017-10-04 Thread Kalle Valo
Arend van Spriel writes: > On 9/30/2017 7:37 PM, silexcom...@gmail.com wrote: >> From: Alagu Sankar >> > > [...] > >> >> Signed-off-by: Alagu Sankar > > Not really have a specific remark for this patch, but for the entire > series. These patches are sent using an anonymous email address, apart

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Kalle Valo
Icenowy Zheng writes: > Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to use > an out-of-band interrupt pin instead of SDIO in-band interrupt. > > Add the device tree binding of this chip, in order to make it possible > to add this interrupt pin to device trees. > > Signed-off

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Icenowy Zheng
于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到: >Icenowy Zheng writes: > >> Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to >use >> an out-of-band interrupt pin instead of SDIO in-band interrupt. >> >> Add the device tree binding of this chip, in order to make it >possible

Re: ath9k: make const array reg_hole_list static, reduces object code size

2017-10-04 Thread Kalle Valo
Colin Ian King wrote: > Don't populate the read-only array reg_hole_list on the stack, instead make > it static. Makes the object code smaller by over 200 bytes: > > Before: >text data bss dec hex filename > 57518 15248 0 72766 11c3e debug.o > > Aft

Re: [PATCH 08/11] ath10k_sdio: common read write

2017-10-04 Thread Kalle Valo
silexcom...@gmail.com writes: > From: Alagu Sankar > > convert different read write functions in sdio hif to bring it under a > single read-write path. This helps in having a common dma bounce buffer > implementation. Also helps in address modification that is required > specific to change in cer

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Arend van Spriel
On 10/4/2017 11:03 AM, Icenowy Zheng wrote: 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到: Icenowy Zheng writes: Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to use an out-of-band interrupt pin instead of SDIO in-band interrupt. Add the device tree binding of this

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Maxime Ripard
On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: > On 10/4/2017 11:03 AM, Icenowy Zheng wrote: > > > > > > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到: > > > Icenowy Zheng writes: > > > > > > > Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to > > > use

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Icenowy Zheng
于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard 写到: >On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: >> On 10/4/2017 11:03 AM, Icenowy Zheng wrote: >> > >> > >> > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo >写到: >> > > Icenowy Zheng writes: >> > > >> > > > Allwinner XR81

Re: QCA988x and kernel 4.13

2017-10-04 Thread Sebastian Gottschall
Am 04.10.2017 um 10:50 schrieb Kalle Valo: Ben Greear writes: On 10/01/2017 07:06 AM, Sebastian Gottschall wrote: you have to update to the latest mac80211 code. there is a well known bug in mac80211 which causes a deadlock with ath10k Do you have a pointer to the patch that fixes this? I'd

[PATCH] mwifiex: double the size of chan_stats array in adapter

2017-10-04 Thread Ganapathi Bhat
From: Rohit Fule When a user requests scan, driver sends multiple scan requests to firmware, which might be active or passive. Firmware will send channel statistics for each channel in the request. This will be stored in chan_stats array. Few channels might report hidden SSIDs in passive scan re

Re: QCA988x and kernel 4.13

2017-10-04 Thread Ben Greear
On 10/04/2017 01:50 AM, Kalle Valo wrote: Ben Greear writes: On 10/01/2017 07:06 AM, Sebastian Gottschall wrote: you have to update to the latest mac80211 code. there is a well known bug in mac80211 which causes a deadlock with ath10k Do you have a pointer to the patch that fixes this? I

Re: [PATCH 00/11] SDIO support for ath10k

2017-10-04 Thread Erik Stromdahl
On 2017-10-04 08:22, Alagu Sankar wrote: Hi Erik, We will work to have this support mainlined as soon as possible. Would appreciate your support in making sure that the patches do not affect the USB high latency path. I have added the patches in my own ath-repo and I have tested with the WU

[PATCH 3/3] wireless: iwlwifi: wrap macro into braces

2017-10-04 Thread Christoph Böhmwalder
Macros should always be wrapped in braces, so fix this instance. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-io.c b/drivers/net/wireless/intel/iwlwi

[PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Christoph Böhmwalder
Change a usage of int in a boolean context to use the bool type instead, as it makes the intent of the function clearer and helps clarify its semantics. Also eliminate the if/else and just return the boolean result directly, making the code more readable. Signed-off-by: Christoph Böhmwalder ---

[PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix

2017-10-04 Thread Christoph Böhmwalder
Separate the function from the previous definition with a newline and put the `static` keyword on the same line, as it just looks nicer. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 0/3] iwlwifi: cosmetic fixes

2017-10-04 Thread Christoph Böhmwalder
Fix several code style issues, some of which were reported by checkpatch.pl. The changes are: * One instance of an `int` variable being used in a boolean context, chaned to use the more appropriate `bool` type. * One very minor fix, removing a newline between a function definition and its asso

Re: [PATCH 3/3] wireless: iwlwifi: wrap macro into braces

2017-10-04 Thread Johannes Berg
Please don't send obviously broken patches. johannes

Re: [PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Separate the function from the previous definition with a newline and > put the `static` keyword on the same line, as it just looks nicer. > > Signed-off-by: Christoph Böhmwalder > --- > drivers/net/wireless/intel/iwlwifi/iwl-phy-d

Re: [PATCH 3/3] wireless: iwlwifi: wrap macro into braces

2017-10-04 Thread Joe Perches
On Wed, 2017-10-04 at 17:57 +0200, Christoph Böhmwalder wrote: > Macros should always be wrapped in braces, so fix this instance. > > Signed-off-by: Christoph Böhmwalder > --- > drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Change a usage of int in a boolean context to use the bool type > instead, as it > makes the intent of the function clearer and helps clarify its > semantics. > > Also eliminate the if/else and just return the boolean result > direct

Re: [PATCH 0/3] iwlwifi: cosmetic fixes

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Fix several code style issues, some of which were reported by > checkpatch.pl. > > The changes are: > * One instance of an `int` variable being used in a boolean context, > chaned to > use the more appropriate `bool` type. > * One

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Joe Perches
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Change a usage of int in a boolean context to use the bool type instead, as it > makes the intent of the function clearer and helps clarify its semantics. > > Also eliminate the if/else and just return the boolean result directly, >

Re: QCA988x and kernel 4.13

2017-10-04 Thread Sebastian Gottschall
Am 04.10.2017 um 17:13 schrieb Ben Greear: On 10/04/2017 01:50 AM, Kalle Valo wrote: Ben Greear writes: On 10/01/2017 07:06 AM, Sebastian Gottschall wrote: you have to update to the latest mac80211 code. there is a well known bug in mac80211 which causes a deadlock with ath10k Do you hav

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote: > On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > > Change a usage of int in a boolean context to use the bool type > > instead, as it > > makes the intent of the function clearer and helps clarify its > > semantics. > > > > Al

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Joe Perches
On Wed, 2017-10-04 at 19:39 +0300, Luciano Coelho wrote: > On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote: [] > > This might be more intelligble as separate tests > > > > static bool is_valid_channel(u16 ch_id) > > { > > if (ch_id <= 14) > > return true; > > > > if ((ch_

[PATCH] mwifiex: Use put_unaligned_le32

2017-10-04 Thread Himanshu Jha
Use put_unaligned_le32 rather than using byte ordering function and memcpy which makes code clear. Also, add the header file where it is declared. Done using Coccinelle and semantic patch used is : @ rule1 @ identifier tmp; expression ptr,x; type T; @@ - tmp = cpu_to_le32(x); <+... when != tm

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 10:55 -0700, Joe Perches wrote: > On Wed, 2017-10-04 at 19:39 +0300, Luciano Coelho wrote: > > On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote: > > [] > > > This might be more intelligble as separate tests > > > > > > static bool is_valid_channel(u16 ch_id) > > > { > >

Re: [PATCH 09/11] ath10k_sdio: virtual scatter gather for receive

2017-10-04 Thread Erik Stromdahl
On 2017-09-30 19:37, silexcom...@gmail.com wrote: From: Alagu Sankar The existing implementation of initiating multiple sdio transfers for receive bundling is slowing down the receive speed. Combining the transfers using a scatter gather method would be ideal. This results in significant perf

[PATCH 02/13] timer: Remove init_timer_pinned_deferrable() in favor of timer_setup()

2017-10-04 Thread Kees Cook
This refactors the only user of init_timer_pinned_deferrable() to use the new timer_setup() and from_timer(). Adds a pointer back to the policy, and drops the definition of init_timer_pinned_deferrable(). Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc

[PATCH 07/13] timer: Remove last user of TIMER_INITIALIZER

2017-10-04 Thread Kees Cook
Drops the last user of TIMER_INITIALIZER and adapts timer.h to use the internal version. Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Mark Gross Cc: Thomas Gleixner Signed-off-by: Kees Cook --- drivers/char/tlclk.c | 12 +--- include/linux/timer.h | 2 +- 2 files changed, 6 inserti

[PATCH 06/13] timer: Remove users of TIMER_DEFERRED_INITIALIZER

2017-10-04 Thread Kees Cook
This removes uses of TIMER_DEFERRED_INITIALIZER and chooses a location to call timer_setup() from before add_timer() or mod_timer() is called. Adjusts callbacks to use from_timer() as needed. Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: Tejun Heo Cc: Lai Jiangshan Cc: linux-s...@vger.kernel.o

[PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

2017-10-04 Thread Kees Cook
The expire and data arguments of DEFINE_TIMER are only used in two places and are ignored by the code (malta-display.c only uses mod_timer(), never add_timer(), so the preset expires value is ignored). Set both sets of arguments to zero. Cc: Ralf Baechle Cc: Wim Van Sebroeck Cc: Guenter Roeck C

[PATCH 12/13] kthread: Convert callback to use from_timer()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch kthread to use from_timer() and pass the timer pointer explicitly. Cc: Andrew Morton Cc: Petr Mladek Cc: Tejun Heo Cc: Thomas Gleixner Cc: Oleg Nesterov Signed-off-by: Kees Cook --- inclu

[PATCH 13/13] workqueue: Convert callback to use from_timer()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch workqueue to use from_timer() and pass the timer pointer explicitly. Cc: Tejun Heo Cc: Lai Jiangshan Signed-off-by: Kees Cook --- include/linux/workqueue.h | 15 --- kernel/workq

[PATCH 11/13] timer: Remove expires argument from __TIMER_INITIALIZER()

2017-10-04 Thread Kees Cook
The expires field is normally initialized during the first mod_timer() call. It was unused by all callers, so remove it from the macro. Signed-off-by: Kees Cook --- include/linux/kthread.h | 2 +- include/linux/timer.h | 5 ++--- include/linux/workqueue.h | 2 +- 3 files changed, 4 inserti

[PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread Kees Cook
Drop the arguments from the macro and adjust all callers with the following script: perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) Signed-off-by: Kees Cook Acked-by: Geert Uytterhoeven # for m68k parts

[PATCH 08/13] timer: Remove unused static initializer macros

2017-10-04 Thread Kees Cook
This removes the now unused TIMER_*INITIALIZER macros: TIMER_INITIALIZER TIMER_PINNED_INITIALIZER TIMER_DEFERRED_INITIALIZER TIMER_PINNED_DEFERRED_INITIALIZER Signed-off-by: Kees Cook --- include/linux/timer.h | 12 1 file changed, 12 deletions(-) diff --git a/include/linux/timer.

[PATCH 01/13] timer: Convert schedule_timeout() to use from_timer()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new from_timer() helper and passing the timer pointer explicitly. Since this special timer is on the stack, it needs to have a wrapper structure to carry state once .data is eliminat

[PATCH 05/13] timer: Remove init_timer_deferrable() in favor of timer_setup()

2017-10-04 Thread Kees Cook
This refactors the only users of init_timer_deferrable() to use the new timer_setup() and from_timer(). Removes definition of init_timer_deferrable(). Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Sebastian Reichel Cc: Harish Patil Cc: Manish Chopra Cc: Kalle Valo Cc: linuxppc-...@list

[PATCH 03/13] timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()

2017-10-04 Thread Kees Cook
Remove uses of init_timer_on_stack() with open-coded function and data assignments that could be expressed using timer_setup_on_stack(). Several were removed from the stack entirely since there was a one-to-one mapping of parent structure to timer, those are switched to using timer_setup() instead.

[PATCH 00/13] timer: Start conversion to timer_setup()

2017-10-04 Thread Kees Cook
Hi, This is the first of many timer infrastructure cleanups to simplify the timer API[1]. All of these patches are expected to land via the timer tree, so Acks (or corrections) appreciated. These patches refactor various users of timer API that are NOT just using init_timer() or setup_timer() (wh

[PATCH 04/13] timer: Remove init_timer_pinned() in favor of timer_setup()

2017-10-04 Thread Kees Cook
This refactors the only users of init_timer_pinned() to use the new timer_setup() and from_timer(). Drops the definition of init_timer_pinned(). Cc: Chris Metcalf Cc: Thomas Gleixner Cc: net...@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/ethernet/tile/tilepro.c | 9 - incl

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

2017-10-04 Thread Guenter Roeck
On 10/04/2017 04:27 PM, Kees Cook wrote: The expire and data arguments of DEFINE_TIMER are only used in two places and are ignored by the code (malta-display.c only uses mod_timer(), never add_timer(), so the preset expires value is ignored). Set both sets of arguments to zero. Cc: Ralf Baechle

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread Guenter Roeck
On 10/04/2017 04:27 PM, Kees Cook wrote: Drop the arguments from the macro and adjust all callers with the following script: perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) Signed-off-by: Kees Cook Ac

Re: [PATCH 05/13] timer: Remove init_timer_deferrable() in favor of timer_setup()

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:26:59 -0700 > This refactors the only users of init_timer_deferrable() to use > the new timer_setup() and from_timer(). Removes definition of > init_timer_deferrable(). > > Cc: Benjamin Herrenschmidt > Cc: Michael Ellerman > Cc: Sebastian Reichel > Cc

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:27:04 -0700 > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ > $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) > > Sig

Re: [PATCH 04/13] timer: Remove init_timer_pinned() in favor of timer_setup()

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:26:58 -0700 > This refactors the only users of init_timer_pinned() to use > the new timer_setup() and from_timer(). Drops the definition of > init_timer_pinned(). > > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: net...@vger.kernel.org > Signed-off-by:

[PATCH] staging/wilc1000: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
As part of removing the timer_list.data field, this converts the wilc1000 driver to using from_timer and an explicit per-timer data field, since there doesn't appear to be a way to sanely resolve vif from hif_drv. Cc: Aditya Shankar Cc: Ganesh Krishna Cc: Greg Kroah-Hartman Cc: linux-wireless@v

Re: [PATCH 05/13] timer: Remove init_timer_deferrable() in favor of timer_setup()

2017-10-04 Thread Sebastian Reichel
Hi, On Wed, Oct 04, 2017 at 04:26:59PM -0700, Kees Cook wrote: > This refactors the only users of init_timer_deferrable() to use > the new timer_setup() and from_timer(). Removes definition of > init_timer_deferrable(). [...] > drivers/hsi/clients/ssi_protocol.c | 32 > ++

[PATCH] net/cw1200: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Solomon Peachy Cc: Kalle Valo Cc: linux-wireless@vger.kernel.org Cc: net...@vger.kernel.org Cc: Thomas

[PATCH] net/wireless/ray_cs: Convert timers to use

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Kalle Valo Cc: linux-wireless@vger.kernel.org Cc: net...@vger.kernel.org Cc: Thomas Gleixner Signed-of

[PATCH] net/mac80211/mesh_plink: Convert timers to use

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This requires adding a pointer back to the sta_info since container_of() can't resolve the sta_info. Cc: Joh

[PATCH V2 3/8] qtnfmac: pass channel definition to WiFi card on START_AP command

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko Introduce "channel definition" TLV containing full channel description (center frequence for both segments + BW) and pass it to wireless card in a payload to START_AP command. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 9 --

[PATCH V2 6/8] qtnfmac: do not cache BSS state in per-VIF structure

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko This cached state is used only once immediately after it is initilized, except for BSSID value that is used for events processing. There is no reason in keeping unused data in driver's state. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211

[PATCH V2 7/8] qtnfmac: make encryption info a part of CONNECT command.

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko Encryption info is a constant part of STA settings, no point to pass it as an optional TLV. Remove QTN_TLV_ID_CRYPTO type as it's not used anymore. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 42 ++- drivers/net

[PATCH V2 2/8] qtnfmac: pass all AP settings to wireless card for processing

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko Modify QLINK START_AP command payload to pass all AP settings contained within struct cfg80211_ap_settings. Make most of settings a constant part of "config AP" command instead of passing it as an optional TLVs. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quante

[PATCH V2 1/8] qtnfmac: do not cache AP settings in driver structures

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko Cached AP setings are passed to WiFi card right after they are initialized and are never used for anything else. There is no point in keeping them in driver state. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 17 + drivers/n

[PATCH V2 0/8] qtnfmac: get rid of redundant state caching in driver

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko In many cases qtnfmac driver stores state info (like current channel, interface state) in driver's internal state that is either unused or duplicates information that is available elsewhere. Cleanup driver to get rid of not needed cached data. It was part of bigger changeset

[PATCH V2 4/8] qtnfmac: get rid of QTNF_STATE_AP_CONFIG

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko QTNF_STATE_AP_CONFIG is redundant and its usage can be safely removed. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 8 drivers/net/wireless/quantenna/qtnfmac/commands.c | 3 --- drivers/net/wireless/quantenna/qtnfmac/core.h

[PATCH V2 5/8] qtnfmac: get rid of QTNF_STATE_AP_START flag

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko QTNF_STATE_AP_START usage is redundant and imposes additional state synchronization maintenance. We may as well leave state checking to network card and upper layers (cfg80211, nl80211 and userspace). Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac

[PATCH V2 8/8] qtnfmac: do not cache current channel info in driver's state

2017-10-04 Thread igor . mitsyanko . os
From: Igor Mitsyanko Linux Wireless device structure already has current channel information that can be used when needed. Start using it. Since driver's channel info is not used anymore, remove it. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 7 ++-

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-04 Thread Herbert Xu
On Tue, Oct 03, 2017 at 07:45:06PM -0300, Marcelo Ricardo Leitner wrote: > > > Usually if you're invoking setkey from a non-sleeping code-path > > you're probably doing something wrong. > > Usually but not always. There are 3 calls to that function on SCTP > code: > - pack a cookie, which is sent

Re: [PATCH] PCI MSI: allow alignment restrictions on vector allocation

2017-10-04 Thread Daniel Drake
On Mon, Oct 2, 2017 at 10:38 PM, Thomas Gleixner wrote: >> After checking out the new code and thinking this through a bit, I think >> perhaps the only generic approach that would work is to make the >> ath9k driver require a vector allocation that enables the entire block >> of 4 MSI IRQs that th

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-04 Thread David Miller
From: Herbert Xu Date: Thu, 5 Oct 2017 11:40:54 +0800 > On Tue, Oct 03, 2017 at 07:45:06PM -0300, Marcelo Ricardo Leitner wrote: >> >> > Usually if you're invoking setkey from a non-sleeping code-path >> > you're probably doing something wrong. >> >> Usually but not always. There are 3 calls to

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread Greg Kroah-Hartman
On Wed, Oct 04, 2017 at 04:27:04PM -0700, Kees Cook wrote: > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ > $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) > >

[PATCH 1/2] ath10k: move ath10k_mac_tdls_vif*() functions

2017-10-04 Thread akolli
From: Anilkumar Kolli To be able to use ath10k_mac_tdls_vif_stations_count() in ath10k_hw_scan() in the following patch, move the functions earlier in the file. This commit is pure code move, no functional changes. Signed-off-by: Anilkumar Kolli --- drivers/net/wireless/ath/ath10k/mac.c | 10

[PATCH 2/2] ath10k: block offchannel operations if TDLS session is active

2017-10-04 Thread akolli
From: Anilkumar Kolli Do not allow off channel operations like scans/roc when there are active TDLS sessions. The Current firmware 10.4-3.5.1-00035 on QCA9888 does not supports any offchannel operations on active TDLS sessions, either driver needs to block the offchannel operation requests or sh

[PATCH] ath10k: fix sending wmi cmd during the tdls teardown

2017-10-04 Thread akolli
From: Anilkumar Kolli The current firmware 10.4-3.5.1-00035 on QCA9888 supports TDLS explicit mode, it expects WMI_TDLS_ENABLE_PASSIVE for tdls setup and WMI_TDLS_DISABLE for tdls teardown. Signed-off-by: Anilkumar Kolli --- drivers/net/wireless/ath/ath10k/wmi.c |3 ++- 1 file changed, 2 i

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-10-04 Thread AceLan Kao
Hi all, Please drop my patches, Qualcomm is working internally and will submit the MSI patch by themselves. Thanks. Hi Daniel, I'll try your patches tomorrow. Best regards, AceLan Kao. 2017-10-02 12:21 GMT+08:00 Daniel Drake : > Hi AceLan, > > On Thu, Sep 28, 2017 at 4:28 PM, AceLan Kao wrote

Re: [PATCH] net/mac80211/mesh_plink: Convert timers to use

2017-10-04 Thread Johannes Berg
On Wed, 2017-10-04 at 17:49 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. This requires > adding a pointer back to the sta_in

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Kalle Valo
Icenowy Zheng writes: > 于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard > 写到: >>On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: >>> On 10/4/2017 11:03 AM, Icenowy Zheng wrote: >>> > >>> > >>> > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo >>写到: >>> > > Icenowy Zheng writes: