Re: [PATCH] mac80211: aead api to reduce redundancy

2017-10-09 Thread Johannes Berg
On Sun, 2017-10-08 at 01:43 -0400, Xiang Gao wrote: > > By the way, I'm still struggling on how to run unit tests. It might > take time for me to make it run on my machine. I can run it easily, so don't worry about it too much. Running it is of course much appreciated, but I don't really want to

Re: [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread Johannes Berg
On Sat, 2017-10-07 at 13:22 +0200, Toke Høiland-Jørgensen wrote: > Guess you are right that it will be difficult to get a completely > accurate number. But as David Lang notes, as long as we are off by > the same amount for all stations, that is fine - we're just > interested in relative numbers.

pull-request: mac80211 2017-10-09

2017-10-09 Thread Johannes Berg
Hi Dave, The QCA folks found another netlink problem - we were missing validation of some attributes. It's not super problematic since one can only read a few bytes beyond the message (and that memory must exist), but here's the fix for it. I thought perhaps we can make nla_parse_nested() require

Re: [Make-wifi-fast] [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread David Lang
On Mon, 9 Oct 2017, Johannes Berg wrote: On Sat, 2017-10-07 at 13:22 +0200, Toke Høiland-Jørgensen wrote: Guess you are right that it will be difficult to get a completely accurate number. But as David Lang notes, as long as we are off by the same amount for all stations, that is fine - we're

Re: [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Sat, 2017-10-07 at 13:22 +0200, Toke Høiland-Jørgensen wrote: > >> Guess you are right that it will be difficult to get a completely >> accurate number. But as David Lang notes, as long as we are off by >> the same amount for all stations, that is fine - we're just >> i

[PATCH v2 1/4] cfg80211: support loading regulatory database as firmware file

2017-10-09 Thread Johannes Berg
From: Johannes Berg As the current regulatory database is only about 4k big, and already difficult to extend, we decided that overall it would be better to get rid of the complications with CRDA and load the database into the kernel directly, but in a new format that is extensible. The new file

[PATCH v2 4/4] cfg80211: implement regdb signature checking

2017-10-09 Thread Johannes Berg
From: Johannes Berg Currently CRDA implements the signature checking, and the previous commits added the ability to load the whole regulatory database into the kernel. However, we really can't lose the signature checking, so implement it in the kernel by loading a detached signature (regulatory.

[PATCH v2 2/4] cfg80211: support reloading regulatory database

2017-10-09 Thread Johannes Berg
From: Johannes Berg If the regulatory database is loaded, and then updated, it may be necessary to reload it. Add an nl80211 command to do this. Note that this just reloads the database, it doesn't re-apply the rules from it immediately. Signed-off-by: Johannes Berg --- include/uapi/linux/nl8

[PATCH v2 0/4] built-in regulatory database

2017-10-09 Thread Johannes Berg
Here's a new version of these patches, hopefully the final. I changed the database format to make it smaller * dropping antenna gain limitation (never used in db.txt) * make CAC timeout in seconds, and optional * change length fields to u8 * change n_rules field to u8 * re-pack those flags tha

[PATCH v2 3/4] cfg80211: reg: remove support for built-in regdb

2017-10-09 Thread Johannes Berg
From: Johannes Berg Parsing and building C structures from a regdb is no longer needed since the "firmware" file (regulatory.db) can be linked into the kernel image to achieve the same effect. Signed-off-by: Johannes Berg --- Documentation/networking/regulatory.txt | 22 + net/wireless/Kc

[PATCH] regdb: write firmware file format (version code 20)

2017-10-09 Thread Johannes Berg
From: Johannes Berg TODO: clean up the Makefile stuff ... Signed-off-by: Johannes Berg --- Makefile | 53 - README | 4 +- db2fw.py | 133 +++ 3 files changed, 160 insertions(+), 30 deletions(-) create mo

Re: [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread Johannes Berg
On Mon, 2017-10-09 at 11:42 +0200, Toke Høiland-Jørgensen wrote: > Well, the padding and spacing between frames is at most 11 bytes (4- > byte delimiter, 4-byte FCS and 3-byte padding), which is ~0.7% of a > full-sized frame. I'm not too worried about errors on that scale, > TBH. I'm not sure - t

Re: [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Mon, 2017-10-09 at 11:42 +0200, Toke Høiland-Jørgensen wrote: > >> Well, the padding and spacing between frames is at most 11 bytes (4- >> byte delimiter, 4-byte FCS and 3-byte padding), which is ~0.7% of a >> full-sized frame. I'm not too worried about errors on that s

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

2017-10-09 Thread Ralf Baechle
On Wed, Oct 04, 2017 at 04:27:03PM -0700, Kees Cook wrote: > Subject: [PATCH 09/13] timer: Remove users of expire and data arguments to > DEFINE_TIMER > > The expire and data arguments of DEFINE_TIMER are only used in two places > and are ignored by the code (malta-display.c only uses mod_timer(

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-09 Thread Ralf Baechle
On Wed, Oct 04, 2017 at 04:27:04PM -0700, Kees Cook wrote: > Subject: [PATCH 10/13] timer: Remove expires and data arguments from > DEFINE_TIMER > > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIME

Re: [PATCH V2 0/8] qtnfmac: get rid of redundant state caching in driver

2017-10-09 Thread Sergey Matyukevich
> In many cases qtnfmac driver stores state info (like current channel, > interface state) in driver's internal state that is either unused or > duplicates information that is available elsewhere. Cleanup driver > to get rid of not needed cached data. > > It was part of bigger changeset when it wa

Re: [PATCH 0/3] linux-firmware: ath10k update 20170918

2017-10-09 Thread Ben Hutchings
On Mon, 2017-09-18 at 18:00 +0300, Kalle Valo wrote: > Few firmware fixes to user reported issues for ath10k, but the other "fix" > being a revert back to older firmware. Also a small board-2.bin update. I've applied this series, thanks. Ben. > Kalle Valo (3): > ath10k: QCA6174 hw3.0: update f

Re: pull-request: mac80211 2017-10-09

2017-10-09 Thread David Miller
From: Johannes Berg Date: Mon, 9 Oct 2017 09:40:12 +0200 > The QCA folks found another netlink problem - we were missing validation > of some attributes. It's not super problematic since one can only read a > few bytes beyond the message (and that memory must exist), but here's the > fix for it.

usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). I'm not sure whether this is a bug in the driver, or just a way to report misbehaving device. In the latter case this shouldn't be a WARN() call, since WARN()

usb/net/rtlwifi: trying to register non-static key in rtl_c2hcmd_launcher

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 24 Comm: kw

usb/nfs/pn533: use-after-free in pn533_send_complete

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). usb 1-1: NFC: Can't submit reader poweron cmd response -90 pn533_usb 1-1:6.1: NFC: Couldn't poweron the reader (error -90) pn533_usb: probe of 1-1:6.1 failed

usb/net/ath6kl: GPF in ath6kl_usb_alloc_urb_from_pipe

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). usb 1-1: New USB device found, idVendor=0cf3, idProduct=9375 usb 1-1: New USB device strings: Mfr=2, Product=255, SerialNumber=8 usb 1-1: Product: a usb 1-1:

usb/net/ar5523: warning in ar5523_submit_rx_cmd/usb_submit_urb

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). It seems that the driver doesn't check the endpoint type provided in the USB descriptor. usb 1-1: BOGUS urb xfer, pipe 3 != type 1 [ cut here ]--

Re: [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread Johannes Berg
Hi, > Right, but most of these are constant values that are straight > forward to add as long as you know how the frame was received, no? > Maybe not as a general function in mac80211, but the driver should be > able to perform a reasonable computation in the absence of > information from the hard

Re: [RFC] mac80211: Add airtime fairness accounting

2017-10-09 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > Hi, > >> Right, but most of these are constant values that are straight >> forward to add as long as you know how the frame was received, no? >> Maybe not as a general function in mac80211, but the driver should be >> able to perform a reasonable computation in the absence

[PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread Kees Cook
Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc: Ganesh Krishna Cc: Greg Kroah-Hartman Cc: Jen

Re: [PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread David Miller
From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc: Krzysztof Halasa > Cc:

Re: pull-request: iwlwifi 2017-10-06

2017-10-09 Thread Kalle Valo
Luca Coelho writes: > Here is the second set of fixes for 4.14. More details in the tag > description. > > I have sent this out before and kbuildbot didn't find any issues. > Please let me know if there are any issues. > > Cheers, > Luca. > > > The following changes since commit c503dd38f850be2

Contributing to Linux-wireless drivers.

2017-10-09 Thread Himanshu Jha
- Forwarded message from Himanshu Jha - Date: Fri, 6 Oct 2017 02:05:39 +0530 From: Himanshu Jha To: kv...@codeaurora.org Subject: Contributing to Linux-wireless drivers. User-Agent: Mutt/1.5.24 (2015-08-30) Hi Kalle, I am an undergraduate student in ECE(3rd year) and wish to contribut

[PATCH 0/2] ath10k: more on tdls support for 10.4 firmwares

2017-10-09 Thread mpubbise
From: Manikanta Pubbisetty This patchset includes a bug fix and an enhancement of tdls functionality for 10.4 firmwares. First patch in this series is a bug fix, second one is an enhancement. Manikanta Pubbisetty (2): ath10k: update tdls teardown state to target ath10k: handle tdls peer eve

[PATCH 1/2] ath10k: update tdls teardown state to target

2017-10-09 Thread mpubbise
From: Manikanta Pubbisetty It is required to update the teardown state of the peer when a tdls link with that peer is terminated. This information is useful for the target to perform some cleanups wrt the tdls peer. Without proper cleanup, target assumes that the peer is connected and blocks fut

[PATCH 2/2] ath10k: handle tdls peer events

2017-10-09 Thread mpubbise
From: Manikanta Pubbisetty Handle tdls peer events from the target. TDLS events for the peer could be discover, teardown, etc. As of now, adding the logic to handle tdls teardown events alone. Teardown due to peer traffic indication(PTR) timeout is one such teardown event from the target. Teste