Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

Kees Cook writes: > On Tue, Oct 17, 2017 at 7:18 AM, Kalle Valo wrote: >> + linux-wireless >> >> Hi Kees, >> >> Kees Cook writes: >> >>> This is the current set of outstanding networking patches to perform >>> conversions to

Re: Two rtlwifi drivers?

Pkshih writes: >> My recommendation is to avoid accumulating patches at all cost and start >> submitting them as soon as you can. This way you get patches committed >> much more smoother. So do not wait until _all_ patches are ready, >> instead start submitting patches as

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

Luca Coelho writes: > On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: >> On Tue, Oct 17, 2017 at 05:05:57PM +0300, Luca Coelho wrote: >> > Hi, >> > >> > On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN wrote: >> > > Was broken in 4.11, still broken in 4.12. This is

Re: [PATCH v6 1/3] dt-bindings: net: add mt76 wireless device binding

On Sat, Oct 14, 2017 at 10:43 AM, Christian Lamparter wrote: > On Saturday, October 14, 2017 9:20:46 AM CEST Felix Fietkau wrote: >> On 2017-10-13 21:07, Rob Herring wrote: >> > On Fri, Oct 06, 2017 at 01:02:47PM +0200, Felix Fietkau wrote: >> >> Add documentation describing

[PATCH] ath10k: Fix offchannel tx failure when no ath10k_mac_tx_frm_has_freq

From: Ben Greear This bug appears to have been added between 4.0 (which works for us), and 4.4, which does not work. I think this is because the tx-offchannel logic gets in a loop when ath10k_mac_tx_frm_has_freq(ar) is false, so pkt is never actually sent to the

Re: iwlwifi crash with hostapd

On Tue, Oct 17, 2017 at 09:35:39PM +0200, Mario Theodoridis wrote: > On 16.10.2017 05:37, James Cameron wrote: > >On Sun, Oct 15, 2017 at 06:21:36PM +0200, Mario Theodoridis wrote: > >>Thanks for the pointers, James. > >> > >>On 12.10.2017 23:24, James Cameron wrote: > >>>There's a good chance

[PATCH] net: mac80211: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in some cases I replaced "fall through on else" and "otherwise fall through" comments with just a "fall through" comment, which is what GCC is expecting to find.

Re: using verifier to ensure a BPF program uses certain metadata?

On Mon, Oct 16, 2017 at 09:38:44AM +0200, Johannes Berg wrote: > Hi, > > As we discussed in April already (it's really been that long...), I'd > wanted to allow using BPF to filter wireless monitor frames, to enable > new use cases and higher performance in monitoring. I have some code, > at > >

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: > On Tue, Oct 17, 2017 at 05:05:57PM +0300, Luca Coelho wrote: > > Hi, > > > > On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN wrote: > > > Was broken in 4.11, still broken in 4.12. This is crippling, I'm > > > not > > > running linux so that I

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

On Tue, Oct 17, 2017 at 05:05:57PM +0300, Luca Coelho wrote: > Hi, > > On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN wrote: > > Was broken in 4.11, still broken in 4.12. This is crippling, I'm not > > running linux so that I have to reboot it to reload an intel wireless > > driver :-/ > > Can

[PATCH] mac80211: aggregation: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This removes the tid mapping array and expands the tid structures to add a pointer back to the station,

[PATCH] cfg80211: fix connect/disconnect edge cases

From: Johannes Berg If we try to connect while already connected/connecting, but this fails, we set ssid_len=0 but leave current_bss hanging, leading to errors. Check all of this better, first of all ensuring that we can't try to connect to a different SSID while

[PATCH] nl80211: don't expose wdev->ssid for most interfaces

From: Johannes Berg For mesh, this is simply wrong - there's no SSID, only the mesh ID, so don't expose it at all. For (P2P) client, it's wrong, because it exposes an internal value that's only used when certain APIs are used. For AP, it's actually the only correct case,

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

On Tue, Oct 17, 2017 at 7:18 AM, Kalle Valo wrote: > + linux-wireless > > Hi Kees, > > Kees Cook writes: > >> This is the current set of outstanding networking patches to perform >> conversions to the new timer interface (rebased to -next). This is

Re: iwlwifi crash with hostapd

On 16.10.2017 05:37, James Cameron wrote: On Sun, Oct 15, 2017 at 06:21:36PM +0200, Mario Theodoridis wrote: Thanks for the pointers, James. On 12.10.2017 23:24, James Cameron wrote: There's a good chance this problem has been fixed already. You are using a v4.4 kernel with many patches

[PATCH] libertas: don't write wdev->ssid/_len

From: Johannes Berg When joining an IBSS network, wdev->ssid/_len will already be set, so there's no need to write them. In any case, they are internal cfg80211 values, and have very little user-visible impact. Signed-off-by: Johannes Berg ---

[PATCH] wil6210: remove wil6210_uapi.h from MAINTAINERS

From: Johannes Berg This file doesn't exist. Signed-off-by: Johannes Berg --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3944f1626911..7051e2ae9971 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH] wil6210: remove SSID debugfs

From: Johannes Berg This driver shouldn't be using wdev->ssid to start with, as it's more or less an internal field in cfg80211 used for various purposes. Reading it is possible through nl80211, even if that's not really what we should be doing there for anything but AP

[PATCH] mac80211: use constant time comparison with keys

Otherwise we risk leaking information via timing side channel. Fixes: fdf7cb4185b6 ("mac80211: accept key reinstall without changing anything") Signed-off-by: Jason A. Donenfeld --- net/mac80211/key.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: pull-request: mac80211 2017-10-16

On Tue, Oct 17, 2017 at 7:46 AM, Johannes Berg wrote: > If it's not equal, you execute so much code > beneath, going to the driver etc., that I'd think this particular time > is in the noise. Usually presumptions like this get you in trouble when some crafty academic

Re: [PATCH v2] ath10k: Retry pci probe on failure.

On 10/17/2017 01:45 AM, Kalle Valo wrote: Ben Greear writes: On 10/13/2017 08:50 AM, Adrian Chadd wrote: On 13 October 2017 at 05:41, Kalle Valo wrote: gree...@candelatech.com writes: From: Ben Greear This works

Re: Commit 0711d638 breaks mwifiex

On Tue, Oct 17, 2017 at 11:10 PM, Johannes Berg wrote: > Hi, > >> > > https://p.sipsolutions.net/8f9d5917a5cbe4b3.txt >> > > >> > > Can you also give that a spin? > > Thanks for testing! > >> > Issued four reassociate, the network interface is still alive. Also >> >

Re: Commit 0711d638 breaks mwifiex

Hi, > > > https://p.sipsolutions.net/8f9d5917a5cbe4b3.txt > > > > > > Can you also give that a spin? Thanks for testing! > > Issued four reassociate, the network interface is still alive. Also > > with this patch it stays with BSSID1 and I don't see any > > "Association request to the driver

Re: bcma: use bcma_debug and pr_cont in MIPS driver

Rafał Miłecki wrote: > From: Rafał Miłecki > > Using bcma_debug gives a device-specific prefix for messages and pr_cont > is a common helper for continuing a line. > > Signed-off-by: Rafał Miłecki > Acked-By: Hauke Mehrtens Patch applied

Re: rtlwifi: Fix typo in if ... else if ... else construct

Larry Finger wrote: > The kbuild test robot reports two conditions with no effect (if == else). > These are the result of copy and paste typographical errors. > > Signed-off-by: Larry Finger > Cc: Ping-Ke Shih > Cc:

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

+ linux-wireless Hi Kees, Kees Cook writes: > This is the current set of outstanding networking patches to perform > conversions to the new timer interface (rebased to -next). This is not > all expected conversions, but it contains everything needed in networking > to

Re: Help with bug "Black screen freeze on suspend to ram (rtl8188ee)"

On 10/17/2017 09:03 AM, Lauro Costa wrote: Dear maintainer, I have opened a bug report on bugzilla [1] regarding this issue I find when I attempt to suspend to ram, unfortunately no one has replied to me yet. I assumed this issue is related to the driver rtl8188ee since the black screen

Re: Commit 0711d638 breaks mwifiex

On Tue, Oct 17, 2017 at 10:08 PM, Jesse Sung wrote: > On Tue, Oct 17, 2017 at 9:13 PM, Johannes Berg > wrote: >> >> On Tue, 2017-10-17 at 21:07 +0800, Jesse Sung wrote: >> > >> > > Not really quite sure about it yet, but that should address

Re: Commit 0711d638 breaks mwifiex

On Tue, Oct 17, 2017 at 9:13 PM, Johannes Berg wrote: > > On Tue, 2017-10-17 at 21:07 +0800, Jesse Sung wrote: > > > > > Not really quite sure about it yet, but that should address the > > > issue? > > > > A very rough test by issuing reassociate in wpa_cli: > > mwifiex

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

Hi, On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN wrote: > Was broken in 4.11, still broken in 4.12. This is crippling, I'm not > running linux so that I have to reboot it to reload an intel wireless > driver :-/ Can you report a bug in https://bugzilla.kernel.org so it's easier to track this?

Re: Commit 0711d638 breaks mwifiex

On Tue, 2017-10-17 at 21:07 +0800, Jesse Sung wrote: > > > Not really quite sure about it yet, but that should address the > > issue? > > A very rough test by issuing reassociate in wpa_cli: > mwifiex works after reassociate - looks good Ok. Discussing this with Ilan, we realized that this was

Re: Commit 0711d638 breaks mwifiex

On Tue, Oct 17, 2017 at 6:48 PM, Johannes Berg wrote: > On Tue, 2017-10-17 at 18:18 +0800, Jesse Sung wrote: > >> > Does mwifiex treat this -EALREADY as *keeping* an old connection, >> > or tearing it down entirely? >> >> From the call trace: > > Well, the call trace

Re: AP6335 with mainline kernel

Hi Arend, On Qui, 2017-09-21 at 12:30 -0300, Vanessa Ayumi Maegima wrote: > Hi Arend, > > On Thu, Sep 21, 2017 at 4:26 AM, Arend van Spriel > wrote: > > > > On 20-09-17 21:33, Vanessa Ayumi Maegima wrote: > > > > > > > > > Hi, > > > > > > I am trying to enable

Re: Commit 0711d638 breaks mwifiex

On Tue, 2017-10-17 at 18:18 +0800, Jesse Sung wrote: > > Does mwifiex treat this -EALREADY as *keeping* an old connection, > > or tearing it down entirely? > > From the call trace: Well, the call trace can't really answer that :-) Does mwifiex firmware stay connected? > 139.451318:

Re: Commit 0711d638 breaks mwifiex

Hi Johannes, On Tue, Oct 17, 2017 at 5:51 PM, Johannes Berg wrote: > Hi, > >> While working on an issue that marvell module stops connecting to AP, >> bisect reveals that the issue starts to happen from commit 0711d638, >> which uses wdev->ssid_len instead of

Re: [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs

Johannes Berg writes: > On Tue, 2017-10-17 at 09:34 +0200, Toke Høiland-Jørgensen wrote: > >> Yeah, I did that initially. The reason I ended up squashing them is >> that >> this patch moved the per-station 'airtime' debugfs-entry that was >> previously created by ath9k

Re: [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs

On Tue, 2017-10-17 at 09:34 +0200, Toke Høiland-Jørgensen wrote: > Yeah, I did that initially. The reason I ended up squashing them is > that > this patch moved the per-station 'airtime' debugfs-entry that was > previously created by ath9k into mac80211. I assumed it would create > problems if

Re: Commit 0711d638 breaks mwifiex

Hi, > While working on an issue that marvell module stops connecting to AP, > bisect reveals that the issue starts to happen from commit 0711d638, > which uses wdev->ssid_len instead of wdev->current_bss to determine > if driver's .disconnect() should be called. > > It happens because

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

Was broken in 4.11, still broken in 4.12. This is crippling, I'm not running linux so that I have to reboot it to reload an intel wireless driver :-/ I currently have: -rw-rw-r-- 1 merlin merlin 1745176 Jun 18 2015 /lib/firmware/iwlwifi-8000C-13.ucode -rw-r--r-- 1 root root 2345768 Dec 6

RE: [2/2] ath10k: handle tdls peer events

>This patch introduces new warnings: > >$ ath10k-check >drivers/net/wireless/ath/ath10k/wmi.c:4470:39: warning: incorrect type in >argument 2 (different base types) >drivers/net/wireless/ath/ath10k/wmi.c:4470:39:expected int [signed] >vdev_id >drivers/net/wireless/ath/ath10k/wmi.c:4470:39:

Commit 0711d638 breaks mwifiex

Hi, While working on an issue that marvell module stops connecting to AP, bisect reveals that the issue starts to happen from commit 0711d638, which uses wdev->ssid_len instead of wdev->current_bss to determine if driver's .disconnect() should be called. It happens because

Re: [PATCH v2] ath10k: Retry pci probe on failure.

Ben Greear writes: > On 10/13/2017 08:50 AM, Adrian Chadd wrote: >> On 13 October 2017 at 05:41, Kalle Valo wrote: >>> gree...@candelatech.com writes: >>> From: Ben Greear This works around a problem we

Re: [PATCH] wireless: qtnfmac: Convert timers to use timer_setup()

> In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Igor Mitsyanko > Cc: Avinash Patil > Cc:

Re: [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs

Johannes Berg writes: >> Only ath9k currently sets the AIRTIME_ACCOUNTING flag. > > I think you should actually make that a separate patch. > > In the previous patch that's not possible or it breaks things, but > this patch just adds a new feature that drivers _may_

Re: [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs

> Only ath9k currently sets the AIRTIME_ACCOUNTING flag. I think you should actually make that a separate patch. In the previous patch that's not possible or it breaks things, but this patch just adds a new feature that drivers _may_ use, they don't have to since it doesn't change the API, so

Re: [PATCH 1/2] mac80211: Add TXQ scheduling API

> /* protects shared structure data */ > spinlock_t data_lock; > - /* protects: ar->txqs, artxq->list */ > - spinlock_t txqs_lock; > > - struct list_head txqs; I don't see you removing the artxq->list member, but surely it can't be used any more now, without a list?

Re: [PATCH] iw: add command to register and capture mgmt frames

> Maybe we could add an additional nl attribute to > NL80211_CMD_REGISTER_FRAME command to allow applications to > advertise > what is their intention, something like > NL80211_ATTR_MGMT_LISTENER_TYPE. > Only allow to register more then one listener if it explicitly > specifies > that it will