[PATCH V2] bcma: Use bcma_debug and not pr_cont in MIPS driver

Commit 66cc04424960 ("bcma: use bcma_debug and pr_cont in MIPS driver") converted a printk(KERN_DEBUG to bcma_debug. bcma_debug is guarded by a #define DEBUG via pr_debug. This means that the bcma_debug will generally not be emitted but any pr_cont following the bcma_debug will be emitted.

Re: [PATCH] bcma: Use bcma_debug and not pr_cont in MIPS driver

On Wed, Oct 18, 2017 at 10:12:18PM -0700, Joe Perches wrote: > Commit 66cc04424960 ("bcma: use bcma_debug and pr_cont in MIPS driver") > converted a printk(KERN_DEBUG to bcma_debug. > > bcma_debug is guarded by a #define DEBUG via pr_debug. > > This means that the bcma_debug will generally not

[PATCH] bcma: Use bcma_debug and not pr_cont in MIPS driver

Commit 66cc04424960 ("bcma: use bcma_debug and pr_cont in MIPS driver") converted a printk(KERN_DEBUG to bcma_debug. bcma_debug is guarded by a #define DEBUG via pr_debug. This means that the bcma_debug will generally not be emitted but any pr_cont following the bcma_debug will be emitted.

Re: [PATCH] bcma: use bcma_debug and pr_cont in MIPS driver

Joe Perches writes: > On Mon, 2017-10-16 at 23:21 +0200, Hauke Mehrtens wrote: >> On 10/16/2017 02:54 PM, Rafał Miłecki wrote: >> > From: Rafał Miłecki >> > >> > Using bcma_debug gives a device-specific prefix for messages and pr_cont >> > is a common helper

Re: rtlwifi oops

On 10/18/2017 08:40 PM, nirinA wrote: i checked my dmesg and have this similar log, i think when i unplugged the device. [ 5640.100541] usb 2-1.4: USB disconnect, device number 5 [ 5640.104108] rtl_usb: reg 0x102, usbctrl_vendorreq TimeOut! status:0xffed value=0x0 [ 5640.104110] rtl_usb:

Re: [PATCH] bcma: use bcma_debug and pr_cont in MIPS driver

On Mon, 2017-10-16 at 23:21 +0200, Hauke Mehrtens wrote: > On 10/16/2017 02:54 PM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > Using bcma_debug gives a device-specific prefix for messages and pr_cont > > is a common helper for continuing a line. > > > > Signed-off-by:

Re: rtlwifi oops

i checked my dmesg and have this similar log, i think when i unplugged the device. [ 5640.100541] usb 2-1.4: USB disconnect, device number 5 [ 5640.104108] rtl_usb: reg 0x102, usbctrl_vendorreq TimeOut! status:0xffed value=0x0 [ 5640.104110] rtl_usb: reg 0x422, usbctrl_vendorreq TimeOut!

Re: rtlwifi oops

On 10/18/2017 06:18 PM, nirinA wrote: not really a rtlwifi oops then. maybe issue with udev as that also disabled the usb mouse. but i have no problem since. i will report if i will catch it again. thanks, -- nirinA James Cameron wrote: On Thu, Oct 19, 2017 at 01:31:43AM +0300, nirinA

Re: [PATCH V6 0/5] Add TDLS feature for ath10k

On 10/15/2017 11:00 PM, yint...@qti.qualcomm.com wrote: From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Please add your patchset history here until V6. That's what cover letter is supposed to have. Yingying Tang (5):

Re: rtlwifi oops

not really a rtlwifi oops then. maybe issue with udev as that also disabled the usb mouse. but i have no problem since. i will report if i will catch it again. thanks, -- nirinA James Cameron wrote: On Thu, Oct 19, 2017 at 01:31:43AM +0300, nirinA wrote: hello there, i got the oops below

Re: [PATCH] staging: wilc1000: replace redundant computations with 0

On Tue, 2017-10-10 at 15:05 +0100, Colin King wrote: > From: Colin Ian King > > Shifting and masking strHostIfSetMulti->enabled is redundant since > enabled is a bool and so all the shifted and masked values will be > zero. Replace them with zero to simplify the code. >

Re: rtlwifi oops

On Thu, Oct 19, 2017 at 01:31:43AM +0300, nirinA wrote: > hello there, > i got the oops below with a rtl8192cu:0bda:8178 and kernel 4.13.6, but > cannot reproduce it. > i use this device since 4.3 or so without noticing any issue. > > nirinA > > [ 239.338040] usb 2-1.3: new high-speed USB

rtlwifi oops

hello there, i got the oops below with a rtl8192cu:0bda:8178 and kernel 4.13.6, but cannot reproduce it. i use this device since 4.3 or so without noticing any issue. nirinA [ 239.338040] usb 2-1.3: new high-speed USB device number 4 using ehci-pci [ 239.417728] usb 2-1.3: New USB device

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

On 10/18/2017 02:02 PM, Johannes Berg wrote: On Wed, 2017-10-18 at 13:51 -0700, Ben Greear wrote: " I guess you could implement this part? I.e. iterating the clients and checking that they all support the rate that is set. However, then you also need to implement that this gets reset when a new

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

On Wed, Oct 18, 2017 at 1:50 PM, Johannes Berg wrote: > On Wed, 2017-10-18 at 07:19 -0700, Kees Cook wrote: >> On Wed, Oct 18, 2017 at 3:29 AM, Johannes Berg >> wrote: >> > > This has been the least trivial timer conversion yet. Given the use

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

On Wed, 2017-10-18 at 13:51 -0700, Ben Greear wrote: > " > I guess you could implement this part? I.e. iterating the clients and > checking that they all support the rate that is set. However, then you > also need to implement that this gets reset when a new client that > doesn't support this rate

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

On 10/18/2017 01:34 PM, Johannes Berg wrote: Hi, On Wed, 2017-10-18 at 19:56 +0200, Oleksij Rempel wrote: People trying to do regulatory testing want this feature, and other people that are not me also like to test with specific rates. Still a small-ish set of people, but bigger than just

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

On Wed, 2017-10-18 at 07:19 -0700, Kees Cook wrote: > On Wed, Oct 18, 2017 at 3:29 AM, Johannes Berg > wrote: > > > This has been the least trivial timer conversion yet. Given the use of > > > RCU and other things I may not even know about, I'd love to get a close > > >

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

Hi, On Wed, 2017-10-18 at 19:56 +0200, Oleksij Rempel wrote: > > > People trying to do regulatory testing want this feature, and other people > > that are not me also like to test with specific rates. Still a > > small-ish set of people, but bigger than just me at least. > > Till now i was

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

On Tue, Oct 17, 2017 at 10:44 PM, Kalle Valo wrote: > Kees Cook writes: >> Which split is preferred? I had been trying to separate wireless from >> the rest of net (but missed some cases). > > So what we try to follow is that I apply all patches for >

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

Am 18.10.2017 um 16:50 schrieb Ben Greear: On 10/18/2017 12:33 AM, Johannes Berg wrote: Hi, The call to set the rate in the driver comes before the error check. if (ieee80211_hw_check(>hw, HAS_RATE_CONTROL)) {     ret = drv_set_bitrate_mask(local, sdata, mask);     if (ret) {   

Re: using verifier to ensure a BPF program uses certain metadata?

On Wed, Oct 18, 2017 at 08:56:31AM +0200, Johannes Berg wrote: > > > Now, I realize that people could trivially just work around this in > > > their program if they wanted, but I think most will take the > > > reminder > > > and just implement > > > > > > if (ctx->is_data_ethernet) > > >

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

On 10/18/2017 12:33 AM, Johannes Berg wrote: Hi, The call to set the rate in the driver comes before the error check. if (ieee80211_hw_check(>hw, HAS_RATE_CONTROL)) { ret = drv_set_bitrate_mask(local, sdata, mask); if (ret) {

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

On Wed, Oct 18, 2017 at 3:29 AM, Johannes Berg wrote: >> This has been the least trivial timer conversion yet. Given the use of >> RCU and other things I may not even know about, I'd love to get a close >> look at this. I *think* this is correct, as it will re-lookup

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

On Wed, Oct 18, 2017 at 4:37 AM, Johannes Berg wrote: > On Wed, 2017-10-18 at 13:31 +0200, Johannes Berg wrote: >> On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote: >> >> > Anyway, the change here looks correct to me, so I'll apply it and then >> > perhaps clean

Re: wireless-regdb: Update regulatory rules for Kazakhstan (KZ) on 5GHz

On Wed, Oct 18, 2017 at 02:26:17PM +0300, Андрей Иванов wrote: > Please add support for 5 GHz in Kazakhstan > (5170 - 5250 @ 80), (20), AUTO-BW > (5250 - 5330 @ 80), (20), DFS, AUTO-BW > (5650 - 5730 @ 80), (30), DFS > (5735 - 5835 @ 80), (30) We got a very similar

[PATCH] mac80211: avoid looking up tid_tx/tid_rx from timers

From: Johannes Berg There's no need to re-lookup the data structures now that we actually get them immediately with from_timer(), just avoid that. The struct has to be valid anyway, otherwise the timer object itself would no longer be valid, and we can't have a different

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

On Wed, 2017-10-18 at 13:31 +0200, Johannes Berg wrote: > On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote: > > > Anyway, the change here looks correct to me, so I'll apply it and then > > perhaps clean up more. I've only changed "u16 tid" to "u8 tid" since > > the valid range is 0-15 (in

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote: > Anyway, the change here looks correct to me, so I'll apply it and then > perhaps clean up more. I've only changed "u16 tid" to "u8 tid" since > the valid range is 0-15 (in theory, in practice 0-7). Well, I guess I'm clearly wrong - it's

Re: [PATCH] netlink: fix netlink_ack() extack race

From: Johannes Berg Date: Mon, 16 Oct 2017 17:09:53 +0200 > From: Johannes Berg > > It seems that it's possible to toggle NETLINK_F_EXT_ACK > through setsockopt() while another thread/CPU is building > a message inside netlink_ack(), which

Re: [PATCH] netlink: use NETLINK_CB(in_skb).sk instead of looking it up

From: Johannes Berg Date: Mon, 16 Oct 2017 16:57:49 +0200 > From: Johannes Berg > > When netlink_ack() reports an allocation error to the sending > socket, there's no need to look up the sending socket since > it's available in the SKB's CB.

pull-request: iwlwifi-next 2017-10-18

Hi Kalle, Here's the second batch of patches intended for v4.15. It contains the last patch set I send out with v2 of the lq_color patch. I have sent this out before and kbuildbot reported success. Please let me know if there are any issues. Cheers, Luca. The following changes since commit

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

Hi, [quoting your other email:] > This has been the least trivial timer conversion yet. Given the use of > RCU and other things I may not even know about, I'd love to get a close > look at this. I *think* this is correct, as it will re-lookup the tid > entries when firing the timer. I'm not

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

On Wed, 2017-10-18 at 12:50 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > On Wed, 2017-10-18 at 07:59 +0300, Kalle Valo wrote: > > > Luca Coelho writes: > > > > > > > On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: > > > > > > > > > I don't know

Re: [PATCH] fq_impl: Properly enforce memory limit

On Mon, 2017-10-16 at 17:05 +0200, Toke Høiland-Jørgensen wrote: > The fq structure would fail to properly enforce the memory limit in > the case > where the packet being enqueued was bigger than the packet being > removed to > bring the memory usage down. So keep dropping packets until the >

Re: [PATCH] mac80211: use constant time comparison with keys

On Tue, 2017-10-17 at 20:32 +0200, Jason A. Donenfeld wrote: > Otherwise we risk leaking information via timing side channel. > Applied. johannes

Re: [PATCH] wil6210: disallow changing RSN in beacon change

Hi, > This is not dead code, we reach it in several scenarios, mainly WPS > tests. Interesting. > hostapd uses change_beacon to change the security of the AP so this > needs to be supported. I didn't think this made sense - Jouni? Does hostapd kick off all stations in this case? > We do need

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

Luca Coelho writes: > On Wed, 2017-10-18 at 07:59 +0300, Kalle Valo wrote: >> Luca Coelho writes: >> >> > On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: >> > >> > > I don't know how or why, but I seem to: >> > > saruman:~# grep IWLWIFI

pull-request: wireless-drivers-next 2017-10-18

Hi Dave, this for 4.15 stream to net-next tree. Please let me know if there are any problems. Kalle The following changes since commit 3e747fa18202896b5be66b88478352d5880fb8eb: Merge ath-current from ath.git (2017-09-25 10:06:12 +0300) are available in the git repository at:

Re: [PATCH] wil6210: disallow changing RSN in beacon change

Hi Johannes, On 10/17/2017 10:42 PM, Johannes Berg wrote: > From: Johannes Berg > > This is a code path that will never really get hit anyway, since > it's nonsense to change the beacon of an existing BSS to suddenly > include or no longer include the RSN IE. Reject

[PATCH] mac80211: validate user rate mask before configuring driver

From: Johannes Berg Ben reported that when the user rate mask is rejected for not matching any basic rate, the driver had already been configured. This is clearly an oversight in my original change, fix this by doing the validation before calling the driver.

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

Hi, > The call to set the rate in the driver comes before the error > check. > > if (ieee80211_hw_check(>hw, HAS_RATE_CONTROL)) { > ret = drv_set_bitrate_mask(local, sdata, mask); > if (ret) { > pr_err("%s: drv-set-bitrate-mask had error >

Re: using verifier to ensure a BPF program uses certain metadata?

Hi Alexei, > > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next > > .git/log/?h=bpf > > bpf bits looks pretty straightforward. Thanks for looking at this! > attach looks fine too. I'm assuming there is some rtnl or other lock, > so multiple assigns cannot race? Yes. > It's

Re: [PATCH v6 1/3] dt-bindings: net: add mt76 wireless device binding

On 2017-10-18 04:02, Rob Herring wrote: > On Sat, Oct 14, 2017 at 10:43 AM, Christian Lamparter > wrote: >> On Saturday, October 14, 2017 9:20:46 AM CEST Felix Fietkau wrote: >>> On 2017-10-13 21:07, Rob Herring wrote: >>> > On Fri, Oct 06, 2017 at 01:02:47PM +0200, Felix

[PATCH v2 7/9] iwlwifi: mvm: add missing lq_color

From: Liad Kaufman In the compressed BA notif, the driver didn't parse out the LQ color, so statistics for the rates tried were always thrown out. Add it so it gets correctly used. While at it, fix the name of the relevant field in the struct. Fixes: c46e7724bfe9

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

On Wed, 2017-10-18 at 07:59 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: > > > On Tue, Oct 17, 2017 at 05:05:57PM +0300, Luca Coelho wrote: > > > > Hi, > > > > > > > > On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN