Re: [PATCH] mwifiex: cancel pcie/sdio work in remove/shutdown handler

Brian Norris writes: >> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c >> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c >> @@ -310,6 +310,8 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev) >> mwifiex_init_shutdown_fw(priv,

Re: [PATCH] ath9k: add a quirk to set use_msi automatically

AceLan Kao writes: > Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI > for WLAN device. So adding a quirk to list those machines and set > use_msi automatically. > Adding the following platforms to the quirk. >Dell Inspiron 24-3460 >Dell

Question on stopping ath dmesg output spam

First off thank you to all of you for your work in letting me run linux on my system! It really is greatly appreciated! It has come a long ways from the early 90's due to everyone sharing their skills and contributing. Sadly the below is driving me nuts for some reason and I am at a loss on how to

[PATCH] ath9k: add a quirk to set use_msi automatically

Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI for WLAN device. So adding a quirk to list those machines and set use_msi automatically. Adding the following platforms to the quirk. Dell Inspiron 24-3460 Dell Inspiron 3472 Dell Inspiron 14-3473 Dell Vostro 3262

[PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with usleep_range, to reduce busy wait. Signed-off-by: Jia-Ju Bai --- v2: * Replace mdelay with usleep_range, instead of msleep in v1. Thank

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

On 2018/1/9 0:31, Larry Finger wrote: On 01/08/2018 10:21 AM, Kalle Valo wrote: Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait.

Re: [v2] ath9k: add MSI support

Hi Kalle, I'm happy to see Russel's patch can be merged, and I'm willing to rebase and merge those quirks into one commit and submit it again. Although the solution is not perfect, but it's nice to have. Thanks. Best regards, AceLan Kao. 2018-01-09 7:07 GMT+08:00 Daniel Drake

[PATCH] ath10k: add sanity check to ie_len before parsing fw/board ie

From: Ryan Hsu Validate ie_len after the alignment padding before access the buffer to avoid potential overflow. Signed-off-by: Ryan Hsu --- drivers/net/wireless/ath/ath10k/core.c | 13 +++-- 1 file changed, 7 insertions(+), 6

Re: [v2] ath9k: add MSI support

On Mon, Jan 8, 2018 at 6:24 AM, Kalle Valo wrote: > (Adding AceLan) > > Daniel Drake writes: > >> On Wed, Nov 15, 2017 at 7:38 AM, Daniel Drake wrote: >>> On Tue, Nov 14, 2017 at 8:15 PM, Kalle Valo wrote:

[PATCH] wireless: broadcom: radio_2056: delete duplicated macro definitions

Ctrl-V was hit twice when these macros were inserted: $ sed -n '9,527p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum 4db53450c59d9939e903d4e4ba6bc9b1 - $ sed -n '528,1046p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum 4db53450c59d9939e903d4e4ba6bc9b1 - Signed-off-by:

[PATCH v2] brcmfmac: Use zeroing memory allocator than allocator/memset

Use dma_zalloc_coherent for allocating zeroed memory and remove unnecessary memset function. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by: Luis R. Rodriguez Signed-off-by: Himanshu Jha --- v2: -corrected the

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

* Alan Cox wrote: > On Mon, 8 Jan 2018 11:08:36 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > > wrote: >

Re: [1/2] mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action()

> Lorenzo Bianconi writes: > >>> Lorenzo Bianconi wrote: >>> Initialize mt76_txq pointer after ieee80211_txq pointer check. Remove space after the pointer cast Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")

Re: brcmfmac: Use zeroing memory allocator than allocator/memset

On Mon, Jan 08, 2018 at 05:23:22PM +, Kalle Valo wrote: > Himanshu Jha wrote: > > > Use dma_zalloc_coherent for allocating zeroed > > memory and remove unnecessary memset function. > > > > Done using Coccinelle. > > Generated-by:

Re: [1/2] mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action()

Lorenzo Bianconi writes: >> Lorenzo Bianconi wrote: >> >>> Initialize mt76_txq pointer after ieee80211_txq pointer check. >>> Remove space after the pointer cast >>> >>> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") >>>

Re: [PATCH] mwifiex: cancel pcie/sdio work in remove/shutdown handler

Hi, On Wed, Dec 13, 2017 at 07:27:53PM +0800, Xinming Hu wrote: > The last command used to shutdown firmware might be timeout, > and trigger firmware dump in asynchronous pcie/sdio work. > > The remove/shutdown handler will continue free core data > structure private/adapter, which might be

Re: [1/2] mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action()

> Lorenzo Bianconi wrote: > >> Initialize mt76_txq pointer after ieee80211_txq pointer check. >> Remove space after the pointer cast >> >> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") >> Signed-off-by: Lorenzo Bianconi > >

Re: [linux-next] rt2x00: Fix a typo in printk

Masanari Iida wrote: > This patch fix a typo in rt2800lib.c > > Signed-off-by: Masanari Iida > Acked-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks. 83476cd5871c rt2x00: Fix a typo in printk --

Re: wl1251: check return from call to wl1251_acx_arp_ip_filter

Colin Ian King wrote: > From: Colin Ian King > > Currently the less than zero error check on ret is incorrect > as it is checking a far earlier ret assignment rather than the > return from the call to wl1251_acx_arp_ip_filter. Fix this by >

Re: [1/2] rt2x00: pause almost full queue early

Stanislaw Gruszka wrote: > Do not drop >tx_lock and acquire it again to pause queue when > available entries are below the threshold. > > Patch should mitigate problem of frequently printed errors: > "Error - Dropping frame due to full tx queue" > > Signed-off-by:

Re: mwifiex: cancel pcie/sdio work in remove/shutdown handler

Xinming Hu wrote: > The last command used to shutdown firmware might be timeout, > and trigger firmware dump in asynchronous pcie/sdio work. > > The remove/shutdown handler will continue free core data > structure private/adapter, which might be dereferenced in > pcie/sdio

Re: [v5, 1/3] mwifiex: refactor device dump code to make it generic for usb interface

Xinming Hu wrote: > This patch refactor current device dump code to make it generic > for subsequent implementation on usb interface. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo > Signed-off-by: Ganapathi Bhat

Re: [1/2] mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action()

Lorenzo Bianconi wrote: > Initialize mt76_txq pointer after ieee80211_txq pointer check. > Remove space after the pointer cast > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi What am I

Re: [PATCH] mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

Kalle Valo writes: > Colin Ian King writes: > >> On 14/12/17 10:46, Lorenzo Bianconi wrote: >>> Fix typo in 5GHz power vs channel eeprom parsing >>> >>> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") >>> Signed-off-by: Lorenzo Bianconi

Re: mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

Lorenzo Bianconi wrote: > Fix typo in 5GHz power vs channel eeprom parsing > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi > Acked-by: Felix Fietkau > Reported-by: Colin

Re: mt76: fix memcpy to potential null pointer on failed allocation

Colin Ian King wrote: > From: Colin Ian King > > Currently if the allocation of skb fails and returns NULL then the > call to skb_put will cause a null pointer dereference. Fix this by > checking for a null skb and returning NULL. Note that

Re: [04/14] mt76x2: fix transmission of encrypted management frames

Felix Fietkau wrote: > Hardware encryption seems to break encrypted unicast mgmt tx. > Unfortunately the hardware TXWI header does not have a bit to indicate > that a frame is software encrypted, so sw-encrypted frames need to use a > different WCID. For that to work, the CCMP PN

Re: [01/14] mt76: fix debugfs_simple_attr.cocci warnings

Felix Fietkau wrote: > From: Fengguang Wu > > drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for

Re: brcmfmac: Use zeroing memory allocator than allocator/memset

Himanshu Jha wrote: > Use dma_zalloc_coherent for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day tested with no failures. > > Suggested-by: Luis

Re: [v2] brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

Wright Feng wrote: > From: Double Lo > > This patch will add 43455 into the save-restore(SR) capable chip list, so > the SR engine will be enabled with 43455 FW which built-in the -sr > function. > > Signed-off-by: Double Lo

Re: [09/11] brcmfmac: Remove array of functions

Arend Van Spriel wrote: > Replace the array of functions with a pair of pointers to the > relevant functions. > > Signed-off-by: Ian Molton > Acked-by: Arend van Spriel > Signed-off-by: Arend van Spriel

Re: [01/11] brcmfmac: Remove {r,w}_sdreg32

Arend Van Spriel wrote: > From: Ian Molton > > Remove yet another IO function from the code and replace with one > that already exists. > > Signed-off-by: Ian Molton > Reviewed-by: Arend van Spriel

Re: [01/11] MAINTAINERS: Change maintainer for rtlwifi

Ping-Ke Shih wrote: > From: Larry Finger > > This section is also modified to include the entire rtlwifi family, > not just RTL8192CE. > > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry Finger

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

Larry Finger writes: > On 01/08/2018 10:21 AM, Kalle Valo wrote: >> Jia-Ju Bai wrote: >> >>> b43_radio_2057_init_post is not called in an interrupt handler >>> nor holding a spinlock. >>> The function mdelay in it can be replaced with msleep,

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

On 01/08/2018 10:21 AM, Kalle Valo wrote: Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai You submitted an identical

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On 01/05/18 22:30, Dan Williams wrote: On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman wrote: Please expand this. It is not clear what the static analysis is looking for. Have a clear description of what is being fixed is crucial for allowing any of these changes.

Re: Drivers:RTLWIFI:rtl8723ae: add the function name to the printouts

venkat.prashanth2...@gmail.com wrote: > From: Venkat Prashanth B U > > This is a patch to rtl8723ae/trx.c file that adds the > function name to the printouts. > > Signed-off-by: Venkat Prashanth B U The title is wrong:

Re: rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 29 Dec 2017 22:11:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > >

Re: [v2] ath9k: add MSI support

On Mon, Jan 8, 2018 at 2:24 PM, Kalle Valo wrote: > (Adding AceLan) > > Daniel Drake writes: > >> On Wed, Nov 15, 2017 at 7:38 AM, Daniel Drake wrote: >>> On Tue, Nov 14, 2017 at 8:15 PM, Kalle Valo wrote:

RE: [RFC v3 03/11] ath10k: per target configurablity of various items

>> A good point, I didn't thought of that during review. No time to investigate >> this right now, but maybe Rakesh and Govind (CCed) can comment? Yes, ar->max_num_peers needs to be assigned with ar->hw_param->num_peers. This can create mismatch for wcn3990 target if we create multiple peers(

Re: [RFC v3 03/11] ath10k: per target configurablity of various items

Erik Stromdahl writes: > On 2017-12-22 16:19, Kalle Valo wrote: > >> I was a bit torn about this, I definitely see the need for this but on >> the other hand it creates duplicate data (for example two entries for >> QCA9377 chip). I guess this is the right approach, at

Re: [PATCH 03/11] ath10k_sdio: DMA bounce buffers for read write

Alagu Sankar writes: > On 2017-12-22 21:38, Kalle Valo wrote: >> silexcom...@gmail.com writes: >> >>> From: Alagu Sankar >>> >>> Some SD host controllers still need bounce buffers for SDIO data >>> transfers. While the transfers worked

Re: [v2] ath9k: add MSI support

(Adding AceLan) Daniel Drake writes: > On Wed, Nov 15, 2017 at 7:38 AM, Daniel Drake wrote: >> On Tue, Nov 14, 2017 at 8:15 PM, Kalle Valo wrote: Can't be fixed in firmware, but it would be good to have confirmation of

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Mon, Jan 08, 2018 at 11:43:42AM +, Alan Cox wrote: > On Mon, 8 Jan 2018 11:08:36 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > >

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Mon, 8 Jan 2018 11:08:36 +0100 Peter Zijlstra wrote: > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > wrote: > > > In at least one place (mpls) you are patching a fast

RE: Mailbox authentication Updates!!

We are asking all Outlook users to update their security Info due to recent security incidents online. Starting from 8-1-2018 you wont be able to log in to your Outlook Account. This is for your own safety to continue using your Outlook account, and upgrade, to our Latest security Server

Re: brcmfmac: set p2p_disc error on BCM4350

Hello Arend, Thanks for your quick answer. On Mon, Jan 08, 2018 at 10:31:52AM +0100, Arend van Spriel wrote: > This has been reported before, but not been able to look into it. Diving > into firmware it seems that error can only occur if the mac address for the > p2pdev interface is already

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > wrote: > > In at least one place (mpls) you are patching a fast path. Compile out > > or don't load mpls by all means. But it is not acceptable to change

Re: brcmfmac: set p2p_disc error on BCM4350

On 1/8/2018 12:49 AM, William Dauchy wrote: Hello, Using the last v4.14.x I am getting this error at each boot, on my BCM4350 802.11ac Wireless Network Adapter: brcmfmac: brcmf_p2p_create_p2pdev: set p2p_disc error brcmfmac: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp58s0 type 10 failed: