Re: testing tool for packet delay

2018-02-20 Thread Toke Høiland-Jørgensen
Steve deRosier writes: > On Mon, Feb 19, 2018 at 9:19 AM, sdnlabs Janakaraj > wrote: >> >> Hello All, >> >> I am working on delay analysis of packets in wireless stacks. I am >> able to see lots of papers talk about therotical analysis. But I am >> more interested in practical evaluation. >> >>

[4.4-stable 17/22] cw1200: fix bogus maybe-uninitialized warning

2018-02-20 Thread Arnd Bergmann
commit 7fc1503c906f0fac62d3506a6e993e49fb996248 upstream. On x86, the cw1200 driver produces a rather silly warning about the possible use of the 'ret' variable without an initialization presumably after being confused by the architecture specific definition of WARN_ON: drivers/net/wireless/st/cw

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Bo YU
Hi, On Tue, Feb 20, 2018 at 08:32:59AM +0100, s.gottsch...@dd-wrt.com wrote: From: Sebastian Gottschall Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based chipsets with on chipset connected led's using WMI Firmware API. The LED device will get available named as "ath10k-p

Re: [v7 3/8] rsi: add header file rsi_91x

2018-02-20 Thread Kalle Valo
Hi Dave and Johannes, a question to both of you below: Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > The common parameters used by wlan and bt modules are add > to a new header file "rsi_91x.h" defined in 'include/net' > > Signed-off-by: Prameela Rani Garnepudi > Signed-off-by:

[RFC PATCH 2/2] net: rfkill: gpio: Convert driver to SerDev

2018-02-20 Thread Carlo Caione
From: Carlo Caione With commit e361d1f85855 ("ACPI / scan: Fix enumeration for special UART devices") UART devices are now expected to be enumerated by SerDev subsystem. This is breaking the enumeration of platform devices connected to the UART without a proper SerDev support, like in the rfkill-

[RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Carlo Caione
From: Carlo Caione Hi, this patch came after investigating why the rfkill-gpio driver was failing on the latest kernel on a machine I have. Sending this out as RFC because I'm still not sure if this is the right way to approach this problem. I was honestly expecting not to see the platform device

[RFC PATCH 1/2] net: rfkill: gpio: Fix NULL pointer deference

2018-02-20 Thread Carlo Caione
From: Carlo Caione In the rfkill_gpio code the variable type_name is not initialized and it can point to a spurious memory location. When device_property_read_string is not able to locate the string we are passing to rfkill_find_type this random pointer, causing a NULL pointer dereference when us

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Hans de Goede
Hi Carlo, Is this for devices with a RTL8723BS chip? If so then they still will not work after this since there also no longer is a /dev/ttyS4 created for the UART for the bluetooth, instead you probably want: https://github.com/jwrdegoede/linux-sunxi/commit/c383dac5ea00738ac01d704d820aa548494fc

Re: [RFC PATCH 2/2] net: rfkill: gpio: Convert driver to SerDev

2018-02-20 Thread Marcel Holtmann
Hi Carlo, > With commit e361d1f85855 ("ACPI / scan: Fix enumeration for special UART > devices") UART devices are now expected to be enumerated by > SerDev subsystem. This is breaking the enumeration of platform devices > connected to the UART without a proper SerDev support, like in the > rfkill-

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Marcel Holtmann
Hi Hans, > Is this for devices with a RTL8723BS chip? If so then they > still will not work after this since there also no longer is > a /dev/ttyS4 created for the UART for the bluetooth, instead > you probably want: > it is not for that hardware, it is for some GPS devices. static const struct

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Carlo Caione
On Tue, Feb 20, 2018 at 2:01 PM, Hans de Goede wrote: > Hi Carlo, Hi Hans, > Is this for devices with a RTL8723BS chip? If so then they > still will not work after this since there also no longer is > a /dev/ttyS4 created for the UART for the bluetooth, instead > you probably want: > > https://g

Re: [RFC PATCH 2/2] net: rfkill: gpio: Convert driver to SerDev

2018-02-20 Thread Carlo Caione
On Tue, Feb 20, 2018 at 2:04 PM, Marcel Holtmann wrote: > Hi Carlo, Hi Marcel, >> With commit e361d1f85855 ("ACPI / scan: Fix enumeration for special UART >> devices") UART devices are now expected to be enumerated by >> SerDev subsystem. This is breaking the enumeration of platform devices >> c

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Sebastian Gottschall
+struct ath10k_gpiocontrol { +    struct ath10k *ar; +    u32 gpio_set_num, gpio_num, gpio_input, gpio_pull_type, gpio_intr_mode, gpio_set; /* since we have no gpio read method, these are the state variables for debugfs.  */ I think the checkpatch.pl will complain above defintely. Best rega

[PATCH 1/2] ath9k: Fix airtime calculation for quarter/half channels

2018-02-20 Thread Wojciech Dubowik
The bitrate value for airtime calculation is specified for full rates. We need to divide it for 5 and 10MHz channels to get correct result. Signed-off-by: Wojciech Dubowik --- drivers/net/wireless/ath/ath9k/hw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[PATCH 2/2] ath9k: Fix ack SIFS time for quarter/half channels

2018-02-20 Thread Wojciech Dubowik
Ack timing generation has to be adapted for 5/10 MHz channels. Do it by properly initializing ack shift field in TXSIFS register. Ack shift assumes channel width of 2.5 Hhz so value zero means 2.5 MHz, 1 is 5 MHz and so on. Signed-off-by: Wojciech Dubowik --- drivers/net/wireless/ath/ath9k/hw.c

Re: [PATCH 2/2] ath9k: Fix ack SIFS time for quarter/half channels

2018-02-20 Thread Kalle Valo
Wojciech Dubowik writes: > Ack timing generation has to be adapted for 5/10 MHz channels. > Do it by properly initializing ack shift field in TXSIFS > register. Ack shift assumes channel width of 2.5 Hhz so Is this supposed to be MHz? I can fix that during commit, no need to resend just because

Re: [PATCH 2/2] ath9k: Fix ack SIFS time for quarter/half channels

2018-02-20 Thread Kalle Valo
+ linux-wireless Wojciech Dubowik writes: > Yes in MHz. Please always reply in public (Cc linux-wireless) so that it goes to the mailing list and patchwork. > Sorry, got distracted. No problem. -- Kalle Valo

[PATCH 05/12] staging: wilc1000: rename Handle_SetMulticastFilter to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c inde

[PATCH 03/12] staging: wilc1000: rename variables using camelCase in handle_rcvd_ntwrk_info()

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 45 +++ 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wi

[PATCH 07/12] staging: wilc1000: rename pstrStatistics to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid caseCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_

[PATCH 09/12] staging: wilc1000: rename pstrDelStaParam to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 08/12] staging: wilc1000: rename strDisconnectNotifInfo to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/

[PATCH 11/12] staging: wilc1000: rename _WPAPtk_end_case_ label to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c inde

[PATCH 12/12] staging: wilc1000: rename _WPARxGtk_end_case_ label to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c inde

[PATCH 10/12] staging: wilc1000: rename pstrStationParam to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 46 +++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wi

[PATCH 00/12] staging: wilc1000: fixes to avoid use of camelCase in host interface

2018-02-20 Thread Ajay Singh
This patch series contains fixes for "Avoid camelCase" issues found by checkpatch.pl script. Ajay Singh (12): staging: wilc1000: rename pu8HdnNtwrksWidVal to avoid camelCase staging: wilc1000: rename ptstrJoinBssParam to avoid camelCase staging: wilc1000: rename variables using camelCase in

[PATCH 01/12] staging: wilc1000: rename pu8HdnNtwrksWidVal to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c in

[PATCH 04/12] staging: wilc1000: rename pu32InactiveTime to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 02/12] staging: wilc1000: rename ptstrJoinBssParam to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 78 +++ 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wi

[PATCH 06/12] staging: wilc1000: rename pstrSetBeaconParam to avoid camelCase

2018-02-20 Thread Ajay Singh
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 51 +++ 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wi

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Marcel Holtmann
Hi Carlo, >> Is this for devices with a RTL8723BS chip? If so then they >> still will not work after this since there also no longer is >> a /dev/ttyS4 created for the UART for the bluetooth, instead >> you probably want: >> >> https://github.com/jwrdegoede/linux-sunxi/commit/c383dac5ea00738ac01d

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Hans de Goede
Hi, On 02/20/2018 03:36 PM, Carlo Caione wrote: On Tue, Feb 20, 2018 at 2:01 PM, Hans de Goede wrote: Hi Carlo, Hi Hans, Is this for devices with a RTL8723BS chip? If so then they still will not work after this since there also no longer is a /dev/ttyS4 created for the UART for the bluetoo

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Steve deRosier
Hi Sebastian, On Mon, Feb 19, 2018 at 11:32 PM, wrote: > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based > chipsets with on chipset connected led's > using WMI Firmware API. > The LED device will get available named as "ath10k-phyX" at sy

Re: [RFC v4 3/6] nl80211: Implement TX of control port frames

2018-02-20 Thread Denis Kenzior
Hi Johannes, On 02/19/2018 06:44 AM, Johannes Berg wrote: On Wed, 2018-01-31 at 19:04 -0600, Denis Kenzior wrote: + switch (wdev->iftype) { + case NL80211_IFTYPE_STATION: + if (wdev->current_bss) + break; + err = -ENOTCONN; +

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Sebastian Gottschall
Am 20.02.2018 um 17:52 schrieb Steve deRosier: +static int ath10k_register_gpio_chip(struct ath10k *ar) +{ + struct ath10k_gpiocontrol *gpio; + gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL); + if (!gpio) { + return -ENOMEM; + } + + snp

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Steve deRosier
On Tue, Feb 20, 2018 at 10:06 AM, Sebastian Gottschall wrote: > Am 20.02.2018 um 17:52 schrieb Steve deRosier: >> >> >>> +static int ath10k_register_gpio_chip(struct ath10k *ar) >>> +{ >>> + struct ath10k_gpiocontrol *gpio; >>> + gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KE

Re: [PATCH v7] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread Sebastian Gottschall
Agreed, I am also not a fan of bloat code. I wasn't suggesting you move it to the .h, just saying that if it were not static, that's how I'd suggest doing it. In this case, keep it static, keep it in the .c. And use the blocking I suggested. You will get the optimizer friendly result you're lo

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Martin Blumenstingl
Hello Jeremy, Hello Hans, On Tue, Feb 20, 2018 at 5:15 PM, Hans de Goede wrote: > Hi, > > On 02/20/2018 03:36 PM, Carlo Caione wrote: >> >> On Tue, Feb 20, 2018 at 2:01 PM, Hans de Goede >> wrote: >>> >>> Hi Carlo, >> >> >> Hi Hans, >> >>> Is this for devices with a RTL8723BS chip? If so then th

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Jeremy Cline
Hi Martin, On 02/20/2018 03:26 PM, Martin Blumenstingl wrote: > Hello Jeremy, Hello Hans, > > On Tue, Feb 20, 2018 at 5:15 PM, Hans de Goede wrote: >> Hi, >> >> On 02/20/2018 03:36 PM, Carlo Caione wrote: >>> >>> On Tue, Feb 20, 2018 at 2:01 PM, Hans de Goede >>> wrote: Hi Carlo, >>>

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-20 Thread Carlo Caione
On Tue, Feb 20, 2018 at 9:18 PM, Jeremy Cline wrote: > Great, thanks for all the info! I'll definitely keep you CC'ed on my > progress. I'm still very new to kernel development so I expect it'll > take me quite a while, but I do have a fair bit of time to devote to > this. Welcome to this crazy

Re: testing tool for packet delay

2018-02-20 Thread sdnlabs Janakaraj
Hello Toke, Thanks for sharing this information. I took a look at Flent yesterday and planning to test it by the weekend due to something things I have to catch up with. On Tue, Feb 20, 2018 at 6:13 AM, Toke Høiland-Jørgensen wrote: > Steve deRosier writes: > >> On Mon, Feb 19, 2018 at 9:19 A

Re: testing tool for packet delay

2018-02-20 Thread Toke Høiland-Jørgensen
sdnlabs Janakaraj writes: > Hello Toke, > Thanks for sharing this information. > > I took a look at Flent yesterday and planning to test it by the > weekend due to something things I have to catch up with. Awesome! Let me know if you run into any problems :) -Toke

[PATCH v8] ath10k: add LED and GPIO controlling support for various chipsets

2018-02-20 Thread s . gottschall
From: Sebastian Gottschall Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based chipsets with on chipset connected led's using WMI Firmware API. The LED device will get available named as "ath10k-phyX" at sysfs and can be controlled with various triggers. adds also debugfs i