Re: [PATCH v2] ath10k: Implement get_expected_throughput callback

Hi Anilkumar, On 03/27/2018 11:37 PM, Sven Eckelmann wrote: On Mittwoch, 28. März 2018 11:41:51 CEST ako...@codeaurora.org wrote: [...] The rate average and throughput are relative. no? Can you share the output number from your new function? It may help us to understand a little bit more how

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

Hi Carl, On Fri, Mar 30, 2018 at 11:14:00AM +0800, Carl Huang wrote: > The ath10k reports the random_mac_addr capability to upper layer > based on the service bit firmware reported. Driver sets the > spoofed flag in scan_ctrl_flag to firmware if upper layer has > enabled this feature in scan

Re: second wifi card enforce CN reg dom

It seems you are already pissed off, but could you please reply inline instead of top posting. Its a drag to scroll up and down. On 4/12/2018 7:05 PM, solsTiCe d'Hiver wrote: Hi. I thought I made myself clear. I leave in France. My system(s) is/are set up to use FR as default regulatory

Re: [PATCH] ANDROID: mac80211_hwsim: support/ignore power state changes

On Thu, 2018-04-12 at 17:04 +, Roman Kiryanov wrote: > Hi Kalle, > > thank you for reviewing our patch. I am ok with applying this patch without > "ANDROID:" prefix. Do you want me to send an updated patch? I can fix it up. johannes

Re: second wifi card enforce CN reg dom

On 4/12/2018 5:52 PM, Dan Williams wrote: On Thu, 2018-04-12 at 08:18 -0700, Steve deRosier wrote: On Thu, Apr 12, 2018 at 3:51 AM, Arend van Spriel wrote: On 4/12/2018 10:42 AM, solsTiCe d'Hiver wrote: Hi. This is beyond my comprehension that you could assert

Re: [PATCH] ath9k: introduce endian_check module parameter

Hello Bas, On Tue, Apr 10, 2018 at 11:05 AM, Bas Vermeulen wrote: > On 14-03-18 15:34, Kalle Valo wrote: >> >> Bas Vermeulen writes: >> >>> --- a/drivers/net/wireless/ath/ath9k/init.c >>> +++ b/drivers/net/wireless/ath/ath9k/init.c >>>

Re: second wifi card enforce CN reg dom

On Thu, Apr 12, 2018 at 10:25 AM, solsTiCe d'Hiver wrote: > It's the second time that you (Ben and Steve) are implying that I > might break the law. > No implication intended. All I said is regulatory operation is constrained by laws in various jurisdictions. And how

Re: second wifi card enforce CN reg dom

On 04/12/2018 10:25 AM, solsTiCe d'Hiver wrote: It's the second time that you (Ben and Steve) are implying that I might break the law. But why are you saying that ? I am not gonna repeat myself again. If you force the NIC to use a different regulatory domain that what it originally was tested

Re: second wifi card enforce CN reg dom

It's the second time that you (Ben and Steve) are implying that I might break the law. But why are you saying that ? I am not gonna repeat myself again. And for the patch, it is also implied that I am able to write one. 2018-04-12 19:11 GMT+02:00 Ben Greear : > On

Re: second wifi card enforce CN reg dom

On 04/12/2018 10:05 AM, solsTiCe d'Hiver wrote: Hi. I thought I made myself clear. I leave in France. My system(s) is/are set up to use FR as default regulatory domain. But when I plug in that tp-link card, I am restricted to use CN regulatory domain. Why am I the only one to see this as a

Re: second wifi card enforce CN reg dom

Hi. I thought I made myself clear. I leave in France. My system(s) is/are set up to use FR as default regulatory domain. But when I plug in that tp-link card, I am restricted to use CN regulatory domain. Why am I the only one to see this as a problem ? I know that one can only have one regdom

Re: [PATCH] ANDROID: mac80211_hwsim: support/ignore power state changes

Hi Kalle, thank you for reviewing our patch. I am ok with applying this patch without "ANDROID:" prefix. Do you want me to send an updated patch? Regards, Roman. On Wed, Apr 11, 2018 at 9:23 PM Kalle Valo wrote: > r...@google.com writes: > > From: Bjoern Johansson

[PATCH] NFC: fix attrs checks in netlink interface

nfc_genl_deactivate_target() relies on the NFC_ATTR_TARGET_INDEX attribute being present, but doesn't check whether it is actually provided by the user. Same goes for nfc_genl_fw_download() and NFC_ATTR_FIRMWARE_NAME. This patch adds appropriate checks. Found with syzkaller. Signed-off-by:

Re: second wifi card enforce CN reg dom

On Thu, 2018-04-12 at 08:18 -0700, Steve deRosier wrote: > On Thu, Apr 12, 2018 at 3:51 AM, Arend van Spriel > wrote: > > On 4/12/2018 10:42 AM, solsTiCe d'Hiver wrote: > > > > > > Hi. > > > > > > This is beyond my comprehension that you could assert this is a > >

[PATCH] ath6kl: use WMI to set RSN capabilities

This fixes AP mode when the ATH6KL_FW_CAPABILITY_RSN_CAP_OVERRIDE flag is not present in the FW. The id of some WMI commands is also fixed (there was an error in the enum order), and a function to set RSN caps is added. Signed-off-by: Alfonso Sánchez-Beato

Re: second wifi card enforce CN reg dom

On Thu, Apr 12, 2018 at 3:51 AM, Arend van Spriel wrote: > On 4/12/2018 10:42 AM, solsTiCe d'Hiver wrote: >> >> Hi. >> >> This is beyond my comprehension that you could assert this is a non issue. > > > Well. I am just saying that it is by design. There is no way for

Re: [PATCH 1/1 RFC] wcn36xx: fix buffer commit logic on TX path

On 11 April 2018 at 15:37, Daniel Mack wrote: > Hi Loic, > > On Wednesday, April 11, 2018 03:30 PM, Loic Poulain wrote: >>> /* Move the head of the ring to the next empty descriptor */ >>> -ch->head_blk_ctl = ctl->next; >>> +ch->head_blk_ctl =

Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

Daniel Mack writes: >>> Yeah, sorry. I did that intentionally, but missed to mention it in the >>> commit log. >> >> I can add that to the commit log, just tell me what to add. > > I'll resend, hang on :) Even better, thanks. -- Kalle Valo

[PATCH v2] wcn36xx: pass correct BSS index when deleting BSS keys

The firmware message to delete BSS keys expects a BSS index to be passed. This field is currently hard-coded to 0. Fix this by passing in the index we received from the firmware when the BSS was configured. The encryption type in that message also needs to be set to what was used when the key was

[PATCH] ath10k: correct target assert problem due to CE5 stuck

From: Manikanta Pubbisetty Correct a minor bug in the commit 0628467f97b5 ("ath10k: fix copy engine 5 destination ring stuck") which introduced a change to fix firmware assert that happens when ring indices of copy engine 5 are stuck for a specific duration, problem with

Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

On Thursday, April 12, 2018 02:14 PM, Kalle Valo wrote: > Daniel Mack writes: > >> On Thursday, April 12, 2018 01:46 PM, Loic Poulain wrote: >>> Hi Daniel, >>> @@ -564,10 +565,13 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,

[PATCH] ath10k: correct target assert problem due to CE5 stuck

From: Manikanta Pubbisetty Correct a minor bug in the commit 0628467f97b5 ("ath10k: fix copy engine 5 destination ring stuck") which introduced a change to fix firmware assert that happens when ring indices of copy engine 5 are stuck for a specific duration, problem with

Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

Daniel Mack writes: > On Thursday, April 12, 2018 01:46 PM, Loic Poulain wrote: >> Hi Daniel, >> >>> @@ -564,10 +565,13 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, >>> enum set_key_cmd cmd, >>> break; >>> case DISABLE_KEY: >>>

Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

On Thursday, April 12, 2018 01:46 PM, Loic Poulain wrote: > Hi Daniel, > >> @@ -564,10 +565,13 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, >> enum set_key_cmd cmd, >> break; >> case DISABLE_KEY: >> if (!(IEEE80211_KEY_FLAG_PAIRWISE &

Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

Hi Daniel, > @@ -564,10 +565,13 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, > enum set_key_cmd cmd, > break; > case DISABLE_KEY: > if (!(IEEE80211_KEY_FLAG_PAIRWISE & key_conf->flags)) { > + if (vif_priv->bss_index != >

[PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

The firmware message to delete BSS keys expects a BSS index to be passed. This field is currently hard-coded to 0. Fix this by passing in the index we received from the firmware when the BSS was configured. Also, AFAIU, when a BSS is deleted, the firmware apparently drops all the keys associated

Re: second wifi card enforce CN reg dom

On 4/12/2018 10:42 AM, solsTiCe d'Hiver wrote: Hi. This is beyond my comprehension that you could assert this is a non issue. Well. I am just saying that it is by design. There is no way for the regulatory code to determine where you and your hardware actually reside so instead it takes a

[PATCH] staging: wilc1000: fix NULL pointer exception in host_int_parse_assoc_resp_info()

Commit fe014d4e6b55 (staging: wilc1000: free memory allocated for general info message from firmware) introduced a bug by using wrong source address in kmemdup(). 'conn_info.req_ies' is used for source address in kempdup() instead of 'hif_drv->usr_conn_req.ies'. This commit fixes the NULL pointer

Re: [PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block

On 12.04.2018 10:59, Eyal Ilsar wrote: > Remove unnecessary braces {} around an 'if' statement block with a single > statement. Issue found by checkpatch. > > Signed-off-by: Eyal Ilsar Reviewed-by: Claudiu Beznea > --- > Added an empty line

[PATCH 04/10] wil6210: fix call to wil6210_disconnect during unload

From: Lior David Move the call to wil6210_disconnect so it will be called before unregister_netdevice. This is because it calls netif_carrier_off which is forbidden to call on an unregistered net device. Calling netif_carrier_off can add a link watch event which might be

[PATCH 02/10] wil6210: set/get EDMG channel through debugfs

From: Alexei Avshalom Lazar Setting EDMG channel through debugfs for connect and PCP start commands. Signed-off-by: Alexei Avshalom Lazar Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/cfg80211.c | 89

[PATCH 05/10] wil6210: change reply_size arg to u16 in wmi_call

From: Lior David Change the type of the argument reply_size from u8 to u16 in order to support reply sizes > 255 bytes. The driver already supports u16 reply size in all other places, this was the only missing change. Signed-off-by: Lior David

[PATCH 09/10] wil6210: remove unused rx_reorder members

From: Dedy Lansky Remove unused members from struct wil_tid_ampdu_rx Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/debugfs.c| 3 +--

[PATCH 06/10] wil6210: use country specific board file upon reg domain change

From: Dedy Lansky wil6210 device needs to use country specific board file while in China regulatory domain. Register cfg80211 reg_notifier and switch board file if needed according to new regulatory domain. This feature is disabled by default and can be enabled with a new

[PATCH 10/10] wil6210: rate limit wil_rx_refill error

From: Dedy Lansky wil_err inside wil_rx_refill can flood the log buffer. Replace it with wil_err_ratelimited. Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/txrx.c | 4 ++-- 1 file

[PATCH 08/10] wil6210: Initialize reply struct of the WMI commands

From: Alexei Avshalom Lazar WMI command reply saved in uninitialized struct. In order to avoid accessing unset values from FW initialize the reply struct. Signed-off-by: Alexei Avshalom Lazar Signed-off-by: Maya Erez ---

[PATCH 01/10] wil6210: disable tracing config option

From: Alexei Avshalom Lazar Disable WIL6210_TRACING by default to avoid its performance overhead. Signed-off-by: Alexei Avshalom Lazar Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/Kconfig | 2 +- 1 file

[PATCH 07/10] wil6210: move WMI functionality out of wil_cfg80211_mgmt_tx

From: Dedy Lansky Rearrange the code by having new function wmi_mgmt_tx() to take care of the WMI part of wil_cfg80211_mgmt_tx(). Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez ---

[PATCH 03/10] wil6210: align to latest auto generated wmi.h

From: Ahmad Masri Align to latest version of the auto generated wmi file describing the interface with FW Signed-off-by: Ahmad Masri Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/wmi.c | 6 +-

[PATCH 00/10] wil6210 patches

The following patches include multiple wil6210 fixes. Ahmad Masri (1): wil6210: align to latest auto generated wmi.h Alexei Avshalom Lazar (3): wil6210: disable tracing config option wil6210: set/get EDMG channel through debugfs wil6210: Initialize reply struct of the WMI commands Dedy

[PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block

Remove unnecessary braces {} around an 'if' statement block with a single statement. Issue found by checkpatch. Signed-off-by: Eyal Ilsar --- Added an empty line before the 'Signed-off-by' line and a space between the name and e-mail address within that line.

Re: [PATCH] ath10k:add support for multicast rate control

On Mittwoch, 11. April 2018 21:04:46 CEST Pradeep Kumar Chitrapu wrote: > Issues wmi command to firmware when multicast rate change is received > with the new BSS_CHANGED_MCAST_RATE flag. [...] > > + if (changed & BSS_CHANGED_MCAST_RATE && > + !WARN_ON(ath10k_mac_vif_chan(arvif->vif,

[PATCH 00/10] wil6210 patches

The following patches include multiple wil6210 fixes. Ahmad Masri (1): wil6210: align to latest auto generated wmi.h Alexei Avshalom Lazar (2): wil6210: disable tracing config option wil6210: set/get EDMG channel through debugfs Dedy Lansky (4): wil6210: use country specific board file

Re: second wifi card enforce CN reg dom

On 4/12/2018 9:00 AM, solsTiCe d'Hiver wrote: Nobody cares about this ? Should I report this as a bug to the LKML ? or elsewhere ? to ath9k_htc dev ? to crda dev ? Please. Hi, I do not think nobody cares, but what you describe is actually no issue as far as I can determine. Wifi cards are

Re: [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block

On 10.04.2018 17:49, Eyal Ilsar wrote: > Remove unnecessary braces {} around an 'if' statement block with a single > statement. Issue found by checkpatch. You should add an empty line before "Signed-off" line as stated in [1]. I would also add a space b/w your name and your email in Signed-off

Re: second wifi card enforce CN reg dom

Nobody cares about this ? Should I report this as a bug to the LKML ? or elsewhere ? to ath9k_htc dev ? to crda dev ? Please. 2018-04-10 21:57 GMT+02:00 solsTiCe d'Hiver : > hi. > > I am trying to capture on 2 channels at the same time with 2 cards. > > One card is