[PATCH v4 2/2] drivers: remove force dma flag from buses

2018-04-27 Thread Nipun Gupta
With each bus implementing its own DMA configuration callback, there is no need for bus to explicitly have force_dma in its global structure. This patch modifies of_dma_configure API to accept an input parameter which specifies if implicit DMA configuration is required even when it is not

[PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure

2018-04-27 Thread Nipun Gupta
It is bus specific aspect to map a given device on the bus and relevant firmware description of its DMA configuration. So, this change introduces 'dma_configure' as bus callback giving flexibility to busses for implementing its own dma configuration function. The change eases the addition of new

[PATCH] nl80211: Reject disconnect commands except from conn_owner

2018-04-27 Thread Andrew Zaborowski
Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands from clients other than the connection owner set in the connect, authenticate or associate commands, if it was set. The main point of this check is to prevent chaos when two

[PATCH v4] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread s . gottschall
From: Sebastian Gottschall current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx rate. this is wrong and may lead to a non initialized peer_bw_rxnss_override parameter which is required since VHT160 operation mode

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Sebastian Gottschall
I did some testing with the patch below. i mean you tested your own patch here but i dont see results for mine. i tested my patch in the same way, just not on firmware side but i logged the values for rxnss_override and the looked correct all the time The CHAIMASK_ERR is a debug log from

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Sebastian Gottschall
Am 27.04.2018 um 23:57 schrieb Ben Greear: On 04/27/2018 11:54 AM, Sebastian Gottschall wrote: Am 27.04.2018 um 18:07 schrieb Ben Greear: On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-27 Thread Barry Day
On Fri, Apr 27, 2018 at 05:44:16AM +, Pkshih wrote: > > The registers reside in driver causes error frequently, because MAC register > is maintained by Realtek's MAC team so they create this module to avoid > mistakes. > Another benefit is to make it possible to become a thin driver, because

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Ben Greear
On 04/27/2018 11:54 AM, Sebastian Gottschall wrote: Am 27.04.2018 um 18:07 schrieb Ben Greear: On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 17:30 schrieb Ben Greear: On

Re: wil6210: low level sector API

2018-04-27 Thread David Dean Zhang
Thanks so much for your information. I tried to use this command and set "triggers" and "long_term_enable" to 0. Actually, in the definition of the triggers, there is no 0x00 but it could be set. After calling this WMI command, it returned 0 which looks like correct. But when I checked the station

[PATCH] mesh: don't process mesh channel switch unless csa ie provided

2018-04-27 Thread peter . oh
From: Peter Oh There is no meaning to call ieee80211_mesh_process_chnswitch without CSA IE provided, since the function will always return error. Signed-off-by: Peter Oh --- net/mac80211/mesh.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread kbuild test robot
/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-fix-crash-in-recent-3-5-3-9984-firmware-due-wrong-handling-of-peer_bw_rxnss_override-parameter/20180427-234051 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next config: i386-allmodconfig (attached as .config) compiler

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Sebastian Gottschall
Am 27.04.2018 um 18:07 schrieb Ben Greear: On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 17:30 schrieb Ben Greear: On 04/26/2018 02:28 AM, s.gottsch...@dd-wrt.com wrote:

Re: pull-request: wireless-drivers 2018-04-26

2018-04-27 Thread David Miller
From: Kalle Valo Date: Thu, 26 Apr 2018 13:12:54 +0300 > here's a pull request to net tree, more info below. Please let me know > if you have any problems. Pulled, thanks Kalle.

Re: [PATCH] ath6kl: use WMI to set RSN capabilities

2018-04-27 Thread Steve deRosier
On Fri, Apr 27, 2018 at 9:57 AM Alfonso Sanchez-Beato < alfonso.sanchez-be...@canonical.com> wrote: > Hi Steve, > On Fri, Apr 27, 2018 at 5:47 PM, Steve deRosier wrote: > > Hi Alfonso, > > > > On Thu, Apr 12, 2018 at 8:42 AM Alfonso Sánchez-Beato < > >

RE: [PATCH v3 1/2] dma-mapping: move dma configuration to bus infrastructure

2018-04-27 Thread Nipun Gupta
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Monday, April 23, 2018 6:27 PM > To: Nipun Gupta > Cc: robin.mur...@arm.com; h...@lst.de; li...@armlinux.org.uk; > gre...@linuxfoundation.org; m.szyprow...@samsung.com; >

Re: [PATCH] ath6kl: use WMI to set RSN capabilities

2018-04-27 Thread Alfonso Sanchez-Beato
Hi Steve, On Fri, Apr 27, 2018 at 5:47 PM, Steve deRosier wrote: > Hi Alfonso, > > On Thu, Apr 12, 2018 at 8:42 AM Alfonso Sánchez-Beato < > alfonso.sanchez-be...@canonical.com> wrote: > >> This fixes AP mode when the ATH6KL_FW_CAPABILITY_RSN_CAP_OVERRIDE flag >> is not

Re: [PATCH v2] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

2018-04-27 Thread Ben Greear
On 04/26/2018 09:40 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 22:35 schrieb Ben Greear: On 04/26/2018 01:21 PM, Sebastian Gottschall wrote: Am 26.04.2018 um 17:30 schrieb Ben Greear: On 04/26/2018 02:28 AM, s.gottsch...@dd-wrt.com wrote: From: Sebastian Gottschall

Re: [PATCH] ath6kl: use WMI to set RSN capabilities

2018-04-27 Thread Steve deRosier
Hi Alfonso, On Thu, Apr 12, 2018 at 8:42 AM Alfonso Sánchez-Beato < alfonso.sanchez-be...@canonical.com> wrote: > This fixes AP mode when the ATH6KL_FW_CAPABILITY_RSN_CAP_OVERRIDE flag > is not present in the FW. The id of some WMI commands is also fixed > (there was an error in the enum order),

Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

2018-04-27 Thread Gustavo A. R. Silva
Hi Dan, On 04/27/2018 06:44 AM, Dan Carpenter wrote: On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote: Gustavo submitted an identical patch also for this one :) https://patchwork.kernel.org/patch/10365997/ Hey Gustavo, We keep on sending duplicate patches. Most of the static

Re: [PATCH] rsi: Uninitialized return value in rsi_reset_card()

2018-04-27 Thread Kalle Valo
Dan Carpenter writes: > If rsi_usb_master_reg_write() fails then "ret" hasn't been initialized. > > Fixes: 16d3bb7b2f37 ("rsi: disable fw watchdog timer during reset") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

2018-04-27 Thread Dan Carpenter
On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote: > > Gustavo submitted an identical patch also for this one :) > > https://patchwork.kernel.org/patch/10365997/ > Hey Gustavo, We keep on sending duplicate patches. Most of the static checker people CC kernel-janit...@vger.kernel.org

Re: [next] ath10k: fix spelling mistake: "servive" -> "service"

2018-04-27 Thread Kalle Valo
Colin Ian King wrote: > Trivial fix to spelling mistake in ath10k_warn warning message text > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks.

Re: ath6kl: fix ath6kl_data_tx()'s return type

2018-04-27 Thread Kalle Valo
Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: [PATCHv3] ath10k: fix kernel panic while reading tpc_stats

2018-04-27 Thread Kalle Valo
tami...@codeaurora.org wrote: > When attempt to read tpc_stats for the chipsets which support > more than 3 tx chain will trigger kernel panic(kernel stack is corrupted) > due to writing values on rate_code array out of range. > This patch changes the array size depends on the WMI_TPC_TX_N_CHAIN

Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

2018-04-27 Thread Kalle Valo
Dan Carpenter writes: > Smatch complains that the end of this function is dead code. I'm pretty > sure that this return needs to be changed to only return on error. > > Fixes: 4fd6c4762f37 ("rsi: roaming enhancements") > Signed-off-by: Dan Carpenter

Re: ath10k: fix information leak in debugfs

2018-04-27 Thread Kalle Valo
Venkateswara Naralasetty wrote: > During write to some of debugfs in ath10k, few variables exposing stack > data when process user input. which leads to possible information leak. > > This patch fix this issue by initializing buffer and checks > the return valure of

Re: ath6kl: use WMI to set RSN capabilities

2018-04-27 Thread Kalle Valo
Alfonso Sánchez-Beato wrote: > This fixes AP mode when the ATH6KL_FW_CAPABILITY_RSN_CAP_OVERRIDE flag > is not present in the FW. The id of some WMI commands is also fixed > (there was an error in the enum order), and a function to set RSN caps > is added. > > Signed-off-by: Alfonso

[PATCH] rsi: fix a bug in rsi_hal_key_config()

2018-04-27 Thread Dan Carpenter
Smatch complains that the end of this function is dead code. I'm pretty sure that this return needs to be changed to only return on error. Fixes: 4fd6c4762f37 ("rsi: roaming enhancements") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH] mac80211_hwsim: fix a possible memory leak in hwsim_new_radio_nl()

2018-04-27 Thread YueHaibing
cc Ben Hutchings On 2018/4/24 11:08, YueHaibing wrote: > 'hwname' should be freed before leaving from the error handling cases, > otherwise it will cause mem leak > > Fixes: cb1a5bae5684 ("mac80211_hwsim: add permanent mac address option for > new radios") >