Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"

2018-05-12 Thread Rafał Miłecki
On 2018-05-12 10:01, Michael Büsch wrote: On Sat, 12 May 2018 10:50:42 +0300 Kalle Valo wrote: Larry Finger writes: > On 05/11/2018 05:13 AM, Kalle Valo wrote: >> Rafał Miłecki writes: >> >>> On 11 May 2018 at 11:17, Rafał Miłecki wrote: [...] >>> >>> As these patches fix regression/build

Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"

2018-05-12 Thread Michael Büsch
On Sat, 12 May 2018 12:00:07 +0200 Rafał Miłecki wrote: > > Yes, I'm OK with the patch, if we have a third patch that cleans up the > > PCI_DRIVERS_LEGACY dependency by moving it to SSB_PCICORE_HOSTMODE > > where it belongs. (This doesn't need to go into the stable tree.) > > We currently implici

Re: [PATCH] ath10k: add fw crash dump support for QCA9888 and QCA99X0

2018-05-12 Thread Kalle Valo
Anilkumar Kolli writes: > This patch adds crash dump support for QCA9888 and QCA99X0 > > Tested On: QCA9888, Firmware Version: 10.4-3.5.3-00053 > Tested on QCA99X0, Firmware Version: 10.4.1.00030-1 > > Signed-off-by: Anilkumar Kolli [...] > --- a/drivers/net/wireless/ath/ath10k/coredump.c > ++

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

2018-05-12 Thread Kalle Valo
Sriram R writes: > In the 10.4-3.6 firmware branch there's a new DFS Host confirmation > feature which is advertised using WMI_SERVICE_HOST_DFS_CHECK_SUPPORT flag. > > This new features enables the ath10k host to send information to the > firmware on the specifications of detected radar type. Thi

Re: [v3,1/8] wil6210: disable tracing config option

2018-05-12 Thread Kalle Valo
Maya Erez wrote: > Disable WIL6210_TRACING by default to avoid its performance overhead. > > Signed-off-by: Alexei Avshalom Lazar > Signed-off-by: Maya Erez > Signed-off-by: Kalle Valo 8 patches applied to ath-next branch of ath.git, thanks. 777b4690fc4a wil6210: disable tracing config opti

Re: [v2] ath10k: Replace bit shifts with the BIT() macro for rx desc bits

2018-05-12 Thread Kalle Valo
Govind Singh wrote: > Use the BIT() macro from 'linux/bitops.h' to define the rx desc > bit flags to have consistency with new definitions. > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c3f7f31efe39 ath10k: replace bit shifts

Re: ath10k: hw: make consistent usage of ATH10K_FW_DIR in paths

2018-05-12 Thread Kalle Valo
Marcus Folkesson wrote: > For some reason not all entries used ATH10K_FW_DIR so fix that. No functional > changes. > > Signed-off-by: Marcus Folkesson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 0be928850dac ath10k: hw: make consistent usage of ATH10K_FW_

Re: [v2] ath10k: remove variables which set but not used

2018-05-12 Thread Kalle Valo
Kenneth Lu wrote: > Variable buf_len and num_vdev_stats are being assigned but never read. > These are redundant and can be remove. > > Signed-off-by: Kenneth Lu > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 3e2740cda224 ath10k: remove variables which set b

Re: [PATCH] ath10k: hw: make consistent usage of ATH10K_FW_DIR in paths

2018-05-12 Thread Kalle Valo
Marcus Folkesson writes: > Signed-off-by: Marcus Folkesson I don't like empty commit logs so I added this in the pending branch: ath10k: hw: make consistent usage of ATH10K_FW_DIR in paths For some reason not all entries used ATH10K_FW_DIR so fix that. No functional changes. -- Kalle

Re: [PATCH v2] ath10k: remove variables which set but not used

2018-05-12 Thread Kalle Valo
Jeff Johnson writes: > On 2018-05-07 02:39, Kenneth Lu wrote: >> Variable buf_len and num_vdev_stats are bging assigned but never read. > > typo: bging => being I fixed this in the pending branch. -- Kalle Valo

Re: [PATCH 6/9] firmware: print firmware name on fallback path

2018-05-12 Thread Luis R. Rodriguez
On Sat, May 12, 2018 at 11:03:52AM +0300, Kalle Valo wrote: > (sorry for the delay, this got buried in my inbox) > > "Luis R. Rodriguez" writes: > > > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: > >> Previously, one could assume the firmware name from the preceding > >> mes

Re: ath10k: fix return value check in wake_tx_q op

2018-05-12 Thread Kalle Valo
Erik Stromdahl wrote: > ath10k_mac_tx_push_txq returns either a postive integer (length) on > success or a negative error code on error. > > The "if (ret) break;" statement will thus always break out of the loop > immediately after ath10k_mac_tx_push_txq has returned (making the loop > pointless

Re: ath10k: snoc: Remove owner assignment from platform_driver

2018-05-12 Thread Kalle Valo
Fabio Estevam wrote: > Structure platform_driver does not need to set the owner field, as this > will be populated by the driver core. > > Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. > > Signed-off-by: Fabio Estevam > Signed-off-by: Kalle Valo Patch applied to ath-next b

Re: ath10k: add quiet mode support for QCA6174/QCA9377

2018-05-12 Thread Kalle Valo
Yu Wang wrote: > To enable thermal throttling for QCA6174 and QCA9377, > implement gen_pdev_set_quiet_mode for them. > With this change, quiet period for QCA6174/QCA9377 can > be also set/get via debugfs. > Usage: > To set quiet period: > echo > /sys/kernel/debug/ieee80211/phyX/ath10k/quiet_per

Re: rsi: fix spelling mistake: "thead" -> "thread"

2018-05-12 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in rsi_dbg debug message text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. b41c39367669 rsi: fix spelling mistake: "thead" -> "thread" -- https://patchwork.kernel.org/

Re: mt76x2: add a polling delay in mt76x2_mac_stop routine

2018-05-12 Thread Kalle Valo
Lorenzo Bianconi wrote: > Add a usleep_range in mt76x2_mac_stop routine in order to add > a polling delay checking values of MT_MAC_STATUS and IBI_R12 registers > > Signed-off-by: Lorenzo Bianconi > Acked-by: Felix Fietkau Patch applied to wireless-drivers-next.git, thanks. 6823dc0d91e5 mt76

Re: [v5] wireless-drivers: Dynamically allocate struct station_info

2018-05-12 Thread Kalle Valo
Toke Høiland-Jørgensen wrote: > Since the addition of the TXQ stats to cfg80211, the station_info struct > has grown to be quite large, which results in warnings when allocated on > the stack. Fix the affected places to do dynamic allocations instead. > > Fixes: 52539ca89f36 ("cfg80211: Expose TX

Re: [v2] b43: fix transmit failure when VT is switched

2018-05-12 Thread Kalle Valo
k...@sra-tohoku.co.jp wrote: > From: Taketo Kabe > > Fix for b43 wireless card stopping transmission when switching VTs. > > Setup: > Using BCM4306 rev.03 chip based CardBus wireless card. > IRQ is shared with yenta (cardbus bridge) and i915 (display) driver. > For firmware, installed latest bu

Re: [V2, 1/2] Revert "ssb: Prevent build of PCI host features in module"

2018-05-12 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e. > > Above commit added "SSB = y" dependency to the wrong symbol > SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being > selected when needed. PCI core driver for core

Re: [4.17] bcma: fix buffer size caused crash in bcma_core_mips_print_irq()

2018-05-12 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > Used buffer wasn't big enough to hold whole strings. Example output of > this function is: > [0.180892] bcma: bus0: core 0x0800, irq: 2(S)* 3 4 5 6 D I > [0.180948] bcma: bus0: core 0x0812, irq: 2(S) 3* 4 5 6 D I > [0.180998] b

Re: [PATCH 6/9] firmware: print firmware name on fallback path

2018-05-12 Thread Kalle Valo
(sorry for the delay, this got buried in my inbox) "Luis R. Rodriguez" writes: > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: >> Previously, one could assume the firmware name from the preceding >> message: "Direct firmware load for {name} failed with error %d". >> >> Howev

Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"

2018-05-12 Thread Michael Büsch
On Sat, 12 May 2018 10:50:42 +0300 Kalle Valo wrote: > Larry Finger writes: > > > On 05/11/2018 05:13 AM, Kalle Valo wrote: > >> Rafał Miłecki writes: > >> > >>> On 11 May 2018 at 11:17, Rafał Miłecki wrote: > [...] > >>> > >>> As these patches fix regression/build error, I believe b

Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"

2018-05-12 Thread Kalle Valo
Larry Finger writes: > On 05/11/2018 05:13 AM, Kalle Valo wrote: >> Rafał Miłecki writes: >> >>> On 11 May 2018 at 11:17, Rafał Miłecki wrote: From: Rafał Miłecki This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e. Above commit added "SSB = y" dependency to t