Re: iwlwifi: regression due to: allow different csr flags for different device families

2018-05-30 Thread Luca Coelho
On Sun, 2018-05-27 at 14:08 +0200, Alexander Wetzel wrote: > > From: Golan Ben Ami > > > > Different device families may have different flag values > > for passing a message to the fw (i.e. SW_RESET). > > In order to keep the code readable, and avoid conditioning > > upon the family, store a valu

Re: [PATCH 1/2] cfg80211: last ack singal support in station dump

2018-05-30 Thread Balaji Pothunoori
On 2018-05-27 15:18, kbuild test robot wrote: Hi Balaji, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [cannot apply to v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https:

Re: [PATCH v4 0/9] rtlwifi: btcoex: Add 8822b btcoex support

2018-05-30 Thread Pkshih
On Fri, 2018-04-13 at 14:16 +0800, pks...@realtek.com wrote: > From: Ping-Ke Shih > > v4: swap the order of patch 4/9 and 5/9, because kbuild test robot reports > undefined reference. No source code change. > v3: forget to CC wireless mailing list, so resend again. No any change. > v2: fix mi

Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

2018-05-30 Thread Pkshih
On Tue, 2018-05-29 at 08:18 +0300, Kalle Valo wrote: > writes: >  > > From: Ping-Ke Shih > > > > The format of C2H data is ID(1 byte) + Length(1 byte) + value, and it is > > more readable to use macros to access C2H data. > > > > Signed-off-by: Ping-Ke Shih >  > [...] >  > > --- a/drivers/net/wi

Re: [RFT 6/6] wlcore: Use generic runtime pm calls for wowlan elp configuration

2018-05-30 Thread Tony Lindgren
* Reizer, Eyal [180530 06:37]: > > > > > > > > With runtime PM enabled, we can now use generic calls to > > > > pm_generic_runtime_suspend and pm_generic_runtime_resume for > > enabling elp > > > > during suspend when wowlan is enabled and waking the chip from elp > > > > on resume. > > > > > > Sr

Re: [PATCH V2 2/3] brcmfmac: handle monitor mode marked msgbuf packets

2018-05-30 Thread Arend van Spriel
On 5/30/2018 10:13 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware ge

[PATCH V2 1/3] brcmfmac: allow specifying features per firmware version

2018-05-30 Thread Rafał Miłecki
From: Rafał Miłecki Some features supported by firmware aren't advertised and there is no way for a driver to query them. This includes e.g. monitor mode details. Some firmwares support tagging monitor frames, some build radiotap header but there is no way to detect it. Such features often depend

[PATCH V2 3/3] brcmfmac: add initial support for monitor mode interface

2018-05-30 Thread Rafał Miłecki
From: Rafał Miłecki Right now it's limited to firmwares that mark monitor interface packets with a special flag. It's required to distinguish them from other interface packets as firmware doesn't use any unique ifidx for monitor interface. In the future one may also add support for older firmwar

[PATCH V2 2/3] brcmfmac: handle monitor mode marked msgbuf packets

2018-05-30 Thread Rafał Miłecki
From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware generates radiotap header this commit introduces

Re: [1/9] qtnfmac: remove unused function declarations

2018-05-30 Thread Kalle Valo
Sergey Matyukevich wrote: > From: Andrey Shevchenko > > Functions qtnf_cmd_resp_parse and qtnf_cmd_resp_check have > been removed. Remove their declarations as well. > > Signed-off-by: Andrey Shevchenko 9 patches applied to wireless-drivers-next.git, thanks. 6d89265d7841 qtnfmac: remove unu

Re: pull-request: iwlwifi-next 2018-05-30

2018-05-30 Thread Kalle Valo
Luca Coelho writes: > Hi Kalle, > > This is the final batch of patches intended for v4.18. As discussed, > it is focused on bugfixes. More details about the contents in the tag > description. > > I have sent this out before and kbuildbot this morning, but I didn't > get any replies from it yet.

[RFCv3 4/4] mac80211: Implement functionality to monitor txrate cross event for a station

2018-05-30 Thread Tamizh chelvam
Trigger cfg80211_sta_mon_txrate_notify with the corresponding txrate event when the txrate for a station goes out of configured range. This event will be useful for the application like steering to take decision on any station depends on its current capability. Signed-off-by: Tamizh chelvam ---

[RFCv3 1/4] cfg80211: Add support to configure station specific txrate threshold

2018-05-30 Thread Tamizh chelvam
Add support to configure station specific txrate threshold to monitor variation in the txrate for a station. Configuration is passed using NL80211_ATTR_STA_MON_LOW_TXRATE_THOLD and NL80211_ATTR_STA_MON_HIGH_TXRATE_THOLD in NL80211_CMD_SET_STA_MON command and the configuration will be represented in

[RFCv3 2/4] mac80211: Add api to configure low and high txrate threshold

2018-05-30 Thread Tamizh chelvam
Add set_sta_mon_txrate_config api to configure low and high txrate threshold for a connected station. The configuration will be represented in 100kbps. Signed-off-by: Tamizh chelvam --- net/mac80211/cfg.c | 35 +++ net/mac80211/sta_info.h | 7 +++ 2 file

[RFCv3 3/4] cfg80211: Add support to notify station's txrate crossing event

2018-05-30 Thread Tamizh chelvam
Add cfg80211_sta_mon_txrate_notify to update userspace upon crossing the configured txrate threshold for a station. This uses NL80211_CMD_NOTIFY_STA_MON along with NL80211_ATTR_STA_MON_TXRATE_THRESHOLD_EVENT, NL80211_ATTR_MAC and NL80211_ATTR_STA_MON_TXRATE_LEVEL. Userspace application can make a d

[RFCv3 0/4] cfg80211/mac80211: Add support to configure and monitor txrate threshold

2018-05-30 Thread Tamizh chelvam
This patchsets introduced new NL command and api to support configuring txrate threshold for the connected stations and api to notify userspace application upon crossing the configured txrate threshold. This will be useful for the application which requires station's current capability change infor

[RFCv3 7/7] mac80211: Add api to configure low and high RSSI threshold

2018-05-30 Thread Tamizh chelvam
Add set_sta_mon_rssi_range_config api to support configuring low and high RSSI threshold values for a connected station. And trigger an event if a station's signal strength goes out of configured range. Signed-off-by: Tamizh chelvam --- net/mac80211/cfg.c | 40 ++

[RFCv3 2/7] cfg80211: Add new NL command to configure peer specific rssi threshold

2018-05-30 Thread Tamizh chelvam
This patch add support to configure peer specific rssi configuration to monitor station's signal strength variation. New NL80211_CMD_SET_STA_MON introduced to configure rssi threshold and hysteresis info using NL80211_ATTR_STA_MON_RSSI_THOLD and NL80211_ATTR_STA_MON_RSSI_HYST along with NL80211_ATT

[RFCv3 3/7] mac80211: Add api to support configuring station specific rssi threshold

2018-05-30 Thread Tamizh chelvam
This patch add set_sta_mon_rssi_config api to configure rssi and hysteresis threshold value for a connected station. This configuration will be applied only for the connected station. Signed-off-by: Tamizh chelvam --- net/mac80211/cfg.c | 35 +++ net/mac80211

[RFCv3 4/7] cfg80211: Add support to notify station's rssi level crossing

2018-05-30 Thread Tamizh chelvam
Add cfg80211_sta_mon_rssi_notify api to update user space upon crossing the configured rssi threshold of a station. NL80211_CMD_NOTIFY_STA_MON introduced to send this event to userspace along with NL80211_ATTR_STA_MON_RSSI_THRESHOLD_EVENT, NL80211_ATTR_MAC and NL80211_ATTR_STA_MON_RSSI_LEVEL info.

[RFCv3 6/7] cfg80211: Accept multiple RSSI threholds for STA_MON command

2018-05-30 Thread Tamizh chelvam
Change the NL80211_CMD_STA_MON RSSI threshold attribut to accept any number of thresholds as a sorted array. If user send the configuration with single RSSI threshold then the old mechanism is enabled. Same netlink event will be generated in both cases. This patch introduced set_sta_mon_rssi_range_

[RFCv3 5/7] mac80211: Implement functionality to monitor station's rssi cross event

2018-05-30 Thread Tamizh chelvam
Triggers cfg80211_sta_mon_rssi_notify with the corresponding event when station signal goes out of configured threshold. It uses rx data signal to check against rssi threshold configured by the user. This event will be useful for the application like steering to take decision on any station depends

[RFCv3 1/7] wireless: Change single cqm_config to rssi config list

2018-05-30 Thread Tamizh chelvam
This patch changes single cqm_config into mac address based rssi config list. This way the same structure can be utilized by AP mode as well. Signed-off-by: Tamizh chelvam --- include/net/cfg80211.h | 7 +++-- net/wireless/core.c| 29 net/wireless/core.h| 6 ++-- n

[RFCv3 0/7] cfg80211/mac80211: Add support to configure and monitor rssi threshold

2018-05-30 Thread Tamizh chelvam
This patchsets introduced new NL command and api to support configuring rssi for the connected stations and api to notify userspace application upon crossing the configured threshold. This will be useful for the application which requires station's current capability change information. Tamizh che

Re: Atheros AR9462 - 5Ghz not working

2018-05-30 Thread mgreger
Sedat Dilek wrote: > On Tue, May 22, 2018 at 7:21 PM, wrote: > > I've run out of ideas and am hoping someone here can help. > > > > All I want to do is connect a client to my 5Ghz network. > > > > My client: > > OS is Debian stable "Stretch" with sysvinit instead of systemd > > Ather

pull-request: iwlwifi-next 2018-05-30

2018-05-30 Thread Luca Coelho
Hi Kalle, This is the final batch of patches intended for v4.18. As discussed, it is focused on bugfixes. More details about the contents in the tag description. I have sent this out before and kbuildbot this morning, but I didn't get any replies from it yet. Please let me know if there are an

Re: Research + questions on brcmfmac and support for monitor mode

2018-05-30 Thread Rafał Miłecki
I'm providing extra version info of tested firmware images as requested by Arend in another e-mail thread. On 15.05.2018 14:29, Rafał Miłecki wrote: 1) brcmfmac43602-pcie.ap.bin from linux-firmware.git Firmware version = wl0: Sep 18 2015 03:30:01 version 7.35.177.56 (r587209) FWID 01-6cb8e269

Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

2018-05-30 Thread Julian Calaby
Hi Arend, On Wed, May 30, 2018 at 8:05 PM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: > On 5/27/2018 7:34 AM, Julian Calaby wrote: > > Hi Arend, > > On Fri, May 25, 2018 at 12:38 PM Arend van Spriel < > > arend.vanspr...@broadcom.com> wrote: > > > >> On 5/22/2018 3:18 PM, Rafał Miłeck

Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

2018-05-30 Thread Arend van Spriel
On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware gen

Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

2018-05-30 Thread Arend van Spriel
On 5/27/2018 7:34 AM, Julian Calaby wrote: Hi Arend, On Fri, May 25, 2018 at 12:38 PM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags

[RFT v2, 6/6] wlcore: Use generic runtime pm calls for wowlan elp configuration

2018-05-30 Thread Eyal Reizer
With runtime PM enabled, we can now use calls to pm_runtime_force_suspend and pm_runtime_force_resume for enabling elp during suspend when wowlan is enabled and waking the chip from elp on resume. Remove the custom API that was used to ensure that the command that is used to allow ELP during suspe

Re: [PATCH V3 0/5] Update brcm firmware files

2018-05-30 Thread Hans de Goede
Hi, On 30-05-18 09:28, Chi-Hsien Lin wrote: On 05/27/2018 10:37, Hans de Goede wrote: Hi, On 18-05-18 09:04, Hans de Goede wrote: Hi, On 15-05-18 10:43, Arend van Spriel wrote: On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broad

Re: [PATCH V3 0/5] Update brcm firmware files

2018-05-30 Thread Chi-Hsien Lin
On 05/27/2018 10:37, Hans de Goede wrote: Hi, On 18-05-18 09:04, Hans de Goede wrote: Hi, On 15-05-18 10:43, Arend van Spriel wrote: On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 3/16/2018 3:08 PM, Chi-H

[PATCH 10/10] iwlwifi: fix non_shared_ant for 9000 devices

2018-05-30 Thread Luca Coelho
From: Erel Geron The non-shared antenna was wrong for 9000 device series. Fix it to ANT_B for correct antenna preference by coex in MVM driver. Fixes: 89374fe60bfb ("iwlwifi: Add new PCI IDs for 9260 and 5165 series") Signed-off-by: Erel Geron Signed-off-by: Luca Coelho --- drivers/net/wirel

RE: [EXT] Re: [PATCH] mwifiex: handle race during mwifiex_usb_disconnect

2018-05-30 Thread Ganapathi Bhat
Hi Brian, > > @@ -644,6 +644,9 @@ static void mwifiex_usb_disconnect(struct > usb_interface *intf) > > MWIFIEX_FUNC_SHUTDOWN); > > } > > > > + if (adapter->workqueue) > > + flush_workqueue(adapter->workqueue); > > This seems like a bad fix. I'm

[PATCH 03/10] iwlmvm: tdls: Check TDLS channel switch support

2018-05-30 Thread Luca Coelho
From: Aviya Erenfeld Some versions of the FW don't support channel switch in TDLS. Add a condition that checks it. Fixes: 307e47235a10 ("iwlwifi: mvm: configure TDLS peers to FW") Signed-off-by: Aviya Erenfeld Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tdls.c | 16 +

[PATCH 05/10] iwlwifi: pcie: fix race in Rx buffer allocator

2018-05-30 Thread Luca Coelho
From: Shaul Triebitz Make sure the rx_allocator worker is canceled before running the rx_init routine. rx_init frees and re-allocates all rxb's pages. The rx_allocator worker also allocates pages for the used rxb's. Running rx_init and rx_allocator simultaniously causes a kernel panic. Fix th

[PATCH 09/10] iwlwifi: mvm: fix race in queue notification wait

2018-05-30 Thread Luca Coelho
From: Johannes Berg Initially in this code, the race didn't matter since it didn't do anything. Latest with the commit I marked this as fixing it started to matter as something got done here that needed other data that got freed as soon as the queue notification wait was returning. In the scenar

[PATCH 07/10] iwlwifi: mvm: open BA session only when sta is authorized

2018-05-30 Thread Luca Coelho
From: Gregory Greenman Currently, a BA session is opened when the tx traffic exceeds 10 frames per second. As a result of inter-op problems with some APs, add a condition to open BA session only when station is already authorized. Fixes: 482e48440a0e ("iwlwifi: mvm: change open and close criteri

[PATCH 06/10] iwlwifi: mvm: remove division by size of sizeof(struct ieee80211_wmm_rule)

2018-05-30 Thread Luca Coelho
From: Colin Ian King The subtraction of two struct ieee80211_wmm_rule pointers leaves a result that is automatically scaled down by the size of the size of pointed-to type, hence the division by sizeof(struct ieee80211_wmm_rule) is bogus and should be removed. Detected by CoverityScan, CID#14677

[PATCH 04/10] iwlwifi: mvm: fix TSO with highly fragmented SKBs

2018-05-30 Thread Luca Coelho
From: Emmanuel Grumbach Our hardware has a limited amount of buffer descriptors for each Tx packet. Because of that, there is a short piece of code that makes sure that that we don't push too many subframes in an A-MSDU because of subframes needs 2 buffer descriptors. This code also takes into ac

[PATCH 08/10] iwlwifi: mvm: honor the max_amsdu_subframes limit

2018-05-30 Thread Luca Coelho
From: Emmanuel Grumbach A peer can limit the number of subframes it can handle in a single A-MSDU. Honor this limit. Note that the smallest limit is 8, and we are very unlikely to reach that limit. So this isn't really a big deal. Fixes: a6d5e32f247c ("iwlwifi: mvm: send large SKBs to the tran

[PATCH 02/10] iwlwifi: mvm: drop UNKNOWN security type frames

2018-05-30 Thread Luca Coelho
From: Sara Sharon In some cases we may get from FW errored frames with UNKNOWN security type. This may happen in unsecured aggregation flow, where the first packet had a CRC error in the WEP bit, which was followed by a failure to decrypt and was dropped. The next frames in the aggregation "inh

[PATCH 00/10] iwlwifi: updates intended for v4.18 2018-05-30

2018-05-30 Thread Luca Coelho
From: Luca Coelho Hi, Here's the last batch of patches intended for 4.18. Focused on bugfixes, especially (but not exclusively) regressions introduced in 4.18. The patches include these changes: * Some bugzilla fixes; * Some kernel warning fixes; * Fix for an (ETSI) WMM limits bug; * Fix for

[PATCH 01/10] iwlwifi: add csr configuration for 6300 devices

2018-05-30 Thread Luca Coelho
From: Golan Ben Ami Recently we have switched the csr addresses and values configuration from a single configuration to all devices to a per-device configuration. Doing that, the configuration for 6300 devices wasn't set. This missing definition introduced a kernel panic once trying to access the