Re: [PATCH V3 0/2] brcmfmac: initial work for adding monitor mode

2018-06-22 Thread Arend van Spriel
On 6/19/2018 10:25 PM, Rafał Miłecki wrote: On 2018-06-19 22:01, Arend van Spriel wrote: On 6/19/2018 5:48 PM, Rafał Miłecki wrote: From: Rafał Miłecki After a bit long discussions in various e-mail threads I'm coming with this simple & small patchset. It isn't complete support for monitor mo

[PATCH 3/6] brcmfmac: fix for proper support of 160MHz bandwidth

2018-06-22 Thread Arend van Spriel
Decoding of firmware channel information was not complete for 160MHz support. This resulted in the following warning: WARNING: CPU: 2 PID: at .../broadcom/brcm80211/brcmutil/d11.c:196 brcmu_d11ac_decchspec+0x2e/0x100 [brcmutil] Modules linked in: brcmfmac(O) brcmutil(O) sha256_gen

[PATCH 4/6] brcmfmac: increase buffer for obtaining firmware capabilities

2018-06-22 Thread Arend van Spriel
When obtaining the firmware capability a buffer is provided of 512 bytes. However, if all features in firmware are supported the buffer needs to be 565 bytes as otherwise truncated information is retrieved from firmware. Increasing the buffer to 768 bytes on stack. Reviewed-by: Hante Meuleman Rev

[PATCH 2/6] brcmfmac: rename BRCMF_FEAT_MONITOR_FMT_RADIOTAP to BRCMF_FEAT_RADIOTAP

2018-06-22 Thread Arend van Spriel
Just a bit of bike-shedding so nothing functionally changed. Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c| 2 +- drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH 6/6] brcmfmac: fallback mechanism to determine monitor mode features

2018-06-22 Thread Arend van Spriel
Firmwares may not provide all monitor mode features in the "cap" iovar. For those this fallback mechanism uses "sta_monitor" iovar. If firmware is compiled with stamon, this iovar will fail with BCME_NOTUP; Otherwise it fails with BCME_UNSUPPORTED. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-

[PATCH 0/6] brcmfmac: fix 160MHz support and monitor mode

2018-06-22 Thread Arend van Spriel
Here a couple of patches in preparation of monitor mode support. It is mostly about querying firmware for support. While at it I stumbled upon the fact that 160MHz was not completely implemented in the driver so there is a patch for that as well. The first two patches are actually some changes to

[PATCH 5/6] brcmfmac: add new feature flags for monitor mode operation

2018-06-22 Thread Arend van Spriel
Add two new feature flags to be used for monitor mode. One indicating support to enable packet capture and one indicating captured packets from firmware already include radiotap header. Signed-off-by: Rafal Milecki [arend: change flags and description] Reviewed-by: Hante Meuleman Reviewed-by: Pi

[PATCH 1/6] brcmfmac: remove fallback mechanism for BRCMF_FEAT_MONITOR

2018-06-22 Thread Arend van Spriel
Commit 19f505aa3ae0 ("brcmfmac: detect firmware support for monitor interface") introduced a fallback mechanism attempting BRCMF_C_MONITOR command. However, that does not indicate firmware support. Unfortunately, it only indicates the core part of the stack supports it, but not whether it is suppor

Re: mt76x2e MCU message 31 timed out

2018-06-22 Thread Janusz Dziedzic
2018-06-22 16:48 GMT+02:00 Stanislaw Gruszka : > Hi > > On Fri, Jun 22, 2018 at 10:37:35AM +0200, Janusz Dziedzic wrote: >> Have this card in my laptop: >> 02:00.0 Network controller: MEDIATEK Corp. Device 7612 >> >> [8.478104] mt76x2e :02:00.0: ASIC revision: 76120044 >> [8.489582] mt7

Re: mt76x2e MCU message 31 timed out

2018-06-22 Thread Stanislaw Gruszka
Hi On Fri, Jun 22, 2018 at 10:37:35AM +0200, Janusz Dziedzic wrote: > Have this card in my laptop: > 02:00.0 Network controller: MEDIATEK Corp. Device 7612 > > [8.478104] mt76x2e :02:00.0: ASIC revision: 76120044 > [8.489582] mt76x2e :02:00.0: ROM patch already applied > [8.83

mt76x2e MCU message 31 timed out

2018-06-22 Thread Janusz Dziedzic
Hello, Have this card in my laptop: 02:00.0 Network controller: MEDIATEK Corp. Device 7612 [8.478104] mt76x2e :02:00.0: ASIC revision: 76120044 [8.489582] mt76x2e :02:00.0: ROM patch already applied [8.833476] mt76x2e :02:00.0: Firmware Version: 0.0.00 [8.833477] mt76x