Re: [PATCH 4/7] cfg80211: Add support to notify station's rssi level crossing

2018-07-03 Thread Tamizh chelvam
On 2018-06-29 15:05, Johannes Berg wrote: On Wed, 2018-06-13 at 16:15 +0530, Tamizh chelvam wrote: Add cfg80211_sta_mon_rssi_notify api to update user space upon crossing the configured rssi threshold of a station. NL80211_CMD_NOTIFY_STA_MON introduced to send this event to userspace along with

Re: [PATCH 2/7] cfg80211: Add new NL command to configure peer specific rssi threshold

2018-07-03 Thread Tamizh chelvam
On 2018-06-29 14:59, Johannes Berg wrote: On Wed, 2018-06-13 at 16:15 +0530, Tamizh chelvam wrote: + * @NL80211_ATTR_STA_MON: Station's connection monitor configuration in a + * nested attribute with %NL80211_ATTR_STA_MON_* sub-attributes. Can't we reuse the existing attributes in this

Re: [PATCH 3/7] mac80211: Add api to support configuring station specific rssi threshold

2018-07-03 Thread Tamizh chelvam
On 2018-06-29 15:01, Johannes Berg wrote: The subjects are a bit confusing - I think you should align the cfg80211 and mac80211 ones so it's clearer that this one is implementing the previous one's API. Peer vs. station, and mac80211 doesn't add API but implements it. This patch doesn't really

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Ben Greear
On 07/03/2018 04:48 PM, Johannes Berg wrote: On Tue, 2018-07-03 at 13:40 -0700, Peter Oh wrote: On 07/03/2018 05:47 AM, Johannes Berg wrote: From: Johannes Berg Since (QoS) NDP frames shouldn't be put into aggregation nor are assigned real sequence numbers, etc. it's better to treat them

Re: [PATCH v2] mac80211: Fix wlan freezes under load at rekey

2018-07-03 Thread Alexander Wetzel
Hello, > >> I was wrong here, this is not an issue. Tkip is simply dropping frames >> when the IV is too small and never verifies the MIC. And since only MIC >> errors can trigger counter measures we are fine as it is... > > Err, yes, of course. My bad. > 3) Is what I implemented. We try

Re: [PATCH v2] mac80211: Fix wlan freezes under load at rekey

2018-07-03 Thread Johannes Berg
On Tue, 2018-07-03 at 21:54 +0200, Alexander Wetzel wrote: > > I think easier would be to just disconnect ourselves? At least if we're > > in managed mode... > > > > I still have much to learn about 802.11, but so far I did not see way to > directly disconnect a STA. (Maybe spoofing a "signal l

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Johannes Berg
On Tue, 2018-07-03 at 13:40 -0700, Peter Oh wrote: > > On 07/03/2018 05:47 AM, Johannes Berg wrote: > > From: Johannes Berg > > > > Since (QoS) NDP frames shouldn't be put into aggregation nor are > > assigned real sequence numbers, etc. it's better to treat them as > > non-data packets and not

[PATCH] cfg80211: inspect off channel operation only when off channel given

2018-07-03 Thread peter . oh
From: Peter Oh NL80211_ATTR_OFFCHANNEL_TX_OK does not mean given channel is always off channel, but it means the channel given could be off channel. Hence it should not block the given channel to be used if given channel does not require off channel mgmt tx although regulatory domain is non-ETSI.

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Peter Oh
On 07/03/2018 05:47 AM, Johannes Berg wrote: From: Johannes Berg Since (QoS) NDP frames shouldn't be put into aggregation nor are assigned real sequence numbers, etc. it's better to treat them as non-data packets and not put them on the normal TXQs, for example when building A-MPDUs they nee

[PATCH v2] nl80211/mac80211: allow non-linear skb in rx_control_port

2018-07-03 Thread Denis Kenzior
The current implementation of cfg80211_rx_control_port assumed that the caller could provide a contiguous region of memory for the control port frame to be sent up to userspace. Unfortunately, many drivers produce non-linear skbs, especially for data frames. This resulted in userspace getting not

Re: [PATCH] nl80211/mac80211: Fix cfg80211_rx_control_port

2018-07-03 Thread Denis Kenzior
Hi Arend, On 07/03/2018 02:18 PM, Arend van Spriel wrote: Hi Denis, I prefer the subject summarizes the issue, eg. "allow non-linear skb data passed to cfg80211_rx_control_port". Right, I'll fix this in the next version. On 7/3/2018 8:26 PM, Denis Kenzior wrote: The current implementatio

Re: [PATCH] nl80211/mac80211: Fix cfg80211_rx_control_port

2018-07-03 Thread Arend van Spriel
Hi Denis, I prefer the subject summarizes the issue, eg. "allow non-linear skb data passed to cfg80211_rx_control_port". On 7/3/2018 8:26 PM, Denis Kenzior wrote: The current implementation of cfg80211_rx_control_port assumed that the caller could provide a contiguous region of memory for the

[PATCH] nl80211/mac80211: Fix cfg80211_rx_control_port

2018-07-03 Thread Denis Kenzior
The current implementation of cfg80211_rx_control_port assumed that the caller could provide a contiguous region of memory for the control port frame to be sent up to userspace. Unfortunately, many drivers produce non-linear skbs, especially for data frames. This resulted in userspace getting not

Re: [ANN] mt76x0 usb driver

2018-07-03 Thread Hans Ulli Kroll
Hi > > On Mon, Jun 25, 2018 at 02:55:51PM +0200, Lorenzo Bianconi wrote: > > Not sure why many integration commits in upstream is a problem. I think > > having patches posted on mailing list is better than doing them in my > > "private" tree without any review. > > > > > What do you think? > > >

Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

2018-07-03 Thread Larry Finger
On 07/03/2018 05:57 AM, Kalle Valo wrote: Felix Fietkau writes: On 2018-07-03 08:14, Kalle Valo wrote: Pkshih writes: On Fri, 2018-06-29 at 10:30 +0300, Kalle Valo wrote: Pkshih writes: On Tue, 2018-05-29 at 08:18 +0300, Kalle Valo wrote: writes: Because C2H data is little endia

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Tue, 2018-07-03 at 16:31 +0200, Toke Høiland-Jørgensen wrote: >> Johannes Berg writes: >> >> > From: Johannes Berg >> > >> > Since (QoS) NDP frames shouldn't be put into aggregation nor are >> > assigned real sequence numbers, etc. it's better to treat them as >> >

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Johannes Berg
On Tue, 2018-07-03 at 16:31 +0200, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > From: Johannes Berg > > > > Since (QoS) NDP frames shouldn't be put into aggregation nor are > > assigned real sequence numbers, etc. it's better to treat them as > > non-data packets and not put them

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > From: Johannes Berg > > Since (QoS) NDP frames shouldn't be put into aggregation nor are > assigned real sequence numbers, etc. it's better to treat them as > non-data packets and not put them on the normal TXQs, for example > when building A-MPDUs they need to be treated

[PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Johannes Berg
From: Johannes Berg Since (QoS) NDP frames shouldn't be put into aggregation nor are assigned real sequence numbers, etc. it's better to treat them as non-data packets and not put them on the normal TXQs, for example when building A-MPDUs they need to be treated specially, and they are more used

Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

2018-07-03 Thread Felix Fietkau
On 2018-07-03 12:57, Kalle Valo wrote: >>> To me that does not make any sense, I have never heard about bit >>> endianness any of the devices I have worked on. >> >> Unfortunately, the order in which these fields are laid out is different >> between big and little endian, even when only dealing wit

Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

2018-07-03 Thread Kalle Valo
Felix Fietkau writes: > On 2018-07-03 08:14, Kalle Valo wrote: >> Pkshih writes: >> >>> On Fri, 2018-06-29 at 10:30 +0300, Kalle Valo wrote: Pkshih writes: > On Tue, 2018-05-29 at 08:18 +0300, Kalle Valo wrote: >> writes: >>  > > Because C2H data is little

Re: [PATCH v2] mac80211: Fix wlan freezes under load at rekey

2018-07-03 Thread Johannes Berg
On Fri, 2018-06-29 at 23:14 +0200, Alexander Wetzel wrote: > I was wrong here, this is not an issue. Tkip is simply dropping frames > when the IV is too small and never verifies the MIC. And since only MIC > errors can trigger counter measures we are fine as it is... Err, yes, of course. My bad.

Re: [PATCH] mac80211: add stop/start logic for software TXQs

2018-07-03 Thread Johannes Berg
On Mon, 2018-07-02 at 14:48 +0530, Manikanta Pubbisetty wrote: > > > > > @@ -298,10 +354,15 @@ static void __ieee80211_wake_queue(struct > > > ieee80211_hw *hw, int queue, > > > if (local->q_stop_reasons[queue][reason] == 0) > > > __clear_bit(reason, &local->queue_stop

Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

2018-07-03 Thread Felix Fietkau
On 2018-07-03 08:14, Kalle Valo wrote: > Pkshih writes: > >> On Fri, 2018-06-29 at 10:30 +0300, Kalle Valo wrote: >>> Pkshih writes: >>> >>> > On Tue, 2018-05-29 at 08:18 +0300, Kalle Valo wrote: >>> >> writes: >>> >>  >>> > >>> > Because C2H data is little endian order, the struct will look l