On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote:
Another update, addressing most of the concerns raised in the last
round:
- Added schedule_start()/end() functions that adds locking around the
whole scheduling operation, which means we can get rid of the 'first'
parameter to
As a side note (good work!) - I would dearly like to visibly account
for management frames somewhere that can be seen from userspace. ?
Per frame airtime estimation could be used to track outstanding airtime
of each txq and can be used to throttle ieee80211_tx_dequeue(). This
mechanism on its own will get us the queue limiting and latency
reduction goodness for firmwares with deep queues. And for that it can
be completely
On 2018-09-20 01:30, Toke Høiland-Jørgensen wrote:
Rajkumar Manoharan writes:
Per frame airtime estimation could be used to track outstanding
airtime
of each txq and can be used to throttle ieee80211_tx_dequeue(). This
mechanism on its own will get us the queue limiting and latency
reduction
Hello,
Hope all is well!
We are a database organization. We provide business executives' contact
information.
Below, I've included a few examples:
Industry-Specific Lists: Agriculture, Business Services, Chambers of
Commerce, Cities, Towns & Municipalities, Construction, Consumer
On Fri, 2018-09-14 at 12:36 +0200, Jason A. Donenfeld wrote:
> Hi again,
Hi Jason,
> I can confirm that this issue is still present in 4.18. I'm receiving
> very frequent disconnections:
>
> [ 304.707603] wlan0: deauthenticated from <> (Reason:
> 6=CLASS2_FRAME_FROM_NONAUTH_STA)
>
> The last
On Thu, 2018-09-20 at 16:45 +0200, Sedat Dilek wrote:
> On Thu, Sep 20, 2018 at 4:34 PM, Luciano Coelho
> wrote:
> > On Thu, 2018-09-20 at 15:42 +0200, Sedat Dilek wrote:
> > > Hi,
> >
> > Hi,
> >
> >
> > > I am seeing this with Linux v4.18.y and v4.19-rc4.
> > >
> > > Investigating
On Thu, Sep 20, 2018 at 4:34 PM, Luciano Coelho
wrote:
> On Thu, 2018-09-20 at 15:42 +0200, Sedat Dilek wrote:
>> Hi,
>
> Hi,
>
>
>> I am seeing this with Linux v4.18.y and v4.19-rc4.
>>
>> Investigating thermal_zone3...
>>
>> # cat /sys/devices/virtual/thermal/thermal_zone3/type
>> iwlwifi
>>
>>
On Thu, 2018-09-20 at 15:42 +0200, Sedat Dilek wrote:
> Hi,
Hi,
> I am seeing this with Linux v4.18.y and v4.19-rc4.
>
> Investigating thermal_zone3...
>
> # cat /sys/devices/virtual/thermal/thermal_zone3/type
> iwlwifi
>
> I have the following iwlwifi device and firmware installed...
>
> [
On 09/20/2018 12:31 AM, Johannes Berg wrote:
On Wed, 2018-09-19 at 13:47 -0700, Ben Greear wrote:
For one, the driver has no concept of the original vif, since monitor
vifs aren't added to it.
ath10k does create a monitor vif, but maybe it is not mapped directly
to mac80211.
It's
Hi,
I am seeing this with Linux v4.18.y and v4.19-rc4.
Investigating thermal_zone3...
# cat /sys/devices/virtual/thermal/thermal_zone3/type
iwlwifi
I have the following iwlwifi device and firmware installed...
[ 10.476589] iwlwifi :04:00.0: loaded firmware version
36.e91976c0.0 op_mode
On Thu, Sep 20, 2018 at 03:30:05PM +0200, Simon Wunderlich wrote:
> Hi Dan,
>
> whoops, right ... thank you!
>
> Will do in a v2, at least if this patch is wanted. :)
>
These are automated emails, I just look at them and forward them. I
don't actually "love your patch" because I haven't even
Hi Dan,
whoops, right ... thank you!
Will do in a v2, at least if this patch is wanted. :)
Thank you!
Simon
On Thursday, September 20, 2018 12:20:14 PM CEST Dan Carpenter wrote:
> Hi Simon,
>
> I love your patch! Perhaps something to improve:
>
> url:
>
On 2018-09-20 11:11, Lorenzo Bianconi wrote:
> This series unify most of eeprom parsing between mt76x2 and
> mt76x0 driver. That patchset will be used to properly support
> mt76x0e chipsets without duplicating the code.
Merged patches 1-17. Transmit power handling will be unified in a
different
On Thu, Sep 20, 2018 at 11:12 AM Jouni Malinen wrote:
> On Thu, Sep 20, 2018 at 12:55:10AM +0200, Mathy Vanhoef wrote:
> > That figure only appears to be an example. It doesn't say an exchange
> > must ("shall") follow that order. So I don't see where the standard
> > puts a constraint on how the
zhong jiang writes:
> On 2018/9/20 20:07, Kalle Valo wrote:
>> zhong jiang wrote:
>>
>>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
>>> remove the condition check before debugfs_remove_recursive.
>>>
>>> Signed-off-by: zhong jiang
>> It seems you already submitted
print fw_ver and build_ver members of struct mt76x02_fw_header, similarly
to what appears in the output of 'dmesg' when the MCU firmware is loaded.
Reported-by: Sid Hayn
Signed-off-by: Davide Caratti
---
Notes:
This patch is based on top of Felix's pull request:
Takashi Iwai wrote:
> The ucode chunk might be relatively large and the allocation with
> kmalloc() may fail occasionally. Since the data isn't DMA-transferred
> but by manual loops, we can use vmalloc instead of kmalloc.
> For a better performance, though, kvmalloc() would be the best choice
>
Arend van Spriel wrote:
> Decoding of firmware channel information was not complete for 160MHz
> support. This resulted in the following warning:
>
> WARNING: CPU: 2 PID: at .../broadcom/brcm80211/brcmutil/d11.c:196
> brcmu_d11ac_decchspec+0x2e/0x100 [brcmutil]
> Modules linked
Ali MJ Al-Nasrawy wrote:
> Beacons+TIM are created/updated for fw beaconing only when BSS_CHANGED_BEACON.
> This is not compliant with power-saving stations.
> Fix it by updating beacon templates on mac80211 set_tim callback.
> Adresses the issue in:
>
Mesh path metric needs tx rate information from ieee80211_tx_status()
call but in ath10k there is no mechanism to report tx rate information
via ieee80211_tx_status(), the tx rate is only accessible via
sta_statiscs() op.
Per peer tx stats has tx rate info available, Tx rate is available
to
Current mac80211 has provision to update tx status through
ieee80211_tx_status() and ieee80211_tx_status_ext(). But
drivers like ath10k updates the tx status from the skb except
txrate, txrate will be updated from a different path, peer stats.
Using ieee80211_tx_status_ext() in two different
Hi Sebastian,
OK no problem. I can do that.
Can you just tell me what you need ; I mean which commands to export data ?
For nvram I guess you need 'nvram show' results ?
How I can do a "full flash transfer" ?
As you're dd-wrt dev, I add that I try last dd-wrt build (this one :
Larry Finger wrote:
> In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"),
> a condition is noted where the network controller needs to be reset. Note
> that this situation happens when running the open-source firmware
> (http://netweb.ing.unibs.it/~openfwwf/), plus a number
Felix Fietkau writes:
> Here's a large batch of mt76 code cleanup / deduplication / fixes,
> rebased to your latest wireless-drivers-next. This replaces the previous
> pull request.
>
> - Felix
>
> The following changes since commit 43e2f2904160b9a95aad77df9cbc1622910b8598:
>
> Merge
On Thu, 20 Sep 2018 02:57:21 -0700
Joe Perches wrote:
> On Thu, 2018-09-20 at 11:53 +0530, Ajay Singh wrote:
> > Cleanup patch to add extra spaces around the '/' to avoid the below
> > checkpatch warning.
> >
> > 'spaces preferred around that '/' (ctx:VxV)'
> >
> > Signed-off-by: Ajay Singh
>
since i'm mainly the dd-wrt developer and you tested it as well with the
same reproduceable crash it would be nice if you could provide me a
nvram backup with a reproduceable crash (you should change passwords of
course) to my private email. so i can apply it to my device and to see
whats
On Thursday, September 20, 2018 11:21:16 AM CEST Johannes Berg wrote:
> On Tue, 2018-09-18 at 16:16 +0200, Simon Wunderlich wrote:
> > Operating on a DFS channel doesn't mean we can't leave it for a short
> > time - actually, some features like off-channel CAC work by leaving the
> > operation
On Thu, 2018-09-20 at 11:53 +0530, Ajay Singh wrote:
> Cleanup patch to add extra spaces around the '/' to avoid the below
> checkpatch warning.
>
> 'spaces preferred around that '/' (ctx:VxV)'
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/linux_wlan.c | 2 +-
> 1 file
From: Johannes Berg
A simple cleanup, reuse the event definition that we already have.
Signed-off-by: Johannes Berg
---
net/wireless/trace.h | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/net/wireless/trace.h b/net/wireless/trace.h
index
On Tue, 2018-09-18 at 16:16 +0200, Simon Wunderlich wrote:
> Operating on a DFS channel doesn't mean we can't leave it for a short
> time - actually, some features like off-channel CAC work by leaving the
> operation channel to check other channels for availability (although
> off-channel CAC
Hi Simon,
I love your patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Simon-Wunderlich/mac80211-allow-scans-on-radar-channels-unless-there-is-CAC-or-CSA/20180919-071924
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git
master
New
Add mt76x02_get_rx_gain and mt76x02_get_lna_gain utility routines
for rx gain parsing. mt76x02_get_rx_gain and mt76x02_get_lna_gain
will be reused for eeprom parsing in mt76x0 driver
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x02_eeprom.c | 54 +++
Move mt76x02_eeprom_parse_hw_cap utility routine in mt76x02-lib
module in order to be reused in mt76x0 driver
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x02_eeprom.c | 19 +
.../wireless/mediatek/mt76/mt76x02_eeprom.h | 6 ++
Move mt76x2_eeprom_get utility routine in mt76x02_eeprom.h since
it will be used to parse mt76x0 eeprom in order to unify eeprom
support between mt76x2 and mt76x0 drivers
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x02_eeprom.h | 10 +++
Remove mt76x0_set_country_reg routine for the moment
since it is partial and it is not actually used
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 2 -
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 38 ---
Move shared eeprom utility routines in mt76x02_eeprom.h and
remove duplicated code
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 44 +--
.../wireless/mediatek/mt76/mt76x02_eeprom.h | 15 +++
.../wireless/mediatek/mt76/mt76x2_eeprom.c
Use mt76 shared debugfs implementation and remove duplicated code
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 66 +--
.../wireless/mediatek/mt76/mt76x0/mt76x0.h| 2 -
2 files changed, 1 insertion(+), 67 deletions(-)
diff --git
Unify temperature offset parsing with mt76x2 driver using
eeprom utility routines available in mt76x02-lib module
Signed-off-by: Lorenzo Bianconi
---
.../net/wireless/mediatek/mt76/mt76x0/debugfs.c| 3 ++-
drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c | 14 +++---
On Thu, Sep 20, 2018 at 12:55:10AM +0200, Mathy Vanhoef wrote:
> That figure only appears to be an example. It doesn't say an exchange
> must ("shall") follow that order. So I don't see where the standard
> puts a constraint on how the authentication frames are exchanged.
I know this figure is
Move mt76x2_tssi_enabled and mt76x02_temp_tx_alc_enabled in
mt76x02_eeprom.h in order to be reused in mt76x0 driver
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x02_eeprom.h | 21 +++
.../wireless/mediatek/mt76/mt76x2_eeprom.c| 4 ++--
Move mt76x2 and mt76x0 common definitions in mt76x02_eeprom.h
and remove duplicated code
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 18 +--
.../wireless/mediatek/mt76/mt76x0/eeprom.h| 71 +-
.../wireless/mediatek/mt76/mt76x02_eeprom.h |
Move mt76x2_efuse_read and mt76x2_get_efuse_data in mt76x02_eeprom.c
in order to be reused in mt76x0 driver for eeprom parsing
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/Makefile | 3 +-
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 59 +++
Unify lna gain parsing with mt76x2 driver using eeprom utility
routines available in mt76x02-lib module
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 5 +---
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 26 +++
Unify parse hw capabilities with mt76x2 driver using
mt76x02_eeprom_parse_hw_cap utility routine available
in mt76x02-lib module
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 33 +--
1 file changed, 8 insertions(+), 25 deletions(-)
diff
Move mt76x02_mac_setaddr utility routine in mt76x02-lib
module and remove duplicated code. This is a preliminary patch
to unify eeprom code between mt76x2 and mt76x0 driver
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 24 +--
From: Felix Fietkau
Add stbc tx power eeprom parsing support for mt76x2 driver.
Signed-off-by: Felix Fietkau
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/mt76.h | 3 ++-
drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c| 2 ++
Move seq_put_array utility routine in mt76-core module
in order to be reused in mt76x0 driver
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/debugfs.c | 12 +++
drivers/net/wireless/mediatek/mt76/mt76.h | 2 ++
.../wireless/mediatek/mt76/mt76x2_debugfs.c | 31
Unify rssi_offset parsing with mt76x2 driver using eeprom utility
routines available in mt76x02-lib module
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 7 +---
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 38 ---
In order to unify eeprom parsing between mt76x0 and mt76x2 drivers,
remove eeprom pointer dependency from mt76x0_set_tx_power_per_rate.
Moreover use mt76_rate_power to store power vs rate calibration data.
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 32
In order to unify eeprom parsing between mt76x0 and mt76x2 drivers,
remove eeprom pointer dependency from mt76x0_set_tx_power_per_chan
routine.
Remove mt76x0_eeprom_params since it is now an empty structure
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 4
Move mt76x2_ext_pa_enabled utility routine in mt76x02_eeprom.c
and remove duplicated code. This is a preliminary patch to
unify eeprom code between mt76x2 and mt76x0 driver
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/mt76x0/debugfs.c | 6 +-
This series unify most of eeprom parsing between mt76x2 and
mt76x0 driver. That patchset will be used to properly support
mt76x0e chipsets without duplicating the code.
Lorenzo Bianconi (19):
mt76: move seq_put_array in mt76-core module
mt76: move common eeprom definitions in mt76x02-lib
Unify frequency offset parsing with mt76x2 driver using
eeprom utility routines available in mt76x02-lib module
Signed-off-by: Lorenzo Bianconi
---
.../wireless/mediatek/mt76/mt76x0/debugfs.c | 3 ++-
.../wireless/mediatek/mt76/mt76x0/eeprom.c| 26 +--
Rajkumar Manoharan writes:
> Per frame airtime estimation could be used to track outstanding airtime
> of each txq and can be used to throttle ieee80211_tx_dequeue(). This
> mechanism on its own will get us the queue limiting and latency
> reduction goodness for firmwares with deep queues. And
Per frame airtime estimation could be used to track outstanding airtime
of each txq and can be used to throttle ieee80211_tx_dequeue(). This
mechanism on its own will get us the queue limiting and latency
reduction goodness for firmwares with deep queues. And for that it can
be completely
HI Sebastian,
I just flash the r7800 with the openwrt 18.06.1 factory image (here :
https://downloads.openwrt.org/releases/18.06.1/targets/ipq806x/generic/openwrt-18.06.1-ipq806x-netgear_r7800-squashfs-factory.img)
I forgot to mention that I get a beta hardware of the R7800, perhaps
there is
On Wed, 2018-09-19 at 13:47 -0700, Ben Greear wrote:
> > For one, the driver has no concept of the original vif, since monitor
> > vifs aren't added to it.
>
> ath10k does create a monitor vif, but maybe it is not mapped directly
> to mac80211.
It's actually created by mac80211, but only once,
can you tell me how to reproduce this crash? i have 2 r7800 running with
dd-wrt but no crashes
Am 19.09.2018 um 22:37 schrieb Bruno Rosset:
Hi all,
I get a firmware crash using latest openwrt 18.06.1 on the Netgear
R7800 with stock firmware
Dmesg is :
[ 13.804366] ath10k_pci :01:00.0:
Cleanup patch to add extra spaces around the '/' to avoid the below
checkpatch warning.
'spaces preferred around that '/' (ctx:VxV)'
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Cleanup patch to remove -I(src) and -DWILC_ASIC_A0 option used in
ccflag-y in Makefile.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/Makefile
b/drivers/staging/wilc1000/Makefile
index
Refactor wilc_netdev_init() to return the error code received from
register_netdev() during the failure condition.
Earlier discussion link
[1]. https://www.spinics.net/lists/linux-wireless/msg177304.html
Suggested-by: Claudiu Beznea
Signed-off-by: Ajay Singh
---
Changes to avoid the below checkpatch warning:
'usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt;'
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Deleted wilc_debugfs.c file as it's not used.
Earlier discussion link:
[1]. https://www.spinics.net/lists/linux-wireless/msg176076.html
Suggested-by: Greg KH
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 5 +-
drivers/staging/wilc1000/wilc_debugfs.c | 115
Avoid use of static variable and move them as part of private
data(wilc_priv) struct.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 2 +
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 60 +++
'wilc_connected_ssid' actually used to store the BSSID information for
connected BSSID. 'wilc_vif' already has 'bssid' variable to store the
same information. So refactor code to remove 'wilc_connected_ssid' and
instead used 'wilc_vif' struct 'bssid' element.
Signed-off-by: Ajay Singh
---
Use 'void' return for wilc_wlan_txq_filter_dup_tcp_ack() as it always
return value '1' and its not used by the caller.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
Cleanup changes to avoid unnecessary setting 'wilc->bus_data' value to
zero as the buffer was allocated using kzalloc().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 4 +---
drivers/staging/wilc1000/wilc_spi.c | 3 ---
2 files changed, 1 insertion(+), 6 deletions(-)
Instead of using static variable 'g_sdio' move it as part of 'wilc'
struct. Also allocating the memory in the probe function and free during
deinitialization.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 1 +
drivers/staging/wilc1000/wilc_sdio.c | 54
Rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals' as its more
appropriate for structure to store the values of string configuration.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 14 +++---
drivers/staging/wilc1000/wilc_wlan_cfg.h | 4 ++--
2 files changed,
Cleanup patch to remove the unused element stored in cfg struct.
Removed those wid from the cfg variables whose value is not
fetched(GET_CFG) from the code. In case the wid is only set to the
firmware then there is need to store them as part of cfg variables, so
removed the unused code.
Refactor the code in wilc_wlan_cfg.c file to avoid the use of static
variables. Move the static variables as part of wilc struct and also
dynamically allocating memory for keeping those variables.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 12 +-
Use the correct datatype for storing the byte value in 'wilc_cfg_byte'
struct.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.h
Refactor the code by removing use of 'mac_status' from 'wilc_mac_cfg'
and only have the string type configuration values in 'wilc_mac_cfg'
struct. Now fetch the value 'WID_STATUS' configuration from 'g_cfg_byte'
array.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c
Return 'void' from wilc_wlan_parse_info_frame() as same constant value
is returned always. Also removed the 'size' from input parameter as its
not used in the function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 12
1 file changed, 4 insertions(+), 8
Handle the setting of default value for 'wilc_cfg_rsp' type for all
cases in wilc_wlan_cfg_indicate_rx() as the caller make use of this
value to know the type of the received message.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 +--
1 file changed, 1 insertion(+),
Instead of using extra completion variable to handle the sync call now
using msg->is_sync flag to handle the sync call.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 23 +++
drivers/staging/wilc1000/host_interface.h | 2 +-
Cleanup patch to remove the wid type not used in the code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
b/drivers/staging/wilc1000/wilc_wlan_if.h
index b81a73b..ce2066b
Instead of using static variable 'g_spi' move it as part of 'wilc'
struct. Also allocating the memory in the probe function and
free is taken care in wilc_netdev_cleanup().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 58 +++--
1 file
Cleanup patch to use 'void' return type for wilc_wlan_cfg_indicate_rx(),
as its return value is not used in caller. The value set in
'rsp' argument is used to get the success status.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 8 ++--
Use 'void' return for wilc_wlan_txq_add_to_head() as its always
return '0' value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
Use 'void' return type for below functions as they always return '0' and
their return value is not used by caller.
add_tcp_pending_ack()
update_tcp_session()
add_tcp_pending_ack()
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 15 ++-
1 file changed, 6
Use 'void' return type for wilc_wfi_deinit_mon_interface(), as same
value always return.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_mon.c | 3 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff
Cleanup patch to use 'void' return type for wilc_deinit_host_int(),
as its return value is not used in caller.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +-
2 files changed, 2 insertions(+), 4
Change return type to 'void' for host_int_get_assoc_res_info() as its
return value is not used. 'rcvd_assoc_resp_info_len' parameter value is
used to know the status.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 11 +--
1 file changed, 5 insertions(+), 6
Cleanup patch to use 'void' return type for wlan_deinit_locks() &
wlan_init_locks(), as same value is return.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
Cleanup patch to use 'void' return type for wilc_frame_register(), as
its return value is not used.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 6 ++
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git
Cleanup patch to use 'void' return type for wilc_wlan_set_bssid(),
as its always returns the same value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 4 +---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
This patch series contains changes to avoid the use of static variables.
Cleanup changes to fix some checkpatch issues and return void for function
if their return value is not used.
Also deleted 'wilc_debugfs.c' file as it's not used
Changes since v1:
Address Dan's comment for patch#29
-
89 matches
Mail list logo
