Re: [PATCH] rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface

2018-09-22 Thread Nathan Chancellor
On Fri, Sep 21, 2018 at 03:08:24PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface'

[PATCH v2] rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface

2018-09-22 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34: warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversi

Re: [PATCH 2/4] dts: arm64/sdm845: Add WCN3990 WLAN module device node

2018-09-22 Thread kbuild test robot
Hi Govind, Thank you for the patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [PATCH 2/4] dts: arm64/sdm845: Add WCN3990 WLAN module device node

2018-09-22 Thread kbuild test robot
Hi Govind, Thank you for the patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [PATCH 12/12] rtwlan: Kconfig & Makefile

2018-09-22 Thread kbuild test robot
Hi Yan-Hsuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.

[PATCH v2] mac80211: allocate TXQs for active monitor interfaces

2018-09-22 Thread Felix Fietkau
Monitor mode interfaces with the active flag are passed down to the driver. Drivers using TXQ expect that all interfaces have allocated TXQs before they get added. Fixes: 79af1f866193d ("mac80211: avoid allocating TXQs that won't be used") Cc: sta...@vger.kernel.org Reported-by: Catrinel Catrinesc

Re: [PATCH] mac80211: allocate TXQs for active monitor interfaces

2018-09-22 Thread Felix Fietkau
On 2018-09-22 15:09, Felix Fietkau wrote: > Monitor mode interfaces with the active flag are passed down to the driver. > Drivers using TXQ expect that all interfaces have allocated TXQs before > they get added. > > Fixes: 79af1f866193d ("mac80211: avoid allocating TXQs that won't be used") > Cc:

[PATCH v2] brcmsmac: AP mode: update beacon when TIM changes

2018-09-22 Thread Ali MJ Al-Nasrawy
Beacons+TIM are created/updated for beaconing only when BSS_CHANGED_BEACON. This is not compliant with power-saving stations. Fix it by updating beacon templates on mac80211 set_tim callback. Signed-off-by: Ali MJ Al-Nasrawy --- .../broadcom/brcm80211/brcmsmac/mac80211_if.c | 21

Re: [PATCH] brcmsmac: ap mode: update beacon when TIM changes

2018-09-22 Thread Ali MJ Al-Nasrawy
On Sat, 22 Sep 2018 11:07:36 +0200 Arend van Spriel wrote: > On 9/11/2018 7:26 PM, Ali MJ Al-Nasrawy wrote: > > Beacons+TIM are created/updated for fw beaconing only when > > BSS_CHANGED_BEACON. This is not compliant with power-saving > > stations. Fix it by updating beacon templates on mac80211

[PATCH] mac80211: allocate TXQs for active monitor interfaces

2018-09-22 Thread Felix Fietkau
Monitor mode interfaces with the active flag are passed down to the driver. Drivers using TXQ expect that all interfaces have allocated TXQs before they get added. Fixes: 79af1f866193d ("mac80211: avoid allocating TXQs that won't be used") Cc: sta...@vger.kernel.org Reported-by: Catrinel Catrinesc

Re: [PATCH] mt76: fix return value of mt76x02_wait_for_mac

2018-09-22 Thread Felix Fietkau
On 2018-09-06 11:38, Stanislaw Gruszka wrote: > We need to return bool value in mt76x02_wait_for_mac. > > Reported-by: Dan Carpenter > Fixes: 2735a6dd7df3 ("mt76: unify wait_for_mac") > Signed-off-by: Stanislaw Gruszka Merged, thanks. - Felix

Re: [PATCH] mt76: usb: remove WARN_ON in mt76u_get_rx_entry_len

2018-09-22 Thread Felix Fietkau
On 2018-09-18 14:12, Lorenzo Bianconi wrote: > Remove not useful WARN_ON macros in mt76u_get_rx_entry_len routine > since corrupted frames should just be silently discarded > > Signed-off-by: Lorenzo Bianconi Merged, thanks.

[PATCH 8/9] mt76x0: use shared debugfs implementation

2018-09-22 Thread Lorenzo Bianconi
Use mt76 shared debugfs implementation and remove duplicated code in mt76x0 driver Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x0/debugfs.c | 80 +-- .../wireless/mediatek/mt76/mt76x0/mt76x0.h| 2 - 2 files changed, 1 insertion(+), 81 deletions(-) d

[PATCH 5/9] mt76x0: remove mt76x0_phy_set_tx_power and mt76x0_extra_power_over_mac

2018-09-22 Thread Lorenzo Bianconi
Remove mt76x0_extra_power_over_mac and mt76x0_phy_set_tx_power routines since they are not actually used and tx power handling will be unified with mt76x2 driver Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/phy.c | 38 --- 1 file changed, 38 deletio

[PATCH 7/9] mt76x0: remove eeprom dependency from mt76x0_get_power_info

2018-09-22 Thread Lorenzo Bianconi
In order to unify eeprom parsing between mt76x0 and mt76x2 drivers, remove eeprom pointer dependency from mt76x0_get_power_info routine. Remove mt76x0_eeprom_params since it is now an empty structure Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x0/debugfs.c | 5 - .../w

[PATCH 1/9] mt76: move mt76_rate_power in mt76_dev

2018-09-22 Thread Lorenzo Bianconi
Move mt76_rate_power data structure from mt76x2_dev to mt76_dev in order to share it with mt76x0 driver. Moreover move txpower_conf and txpower_cur in mt76_dev Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76.h | 30 +++ drivers/net/wireless/mediate

[PATCH 0/9] unify tx power eeprom parsing for mt76x{0,2}

2018-09-22 Thread Lorenzo Bianconi
This is the second of two series that unify eeprom code between mt76x2 and mt76x0 drivers. In particular this series unifies tx power eeprom parsing. That patchset will be used to properly support mt76x0e chipsets without duplicating the code. Lorenzo Bianconi (9): mt76: move mt76_rate_power in

[PATCH 9/9] mt76x0: phy: introduce mt76x0_phy_set_txpower routine

2018-09-22 Thread Lorenzo Bianconi
Add mt76x0_phy_set_txpower routine in order to configure base and per rate tx power gain. Moreover take into account txpower_conf in order to limit the tx power gain according to the bound provided by mac80211 Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/main.c | 7

[PATCH 2/9] mt76: add mt76x02_phy_set_txpower utility routine

2018-09-22 Thread Lorenzo Bianconi
Add mt76x02_phy_set_txpower utility routine in mt76x02_phy.c in order to be reused in mt76x0 tx power management code. Moreover move following routines in mt76x02-lib module: - mt76x02_tx_power_mask - mt76x02_get_max_rate_power - mt76x02_limit_rate_power - mt76x02_add_rate_power_offset Signed-off-

[PATCH 6/9] mt76x0: remove eeprom dependency from mt76x0_set_tx_power_per_rate

2018-09-22 Thread Lorenzo Bianconi
In order to unify eeprom parsing between mt76x0 and mt76x2 drivers, remove eeprom pointer dependency from mt76x0_set_tx_power_per_rate. Moreover use mt76_rate_power to store power vs rate calibration data. Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x0/debugfs.c | 32 ++

[PATCH 4/9] mt76: move mt76x02_rate_power_val in mt76x02-lib module

2018-09-22 Thread Lorenzo Bianconi
Move mt76x02_rate_power_val and mt76x2_sign_extend_optional utility routines in mt76x02_eeprom.h in order to reuse them in mt76x0 eeprom parsing Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x02_eeprom.h | 16 + .../wireless/mediatek/mt76/mt76x2_eeprom.c| 65 ++

[PATCH 3/9] mt76: move rate_txpower handler in mt76 debugfs

2018-09-22 Thread Lorenzo Bianconi
Move rate_txpower handler in mt76 debugfs in order to be reused in mt76x0 driver and remove duplicated code Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/debugfs.c | 19 +++ .../wireless/mediatek/mt76/mt76x2_debugfs.c | 10 -- 2 files changed,

Re: [PATCH] brcmsmac: ap mode: update beacon when TIM changes

2018-09-22 Thread Arend van Spriel
On 9/11/2018 7:26 PM, Ali MJ Al-Nasrawy wrote: Beacons+TIM are created/updated for fw beaconing only when BSS_CHANGED_BEACON. This is not compliant with power-saving stations. Fix it by updating beacon templates on mac80211 set_tim callback. Adresses the issue in: https://marc.info/?i=20180911163

Re: Netgear R7800 - ath10k QCA 9984 firmware crash

2018-09-22 Thread Sebastian Gottschall
btw. you can do the backup also with openwrt of course. i just need a backup of the flash memory. ben already wrote that my guess about a different location for the calibration data storage might be true. so find out the correct location i need to analyse the flash dump Am 21.09.2018 um 11:35