Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Dominique Martinet
Ellie Revves wrote on Thu, Oct 25, 2018: > Here's another boot log along with some commands after the system > booted up to show what I did. I don't think I did anything wrong, > and yet this is no different, debug option appears to be completely > useless. I'm not familiar with ath at all, just h

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Ellie Revves
Here's another boot log along with some commands after the system booted up to show what I did. I don't think I did anything wrong, and yet this is no different, debug option appears to be completely useless. http://ix.io/1pY0 Thanks Tom Psyborg a écrit : if your system is read-only then you s

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Tom Psyborg
if your system is read-only then you should make a build with debug option enabled: inside your buildroot create this path: files/etc/modules.d/ and put file named ath9k there which should contain "ath9k debug=0x" (more info: https://openwrt.org/docs/guide-developer/build-system/use-build

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Ellie Revves
Hi, CONFIG_ATH9K_PCOEM is already enabled in my kernel build. In fact if it is disabled my card does not show up at all. Thanks Tom Psyborg a écrit : Hi Try selecting config option ATH9K_SUPPORT_PCOEM (Support chips used in PC OEM cards) and rebuild your image. I'm not familiar with your arc

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Tom Psyborg
Hi Try selecting config option ATH9K_SUPPORT_PCOEM (Support chips used in PC OEM cards) and rebuild your image. I'm not familiar with your architecture but it seems you're not getting debug output. It should print a lot of info right after the: ath: phy0: WB335 2-ANT card detected

Re: [PATCH 2/4] ath10k: snoc: fix unabalanced regulator error handling

2018-10-24 Thread Brian Norris
Hi, On Thu, Oct 18, 2018 at 10:54:39AM -0700, Doug Anderson wrote: > On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > > + if (vreg_info->settle_delay) > > + udelay(vreg_info->settle_delay); > > Not new to your patch, but this seems like a duplication of what the > regula

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Ellie Revves
Hi, well I enabled CONFIG_ATH_DEBUG and booted this kernel, sorry for the mess of escape sequence but I captured via serial console: http://ix.io/1pWI I don't see anything different even if I cranked up ath9k.debug= to the *any* value. I guess this thing happens so early at boot that nothing u

Re: [PATCH 5/6] ath10k: migrate to mac80211 txq scheduling

2018-10-24 Thread Rajkumar Manoharan
On 2018-10-24 01:33, Kalle Valo wrote: Rajkumar Manoharan writes: ath10k maintains common txqs list for all stations. This txq management can be removed by migrating to mac80211 txq APIs and let mac80211 handle txqs reordering based on reported airtime. By doing this, txq fairness maintained i

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Andy Lutomirski
On Wed, Oct 24, 2018 at 12:05 AM Johannes Berg wrote: > > From: Johannes Berg > > These files have a long history of code changes, but analysing > the remaining code leads to having only a few changes that are > not already owned by Intel, notably from > - Andy Lutomirski > - Joonwoo Park >

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Ellie Revves
Hi, sure, I enabled atheros wireless debugging in my kernel and am rebuilding it. After this is done, should I set ath9k.debug= on the cmdline ? It is built as module, but my filesystem is read-only so no modprobe.d snippet can be added. Thanks Tom Psyborg a écrit : Hi There was similar iss

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Rajat Jain
On Wed, Oct 24, 2018 at 12:05 AM Johannes Berg wrote: > > From: Johannes Berg > > These files have a long history of code changes, but analysing > the remaining code leads to having only a few changes that are > not already owned by Intel, notably from > - Andy Lutomirski > - Joonwoo Park >

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Joonwoo Park
Acked-by: Joonwoo Park On Wed, Oct 24, 2018 at 6:22 AM Stanislaw Gruszka wrote: > > On Wed, Oct 24, 2018 at 09:04:36AM +0200, Johannes Berg wrote: > > From: Johannes Berg > > > > These files have a long history of code changes, but analysing > > the remaining code leads to having only a few cha

[ANN] wireless-regdb: master-2018-10-24

2018-10-24 Thread Seth Forshee
A new release of wireless-regdb (master-2018-10-24) is available at: https://www.kernel.org/pub/software/network/wireless-regdb/wireless-regdb-2018.10.24.tar.gz The short log of changes since the 2018-09-07 release is below. Thanks, Seth --- Hauke Mehrtens (1): wireless-regdb: remove dep

dynack slows down network when enabled on AR9462 card

2018-10-24 Thread Tom Psyborg
Hi Running several tests with dynack enabled on AR9462 card I can see throughput drop in 10-30Mbps range. The card is running on 4.9.135 kernel (same issue was present on 3.2.11 with backports4.4.2) while QCA9531 router is running 4.9.111. Distance between the two is less than 1m. Results: QCA9

Re: [PATCH] wireless-regdb: remove dependency to python attr

2018-10-24 Thread Seth Forshee
Please remember to Cc wireless-re...@lists.infradead.org for regdb changes, adding now. On Sat, Oct 06, 2018 at 06:02:54PM +0200, Hauke Mehrtens wrote: > Commit 8607edfdb6568 ("wireless-regdb: Parse wmm rule data") introduced > a dependency to the python module attr which is not included by defaul

Re: [GIT] Networking

2018-10-24 Thread Linus Torvalds
On Wed, Oct 24, 2018 at 2:24 PM Andy Gross wrote: > > Yes this will conflict with Niklas's patch which is part of the 4.20 > pull requests. I would prefer that we revert Linus's and take Niklas's > unless there is a compelling argument to have it fixed before -rc1. I have no objection to just rev

Re: Request for brcmfmac4366c-pcie.bin

2018-10-24 Thread Sebastien Floury
Hi, This is a follow-up to these two past threads concerning the 4366c firmware: https://www.spinics.net/lists/linux-wireless/msg159634.html https://www.spinics.net/lists/linux-wireless/msg172063.html I wanted to if we can still expect the firmware to be released by the end of the year? Has it

Re: [GIT] Networking

2018-10-24 Thread Andy Gross
Sorry for spam, I am resending in cleartext because the previous missed the lists. Thanks Google for resetting my config when you 'upgraded'. On Wed, 24 Oct 2018 at 09:05, Kalle Valo wrote: > > Kalle Valo writes: > > > Linus Torvalds writes: > > > >> On Wed, Oct 24, 2018 at 7:01 AM Linus Torva

Re: [PATCH] ath9k: Fix a locking bug in ath9k_add_interface()

2018-10-24 Thread Kalle Valo
Dan Carpenter writes: > On Wed, Oct 24, 2018 at 08:50:52AM +0300, Kalle Valo wrote: >> Dan Carpenter writes: >> >> > We tried to revert commit d9c52fd17cb4 ("ath9k: fix tx99 with monitor >> > mode interface") but accidentally missed part of the locking change. >> > >> > The lock has to be held

Re: [PATCH] ath9k: Fix a locking bug in ath9k_add_interface()

2018-10-24 Thread Dan Carpenter
On Wed, Oct 24, 2018 at 08:50:52AM +0300, Kalle Valo wrote: > Dan Carpenter writes: > > > We tried to revert commit d9c52fd17cb4 ("ath9k: fix tx99 with monitor > > mode interface") but accidentally missed part of the locking change. > > > > The lock has to be held earlier so that we're holding it

Re: ath9k driver may be broken on ARM64 ?

2018-10-24 Thread Tom Psyborg
Hi There was similar issue reported in forum recently: https://forum.openwrt.org/t/wireless-card-atheros-ar9565/23608 Could you enable ath9k debug and post output?

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Stanislaw Gruszka
On Wed, Oct 24, 2018 at 09:04:36AM +0200, Johannes Berg wrote: > From: Johannes Berg > > These files have a long history of code changes, but analysing > the remaining code leads to having only a few changes that are > not already owned by Intel, notably from > - Andy Lutomirski > - Joonwoo Pa

Re: [PATCH v2] wireless: mark expected switch fall-throughs

2018-10-24 Thread Julian Calaby
Hi Gustavo, On Wed, Oct 24, 2018 at 7:36 AM Johannes Berg wrote: > > On Tue, 2018-10-23 at 12:58 +0200, Gustavo A. R. Silva wrote: > > On 10/23/18 10:59 AM, Gustavo A. R. Silva wrote: > > > > > > On 10/23/18 9:01 AM, Johannes Berg wrote: > > > > On Tue, 2018-10-23 at 02:13 +0200, Gustavo A. R. Si

Re: [PATCH] wireless: airo: potential buffer overflow in sprintf()

2018-10-24 Thread Amir Goldstein
On Wed, Oct 24, 2018 at 12:23 PM Kalle Valo wrote: > > Dan Carpenter writes: > > > On Wed, Oct 24, 2018 at 11:56:53AM +0300, Kalle Valo wrote: > >> Dan Carpenter writes: > >> > >> > It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes > >> > of the ssid, but we accidentally us

Re: [PATCH] wireless: airo: potential buffer overflow in sprintf()

2018-10-24 Thread Kalle Valo
Dan Carpenter writes: > On Wed, Oct 24, 2018 at 11:56:53AM +0300, Kalle Valo wrote: >> Dan Carpenter writes: >> >> > It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes >> > of the ssid, but we accidentally use "%*s" (width) instead of "%.*s" >> > (precision) so if the ssid

Re: [PATCH] wireless: airo: potential buffer overflow in sprintf()

2018-10-24 Thread Dan Carpenter
On Wed, Oct 24, 2018 at 11:56:53AM +0300, Kalle Valo wrote: > Dan Carpenter writes: > > > It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes > > of the ssid, but we accidentally use "%*s" (width) instead of "%.*s" > > (precision) so if the ssid doesn't have a NUL terminator t

Re: [PATCH] wireless: airo: potential buffer overflow in sprintf()

2018-10-24 Thread Kalle Valo
Dan Carpenter writes: > It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes > of the ssid, but we accidentally use "%*s" (width) instead of "%.*s" > (precision) so if the ssid doesn't have a NUL terminator this could lead > to an overflow. > > Fixes: e174961ca1a0 ("net: conver

Re: [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()

2018-10-24 Thread Kalle Valo
Wei Yongjun writes: > The return value from devm_memremap() is not checked correctly. > The test is done against a wrong variable. This patch fix it. > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > Signed-off-by: Wei Yongjun Please don't mark wireless patches

Re: [PATCH 6/6] ath10k: reporting estimated tx airtime for fairness

2018-10-24 Thread Kalle Valo
Rajkumar Manoharan writes: > Transmit airtime will be estimated from last tx rate used. > Firmware report tx rate by peer stats. Airtime is computed > on tx path and the same will be reported to mac80211 upon > tx completion. > > Signed-off-by: Kan Yan > Signed-off-by: Rajkumar Manoharan Same

[PATCH] wireless: airo: potential buffer overflow in sprintf()

2018-10-24 Thread Dan Carpenter
It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes of the ssid, but we accidentally use "%*s" (width) instead of "%.*s" (precision) so if the ssid doesn't have a NUL terminator this could lead to an overflow. Fixes: e174961ca1a0 ("net: convert print_mac to %pM") Signed-off-by:

Re: [PATCH 5/6] ath10k: migrate to mac80211 txq scheduling

2018-10-24 Thread Kalle Valo
Rajkumar Manoharan writes: > ath10k maintains common txqs list for all stations. This txq > management can be removed by migrating to mac80211 txq APIs > and let mac80211 handle txqs reordering based on reported airtime. > By doing this, txq fairness maintained in ath10k i.e processing > N frames

Re: [GIT] Networking

2018-10-24 Thread Kalle Valo
Kalle Valo writes: > Linus Torvalds writes: > >> On Wed, Oct 24, 2018 at 7:01 AM Linus Torvalds >> wrote: >>> >>> Hmm. Tentatively pulled, but there's something wrong with the Kconfig rules. >> >> Confirmed. > > BTW, our emails crossed and more info in the other email[1]. > >> I did a978a5b8d83

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Kirtika Ruchandani
On Wed, Oct 24, 2018 at 12:05 AM Johannes Berg wrote: > > From: Johannes Berg > > These files have a long history of code changes, but analysing > the remaining code leads to having only a few changes that are > not already owned by Intel, notably from > - Andy Lutomirski > - Joonwoo Park >

Re: [GIT] Networking

2018-10-24 Thread Kalle Valo
Linus Torvalds writes: > On Wed, Oct 24, 2018 at 7:01 AM Linus Torvalds > wrote: >> >> Hmm. Tentatively pulled, but there's something wrong with the Kconfig rules. > > Confirmed. BTW, our emails crossed and more info in the other email[1]. > I did a978a5b8d83f ("net/kconfig: Make QCOM_QMI_HELP

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Sedat Dilek
On Wed, Oct 24, 2018 at 9:36 AM Johannes Berg wrote: > > On Wed, 2018-10-24 at 09:33 +0200, Sedat Dilek wrote: > > > > > Align the licenses with their permission to clean up and to > > > make it all identical. > > > > > > > Does it make sense to put the BSD license (text) in a separate file > > (l

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Johannes Berg
On Wed, 2018-10-24 at 09:33 +0200, Sedat Dilek wrote: > > > Align the licenses with their permission to clean up and to > > make it all identical. > > > > Does it make sense to put the BSD license (text) in a separate file > (like GPL) and reference it? I agree that it would, and in fact we alr

Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Sedat Dilek
On Wed, Oct 24, 2018 at 9:05 AM Johannes Berg wrote: > > From: Johannes Berg > > These files have a long history of code changes, but analysing > the remaining code leads to having only a few changes that are > not already owned by Intel, notably from > - Andy Lutomirski > - Joonwoo Park > -

Re: [GIT] Networking

2018-10-24 Thread Kalle Valo
+ linux-wireless, ath10k, niklas, jeff, andy, david Linus Torvalds writes: > On Wed, Oct 24, 2018 at 4:30 AM David Miller wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > > Hmm. Tentatively pulled, but there's something wrong with the Kconfig rules. > > Doing "m

[PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Johannes Berg
From: Johannes Berg These files have a long history of code changes, but analysing the remaining code leads to having only a few changes that are not already owned by Intel, notably from - Andy Lutomirski - Joonwoo Park - Kirtika Ruchandani - Rajat Jain - Stanislaw Gruszka remaining in