Re: [RFC v4 08/13] rtw88: debug files

On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > > Joe Perches writes: [] > > > It's very unusual to have _all_ the logging under a CONFIG__DEBUG > > > config guard flag. > > > > For wireless drivers that is actually quite typical. >

Re: [RFC v5 08/13] rtw88: debug files

On Wed, 2018-10-31 at 18:12 +0800, yhchu...@realtek.com wrote > From: Yan-Hsuan Chuang > debug files for Realtek 802.11ac wireless network chips [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.h > b/drivers/net/wireless/realtek/rtw88/debug.h [] > +#ifdef CONFIG_RTW88_DEBUG [] > +#else

Re: atk10k Unknown eventid and WARN() on resume with kernel 4.19

Am Sa., 3. Nov. 2018 um 21:01 Uhr schrieb Gabriel C : > > Hello, > > starting with kernel 4.19 we noticed 'Unknown eventid: ' warnings > on our Laptops. > > ... > > crazy@devnull:~$ dmesg | grep Unknow > [7.144998] ath10k_pci :03:00.0: Unknown eventid: 118809 > [7.147758] ath10k_pc

atk10k Unknown eventid and WARN() on resume with kernel 4.19

Hello, starting with kernel 4.19 we noticed 'Unknown eventid: ' warnings on our Laptops. ... crazy@devnull:~$ dmesg | grep Unknow [7.144998] ath10k_pci :03:00.0: Unknown eventid: 118809 [7.147758] ath10k_pci :03:00.0: Unknown eventid: 90118 [9.441654] ath10k_pci :03:

Re: [PATCH v2] libertas: return errno from lbs_add_card()

On Sun 2018-10-07 02:33:27, Lubomir Rintel wrote: > This makes the error handling somewhat cleaner -- lbs_add_card() does no > logner throw away the errno and lets its callers propagate it. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pave

Re: [PATCH 4/5] b43: Use common cordic algorithm from kernel lib

On 11/3/18 4:59 AM, Priit Laes wrote: Signed-off-by: Priit Laes Where is the commit message? The stuff in the cover letter (Patch 0/N) never makes it to the git repository. You must have a message in each of the individual patches. NACK. Larry --- drivers/net/wireless/broadcom/b43/Kco

[PATCH 5/5] b43: Drop internal cordic algorithm implementation

Signed-off-by: Priit Laes --- drivers/net/wireless/broadcom/b43/phy_common.c | 47 +--- drivers/net/wireless/broadcom/b43/phy_common.h | 9 + 2 files changed, 56 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/phy_common.c b/drivers/net/wireless/broadcom/b43/phy

[PATCH 0/5] Use common cordic algorithm for b43

b43 wireless driver included internal implementation of cordic algorithm which has now been removed in favor of library implementation. During the process, brcmfmac was driver was also cleaned. Please note that this series is only compile-tested, as I do not have access to the hardware. Priit La

[PATCH 2/5] brcmfmac: Use common CORDIC_FLOAT macro from lib

Now that cordic library has the CORDIC_FLOAT macro, use that Signed-off-by: Priit Laes --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 ++-- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 3/5] brcmfmac: Drop unused cordic defines and macros

Now that we use library macros, we can drop internal copies Signed-off-by: Priit Laes --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +--- 1 file changed, 7 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h b/drivers/net/wirele

[PATCH 4/5] b43: Use common cordic algorithm from kernel lib

Signed-off-by: Priit Laes --- drivers/net/wireless/broadcom/b43/Kconfig | 1 + drivers/net/wireless/broadcom/b43/phy_lp.c | 13 +++-- drivers/net/wireless/broadcom/b43/phy_n.c | 13 +++-- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/broa