Re: [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373

2018-11-20 Thread Madhan Mohan R
On Mon, Nov 12, 2018 at 10:13:07AM +0100, Arend van Spriel wrote: > On 11/12/2018 8:29 AM, Chi-Hsien Lin wrote: > >From: Madhan Mohan R > > > >Along with F2 watermark (existing) configuration, F1 MesBusyCtrl > >should be enabled & configured to avoid overflow errors. > > I am a bit confused. Why

Re: [PATCH V2 6/8] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic

2018-11-20 Thread Chi-Hsien Lin
(+Madhan) On 11/12/2018 5:25, Arend van Spriel wrote: > On 11/12/2018 8:29 AM, Chi-Hsien Lin wrote: >> From: Naveen Gupta >> >> The number of words that the read FIFO has to contain except >> the end of frame before sends data back to the host. >> Max watermark = (512B - 2* (BurstLength))/4 = >>

Re: [PATCH V2 7/8] brcmfmac: 4373 save-restore support

2018-11-20 Thread Chi-Hsien Lin
On 11/12/2018 6:30, Arend van Spriel wrote: > On 11/12/2018 8:29 AM, Chi-Hsien Lin wrote: >> Use sr_eng_en bit to check 4373 sr support. >> >> Reviewed-by: Arend van Spriel >> Signed-off-by: Chi-Hsien Lin >> --- >>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 5 + >>  1 file c

Re: [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373

2018-11-20 Thread Arend van Spriel
On 11/20/2018 9:50 AM, Madhan Mohan R wrote: On Mon, Nov 12, 2018 at 10:13:07AM +0100, Arend van Spriel wrote: On 11/12/2018 8:29 AM, Chi-Hsien Lin wrote: From: Madhan Mohan R Along with F2 watermark (existing) configuration, F1 MesBusyCtrl should be enabled & configured to avoid overflow err

mac80211_hwsim: multiple antennas

2018-11-20 Thread Ramon Fontes
Would be possible to simulate (or even add support to) multiple antennas? I was trying to extend wmediumd to 802.11n according the rates provided by http://mcsindex.com/, but the maximum rate I get is ~33Mbps, even if I set the MCS index to 15. Given the result, I thought that it could be related t

rt2800 tx frame dropping issue.

2018-11-20 Thread Daniel Santos
Hello, I'm coming to this issue rather late and I realize there has been much ado about it.  I want to follow up on a thread from 3 months ago https://marc.info/?l=linux-wireless&m=153511575812945 > I get testing results from T-Bone user in bugzilla: > https://bugzilla.kernel.org/show_bug.cgi?id=

[PATCH 0/8] brcmfmac: chip related changes

2018-11-20 Thread Chi-Hsien Lin
This patch series includes various chip-related changes: * 43012 support * 4373 saverestore support * SDIO bus settings * 4354 raw chipid Changelog: V3: - Update comments for patch 3. - Add defines for sr_control0 register bits in patch 7. V2: - Update commit message for patch 1. - Update comm

[PATCH 1/8] brcmfmac: add 4354 raw pcie device id

2018-11-20 Thread Chi-Hsien Lin
From: Winnie Chang Add the raw 4354 PCIe device ID for unprogrammed Cypress boards. Reviewed-by: Arend Van Spriel Signed-off-by: Winnie Chang Signed-off-by: Chi-Hsien Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 + drivers/net/wireless/broadcom/brcm80211/include/

[PATCH 2/8] brcmfmac: set F2 watermark to 256 for 4373

2018-11-20 Thread Chi-Hsien Lin
From: Wright Feng We got SDIO_CRC_ERROR with 4373 on SDR104 when doing bi-directional throughput test. Enable watermark to 256 to guarantee the operation stability. Reviewed-by: Arend van Spriel Signed-off-by: Wright Feng Signed-off-by: Chi-Hsien Lin --- .../wireless/broadcom/brcm80211/brcmf

[PATCH 4/8] brcmfmac: add support for CYW43012 SDIO chipset

2018-11-20 Thread Chi-Hsien Lin
CYW43012 is a 1x1 802.11a/b/g/n Dual-Band HT20, 256-QAM/Turbo QAM. It is an Ultra Low Power WLAN+BT combo chip. Reviewed-by: Arend van Spriel Signed-off-by: Chi-Hsien Lin Signed-off-by: Praveen Babu C --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 + .../wireless/broadcom/brcm8021

[PATCH 6/8] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic

2018-11-20 Thread Chi-Hsien Lin
From: Naveen Gupta The number of words that the read FIFO has to contain except the end of frame before sends data back to the host. Max watermark = (512B - 2* (BurstLength))/4 = (512 - 128)/4 = 384/4 = 0x60 so if burst length (i.e. BurstLength = 64) is increased, watermark has to be reduced. Thi

[PATCH 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373

2018-11-20 Thread Chi-Hsien Lin
From: Madhan Mohan R Along with F2 watermark (existing) configuration, F1 MesBusyCtrl should be enabled & sdio device RX FIFO watermark should be configured to avoid overflow errors. Reviewed-by: Arend van Spriel Signed-off-by: Madhan Mohan R Signed-off-by: Chi-Hsien Lin --- drivers/net/wire

[PATCH 5/8] brcmfmac: allow GCI core enumuration

2018-11-20 Thread Chi-Hsien Lin
GCI core is needed for ULP operation. Allow GCI core enumuration with below changes: - Allow GCI to be added to core list even when it doesn't have a wrapper. - Allow 8K address space size. - Don't overwrite the address value when an additional size descriptor is in place. Reviewed-by: Arend

[PATCH 7/8] brcmfmac: 4373 save-restore support

2018-11-20 Thread Chi-Hsien Lin
Use chipcommon sr_control0 register to check 4373 sr support. Reviewed-by: Arend van Spriel Signed-off-by: Chi-Hsien Lin --- .../wireless/broadcom/brcm80211/brcmfmac/chip.c| 5 + .../broadcom/brcm80211/include/chipcommon.h| 25 ++ 2 files changed, 30 inserti

[PATCH 8/8] brcmfmac: disable command decode in sdio_aos

2018-11-20 Thread Chi-Hsien Lin
From: Wright Feng AOS is a part of the SDIOD core that becomes active when the rest of SDIOD is sleeping to keep SDIO bus alive responding to reduced set of commands. Transaction between AOS and SDIOD is not protected, and if cmd 52 is received in AOS and in the middle of response state changed

[PATCH V4 2/8] brcmfmac: set F2 watermark to 256 for 4373

2018-11-20 Thread Chi-Hsien Lin
From: Wright Feng We got SDIO_CRC_ERROR with 4373 on SDR104 when doing bi-directional throughput test. Enable watermark to 256 to guarantee the operation stability. Reviewed-by: Arend van Spriel Signed-off-by: Wright Feng Signed-off-by: Chi-Hsien Lin --- .../wireless/broadcom/brcm80211/brcmf

[PATCH V4 0/8] brcmfmac: chip related changes

2018-11-20 Thread Chi-Hsien Lin
This patch series includes various chip-related changes: * 43012 support * 4373 saverestore support * SDIO bus settings * 4354 raw chipid Changelog: V4: - Removed bit defines for irrelevant registers from patch 7. - Correct patch 0 subject (missing V3). V3: - Update comments for patch 3. - Add

[PATCH V4 8/8] brcmfmac: disable command decode in sdio_aos

2018-11-20 Thread Chi-Hsien Lin
From: Wright Feng AOS is a part of the SDIOD core that becomes active when the rest of SDIOD is sleeping to keep SDIO bus alive responding to reduced set of commands. Transaction between AOS and SDIOD is not protected, and if cmd 52 is received in AOS and in the middle of response state changed

[PATCH V4 1/8] brcmfmac: add 4354 raw pcie device id

2018-11-20 Thread Chi-Hsien Lin
From: Winnie Chang Add the raw 4354 PCIe device ID for unprogrammed Cypress boards. Reviewed-by: Arend Van Spriel Signed-off-by: Winnie Chang Signed-off-by: Chi-Hsien Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 + drivers/net/wireless/broadcom/brcm80211/include/

[PATCH V4 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373

2018-11-20 Thread Chi-Hsien Lin
From: Madhan Mohan R Along with F2 watermark (existing) configuration, F1 MesBusyCtrl should be enabled & sdio device RX FIFO watermark should be configured to avoid overflow errors. Reviewed-by: Arend van Spriel Signed-off-by: Madhan Mohan R Signed-off-by: Chi-Hsien Lin --- drivers/net/wire

[PATCH V4 5/8] brcmfmac: allow GCI core enumuration

2018-11-20 Thread Chi-Hsien Lin
GCI core is needed for ULP operation. Allow GCI core enumuration with below changes: - Allow GCI to be added to core list even when it doesn't have a wrapper. - Allow 8K address space size. - Don't overwrite the address value when an additional size descriptor is in place. Reviewed-by: Arend

[PATCH V4 4/8] brcmfmac: add support for CYW43012 SDIO chipset

2018-11-20 Thread Chi-Hsien Lin
CYW43012 is a 1x1 802.11a/b/g/n Dual-Band HT20, 256-QAM/Turbo QAM. It is an Ultra Low Power WLAN+BT combo chip. Reviewed-by: Arend van Spriel Signed-off-by: Chi-Hsien Lin Signed-off-by: Praveen Babu C --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 + .../wireless/broadcom/brcm8021

[PATCH V4 7/8] brcmfmac: 4373 save-restore support

2018-11-20 Thread Chi-Hsien Lin
Use chipcommon sr_control0 register to check 4373 sr support. Reviewed-by: Arend van Spriel Signed-off-by: Chi-Hsien Lin --- .../net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 5 + .../wireless/broadcom/brcm80211/include/chipcommon.h | 19 +++ 2 files changed, 24 inse

[PATCH V4 6/8] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic

2018-11-20 Thread Chi-Hsien Lin
From: Naveen Gupta The number of words that the read FIFO has to contain except the end of frame before sends data back to the host. Max watermark = (512B - 2* (BurstLength))/4 = (512 - 128)/4 = 384/4 = 0x60 so if burst length (i.e. BurstLength = 64) is increased, watermark has to be reduced. Thi

Re: [PATCH 0/4] wireless: Use common cordic algorithm for b43 driver

2018-11-20 Thread Kalle Valo
Priit Laes writes: > On Mon, Nov 19, 2018 at 08:01:21PM +0200, Priit Laes wrote: >> b43 wireless driver includes an internal implementation of >> cordic algorithm, although there's a common cordic library >> which was split out from brcmsmac driver. Use that and drop >> internal implementation. >

pull-request: wireless-drivers 2018-11-20

2018-11-20 Thread Kalle Valo
Hi Dave, here's a pull request to net tree for 4.20, more info below. Please let me know if there are any problems. Kalle The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the git repository at: git://g

[PATCH mac80211-next v4] mac80211-next: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
This device takes over an existing network device and produces a new one that appears like a wireless connection, returning enough canned responses to nl80211 to satisfy a standard connection manager. If necessary, it can also be set up one step removed from an existing network device, such as thro

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
> I already said in v2 that you should not mark this for net-next as this > goes to mac80211-next (if it gets accepted), now you are just > unnecessarily confusing people. My fault, I misunderstood. The next version will be named correctly. The new version is uploaded here: https://lkml.org/lkml/

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
> > + informed_bss = > > + cfg80211_inform_bss_data(wiphy, &mock_inform_bss, > > +CFG80211_BSS_FTYPE_PRESP, > > +fake_router_bssid, > > +mock_inform_bss.bootti

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
> 1. Do not EVER submit HTML mails, mailing lists will automatically >reject them. So your mail didn't reach the lists and I only got it >because I was in the Cc field. I apologize, my mistake. > 2. Do not top post, it's really annoying: > > > https://wireless.wiki.kernel.org/en/devel

Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device

2018-11-20 Thread Cody Schuffelen
On Tue, Oct 9, 2018 at 1:25 AM Johannes Berg wrote: > > On Thu, 2018-10-04 at 12:59 -0700, Cody Schuffelen wrote: > > > > I wasn't completely clear on whether I should change the title (net-next > > to mac80211-next) so I left it as is for v3 to try to keep the patchwork > > series together. > > Y