Re: [RFC PATCH v2 0/2] Extended Key ID support for linux

2018-12-08 Thread Alexander Wetzel
I got the impression Extended Key IDs were added without updating all sections which should get updates. But the pattern is suspect, even the igtk numbers fit into the pattern: PTK 0 & 1 GTK 1 & 2 & 3 iGTK 4 & 5 An AP is allowed to do this, but there is no requirement for doing so. The

Re: [PATCH 2/5] mt76x02: fixup MT_PROT_RATE_* defines

2018-12-08 Thread Lorenzo Bianconi
> > On new mt76 chips, phy mode is configured by last 3 bits > of rate value. Hence OFDM bit is marked by 0x2000 > instead of 0x4000. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76x02_regs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH 5/5] mt76x2: initialize fall-back rate registers

2018-12-08 Thread Lorenzo Bianconi
> > Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG{0,1} registers. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h >

Re: [PATCH 4/5] mt76x2: initialize fall-back rate registers

2018-12-08 Thread Lorenzo Bianconi
> > Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG0 registers. > MT_VHT_HT_FBK_CFG1 was already configured. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76x2/init.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 1/5] mt76x02: do not set protection on set_rts_threshold callback

2018-12-08 Thread Lorenzo Bianconi
On Fri, Dec 7, 2018 at 2:27 PM Stanislaw Gruszka wrote: > > Use set_rts_threshold calback to enable/disable threshold only for > legacy traffic. > > Protection for HT and VHT traffic is defined by HT operation element > and it's provided by remote AP or by hostapd. > > Signed-off-by: Stanislaw