Re: mt76x[02]u 802.11w support

2018-12-14 Thread Sid Hayn
On Thu, Dec 13, 2018 at 9:39 AM Lorenzo Bianconi wrote: > > > Per a conversation with Lorenzo, it seems that 802.11w for mt76x[02]u > > has only been fixed in 4.20. As 4.19 is a LTS kernel, I'd like to > > request that work be backported. While the improvements in 4.20 and > > 4.21 are already f

Re: [EXTERNAL] Re: wlcore getting stuck on hikey after the runtime PM autosuspend support change

2018-12-14 Thread Ricardo Salveti
On Fri, Dec 14, 2018 at 9:29 PM Tony Lindgren wrote: > * Ricardo Salveti [181214 12:42]: > > Basically since commit 60f36637bbbd ("wlcore: sdio: allow pm to handle > > sdio power") PM is now handling the sdio power off/on process, and if > > wl12xx_sdio_power_on gets called right after wl12xx_sdi

[PATCH] staging: wilc1000: fix NULL dereference inside wilc_scan()

2018-12-14 Thread Ajay.Kathat
From: Ajay Singh Added NULL check before accessing 'hidden_net' pointer inside wilc_scan() to fix the issue found by static code checker. Fixes: 8f1a0ac1eba7 ("staging: wilc1000: handle scan operation callback from cfg80211 context") Reported-by: Dan Carpenter Signed-off-by: Ajay Singh --- d

Re: [EXTERNAL] Re: wlcore getting stuck on hikey after the runtime PM autosuspend support change

2018-12-14 Thread Tony Lindgren
* Ricardo Salveti [181214 12:42]: > Hi, > > On Thu, Dec 13, 2018 at 12:45 PM Tony Lindgren wrote: > > * Ricardo Salveti [181213 13:53]: > > > I tried just increasing WL1271_PRE_POWER_ON_SLEEP from 20ms to 50ms > > > (which gets used before calling wl12xx_sdio_power_on), and that was > > > alrea

Re: [EXTERNAL] Re: wlcore getting stuck on hikey after the runtime PM autosuspend support change

2018-12-14 Thread Ricardo Salveti
Hi, On Thu, Dec 13, 2018 at 12:45 PM Tony Lindgren wrote: > * Ricardo Salveti [181213 13:53]: > > I tried just increasing WL1271_PRE_POWER_ON_SLEEP from 20ms to 50ms > > (which gets used before calling wl12xx_sdio_power_on), and that was > > already enough to fix my issues on both hikey and beag

[PATCH 17/18] iwlwifi: dbg: add debug data to warning

2018-12-14 Thread Luca Coelho
From: Sara Sharon Add debug data to the warning issued when getting wrong region id from firmware. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/i

[PATCH 11/18] iwlwifi: mvm: clean up SSN incrementation

2018-12-14 Thread Luca Coelho
From: Sara Sharon Sometimes, due to SCD bug, we need to start the queue with an higher SSN. The queue allocation function currently increments the SSN in the packet itself, but it is pointless, since this value is overridden later by iwl_mvm_tx_mpdu with the value from mvmsta->tid_data[tid].seq_n

[PATCH 09/18] iwlwifi: mvm: take station lock later in the code

2018-12-14 Thread Luca Coelho
From: Sara Sharon There is no need to lock mvm station for transport reclaim. Move the locking down, after the reclaim. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 06/18] [BUGFIXiwlwifi: make MVM and DVM depend on MAC80211

2018-12-14 Thread Luca Coelho
From: Luca Coelho It's not the iwlwifi module that depends on mac80211, but iwlmvm and iwldvm. To reflect this better, make MVM and DVM Kconfig options depend on MAC80211 instead. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/Kconfig | 4 +++- 1 file changed, 3 insertions(

[PATCH 05/18] iwlwifi: mvm: fix setting HE ppe FW config

2018-12-14 Thread Luca Coelho
From: Naftali Goldstein The FW expects to get the ppe value for each NSS-BW pair in the same format as in the he phy capabilities IE, which means that a value of 0 implies ppe should be used for BPSK (mcs 0). If there are no PPE thresholds in the IE, or if for some NSS-RU pair there's no threshol

[PATCH 04/18] iwlwifi: mvm: cleanup iwl_mvm_tx_skb_non_sta

2018-12-14 Thread Luca Coelho
From: Sara Sharon Make the coupling of station id and queue id clear. Group code together. Remove outdated comment. Never use an undefined hw queue as given from mac80211. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 42 +-

[PATCH 08/18] iwlwifi: mvm: handle RX no data notification

2018-12-14 Thread Luca Coelho
From: Shaul Triebitz Handle RX no data notification, which is used for advertising NDP to radiotap. Signed-off-by: Golan Ben Ami Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/fw/api/datapath.h | 5 + .../net/wireless/intel/iwlwifi/fw/api/rx.h|

[PATCH 14/18] iwlwifi: mvm: set TWT responder capability bit in 11AX SoftAP mode

2018-12-14 Thread Luca Coelho
From: Emmanuel Grumbach This is needed to test TWT requester on the client side. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/

[PATCH 07/18] iwlwifi: split HE capabilities between AP and STA

2018-12-14 Thread Luca Coelho
From: Shaul Triebitz HE capabilities differ between AP and STA. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/iwl-nvm-parse.c| 289 -- 1 file changed, 188 insertions(+), 101 deletions(-) diff --git a/drivers/net/wireless/intel/iwl

[PATCH 18/18] iwlwifi: bump the API version to 43 for 9000 and 22000

2018-12-14 Thread Luca Coelho
From: Luca Coelho Bump the API version to 43 for 9000 and 22000 devices. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- drivers/net/wireless/intel/iwlwifi/cfg/9000.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wirel

[PATCH 10/18] iwlwifi: pcie: lock txq a bit later in reclaim code

2018-12-14 Thread Luca Coelho
From: Sara Sharon In reclaim code, we don't need to take the queue lock for waking the queue. The code section is executed only when the tx path is stopped, and since the reclaim path is not executed in parallel to itself, no one can update the queue pointers, and accessing them is safe without a

[PATCH 15/18] iwlwifi: mvm: fix spelling mistake "Recieved" -> "Received"

2018-12-14 Thread Luca Coelho
From: Colin Ian King Trivial fix to spelling mistake in debug message. Signed-off-by: Colin Ian King Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac8

[PATCH 13/18] iwlwifi: remove unused and wrong PHY_CFG_* macros

2018-12-14 Thread Luca Coelho
From: Luca Coelho These macros are never used and are actually wrong, so it's very confusing. Remove them. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/api/config.h | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/

[PATCH 12/18] iwlwifi: wrt: add rt status and num of rx/tx fifos to dump

2018-12-14 Thread Luca Coelho
From: Shahar S Matityahu Add the rt status of the last assert or 0 if the dump collection was not initiated by an assert. Add the number of rx and tx fifos in use. These fields are added to dump info lst file. Signed-off-by: Shahar S Matityahu Signed-off-by: Luca Coelho --- drivers/net/wirel

[PATCH 16/18] iwlwifi: mvm: d3: use struct_size() in kzalloc()

2018-12-14 Thread Luca Coelho
From: "Gustavo A. R. Silva" One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; };

[PATCH 00/18] iwlwifi: updates intended for v4.21 2018-12-14

2018-12-14 Thread Luca Coelho
From: Luca Coelho Hi, Here's the fourth set of patches intended for v4.21. It's the usual development, with support for a new FW version, some small new features, cleanups and bugfixes. The changes are: * Support for FW version 43 for 9000 and 22000 series; * A couple of janitorial fixes from

[PATCH 03/18] iwlwifi: mvm: remove pointless NULL assignment

2018-12-14 Thread Luca Coelho
From: Sara Sharon Assigning mvmsta to be NULL when we are about to exit the function is pointless. Remove it. Move the variable declaration to the scope it is used. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 6 +- 1 file changed

[PATCH 01/18] iwlwifi: pcie: use iwl_tx_cmd_gen2 and not iwl_tx_cmd

2018-12-14 Thread Luca Coelho
From: Sara Sharon When building AMSDU for gen2, code uses iwl_tx_cmd. The only updated field is len, which is in the same location, so it is not a bug. However, it is a bit confusing and error prone, so change it. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/

[PATCH 02/18] iwlwifi: mvm: remove dead code

2018-12-14 Thread Luca Coelho
From: Sara Sharon In iwl_mvm_tx_skb_non_sta(), in case of managed interface, the AP station was supposed to be used for multicast frames instead of the auxiliary station to avoid frames possibly sent to an absent P2P GO. However, when moving to DQA mode, this was broken as no valid queue was assi

[PATCH v4.20] iwlwifi: mvm: don't send GEO_TX_POWER_LIMIT to old firmwares

2018-12-14 Thread Luca Coelho
From: Emmanuel Grumbach Old firmware versions don't support this command. Sending it to any firmware before -41.ucode will crash the firmware. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201975 Fixes: 66e839030fd6 ("iwlwifi: fix wrong WGDS_WIFI_DATA_SIZE") CC: #4.19+ Signed-off-by:

Re: pull-request: iwlwifi-next 2018-12-14

2018-12-14 Thread Kalle Valo
Luca Coelho writes: > This is the third batch of patches intended for v4.21. This includes > only the last patchset I sent. Usual development work, continuing with > the new debugging infrastructure, some 802.11ax fixes in radiotap and > other small fixes and cleanups. More details about the c

Re: question: ip forwarding and fq/mq qdisc

2018-12-14 Thread Eric Dumazet
On 12/14/2018 06:12 AM, Sergey Matyukevich wrote: > Hi Eric, > > This patch fixes the issue: ip forwarding works for fq/mq qdisc. > Thanks for testing, I will send a formal patch for IPv4 and IPv6.

Re: question: ip forwarding and fq/mq qdisc

2018-12-14 Thread Sergey Matyukevich
> > Hi all, > > > > I have been running 4.18-rc8 kernel with enabled IP forwarding between > > wired and wireless interfaces, where both interfaces > > were configured as fq qdisc. > > > > However after moving to 4.20-rc1 kernel the same configuration does not > > work anymore: pass-through packe

pull-request: iwlwifi-next 2018-12-14

2018-12-14 Thread Luca Coelho
Hi Kalle, This is the third batch of patches intended for v4.21. This includes only the last patchset I sent. Usual development work, continuing with the new debugging infrastructure, some 802.11ax fixes in radiotap and other small fixes and cleanups. More details about the contents in the tag

Re: question: ip forwarding and fq/mq qdisc

2018-12-14 Thread Eric Dumazet
On 12/14/2018 04:02 AM, Sergey Matyukevich wrote: > Hi all, > > I have been running 4.18-rc8 kernel with enabled IP forwarding between > wired and wireless interfaces, where both interfaces > were configured as fq qdisc. > > However after moving to 4.20-rc1 kernel the same configuration does n

Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

2018-12-14 Thread Josh Boyer
On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel wrote: > > These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also > comprise of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel This didn't add brcm/brcmfmac4366c-pcie.bin to WHENCE. I'm assuming it's under the same l

Re: [PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990

2018-12-14 Thread Rakesh Pillai
Hi Kalle, I tested this patch on WCN3990 and did basic STA mode sanity. I do not see any crash with this fix. Thanks, Rakesh Pillai. On 2018-12-14 17:26, Kalle Valo wrote: Kalle Valo writes: From: Rakesh Pillai HL2.0 firmware does not support setting quiet mode. If the host driver send

question: ip forwarding and fq/mq qdisc

2018-12-14 Thread Sergey Matyukevich
Hi all, I have been running 4.18-rc8 kernel with enabled IP forwarding between wired and wireless interfaces, where both interfaces were configured as fq qdisc. However after moving to 4.20-rc1 kernel the same configuration does not work anymore: pass-through packets are not forwarded in both dir

Re: [PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990

2018-12-14 Thread Kalle Valo
Kalle Valo writes: > From: Rakesh Pillai > > HL2.0 firmware does not support setting quiet mode. If the host driver sends > the quiet mode setting command to the HL2.0 firmware, it crashes with the > below > signature. > > fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b

[PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990

2018-12-14 Thread Kalle Valo
From: Rakesh Pillai HL2.0 firmware does not support setting quiet mode. If the host driver sends the quiet mode setting command to the HL2.0 firmware, it crashes with the below signature. fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0 The quiet mode command supp

Re: [PATCH] ath10k: Skip sending quiet mode cmd for WCN3990

2018-12-14 Thread Kalle Valo
Govind Singh writes: > From: Rakesh Pillai > > HL2.0 firmware does not support setting quiet mode. > If the host driver sends the quiet mode setting > command to the HL2.0 firmware, it crashes with the > below signature. > > fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b

[PATCH] cfg80211: Authentication offload to user space in AP mode

2018-12-14 Thread Srinivas Dasari
'commit 40cbfa90218b ("cfg80211/nl80211: Optional authentication offload to userspace")' introduces authentication offload to user space by the host drivers in station mode. This commit extends the same for the AP mode too. Extend NL80211_ATTR_EXTERNAL_AUTH_SUPPORT to also claim the support of ext