On Sat, Dec 15, 2018 at 6:02 AM Arend Van Spriel
wrote:
>
>
>
> On 12/14/2018 2:02 PM, Josh Boyer wrote:
> > On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
> > wrote:
> >>
> >> These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also
> >> comprise of BCM4366E or BCM43664 devices.
On Sat, Dec 15, 2018 at 11:20 AM Luca Coelho wrote:
>
> From: Emmanuel Grumbach
>
> NullFunc packets should never be duplicate just like
> QoS-NullFunc packets.
>
> We saw a client that enters / exits power save with
> NullFunc frames (and not with QoS-NullFunc) despite the
> fact that the associ
Hi,
I have a AMPAK AP6476 with BCM43362 (WiFi) and BCM2076 (Bluetooth) in
an Intel (Bay Trail) tablet. Ever since upgrading linux-firmware a few
weeks ago, I've been having seemingly random WiFi issues. Sometimes,
WiFi stops responding while being connected, or fails to authenticate
to WPA2-PSK ne
On 12/12/2018 8:20 PM, Stefan Wahren wrote:
Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
hostapd (device_ap_sme=1 use_monitor=0):
brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
So add
On 12/14/2018 2:02 PM, Josh Boyer wrote:
On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
wrote:
These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also comprise
of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel
This didn't add brcm/brcmfmac4366c-pcie.bin to
From: Johannes Berg
The pointer and corresponding length is always set in pairs
in cfg80211, so no need to have this strange defensive check
that also confuses static checkers. Clean it up.
Signed-off-by: Johannes Berg
---
net/mac80211/cfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
From: Andrei Otcheretianski
This is needed for the devices that manage PMKSA caching internally and
don't implement SET/DEL PMKSA commands.
Signed-off-by: Andrei Otcheretianski
Signed-off-by: Luca Coelho
---
include/net/cfg80211.h | 6 ++
include/uapi/linux/nl80211.h | 4 +++-
net
From: Shaul Triebitz
Up until now, the IEEE80211_STA_DISABLE_HE flag was set only based
on whether the AP has advertised HE capabilities.
This flag should be set also if STA does not support HE
(regardless of the AP support).
Signed-off-by: Shaul Triebitz
Signed-off-by: Luca Coelho
---
net/ma
From: Shaul Triebitz
When disabling HE due to the lack of HT/VHT, do it
at an earlier stage to avoid advertising HE capabilities IE.
Also, at this point, no need to check if AP supports HE, since
it is already checked earlier (in ieee80211_prep_channel).
Signed-off-by: Shaul Triebitz
Signed-off
From: Johannes Berg
Due to the alignment handling, it actually matters where in the code
we add the 4 bytes for the presence bitmap to the length; the first
field is the timestamp with 8 byte alignment so we need to add the
space for the extra vendor namespace presence bitmap *before* we do
any a
From: Emmanuel Grumbach
NullFunc packets should never be duplicate just like
QoS-NullFunc packets.
We saw a client that enters / exits power save with
NullFunc frames (and not with QoS-NullFunc) despite the
fact that the association supports HT.
This specific client also re-uses a non-zero seque
From: Ilan Peer
The radiotap vendor data might be placed after some other
radiotap elements, and thus when accessing it, need to access
the correct offset in the skb data. Fix the code accordingly.
Signed-off-by: Ilan Peer
Signed-off-by: Luca Coelho
---
net/mac80211/rx.c | 6 +-
1 file ch
From: Johannes Berg
If validate_pae_over_nl80211() were to fail in nl80211_crypto_settings(),
we might leak the 'connkeys' allocation. Fix this.
Fixes: 64bf3d4bc2b0 ("nl80211: Add CONTROL_PORT_OVER_NL80211 attribute")
Signed-off-by: Johannes Berg
---
net/wireless/nl80211.c | 4 +++-
1 file cha
From: Shaul Triebitz
Similar to WMM IE, if MU_EDCA IE parameters changed (or ceased to exist)
tell the Driver about it.
Signed-off-by: Shaul Triebitz
Signed-off-by: Luca Coelho
---
net/mac80211/ieee80211_i.h | 1 +
net/mac80211/mlme.c| 12 ++--
net/mac80211/util.c| 2
On Thu, Dec 6, 2018 at 2:09 AM Joe Perches wrote:
>
> On Mon, 2018-12-03 at 08:40 -0500, Yangtao Li wrote:
> > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Thanks.
>
> Are you doing these manually or using some script?
In fact, just use grep.
Yours,
Yangtao
>
>
From: Johannes Berg
This isn't really a problem now, but it means that the function
has a few NULL checks that are only relevant when coming from
the initial interface added in mac80211, and that's confusing.
Just pass non-NULL (but equivalently empty) in that case and
remove all the NULL checks.
From: Johannes Berg
When we *don't* have a MAC address attribute, we shouldn't
try to use this - this was intended to copy the local MAC
address instead, so fix it.
Fixes: 9bb7e0f24e7e ("cfg80211: add peer measurement with FTM initiator API")
Signed-off-by: Johannes Berg
---
net/wireless/core.
From: Johannes Berg
The older code and current userspace assumed that this data
is the content of the Measurement Report element, starting
with the Measurement Token. Clarify this in the documentation.
Signed-off-by: Johannes Berg
---
include/net/cfg80211.h | 6 --
include/uapi/linu
From: Johannes Berg
Fix two bugs in ieee80211_get_vht_max_nss():
* the spec says we should round down
(reported by Nissim)
* there's a double condition, the first one is wrong,
supp_width == 0 / ext_nss_bw == 2 is valid in 80+80
(found by smatch)
Fixes: b0aa75f0b1b2 ("ieee80211: add n
From: Ilan Peer
The monitor interface Rx handling of SKBs that contain only
radiotap information was buggy as it tried to access the
SKB assuming it contains a frame.
To fix this, check the RX_FLAG_NO_PSDU flag in the Rx status
(indicting that the SKB contains only radiotap information),
and do
From: Emmanuel Grumbach
These bits are defined in ieee802.11ax to advertise support
for TWT in addition to the bits in the HE IE.
Signed-off-by: Emmanuel Grumbach
Signed-off-by: Luca Coelho
---
include/linux/ieee80211.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/linux/iee
From: Sara Sharon
mac80211 uses the frag list to build AMSDU. When freeing
the skb, it may not be really freed, since someone is still
holding a reference to it.
In that case, when TCP skb is being retransmitted, the
pointer to the frag list is being reused, while the data
in there is no longer v
From: Emmanuel Grumbach
TWT is a feature that was added in 11ah and enhanced in
11ax. There are two bits that need to be set if we want
to use the feature in 11ax: one in the HE Capability IE
and one in the Extended Capability IE. This is because
of backward compatibility between 11ah and 11ax.
From: Johannes Berg
At the place where this code lives now, the skb can never be
NULL, so we can remove the pointless NULL check.
It seems to exist because this code was moved around a few times
and originally came from a place where it could in fact be NULL.
Signed-off-by: Johannes Berg
---
From: Sara Sharon
If we build AMSDU from GSO packets, it can lead to
bad results if anyone tries to call skb_gso_segment
on the packets.
Signed-off-by: Sara Sharon
Signed-off-by: Luca Coelho
---
net/mac80211/tx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/mac8
From: Sara Sharon
Recently TXQ teardown was moved earlier in ieee80211_unregister_hw(),
to avoid a use-after-free of the netdev data. However, interfaces
aren't fully removed at the point, and cfg80211_shutdown_all_interfaces
can for example, TX a deauth frame. Move the TXQ teardown to the
point
From: Johannes Berg
In the iwlwifi conversion, we sometimes call this from outside
of the wake_tx_queue() method, and in those cases must be in an
RCU critical section. Document this requirement.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
include/net/mac80211.h | 8
From: Lior Cohen
Suspicious RCU usage observed while calling the
cfg80211_sta_opmode_change_notify() during rx_handlers path.
The issue occurred due to illegal blocking while in RCU read-side
critical section. The blocking caused by an attempt to alloc skb with the
GFP_KERNEL flag, which eventual
From: Luca Coelho
There are talks about enabling -Wimplicit-fallthrough warnings in the
mainline and it is already enabled in linux-next. Add all the
missing annotations to prevent warnings when this happens.
And in one case, remove the extra text from the annotation so that the
compiler recogn
From: Shaul Triebitz
HE Operation element has changed in 11ax D3.0. Update the fields
accordingly.
Signed-off-by: Shaul Triebitz
Signed-off-by: Luca Coelho
---
include/linux/ieee80211.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/include/l
From: Luca Coelho
Hi,
Some patches with mac80211 and cfg80211 changes from our internal
tree.
Please review, though you have already reviewed most if not all of
them ;)
Cheers,
Luca.
Andrei Otcheretianski (1):
cfg80211: Include the PMK and PMKID in NL80211_CMD_EXTERNAL_AUTH
Emmanuel Grumb
31 matches
Mail list logo
