Re: [PATCH 2/2] iw: Print current time in station info dump

2019-04-12 Thread Kirtika Ruchandani
On Fri, Apr 12, 2019 at 2:49 PM Ben Greear wrote: > > On 4/12/19 2:43 PM, Kirtika Ruchandani wrote: > > On Fri, Apr 12, 2019 at 2:40 PM wrote: > >> > >> From: Ben Greear > >> > >> This lets us more precisely calculate the absolute timestamp > >> of last-rix (ie, now - idle). > > > > Can you use

Re: [PATCH 2/2] iw: Print current time in station info dump

2019-04-12 Thread Ben Greear
On 4/12/19 2:43 PM, Kirtika Ruchandani wrote: On Fri, Apr 12, 2019 at 2:40 PM wrote: From: Ben Greear This lets us more precisely calculate the absolute timestamp of last-rix (ie, now - idle). Can you use 64-bit timestamps? struct timeval suffers from the overflow after 2038 problem. Wha

Re: [PATCH 2/2] iw: Print current time in station info dump

2019-04-12 Thread Kirtika Ruchandani
On Fri, Apr 12, 2019 at 2:40 PM wrote: > > From: Ben Greear > > This lets us more precisely calculate the absolute timestamp > of last-rix (ie, now - idle). Can you use 64-bit timestamps? struct timeval suffers from the overflow after 2038 problem. > > Signed-off-by: Ben Greear > --- > statio

[PATCH 2/2] iw: Print current time in station info dump

2019-04-12 Thread greearb
From: Ben Greear This lets us more precisely calculate the absolute timestamp of last-rix (ie, now - idle). Signed-off-by: Ben Greear --- station.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/station.c b/station.c index 3b0c5f1..60804f2 100644 --- a/station.c +++

[PATCH 1/2] iw: Support authenticated-at station statistic.

2019-04-12 Thread greearb
From: Ben Greear This can be helpful for calculating roaming time and other higher precision stats. Signed-off-by: Ben Greear --- nl80211.h | 2 ++ station.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/nl80211.h b/nl80211.h index e1ea2cb..ebaae12 100644 --- a/nl80211.h +++ b/nl8021

[PATCH 1/2] wireless: Support auth-at-ms timer in sta-info

2019-04-12 Thread greearb
From: Ben Greear Report time stamp of when sta became authenticated. Signed-off-by: Ben Greear --- include/net/cfg80211.h | 2 ++ include/uapi/linux/nl80211.h | 2 ++ net/wireless/nl80211.c | 1 + 3 files changed, 5 insertions(+) diff --git a/include/net/cfg80211.h b/include/net/c

[PATCH 2/2] mac80211: add auth-at-ms support.

2019-04-12 Thread greearb
From: Ben Greear Report when sta becomes authenticated. Signed-off-by: Ben Greear --- net/mac80211/sta_info.c | 3 +++ net/mac80211/sta_info.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 044120c45950..6dab7abe1603 100644 --- a/

Re: NL80211_SCAN_FLAG_RANDOM_ADDR ?

2019-04-12 Thread Arend Van Spriel
On 4/12/2019 5:00 PM, Denis Kenzior wrote: Or put another way, besides hardware limitations, are there reasons why you would not want to randomize probe request address when connected? I was hoping to find your answer using 'git blame'. You might already have tried that. The wdev->current_bss

Re: pull-request: iwlwifi-fixes 2019-04-03

2019-04-12 Thread Kalle Valo
Luca Coelho writes: > Hi Kalle, > > This is the second batch of fixes for v5.1. More details about the > contents in the tag description. > > I have sent this out before and kbuildbot reported success. > > Please let me know if there are any issues. > > Cheers, > Luca. > > > The following change

Re: [PATCH 5.1] mt76x02: avoid status_list.lock and sta->rate_ctrl_lock dependency

2019-04-12 Thread Kalle Valo
Stanislaw Gruszka wrote: > Move ieee80211_tx_status_ext() outside of status_list lock section > in order to avoid locking dependency and possible deadlock reposed by > LOCKDEP in below warning. > > Also do mt76_tx_status_lock() just before it's needed. > > [ 440.224832] WARNING: possible circu

Re: [PATCH 5.1] rt2x00: do not increment sequence number while re-transmitting

2019-04-12 Thread Kalle Valo
Stanislaw Gruszka wrote: > From: Vijayakumar Durai > > Currently rt2x00 devices retransmit the management frames with > incremented sequence number if hardware is assigning the sequence. > > This is HW bug fixed already for non-QOS data frames, but it should > be fixed for management frames ex

Re: [PATCH 5.1 1/3] mt76: mt7603: add missing initialization for dev->ps_lock

2019-04-12 Thread Kalle Valo
Felix Fietkau wrote: > Fixes lockdep complaint and a potential race condition > > Signed-off-by: Felix Fietkau 3 patches applied to wireless-drivers.git, thanks. 2170e2157d7c mt76: mt7603: add missing initialization for dev->ps_lock aa3cb24be18b mt76: mt7603: fix sequence number assignment 9d

Re: [PATCHv3 2/2] mac80211: Implement API to configure station specific rssi threshold

2019-04-12 Thread kbuild test robot
Hi Tamizh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on next-20190412] [cannot apply to v5.1-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH] mt76: usb: fix possible memory leak during suspend/resume

2019-04-12 Thread Lorenzo Bianconi
> > On Fri, Apr 12, 2019 at 02:27:16PM +0200, Lorenzo Bianconi wrote: > > > Disable mt76u_tx_tasklet at the end of mt76u_stop_queues in order to > > > properly deallocate all pending skbs during suspend/resume phase > > > > On suspend/resume tx skb's are processed after tasklet_enable() > > in res

Re: [PATCH] mt76: usb: fix possible memory leak during suspend/resume

2019-04-12 Thread Lorenzo Bianconi
> On Fri, Apr 12, 2019 at 02:27:16PM +0200, Lorenzo Bianconi wrote: > > Disable mt76u_tx_tasklet at the end of mt76u_stop_queues in order to > > properly deallocate all pending skbs during suspend/resume phase > > On suspend/resume tx skb's are processed after tasklet_enable() > in resume callback

Re: NL80211_SCAN_FLAG_RANDOM_ADDR ?

2019-04-12 Thread Denis Kenzior
Hi Sergey, On 04/12/2019 04:26 AM, Sergey Matyukevich wrote: I've been poking around at how this flag is used and I noticed this check in net/wireless/nl80211.c: nl80211_check_scan_flags() if (*flags & NL80211_SCAN_FLAG_RANDOM_ADDR) { int err; if (!(

Re: [PATCH] mt76: usb: fix possible memory leak during suspend/resume

2019-04-12 Thread Stanislaw Gruszka
On Fri, Apr 12, 2019 at 02:27:16PM +0200, Lorenzo Bianconi wrote: > Disable mt76u_tx_tasklet at the end of mt76u_stop_queues in order to > properly deallocate all pending skbs during suspend/resume phase On suspend/resume tx skb's are processed after tasklet_enable() in resume callback. There is i

[PATCH] mt76: fix tx power issues

2019-04-12 Thread Felix Fietkau
- tx power is stored in the channels after ieee80211_register_hw, so chan->orig_mpwr needs to be updated as well - for non-TSSI devices, mt76x2e needs to use a different target power value from the EEPROM - fix a rounding error in a few places (need to round up, not down) Signed-off-by: Felix

Re: [PATCH 1/6] ath10k: use clean packet headers

2019-04-12 Thread Kalle Valo
Erik Stromdahl writes: > From: Alagu Sankar > > HTC header carries junk values that may be interpreted by the firmware > differently. Enable credit update only if flow control is enabled for > the corresponding endpoint. > > PLL clock setting sequence does not mask the PLL_CONTROL > register val

[PATCH] nl80211: add iftype mask when sending iftype_data

2019-04-12 Thread John Crispin
Add the iftype mask to the blob passed to userland. This allows hostapd to find the entry applicable for constructing the HE beacons of an AP. Signed-off-by: John Crispin --- include/uapi/linux/nl80211.h | 3 +++ net/wireless/nl80211.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion

[PATCH] mt76: usb: fix possible memory leak during suspend/resume

2019-04-12 Thread Lorenzo Bianconi
Disable mt76u_tx_tasklet at the end of mt76u_stop_queues in order to properly deallocate all pending skbs during suspend/resume phase Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/usb.c | 4 ++-- 1 file changed,

Re: [PATCH 5.1] mt76x02: avoid status_list.lock and sta->rate_ctrl_lock dependency

2019-04-12 Thread Felix Fietkau
On 2019-04-05 13:42, Stanislaw Gruszka wrote: > Move ieee80211_tx_status_ext() outside of status_list lock section > in order to avoid locking dependency and possible deadlock reposed by > LOCKDEP in below warning. > > Also do mt76_tx_status_lock() just before it's needed. > > [ 440.224832] WARN

Re: [PATCH] mt76: introduce mt76_free_device routine

2019-04-12 Thread Felix Fietkau
On 2019-03-27 12:41, Lorenzo Bianconi wrote: > Move mt76_tx_free in mt76_free_device routine in order to > unmap all txwi descriptors at module unload > > Signed-off-by: Lorenzo Bianconi Applied, thanks. - Felix

Re: [RFC V4 1/2] mac80211: add hw 80211 encapsulation offloading support

2019-04-12 Thread Johannes Berg
On Wed, 2019-04-10 at 09:35 +0200, John Crispin wrote: > The driver > needs to enable the support on a per vif basis if it finds that all > pre-reqs are meet. > + * @IEEE80211_HW_SUPPORTS_80211_ENCAP: Hardware/driver supports 802.11 > + * encap for data frames. I'm still not sure I can reconcil

Re: [RFC PATCH v3 07/12] iwlwifi: Extended Key ID support (NATIVE)

2019-04-12 Thread Johannes Berg
> AP-no-delay-client-HW-crypt.cap.gz > same as above, only cleint using HW crypto > You can e.g. find the "corrupted" looking frames with the wireshark filter > "(wlan.fc.type_subtype == 0x0028) && !(llc.dsap == 0xaa)" For everyone else - make sure to set "ignore protected bit - with IV"

Re: [RFC PATCH v3 07/12] iwlwifi: Extended Key ID support (NATIVE)

2019-04-12 Thread Johannes Berg
On Wed, 2019-04-10 at 22:46 +0200, Alexander Wetzel wrote: > my new test AP came with a Intel AC-3168, which seems to use only one > antenna, potentially also explaining my fist impression that it's a > worse card for sniffing than my old Ultimate-N 6300. Right, that's worse in some way. > It

Re: NL80211_SCAN_FLAG_RANDOM_ADDR ?

2019-04-12 Thread Sergey Matyukevich
> I've been poking around at how this flag is used and I noticed this > check in net/wireless/nl80211.c: > > nl80211_check_scan_flags() > > if (*flags & NL80211_SCAN_FLAG_RANDOM_ADDR) { > int err; > > if (!(wiphy->features & randomness_flag) || >