Re: [PATCH 1/9] wil6210: fix spurious interrupts in 3-msi

Maya Erez wrote: > Interrupt is set in ICM (ICR & ~IMV) rising trigger. > As the driver masks the IRQ after clearing it, there can > be a race where an additional spurious interrupt is triggered > when the driver unmask the IRQ. > This can happen in case HW triggers an interrupt after the clear >

Re: [PATCH v9 04/14] rtw88: trx files

On Wed, May 1, 2019 at 11:30 AM Kalle Valo wrote: > My comment was about handling firmware commands and events as a byte > array, not about bitfields. So that instead of accessing 'index + 1' and > 'index + 4' you should create a proper struct for the command and access > it using 'cmd->foo' and '

Re: [RFC 10/17] mt7615: mcu: remove skb_ret from mt7615_mcu_msg_send

> Hi Lorenzo, > Hi Roy, > IMHO, the skb_ret parameter from mt7615_mcu_msg_send is not just used by > patch semaphore control. > The other cmds also got their own event response that can be interpret > accordingly by their own caller, which can provide the status of the cmd > (success/fail) and o

Re: [RFC/RFT 3/7] rt2800: initial watchdog implementation

Stanislaw Gruszka wrote: > Add watchdog for rt2800 devices. For now it only detect hung > and print error. > > [Note: I verified that printing messages from process context is > fine on MT7620 (WT3020) platform that have problem when printk > is called from interrupt context]. > > Signed-off-by

Re: carl9170 crash

Kalle, I just tried to bisect this and got an unexpected result: commit 4c3f49ae1306c05e91211c06feddfd0a4a57fabd "Merge branch 'for-5.1-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu". I wanted to share this in case it is correct. I have a stronger suspicion that the probl

Re: [RFC/RFT 3/7] rt2800: initial watchdog implementation

On Thu, May 02, 2019 at 11:06:56AM +0200, Stanislaw Gruszka wrote: > Add watchdog for rt2800 devices. For now it only detect hung > and print error. > > [Note: I verified that printing messages from process context is > fine on MT7620 (WT3020) platform that have problem when printk > is called fro

[RFC/RFT 3/7] rt2800: initial watchdog implementation

Add watchdog for rt2800 devices. For now it only detect hung and print error. [Note: I verified that printing messages from process context is fine on MT7620 (WT3020) platform that have problem when printk is called from interrupt context]. Signed-off-by: Stanislaw Gruszka --- drivers/net/wirel

[PATCH 3/7] rt2800: initial watchdog implementation

Add watchdog for rt2800 devices. For now it only detect hung and print error. [Note: I verified that printing messages from process context is fine on MT7620 (WT3020) platform that have problem when printk is called from interrupt context]. Signed-off-by: Stanislaw Gruszka --- drivers/net/wirel

[PATCH 1/7] rt2x00: allow to specify watchdog interval

Allow subdriver to change watchdog interval by intialize link->watchdog_interval value before rt2x00link_register(). Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2x00.h | 1 + drivers/net/wireless/ralink/rt2x00/rt2x00link.c | 13 + 2 files changed, 1

[PATCH 0/7] rt2800: add experimental watchdog implementation

Add watchdog to address some remaining problems of Ralink devices random hungs. RFC -> v1 - better description for module parameter - fix white space Stanislaw Gruszka (7): rt2x00: allow to specify watchdog interval rt2800: add helpers for reading dma done index rt2800: initial watchdog

[PATCH 7/7] rt2800: do not enable watchdog by default

Make watchdog disabled by default and add module parameter to enable it. User will have to create file in /etc/modprobe.d/ with options rt2800lib watchdog=1 to enable the watchdog or load "rt2800lib watchdog=1" module manually before loading rt2800{soc,pci,usb} module. Signed-off-by: Stanislaw

[PATCH 2/7] rt2800: add helpers for reading dma done index

For mmio we do not properlly trace dma done Q_INDEX_DMA_DONE index for TX queues. That would require implementing INT_SOURCE_CSR_*_DMA_DONE interrupts, what is rather not worth to do due to adding extra CPU load (small but still somewhat not necessary otherwise). We can just read TX DMA done index

[PATCH 6/7] rt2x00: add restart hw

Add ieee80211_restart_hw() to watchdog and debugfs file for testing if restart works as expected. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 +++ drivers/net/wireless/ralink/rt2x00/rt2x00.h | 7 + drivers/net/wireless/ralink/rt2x00/rt2x00

[PATCH 5/7] rt2800: do not nullify initialization vector data

If we restart hw we should keep existing IV (initialization vector) otherwise HW encryption will be broken after restart. Also fix some coding style issues on the way. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 9 - 1 file changed, 4 insertions

[PATCH 4/7] rt2800: add pre_reset_hw callback

Add routine to cleanup interfaces data before hw reset as ieee80211_restart_hw() will do setup interfaces again. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 19 +++ drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 1 + drivers/net/wirele

Re: [RFC 08/17] mt7615: remove query from mt7615_mcu_msg_send signature

Lorenzo Bianconi writes: > Signed-off-by: Lorenzo Bianconi Please no empty commit logs. As this is a trivial patch you can just add a sentence explaining why you do this. -- Kalle Valo

Re: [RFC 12/17] mt7615: mcu: do not use function pointer whenever possible

> On Wed, 2019-05-01 at 18:07 +0200, Lorenzo Bianconi wrote: > > Remove function pointer in mt7615_mcu_set_bss_info and run function > > directly. Moreover remove __mt7615_mcu_set_bss_info since it is run just > > by mt7615_mcu_set_bss_info and remove duplicated istructions > > > > Signed-off-by: